Re: [PATCH v2 15/19] omap2: omapfb: allow building it with COMPILE_TEST
On Thursday, April 05, 2018 04:29:42 PM Mauro Carvalho Chehab wrote: > This driver builds cleanly with COMPILE_TEST, and it is > needed in order to allow building drivers/media omap2 > driver. > > So, change the logic there to allow building it. > > Signed-off-by: Mauro Carvalho Chehab This change has broken build on OF=n && COMPILE_TEST=y configs: https://patchwork.kernel.org/patch/10352465/ [ This is not a problem when compiling for OMAP2 because it depends on ARM Multiplatform support which (indirectly) selects OF. ] Also I would really prefer that people won't merge fbdev related patches without my ACK and I see this patch in -next coming from one of your trees.. > --- > drivers/video/fbdev/omap2/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/omap2/Kconfig > b/drivers/video/fbdev/omap2/Kconfig > index 0921c4de8407..82008699d253 100644 > --- a/drivers/video/fbdev/omap2/Kconfig > +++ b/drivers/video/fbdev/omap2/Kconfig > @@ -1,4 +1,4 @@ > -if ARCH_OMAP2PLUS > +if ARCH_OMAP2PLUS || COMPILE_TEST > > source "drivers/video/fbdev/omap2/omapfb/Kconfig" Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 15/19] omap2: omapfb: allow building it with COMPILE_TEST
Hi Mauro,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v4.16 next-20180406]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/Make-all-media-drivers-build-with-COMPILE_TEST/20180406-163048
base: git://linuxtv.org/media_tree.git master
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
>> drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c:230:23:
>> sparse: cast to restricted __be32
>> drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c:230:23:
>> sparse: cast to restricted __be32
>> drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c:230:23:
>> sparse: cast to restricted __be32
>> drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c:230:23:
>> sparse: cast to restricted __be32
>> drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c:230:23:
>> sparse: cast to restricted __be32
>> drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c:230:23:
>> sparse: cast to restricted __be32
--
>> drivers/video/fbdev/omap2/omapfb/dss/dispc.c:289:9: sparse: context
>> imbalance in 'mgr_fld_write' - different lock contexts for basic block
vim +230 drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c
f76ee892 Tomi Valkeinen 2015-12-09 222
f76ee892 Tomi Valkeinen 2015-12-09 223 static int panel_enabled(struct
panel_drv_data *ddata)
f76ee892 Tomi Valkeinen 2015-12-09 224 {
f76ee892 Tomi Valkeinen 2015-12-09 225 u32 disp_status;
f76ee892 Tomi Valkeinen 2015-12-09 226 int enabled;
f76ee892 Tomi Valkeinen 2015-12-09 227
f76ee892 Tomi Valkeinen 2015-12-09 228 acx565akm_read(ddata,
MIPID_CMD_READ_DISP_STATUS,
f76ee892 Tomi Valkeinen 2015-12-09 229 (u8
*)&disp_status, 4);
f76ee892 Tomi Valkeinen 2015-12-09 @230 disp_status =
__be32_to_cpu(disp_status);
f76ee892 Tomi Valkeinen 2015-12-09 231 enabled = (disp_status & (1 <<
17)) && (disp_status & (1 << 10));
f76ee892 Tomi Valkeinen 2015-12-09 232 dev_dbg(&ddata->spi->dev,
f76ee892 Tomi Valkeinen 2015-12-09 233 "LCD panel %senabled by
bootloader (status 0x%04x)\n",
f76ee892 Tomi Valkeinen 2015-12-09 234 enabled ? "" : "not ",
disp_status);
f76ee892 Tomi Valkeinen 2015-12-09 235 return enabled;
f76ee892 Tomi Valkeinen 2015-12-09 236 }
f76ee892 Tomi Valkeinen 2015-12-09 237
:: The code at line 230 was first introduced by commit
:: f76ee892a99e68b55402b8d4b8aeffcae2aff34d omapfb: copy omapdss & displays
for omapfb
:: TO: Tomi Valkeinen
:: CC: Tomi Valkeinen
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 15/19] omap2: omapfb: allow building it with COMPILE_TEST
Hi Mauro,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v4.16 next-20180406]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/Make-all-media-drivers-build-with-COMPILE_TEST/20180406-163048
base: git://linuxtv.org/media_tree.git master
config: mips-allmodconfig (attached as .config)
compiler: mips-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=mips
All warnings (new ones prefixed by >>):
drivers/video/fbdev/omap2/omapfb/dss/dispc.c: In function 'pixinc':
>> drivers/video/fbdev/omap2/omapfb/dss/dispc.c:1859:2: warning: this 'else'
>> clause does not guard... [-Wmisleading-indentation]
else
^~~~
drivers/video/fbdev/omap2/omapfb/dss/dispc.c:1861:3: note: ...this
statement, but the latter is misleadingly indented as if it were guarded by the
'else'
return 0;
^~
vim +/else +1859 drivers/video/fbdev/omap2/omapfb/dss/dispc.c
f76ee892 Tomi Valkeinen 2015-12-09 1850
f76ee892 Tomi Valkeinen 2015-12-09 1851 static s32 pixinc(int pixels, u8 ps)
f76ee892 Tomi Valkeinen 2015-12-09 1852 {
f76ee892 Tomi Valkeinen 2015-12-09 1853if (pixels == 1)
f76ee892 Tomi Valkeinen 2015-12-09 1854return 1;
f76ee892 Tomi Valkeinen 2015-12-09 1855else if (pixels > 1)
f76ee892 Tomi Valkeinen 2015-12-09 1856return 1 + (pixels - 1)
* ps;
f76ee892 Tomi Valkeinen 2015-12-09 1857else if (pixels < 0)
f76ee892 Tomi Valkeinen 2015-12-09 1858return 1 - (-pixels +
1) * ps;
f76ee892 Tomi Valkeinen 2015-12-09 @1859else
f76ee892 Tomi Valkeinen 2015-12-09 1860BUG();
f76ee892 Tomi Valkeinen 2015-12-09 1861return 0;
f76ee892 Tomi Valkeinen 2015-12-09 1862 }
f76ee892 Tomi Valkeinen 2015-12-09 1863
:: The code at line 1859 was first introduced by commit
:: f76ee892a99e68b55402b8d4b8aeffcae2aff34d omapfb: copy omapdss & displays
for omapfb
:: TO: Tomi Valkeinen
:: CC: Tomi Valkeinen
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 15/19] omap2: omapfb: allow building it with COMPILE_TEST
On 05/04/18 23:29, Mauro Carvalho Chehab wrote: > This driver builds cleanly with COMPILE_TEST, and it is > needed in order to allow building drivers/media omap2 > driver. > > So, change the logic there to allow building it. > > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/video/fbdev/omap2/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/omap2/Kconfig > b/drivers/video/fbdev/omap2/Kconfig > index 0921c4de8407..82008699d253 100644 > --- a/drivers/video/fbdev/omap2/Kconfig > +++ b/drivers/video/fbdev/omap2/Kconfig > @@ -1,4 +1,4 @@ > -if ARCH_OMAP2PLUS > +if ARCH_OMAP2PLUS || COMPILE_TEST > > source "drivers/video/fbdev/omap2/omapfb/Kconfig" > > Acked-by: Tomi Valkeinen Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH v2 15/19] omap2: omapfb: allow building it with COMPILE_TEST
This driver builds cleanly with COMPILE_TEST, and it is needed in order to allow building drivers/media omap2 driver. So, change the logic there to allow building it. Signed-off-by: Mauro Carvalho Chehab --- drivers/video/fbdev/omap2/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/omap2/Kconfig b/drivers/video/fbdev/omap2/Kconfig index 0921c4de8407..82008699d253 100644 --- a/drivers/video/fbdev/omap2/Kconfig +++ b/drivers/video/fbdev/omap2/Kconfig @@ -1,4 +1,4 @@ -if ARCH_OMAP2PLUS +if ARCH_OMAP2PLUS || COMPILE_TEST source "drivers/video/fbdev/omap2/omapfb/Kconfig" -- 2.14.3 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
