Re: [PATCH v3 11/12] samples: vfio-mdev: constify fb ops

2019-12-10 Thread Kirti Wankhede 




On 12/9/2019 7:31 PM, Jani Nikula wrote:

On Tue, 03 Dec 2019, Jani Nikula  wrote:

Now that the fbops member of struct fb_info is const, we can start
making the ops const as well.

v2: fix typo (Christophe de Dinechin)

Cc: Kirti Wankhede 
Cc: k...@vger.kernel.org
Reviewed-by: Daniel Vetter 
Signed-off-by: Jani Nikula 


Kirti, may I have your ack to merge this through drm-misc please?

BR,
Jani.


---
  samples/vfio-mdev/mdpy-fb.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/samples/vfio-mdev/mdpy-fb.c b/samples/vfio-mdev/mdpy-fb.c
index 2719bb259653..21dbf63d6e41 100644
--- a/samples/vfio-mdev/mdpy-fb.c
+++ b/samples/vfio-mdev/mdpy-fb.c
@@ -86,7 +86,7 @@ static void mdpy_fb_destroy(struct fb_info *info)
iounmap(info->screen_base);
  }
  
-static struct fb_ops mdpy_fb_ops = {

+static const struct fb_ops mdpy_fb_ops = {
.owner  = THIS_MODULE,
.fb_destroy = mdpy_fb_destroy,
.fb_setcolreg   = mdpy_fb_setcolreg,




Acked-by : Kirti Wankhede 

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v3 11/12] samples: vfio-mdev: constify fb ops

2019-12-09 Thread Jani Nikula 
On Tue, 10 Dec 2019, Kirti Wankhede  wrote:
> On 12/9/2019 7:31 PM, Jani Nikula wrote:
>> On Tue, 03 Dec 2019, Jani Nikula  wrote:
>>> Now that the fbops member of struct fb_info is const, we can start
>>> making the ops const as well.
>>>
>>> v2: fix typo (Christophe de Dinechin)
>>>
>>> Cc: Kirti Wankhede 
>>> Cc: k...@vger.kernel.org
>>> Reviewed-by: Daniel Vetter 
>>> Signed-off-by: Jani Nikula 
>> 
>> Kirti, may I have your ack to merge this through drm-misc please?
>> 
>> BR,
>> Jani.
>> 
>>> ---
>>>   samples/vfio-mdev/mdpy-fb.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/samples/vfio-mdev/mdpy-fb.c b/samples/vfio-mdev/mdpy-fb.c
>>> index 2719bb259653..21dbf63d6e41 100644
>>> --- a/samples/vfio-mdev/mdpy-fb.c
>>> +++ b/samples/vfio-mdev/mdpy-fb.c
>>> @@ -86,7 +86,7 @@ static void mdpy_fb_destroy(struct fb_info *info)
>>> iounmap(info->screen_base);
>>>   }
>>>   
>>> -static struct fb_ops mdpy_fb_ops = {
>>> +static const struct fb_ops mdpy_fb_ops = {
>>> .owner  = THIS_MODULE,
>>> .fb_destroy = mdpy_fb_destroy,
>>> .fb_setcolreg   = mdpy_fb_setcolreg,
>> 
>
> Acked-by : Kirti Wankhede 

Thanks, pushed to drm-misc-next.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Graphics Center
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v3 11/12] samples: vfio-mdev: constify fb ops

2019-12-09 Thread Jani Nikula 
On Tue, 03 Dec 2019, Jani Nikula  wrote:
> Now that the fbops member of struct fb_info is const, we can start
> making the ops const as well.
>
> v2: fix   typo (Christophe de Dinechin)
>
> Cc: Kirti Wankhede 
> Cc: k...@vger.kernel.org
> Reviewed-by: Daniel Vetter 
> Signed-off-by: Jani Nikula 

Kirti, may I have your ack to merge this through drm-misc please?

BR,
Jani.

> ---
>  samples/vfio-mdev/mdpy-fb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/samples/vfio-mdev/mdpy-fb.c b/samples/vfio-mdev/mdpy-fb.c
> index 2719bb259653..21dbf63d6e41 100644
> --- a/samples/vfio-mdev/mdpy-fb.c
> +++ b/samples/vfio-mdev/mdpy-fb.c
> @@ -86,7 +86,7 @@ static void mdpy_fb_destroy(struct fb_info *info)
>   iounmap(info->screen_base);
>  }
>  
> -static struct fb_ops mdpy_fb_ops = {
> +static const struct fb_ops mdpy_fb_ops = {
>   .owner  = THIS_MODULE,
>   .fb_destroy = mdpy_fb_destroy,
>   .fb_setcolreg   = mdpy_fb_setcolreg,

-- 
Jani Nikula, Intel Open Source Graphics Center
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v3 11/12] samples: vfio-mdev: constify fb ops

2019-12-03 Thread Jani Nikula 
Now that the fbops member of struct fb_info is const, we can start
making the ops const as well.

v2: fix typo (Christophe de Dinechin)

Cc: Kirti Wankhede 
Cc: k...@vger.kernel.org
Reviewed-by: Daniel Vetter 
Signed-off-by: Jani Nikula 
---
 samples/vfio-mdev/mdpy-fb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/samples/vfio-mdev/mdpy-fb.c b/samples/vfio-mdev/mdpy-fb.c
index 2719bb259653..21dbf63d6e41 100644
--- a/samples/vfio-mdev/mdpy-fb.c
+++ b/samples/vfio-mdev/mdpy-fb.c
@@ -86,7 +86,7 @@ static void mdpy_fb_destroy(struct fb_info *info)
iounmap(info->screen_base);
 }
 
-static struct fb_ops mdpy_fb_ops = {
+static const struct fb_ops mdpy_fb_ops = {
.owner  = THIS_MODULE,
.fb_destroy = mdpy_fb_destroy,
.fb_setcolreg   = mdpy_fb_setcolreg,
-- 
2.20.1

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel