Re: [PATCHv4 3/6] drm/omap: don't check dispc timings for DSI

[Pavel Machek]

On Fri 2018-11-16 00:06:42, Sebastian Reichel wrote:
> While all display types only forward their VM to the DISPC, this

"While most?"

> is not true for DSI. DSI calculates the VM for DISPC based on its
> own, but its not identical. Actually the DSI VM is not even a valid

"but it is not"

> DISPC VM making this check fail. Let's restore the old behaviour
> and avoid checking the DISPC VM for DSI here.
> 
> Fixes: 7c27fa57ef31 ("drm/omap: Call dispc timings check operation directly")
> Signed-off-by: Sebastian Reichel 

Acked-by: Pavel Machek 

With the fixes tag, stable is going to pick this up. Do we want this
in stable?

I believe stable does not need it as it is not going to get manually
updated display support, anyway?

Best regards,
Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


signature.asc
Description: Digital signature
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCHv4 3/6] drm/omap: don't check dispc timings for DSI

[Sebastian Reichel]

While all display types only forward their VM to the DISPC, this
is not true for DSI. DSI calculates the VM for DISPC based on its
own, but its not identical. Actually the DSI VM is not even a valid
DISPC VM making this check fail. Let's restore the old behaviour
and avoid checking the DISPC VM for DSI here.

Fixes: 7c27fa57ef31 ("drm/omap: Call dispc timings check operation directly")
Signed-off-by: Sebastian Reichel 
---
 drivers/gpu/drm/omapdrm/omap_connector.c | 8 +---
 drivers/gpu/drm/omapdrm/omap_encoder.c   | 8 +---
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/omapdrm/omap_connector.c 
b/drivers/gpu/drm/omapdrm/omap_connector.c
index b81302c4bf9e..5c776d6211e1 100644
--- a/drivers/gpu/drm/omapdrm/omap_connector.c
+++ b/drivers/gpu/drm/omapdrm/omap_connector.c
@@ -280,9 +280,11 @@ static int omap_connector_mode_valid(struct drm_connector 
*connector,
drm_display_mode_to_videomode(mode, );
mode->vrefresh = drm_mode_vrefresh(mode);
 
-   r = priv->dispc_ops->mgr_check_timings(priv->dispc, channel, );
-   if (r)
-   goto done;
+   if (omap_connector->display->type != OMAP_DISPLAY_TYPE_DSI) {
+   r = priv->dispc_ops->mgr_check_timings(priv->dispc, channel, 
);
+   if (r)
+   goto done;
+   }
 
for (dssdev = omap_connector->output; dssdev; dssdev = dssdev->next) {
if (!dssdev->ops->check_timings)
diff --git a/drivers/gpu/drm/omapdrm/omap_encoder.c 
b/drivers/gpu/drm/omapdrm/omap_encoder.c
index 452e625f6ce3..32bbe3a80e7d 100644
--- a/drivers/gpu/drm/omapdrm/omap_encoder.c
+++ b/drivers/gpu/drm/omapdrm/omap_encoder.c
@@ -170,9 +170,11 @@ static int omap_encoder_atomic_check(struct drm_encoder 
*encoder,
 
drm_display_mode_to_videomode(_state->mode, );
 
-   ret = priv->dispc_ops->mgr_check_timings(priv->dispc, channel, );
-   if (ret)
-   goto done;
+   if (omap_encoder->display->type != OMAP_DISPLAY_TYPE_DSI) {
+   ret = priv->dispc_ops->mgr_check_timings(priv->dispc, channel, 
);
+   if (ret)
+   goto done;
+   }
 
for (dssdev = omap_encoder->output; dssdev; dssdev = dssdev->next) {
if (!dssdev->ops->check_timings)
-- 
2.19.1

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel