[patch] drm/nva3: checking the wrong variable

2011-10-12 Thread Ben Skeggs
On Tue, 2011-10-11 at 17:34 +0300, Dan Carpenter wrote: > "id" is unsigned here and it's never less than zero. I believe the > intent was to check the return value from nva3_pm_pll_offset(). > Also I've changed it to pass on the -ENOENT error code from the lower > levels instead of returning

[patch] drm/nva3: checking the wrong variable

2011-10-11 Thread Dan Carpenter
"id" is unsigned here and it's never less than zero. I believe the intent was to check the return value from nva3_pm_pll_offset(). Also I've changed it to pass on the -ENOENT error code from the lower levels instead of returning -EINVAL. Signed-off-by: Dan Carpenter diff --git

Re: [patch] drm/nva3: checking the wrong variable

2011-10-11 Thread Ben Skeggs
On Tue, 2011-10-11 at 17:34 +0300, Dan Carpenter wrote: id is unsigned here and it's never less than zero. I believe the intent was to check the return value from nva3_pm_pll_offset(). Also I've changed it to pass on the -ENOENT error code from the lower levels instead of returning -EINVAL.