Re: [PATCH V3 1/7] mdev: class id support

2019-10-17 Thread Jason Wang
On 2019/10/16 下午12:57, Parav Pandit wrote: +static struct mdev_class_id id_table[] = { static const + { MDEV_ID_VFIO }, I guess you don't need extra braces for each entry. Since this enum represents MDEV class id, it better to name it as MDEV_CLASS_ID_VFIO. (Similar to

Re: [PATCH V3 1/7] mdev: class id support

2019-10-16 Thread Jason Wang
On 2019/10/16 下午12:57, Parav Pandit wrote: -Original Message- From: Jason Wang Sent: Friday, October 11, 2019 3:16 AM To: k...@vger.kernel.org; linux-s...@vger.kernel.org; linux- ker...@vger.kernel.org; dri-devel@lists.freedesktop.org; intel- g...@lists.freedesktop.org;

RE: [PATCH V3 1/7] mdev: class id support

2019-10-15 Thread Parav Pandit
> -Original Message- > From: Jason Wang > Sent: Friday, October 11, 2019 3:16 AM > To: k...@vger.kernel.org; linux-s...@vger.kernel.org; linux- > ker...@vger.kernel.org; dri-devel@lists.freedesktop.org; intel- > g...@lists.freedesktop.org; intel-gvt-...@lists.freedesktop.org; >

Re: [PATCH V3 1/7] mdev: class id support

2019-10-15 Thread Jason Wang
On 2019/10/16 上午12:38, Alex Williamson wrote: On Fri, 11 Oct 2019 16:15:51 +0800 Jason Wang wrote: diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev/mdev_core.c index b558d4cfd082..724e9b9841d8 100644 --- a/drivers/vfio/mdev/mdev_core.c +++ b/drivers/vfio/mdev/mdev_core.c @@

Re: [PATCH V3 1/7] mdev: class id support

2019-10-15 Thread Alex Williamson
On Fri, 11 Oct 2019 16:15:51 +0800 Jason Wang wrote: > diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev/mdev_core.c > index b558d4cfd082..724e9b9841d8 100644 > --- a/drivers/vfio/mdev/mdev_core.c > +++ b/drivers/vfio/mdev/mdev_core.c > @@ -45,6 +45,12 @@ void

Re: [PATCH V3 1/7] mdev: class id support

2019-10-15 Thread Jason Wang
On 2019/10/15 下午6:26, Cornelia Huck wrote: On Fri, 11 Oct 2019 16:15:51 +0800 Jason Wang wrote: Mdev bus only supports vfio driver right now, so it doesn't implement match method. But in the future, we may add drivers other than vfio, the first driver could be virtio-mdev. This means we

Re: [PATCH V3 1/7] mdev: class id support

2019-10-15 Thread Cornelia Huck
On Fri, 11 Oct 2019 16:15:51 +0800 Jason Wang wrote: > Mdev bus only supports vfio driver right now, so it doesn't implement > match method. But in the future, we may add drivers other than vfio, > the first driver could be virtio-mdev. This means we need to add > device class id support in bus