Re: [Mesa-dev] [PATCH 01/21] vulkan: Add KHR_display extension using DRM

2018-03-07 Thread Keith Packard
Daniel Stone  writes:

> Or better, just use drmModeAddFB2 and pass the format directly. That
> landed back in 3.2 or so, and I don't think there's anyone trying to
> use Vulkan on a kernel from 2011.

Yeah, that's probably a better plan. I've pushed a patch that does this
on top of the long list of patches made in response to Jason's email.

Once he's replied to that, I'll go ahead and smash the new patches back
on top of the original series and re-publish that.

-- 
-keith


signature.asc
Description: PGP signature
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel


Re: [Mesa-dev] [PATCH 01/21] vulkan: Add KHR_display extension using DRM

2018-02-25 Thread Daniel Stone
Hi,

On 24 February 2018 at 00:43, Jason Ekstrand  wrote:
> On Tue, Feb 13, 2018 at 4:31 PM, Keith Packard  wrote:
>> +   image->chain = chain;
>> +   image->state = wsi_image_idle;
>> +   image->fb_id = 0;
>> +
>> +   /* XXX extract depth and bpp from image somehow */
>
> You have the format in create_info.  We could add some generic VkFormat
> introspection or we can just handle the 2-4 cases we care about directly.

Or better, just use drmModeAddFB2 and pass the format directly. That
landed back in 3.2 or so, and I don't think there's anyone trying to
use Vulkan on a kernel from 2011.

Cheers,
Daniel
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel