Re: [PATCH] Remove handhelds.org links and email addresses

2020-06-30 Thread Wolfram Sang
Hi Alexander,

thanks for trying to fix this, yet I have some doubts.

On Mon, Jun 29, 2020 at 10:31:21PM +0200, Alexander A. Klimov wrote:
> Rationale:
> https://lore.kernel.org/linux-doc/20200626110706.7b5d4...@lwn.net/

I think we need some text here. Clicking on a link to understand what a
patch is about is not comfortable. You can add the link with a Link: tag
for additional information.

Removing stale email addresses may have some value, but removing...

>  Compaq's Bootldr + John Dorsey's patch for Assabet support
> -(http://www.handhelds.org/Compaq/bootldr.html)

... information like this is not good. 'Wayback machine' still has
copies in case someone wants to look at where the infos came from.

> - * Copyright 2004-2005  Phil Blundell 
> + * Copyright 2004-2005  Phil Blundell

This is an OK case in my book...


> -MODULE_AUTHOR("Phil Blundell ");
> +MODULE_AUTHOR("Phil Blundell");

... same here ...

> @@ -435,7 +435,6 @@
> case a PCI bridge (DEC chip 21152). The value of
> 'pb' is now only initialized if a de4x5 chip is
> present.
> -   

This is kind of a signature and should be kept IMO.

>   * 2001/07/23: 
> - *   - Hand merge version from handhelds.org CVS tree.  See patch
> + *   - Hand merge version from CVS tree.  See patch

That information may be useful.


>  /* SPDX-License-Identifier: GPL-2.0-only */
>  /* -*- linux-c -*-
> - *
> - * (C) 2003 ze...@handhelds.org

Removing copyright is a bad idea.

Probably some comment blocks are cruft meanwhile and can be removed as a
whole. That can be discussed. But removing only the handhelds.org part
makes most parts worse IMHO.

Thanks and happy hacking,

   Wolfram



signature.asc
Description: PGP signature
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel


Re: [PATCH] Remove handhelds.org links and email addresses

2020-06-30 Thread Alexander A. Klimov




Am 29.06.20 um 23:10 schrieb Wolfram Sang:

Hi Alexander,

thanks for trying to fix this, yet I have some doubts.

On Mon, Jun 29, 2020 at 10:31:21PM +0200, Alexander A. Klimov wrote:

Rationale:
https://lore.kernel.org/linux-doc/20200626110706.7b5d4...@lwn.net/


I think we need some text here. Clicking on a link to understand what a
patch is about is not comfortable. You can add the link with a Link: tag
for additional information.

Fine. I can easily make a v2 patch, but first...



Removing stale email addresses may have some value, but removing...


  Compaq's Bootldr + John Dorsey's patch for Assabet support
-(http://www.handhelds.org/Compaq/bootldr.html)


... information like this is not good. 'Wayback machine' still has
copies in case someone wants to look at where the infos came from.

If we shall not remove *this link*, maybe we shall not remove *all links*?

@Jon You've kinda initiated the patch, what's your opinion? Bad 
squatters or good Wayback machine?





- * Copyright 2004-2005  Phil Blundell 
+ * Copyright 2004-2005  Phil Blundell


This is an OK case in my book...



-MODULE_AUTHOR("Phil Blundell ");
+MODULE_AUTHOR("Phil Blundell");


... same here ...


@@ -435,7 +435,6 @@
 case a PCI bridge (DEC chip 21152). The value of
 'pb' is now only initialized if a de4x5 chip is
 present.
-   


This is kind of a signature and should be kept IMO.
What for? An email address is for someone who'd like to send an email to 
it. At the moment handhelds.org doesn't even have an MX record.





   * 2001/07/23: 
- * - Hand merge version from handhelds.org CVS tree.  See patch
+ * - Hand merge version from CVS tree.  See patch


That information may be useful.

Again: What for? For visiting it and thinking like damn, it's gone?





  /* SPDX-License-Identifier: GPL-2.0-only */
  /* -*- linux-c -*-
- *
- * (C) 2003 ze...@handhelds.org


Removing copyright is a bad idea.

IMAO the CREDITS file is for (c) headers.
If you didn't submit a patch for that - your problem.

If you disagree, I can look up git blame.



Probably some comment blocks are cruft meanwhile and can be removed as a
whole. That can be discussed. But removing only the handhelds.org part
makes most parts worse IMHO.

Thanks and happy hacking,

Wolfram


___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel


Re: [PATCH] Remove handhelds.org links and email addresses

2020-06-29 Thread Krzysztof Kozlowski
On Mon, Jun 29, 2020 at 10:31:21PM +0200, Alexander A. Klimov wrote:
> Rationale:
> https://lore.kernel.org/linux-doc/20200626110706.7b5d4...@lwn.net/
> 
> Signed-off-by: Alexander A. Klimov 
> ---
>  @Jon I thought about what I said and *no*, unfortunately I *can't* automate
>  the detection of such as easy as the HTTPSifying. As you maybe see below
>  cleaning up is even "harder".
> 
>  We have only 17 files and one domain here. Shall I split it up per subsystem
>  or can we let it as is?
> 
>  Documentation/arm/sa1100/assabet.rst   |  2 --
>  Documentation/arm/samsung-s3c24xx/h1940.rst| 10 --
>  Documentation/arm/samsung-s3c24xx/overview.rst |  3 +--
>  Documentation/arm/samsung-s3c24xx/smdk2440.rst |  4 
>  arch/arm/mach-omap1/Kconfig|  4 +---
>  arch/arm/mach-pxa/h5000.c  |  2 +-
>  arch/arm/mach-s3c24xx/mach-h1940.c |  2 --
>  arch/arm/mach-s3c24xx/mach-n30.c   |  3 ---
>  arch/arm/mach-s3c24xx/mach-rx3715.c|  2 --

For s3c24xx, I am fine taking it through docs tree:
Acked-by: Krzysztof Kozlowski 

Otherwise, after splitting, I could take the s3c-24xx bits.

Best regards,
Krzysztof


>  drivers/input/keyboard/gpio_keys.c |  2 +-
>  drivers/input/keyboard/jornada720_kbd.c|  2 +-
>  drivers/input/touchscreen/jornada720_ts.c  |  2 +-
>  drivers/mfd/asic3.c|  2 +-
>  drivers/mmc/host/renesas_sdhi_core.c   |  2 +-
>  drivers/net/ethernet/dec/tulip/de4x5.c |  1 -
>  drivers/video/fbdev/sa1100fb.c |  2 +-
>  include/linux/apm-emulation.h  |  2 --
>  17 files changed, 9 insertions(+), 38 deletions(-)
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel