Re: [PATCH] drm/ci: Add msm tests
On 08/01/2024 16:50, Rob Clark wrote: From: Rob Clark The msm tests should skip on non-msm hw, so I think it should be safe to enable everywhere. Signed-off-by: Rob Clark Applied to drm-misc-next. Thanks Helen --- drivers/gpu/drm/ci/testlist.txt | 49 + 1 file changed, 49 insertions(+) diff --git a/drivers/gpu/drm/ci/testlist.txt b/drivers/gpu/drm/ci/testlist.txt index f82cd90372f4..eaeb751bb0ad 100644 --- a/drivers/gpu/drm/ci/testlist.txt +++ b/drivers/gpu/drm/ci/testlist.txt @@ -2910,3 +2910,52 @@ kms_writeback@writeback-invalid-parameters kms_writeback@writeback-fb-id kms_writeback@writeback-check-output prime_mmap_kms@buffer-sharing +msm_shrink@copy-gpu-sanitycheck-8 +msm_shrink@copy-gpu-sanitycheck-32 +msm_shrink@copy-gpu-8 +msm_shrink@copy-gpu-32 +msm_shrink@copy-gpu-madvise-8 +msm_shrink@copy-gpu-madvise-32 +msm_shrink@copy-gpu-oom-8 +msm_shrink@copy-gpu-oom-32 +msm_shrink@copy-mmap-sanitycheck-8 +msm_shrink@copy-mmap-sanitycheck-32 +msm_shrink@copy-mmap-8 +msm_shrink@copy-mmap-32 +msm_shrink@copy-mmap-madvise-8 +msm_shrink@copy-mmap-madvise-32 +msm_shrink@copy-mmap-oom-8 +msm_shrink@copy-mmap-oom-32 +msm_shrink@copy-mmap-dmabuf-sanitycheck-8 +msm_shrink@copy-mmap-dmabuf-sanitycheck-32 +msm_shrink@copy-mmap-dmabuf-8 +msm_shrink@copy-mmap-dmabuf-32 +msm_shrink@copy-mmap-dmabuf-madvise-8 +msm_shrink@copy-mmap-dmabuf-madvise-32 +msm_shrink@copy-mmap-dmabuf-oom-8 +msm_shrink@copy-mmap-dmabuf-oom-32 +msm_mapping@ring +msm_mapping@sqefw +msm_mapping@shadow +msm_submitoverhead@submitbench-10-bos +msm_submitoverhead@submitbench-10-bos-no-implicit-sync +msm_submitoverhead@submitbench-100-bos +msm_submitoverhead@submitbench-100-bos-no-implicit-sync +msm_submitoverhead@submitbench-250-bos +msm_submitoverhead@submitbench-250-bos-no-implicit-sync +msm_submitoverhead@submitbench-500-bos +msm_submitoverhead@submitbench-500-bos-no-implicit-sync +msm_submitoverhead@submitbench-1000-bos +msm_submitoverhead@submitbench-1000-bos-no-implicit-sync +msm_recovery@hangcheck +msm_recovery@gpu-fault +msm_recovery@gpu-fault-parallel +msm_recovery@iova-fault +msm_submit@empty-submit +msm_submit@invalid-queue-submit +msm_submit@invalid-flags-submit +msm_submit@invalid-in-fence-submit +msm_submit@invalid-duplicate-bo-submit +msm_submit@invalid-cmd-idx-submit +msm_submit@invalid-cmd-type-submit +msm_submit@valid-submit
Re: [PATCH] drm/ci: Add msm tests
On 15/01/2024 07:22, Vignesh Raman wrote: Hi Rob, On 12/01/24 22:44, Rob Clark wrote: On Fri, Jan 12, 2024 at 7:57 AM Rob Clark wrote: On Fri, Jan 12, 2024 at 3:42 AM Vignesh Raman wrote: Hi Rob, On 09/01/24 01:20, Rob Clark wrote: From: Rob Clark The msm tests should skip on non-msm hw, so I think it should be safe to enable everywhere. Signed-off-by: Rob Clark Acked-by: Helen Koike --- drivers/gpu/drm/ci/testlist.txt | 49 + 1 file changed, 49 insertions(+) diff --git a/drivers/gpu/drm/ci/testlist.txt b/drivers/gpu/drm/ci/testlist.txt index f82cd90372f4..eaeb751bb0ad 100644 --- a/drivers/gpu/drm/ci/testlist.txt +++ b/drivers/gpu/drm/ci/testlist.txt @@ -2910,3 +2910,52 @@ kms_writeback@writeback-invalid-parameters kms_writeback@writeback-fb-id kms_writeback@writeback-check-output prime_mmap_kms@buffer-sharing +msm_shrink@copy-gpu-sanitycheck-8 +msm_shrink@copy-gpu-sanitycheck-32 +msm_shrink@copy-gpu-8 +msm_shrink@copy-gpu-32 +msm_shrink@copy-gpu-madvise-8 +msm_shrink@copy-gpu-madvise-32 +msm_shrink@copy-gpu-oom-8 +msm_shrink@copy-gpu-oom-32 +msm_shrink@copy-mmap-sanitycheck-8 +msm_shrink@copy-mmap-sanitycheck-32 +msm_shrink@copy-mmap-8 +msm_shrink@copy-mmap-32 +msm_shrink@copy-mmap-madvise-8 +msm_shrink@copy-mmap-madvise-32 +msm_shrink@copy-mmap-oom-8 +msm_shrink@copy-mmap-oom-32 +msm_shrink@copy-mmap-dmabuf-sanitycheck-8 +msm_shrink@copy-mmap-dmabuf-sanitycheck-32 +msm_shrink@copy-mmap-dmabuf-8 +msm_shrink@copy-mmap-dmabuf-32 +msm_shrink@copy-mmap-dmabuf-madvise-8 +msm_shrink@copy-mmap-dmabuf-madvise-32 +msm_shrink@copy-mmap-dmabuf-oom-8 +msm_shrink@copy-mmap-dmabuf-oom-32 +msm_mapping@ring +msm_mapping@sqefw +msm_mapping@shadow +msm_submitoverhead@submitbench-10-bos +msm_submitoverhead@submitbench-10-bos-no-implicit-sync +msm_submitoverhead@submitbench-100-bos +msm_submitoverhead@submitbench-100-bos-no-implicit-sync +msm_submitoverhead@submitbench-250-bos +msm_submitoverhead@submitbench-250-bos-no-implicit-sync +msm_submitoverhead@submitbench-500-bos +msm_submitoverhead@submitbench-500-bos-no-implicit-sync +msm_submitoverhead@submitbench-1000-bos +msm_submitoverhead@submitbench-1000-bos-no-implicit-sync +msm_recovery@hangcheck +msm_recovery@gpu-fault +msm_recovery@gpu-fault-parallel +msm_recovery@iova-fault +msm_submit@empty-submit +msm_submit@invalid-queue-submit +msm_submit@invalid-flags-submit +msm_submit@invalid-in-fence-submit +msm_submit@invalid-duplicate-bo-submit +msm_submit@invalid-cmd-idx-submit +msm_submit@invalid-cmd-type-submit +msm_submit@valid-submit I tested this patch with latest drm-misc/drm-misc-next and there was some failures seen for the newly added msm tests. I have updated the xfails with below commit, https://gitlab.freedesktop.org/vigneshraman/linux/-/commit/d012893597a661d6ebbb755bf2607dfb055524a1 I will notify the maintainers about the flaky tests, update the url in the flakes.txt, and submit a separate patch for this change. Oh, you should probably move msm_mapping@* to skips on sdm845. I had a closer look at those, and they are failing due to a bootloader/fw issue. We work around this in mesa CI with these two patches: https://gitlab.freedesktop.org/gfx-ci/linux/-/commit/4b49f902ec6f2bb382cbbf489870573f4b43371e https://gitlab.freedesktop.org/gfx-ci/linux/-/commit/38cdf4c5559771e2474ae0fecef8469f65147bc1 But given that sdm845 is similar to sc7180 as far as kernel gpu driver, it is probably just better to skip these on sdm845 (with a comment referring to the hack patches we use in mesa CI) I have sent a patch with these changes, Thanks! Helen https://lore.kernel.org/dri-devel/20240115101750.27077-1-vignesh.ra...@collabora.com/T/#u Thanks. Regards, Vignesh
Re: [PATCH] drm/ci: Add msm tests
Hi Rob, On 12/01/24 22:44, Rob Clark wrote: On Fri, Jan 12, 2024 at 7:57 AM Rob Clark wrote: On Fri, Jan 12, 2024 at 3:42 AM Vignesh Raman wrote: Hi Rob, On 09/01/24 01:20, Rob Clark wrote: From: Rob Clark The msm tests should skip on non-msm hw, so I think it should be safe to enable everywhere. Signed-off-by: Rob Clark --- drivers/gpu/drm/ci/testlist.txt | 49 + 1 file changed, 49 insertions(+) diff --git a/drivers/gpu/drm/ci/testlist.txt b/drivers/gpu/drm/ci/testlist.txt index f82cd90372f4..eaeb751bb0ad 100644 --- a/drivers/gpu/drm/ci/testlist.txt +++ b/drivers/gpu/drm/ci/testlist.txt @@ -2910,3 +2910,52 @@ kms_writeback@writeback-invalid-parameters kms_writeback@writeback-fb-id kms_writeback@writeback-check-output prime_mmap_kms@buffer-sharing +msm_shrink@copy-gpu-sanitycheck-8 +msm_shrink@copy-gpu-sanitycheck-32 +msm_shrink@copy-gpu-8 +msm_shrink@copy-gpu-32 +msm_shrink@copy-gpu-madvise-8 +msm_shrink@copy-gpu-madvise-32 +msm_shrink@copy-gpu-oom-8 +msm_shrink@copy-gpu-oom-32 +msm_shrink@copy-mmap-sanitycheck-8 +msm_shrink@copy-mmap-sanitycheck-32 +msm_shrink@copy-mmap-8 +msm_shrink@copy-mmap-32 +msm_shrink@copy-mmap-madvise-8 +msm_shrink@copy-mmap-madvise-32 +msm_shrink@copy-mmap-oom-8 +msm_shrink@copy-mmap-oom-32 +msm_shrink@copy-mmap-dmabuf-sanitycheck-8 +msm_shrink@copy-mmap-dmabuf-sanitycheck-32 +msm_shrink@copy-mmap-dmabuf-8 +msm_shrink@copy-mmap-dmabuf-32 +msm_shrink@copy-mmap-dmabuf-madvise-8 +msm_shrink@copy-mmap-dmabuf-madvise-32 +msm_shrink@copy-mmap-dmabuf-oom-8 +msm_shrink@copy-mmap-dmabuf-oom-32 +msm_mapping@ring +msm_mapping@sqefw +msm_mapping@shadow +msm_submitoverhead@submitbench-10-bos +msm_submitoverhead@submitbench-10-bos-no-implicit-sync +msm_submitoverhead@submitbench-100-bos +msm_submitoverhead@submitbench-100-bos-no-implicit-sync +msm_submitoverhead@submitbench-250-bos +msm_submitoverhead@submitbench-250-bos-no-implicit-sync +msm_submitoverhead@submitbench-500-bos +msm_submitoverhead@submitbench-500-bos-no-implicit-sync +msm_submitoverhead@submitbench-1000-bos +msm_submitoverhead@submitbench-1000-bos-no-implicit-sync +msm_recovery@hangcheck +msm_recovery@gpu-fault +msm_recovery@gpu-fault-parallel +msm_recovery@iova-fault +msm_submit@empty-submit +msm_submit@invalid-queue-submit +msm_submit@invalid-flags-submit +msm_submit@invalid-in-fence-submit +msm_submit@invalid-duplicate-bo-submit +msm_submit@invalid-cmd-idx-submit +msm_submit@invalid-cmd-type-submit +msm_submit@valid-submit I tested this patch with latest drm-misc/drm-misc-next and there was some failures seen for the newly added msm tests. I have updated the xfails with below commit, https://gitlab.freedesktop.org/vigneshraman/linux/-/commit/d012893597a661d6ebbb755bf2607dfb055524a1 I will notify the maintainers about the flaky tests, update the url in the flakes.txt, and submit a separate patch for this change. Oh, you should probably move msm_mapping@* to skips on sdm845. I had a closer look at those, and they are failing due to a bootloader/fw issue. We work around this in mesa CI with these two patches: https://gitlab.freedesktop.org/gfx-ci/linux/-/commit/4b49f902ec6f2bb382cbbf489870573f4b43371e https://gitlab.freedesktop.org/gfx-ci/linux/-/commit/38cdf4c5559771e2474ae0fecef8469f65147bc1 But given that sdm845 is similar to sc7180 as far as kernel gpu driver, it is probably just better to skip these on sdm845 (with a comment referring to the hack patches we use in mesa CI) I have sent a patch with these changes, https://lore.kernel.org/dri-devel/20240115101750.27077-1-vignesh.ra...@collabora.com/T/#u Thanks. Regards, Vignesh
Re: [PATCH] drm/ci: Add msm tests
On Fri, Jan 12, 2024 at 7:57 AM Rob Clark wrote: > > On Fri, Jan 12, 2024 at 3:42 AM Vignesh Raman > wrote: > > > > Hi Rob, > > > > > > On 09/01/24 01:20, Rob Clark wrote: > > > From: Rob Clark > > > > > > The msm tests should skip on non-msm hw, so I think it should be safe to > > > enable everywhere. > > > > > > Signed-off-by: Rob Clark > > > --- > > > drivers/gpu/drm/ci/testlist.txt | 49 + > > > 1 file changed, 49 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/ci/testlist.txt > > > b/drivers/gpu/drm/ci/testlist.txt > > > index f82cd90372f4..eaeb751bb0ad 100644 > > > --- a/drivers/gpu/drm/ci/testlist.txt > > > +++ b/drivers/gpu/drm/ci/testlist.txt > > > @@ -2910,3 +2910,52 @@ kms_writeback@writeback-invalid-parameters > > > kms_writeback@writeback-fb-id > > > kms_writeback@writeback-check-output > > > prime_mmap_kms@buffer-sharing > > > +msm_shrink@copy-gpu-sanitycheck-8 > > > +msm_shrink@copy-gpu-sanitycheck-32 > > > +msm_shrink@copy-gpu-8 > > > +msm_shrink@copy-gpu-32 > > > +msm_shrink@copy-gpu-madvise-8 > > > +msm_shrink@copy-gpu-madvise-32 > > > +msm_shrink@copy-gpu-oom-8 > > > +msm_shrink@copy-gpu-oom-32 > > > +msm_shrink@copy-mmap-sanitycheck-8 > > > +msm_shrink@copy-mmap-sanitycheck-32 > > > +msm_shrink@copy-mmap-8 > > > +msm_shrink@copy-mmap-32 > > > +msm_shrink@copy-mmap-madvise-8 > > > +msm_shrink@copy-mmap-madvise-32 > > > +msm_shrink@copy-mmap-oom-8 > > > +msm_shrink@copy-mmap-oom-32 > > > +msm_shrink@copy-mmap-dmabuf-sanitycheck-8 > > > +msm_shrink@copy-mmap-dmabuf-sanitycheck-32 > > > +msm_shrink@copy-mmap-dmabuf-8 > > > +msm_shrink@copy-mmap-dmabuf-32 > > > +msm_shrink@copy-mmap-dmabuf-madvise-8 > > > +msm_shrink@copy-mmap-dmabuf-madvise-32 > > > +msm_shrink@copy-mmap-dmabuf-oom-8 > > > +msm_shrink@copy-mmap-dmabuf-oom-32 > > > +msm_mapping@ring > > > +msm_mapping@sqefw > > > +msm_mapping@shadow > > > +msm_submitoverhead@submitbench-10-bos > > > +msm_submitoverhead@submitbench-10-bos-no-implicit-sync > > > +msm_submitoverhead@submitbench-100-bos > > > +msm_submitoverhead@submitbench-100-bos-no-implicit-sync > > > +msm_submitoverhead@submitbench-250-bos > > > +msm_submitoverhead@submitbench-250-bos-no-implicit-sync > > > +msm_submitoverhead@submitbench-500-bos > > > +msm_submitoverhead@submitbench-500-bos-no-implicit-sync > > > +msm_submitoverhead@submitbench-1000-bos > > > +msm_submitoverhead@submitbench-1000-bos-no-implicit-sync > > > +msm_recovery@hangcheck > > > +msm_recovery@gpu-fault > > > +msm_recovery@gpu-fault-parallel > > > +msm_recovery@iova-fault > > > +msm_submit@empty-submit > > > +msm_submit@invalid-queue-submit > > > +msm_submit@invalid-flags-submit > > > +msm_submit@invalid-in-fence-submit > > > +msm_submit@invalid-duplicate-bo-submit > > > +msm_submit@invalid-cmd-idx-submit > > > +msm_submit@invalid-cmd-type-submit > > > +msm_submit@valid-submit > > > > I tested this patch with latest drm-misc/drm-misc-next and there was > > some failures seen for the newly added msm tests. I have updated the > > xfails with below commit, > > > > https://gitlab.freedesktop.org/vigneshraman/linux/-/commit/d012893597a661d6ebbb755bf2607dfb055524a1 > > > > I will notify the maintainers about the flaky tests, update the url in > > the flakes.txt, and submit a separate patch for this change. Oh, you should probably move msm_mapping@* to skips on sdm845. I had a closer look at those, and they are failing due to a bootloader/fw issue. We work around this in mesa CI with these two patches: https://gitlab.freedesktop.org/gfx-ci/linux/-/commit/4b49f902ec6f2bb382cbbf489870573f4b43371e https://gitlab.freedesktop.org/gfx-ci/linux/-/commit/38cdf4c5559771e2474ae0fecef8469f65147bc1 But given that sdm845 is similar to sc7180 as far as kernel gpu driver, it is probably just better to skip these on sdm845 (with a comment referring to the hack patches we use in mesa CI) BR, -R > > Thanks, it looks like you also have a relatively recent igt (there > were some msm_submit fails until I fixed the test).. > > BR, > -R > > > Regards, > > Vignesh
Re: [PATCH] drm/ci: Add msm tests
On Fri, Jan 12, 2024 at 3:42 AM Vignesh Raman wrote: > > Hi Rob, > > > On 09/01/24 01:20, Rob Clark wrote: > > From: Rob Clark > > > > The msm tests should skip on non-msm hw, so I think it should be safe to > > enable everywhere. > > > > Signed-off-by: Rob Clark > > --- > > drivers/gpu/drm/ci/testlist.txt | 49 + > > 1 file changed, 49 insertions(+) > > > > diff --git a/drivers/gpu/drm/ci/testlist.txt > > b/drivers/gpu/drm/ci/testlist.txt > > index f82cd90372f4..eaeb751bb0ad 100644 > > --- a/drivers/gpu/drm/ci/testlist.txt > > +++ b/drivers/gpu/drm/ci/testlist.txt > > @@ -2910,3 +2910,52 @@ kms_writeback@writeback-invalid-parameters > > kms_writeback@writeback-fb-id > > kms_writeback@writeback-check-output > > prime_mmap_kms@buffer-sharing > > +msm_shrink@copy-gpu-sanitycheck-8 > > +msm_shrink@copy-gpu-sanitycheck-32 > > +msm_shrink@copy-gpu-8 > > +msm_shrink@copy-gpu-32 > > +msm_shrink@copy-gpu-madvise-8 > > +msm_shrink@copy-gpu-madvise-32 > > +msm_shrink@copy-gpu-oom-8 > > +msm_shrink@copy-gpu-oom-32 > > +msm_shrink@copy-mmap-sanitycheck-8 > > +msm_shrink@copy-mmap-sanitycheck-32 > > +msm_shrink@copy-mmap-8 > > +msm_shrink@copy-mmap-32 > > +msm_shrink@copy-mmap-madvise-8 > > +msm_shrink@copy-mmap-madvise-32 > > +msm_shrink@copy-mmap-oom-8 > > +msm_shrink@copy-mmap-oom-32 > > +msm_shrink@copy-mmap-dmabuf-sanitycheck-8 > > +msm_shrink@copy-mmap-dmabuf-sanitycheck-32 > > +msm_shrink@copy-mmap-dmabuf-8 > > +msm_shrink@copy-mmap-dmabuf-32 > > +msm_shrink@copy-mmap-dmabuf-madvise-8 > > +msm_shrink@copy-mmap-dmabuf-madvise-32 > > +msm_shrink@copy-mmap-dmabuf-oom-8 > > +msm_shrink@copy-mmap-dmabuf-oom-32 > > +msm_mapping@ring > > +msm_mapping@sqefw > > +msm_mapping@shadow > > +msm_submitoverhead@submitbench-10-bos > > +msm_submitoverhead@submitbench-10-bos-no-implicit-sync > > +msm_submitoverhead@submitbench-100-bos > > +msm_submitoverhead@submitbench-100-bos-no-implicit-sync > > +msm_submitoverhead@submitbench-250-bos > > +msm_submitoverhead@submitbench-250-bos-no-implicit-sync > > +msm_submitoverhead@submitbench-500-bos > > +msm_submitoverhead@submitbench-500-bos-no-implicit-sync > > +msm_submitoverhead@submitbench-1000-bos > > +msm_submitoverhead@submitbench-1000-bos-no-implicit-sync > > +msm_recovery@hangcheck > > +msm_recovery@gpu-fault > > +msm_recovery@gpu-fault-parallel > > +msm_recovery@iova-fault > > +msm_submit@empty-submit > > +msm_submit@invalid-queue-submit > > +msm_submit@invalid-flags-submit > > +msm_submit@invalid-in-fence-submit > > +msm_submit@invalid-duplicate-bo-submit > > +msm_submit@invalid-cmd-idx-submit > > +msm_submit@invalid-cmd-type-submit > > +msm_submit@valid-submit > > I tested this patch with latest drm-misc/drm-misc-next and there was > some failures seen for the newly added msm tests. I have updated the > xfails with below commit, > > https://gitlab.freedesktop.org/vigneshraman/linux/-/commit/d012893597a661d6ebbb755bf2607dfb055524a1 > > I will notify the maintainers about the flaky tests, update the url in > the flakes.txt, and submit a separate patch for this change. Thanks, it looks like you also have a relatively recent igt (there were some msm_submit fails until I fixed the test).. BR, -R > Regards, > Vignesh
Re: [PATCH] drm/ci: Add msm tests
Hi Rob, On 09/01/24 01:20, Rob Clark wrote: From: Rob Clark The msm tests should skip on non-msm hw, so I think it should be safe to enable everywhere. Signed-off-by: Rob Clark --- drivers/gpu/drm/ci/testlist.txt | 49 + 1 file changed, 49 insertions(+) diff --git a/drivers/gpu/drm/ci/testlist.txt b/drivers/gpu/drm/ci/testlist.txt index f82cd90372f4..eaeb751bb0ad 100644 --- a/drivers/gpu/drm/ci/testlist.txt +++ b/drivers/gpu/drm/ci/testlist.txt @@ -2910,3 +2910,52 @@ kms_writeback@writeback-invalid-parameters kms_writeback@writeback-fb-id kms_writeback@writeback-check-output prime_mmap_kms@buffer-sharing +msm_shrink@copy-gpu-sanitycheck-8 +msm_shrink@copy-gpu-sanitycheck-32 +msm_shrink@copy-gpu-8 +msm_shrink@copy-gpu-32 +msm_shrink@copy-gpu-madvise-8 +msm_shrink@copy-gpu-madvise-32 +msm_shrink@copy-gpu-oom-8 +msm_shrink@copy-gpu-oom-32 +msm_shrink@copy-mmap-sanitycheck-8 +msm_shrink@copy-mmap-sanitycheck-32 +msm_shrink@copy-mmap-8 +msm_shrink@copy-mmap-32 +msm_shrink@copy-mmap-madvise-8 +msm_shrink@copy-mmap-madvise-32 +msm_shrink@copy-mmap-oom-8 +msm_shrink@copy-mmap-oom-32 +msm_shrink@copy-mmap-dmabuf-sanitycheck-8 +msm_shrink@copy-mmap-dmabuf-sanitycheck-32 +msm_shrink@copy-mmap-dmabuf-8 +msm_shrink@copy-mmap-dmabuf-32 +msm_shrink@copy-mmap-dmabuf-madvise-8 +msm_shrink@copy-mmap-dmabuf-madvise-32 +msm_shrink@copy-mmap-dmabuf-oom-8 +msm_shrink@copy-mmap-dmabuf-oom-32 +msm_mapping@ring +msm_mapping@sqefw +msm_mapping@shadow +msm_submitoverhead@submitbench-10-bos +msm_submitoverhead@submitbench-10-bos-no-implicit-sync +msm_submitoverhead@submitbench-100-bos +msm_submitoverhead@submitbench-100-bos-no-implicit-sync +msm_submitoverhead@submitbench-250-bos +msm_submitoverhead@submitbench-250-bos-no-implicit-sync +msm_submitoverhead@submitbench-500-bos +msm_submitoverhead@submitbench-500-bos-no-implicit-sync +msm_submitoverhead@submitbench-1000-bos +msm_submitoverhead@submitbench-1000-bos-no-implicit-sync +msm_recovery@hangcheck +msm_recovery@gpu-fault +msm_recovery@gpu-fault-parallel +msm_recovery@iova-fault +msm_submit@empty-submit +msm_submit@invalid-queue-submit +msm_submit@invalid-flags-submit +msm_submit@invalid-in-fence-submit +msm_submit@invalid-duplicate-bo-submit +msm_submit@invalid-cmd-idx-submit +msm_submit@invalid-cmd-type-submit +msm_submit@valid-submit I tested this patch with latest drm-misc/drm-misc-next and there was some failures seen for the newly added msm tests. I have updated the xfails with below commit, https://gitlab.freedesktop.org/vigneshraman/linux/-/commit/d012893597a661d6ebbb755bf2607dfb055524a1 I will notify the maintainers about the flaky tests, update the url in the flakes.txt, and submit a separate patch for this change. Regards, Vignesh
Re: [PATCH] drm/ci: Add msm tests
On 1/9/2024 7:31 AM, Rob Clark wrote: On Mon, Jan 8, 2024 at 6:13 PM Rob Clark wrote: On Mon, Jan 8, 2024 at 2:58 PM Abhinav Kumar wrote: On 1/8/2024 11:50 AM, Rob Clark wrote: From: Rob Clark The msm tests should skip on non-msm hw, so I think it should be safe to enable everywhere. Signed-off-by: Rob Clark --- drivers/gpu/drm/ci/testlist.txt | 49 + 1 file changed, 49 insertions(+) I do see that all these tests use igt_msm_dev_open() to make sure it opens only the MSM card. But if igt_msm_dev_open() fails, I dont see a igt_require() on some of the tests to skip them. So how will it safely skip on non-msm HW? Unless i am missing something here hmm, at the time I added the initial msm tests, and igt_msm_dev_open(), I verified that they skipped on intel.. but since then I'd switched from intel to sc8280xp device for primary dev device, so I'd need to re-test to remember how it works. If these aren't skipping on !msm, it is a bug I double checked, these tests skip in drm_open_driver() with "No known gpu found for chipset flags 0x64 (msm)", so no problem to run them on all CI runners. BR, -R Ack, thanks for checking Reviewed-by: Abhinav Kumar BR, -R diff --git a/drivers/gpu/drm/ci/testlist.txt b/drivers/gpu/drm/ci/testlist.txt index f82cd90372f4..eaeb751bb0ad 100644 --- a/drivers/gpu/drm/ci/testlist.txt +++ b/drivers/gpu/drm/ci/testlist.txt @@ -2910,3 +2910,52 @@ kms_writeback@writeback-invalid-parameters kms_writeback@writeback-fb-id kms_writeback@writeback-check-output prime_mmap_kms@buffer-sharing +msm_shrink@copy-gpu-sanitycheck-8 +msm_shrink@copy-gpu-sanitycheck-32 +msm_shrink@copy-gpu-8 +msm_shrink@copy-gpu-32 +msm_shrink@copy-gpu-madvise-8 +msm_shrink@copy-gpu-madvise-32 +msm_shrink@copy-gpu-oom-8 +msm_shrink@copy-gpu-oom-32 +msm_shrink@copy-mmap-sanitycheck-8 +msm_shrink@copy-mmap-sanitycheck-32 +msm_shrink@copy-mmap-8 +msm_shrink@copy-mmap-32 +msm_shrink@copy-mmap-madvise-8 +msm_shrink@copy-mmap-madvise-32 +msm_shrink@copy-mmap-oom-8 +msm_shrink@copy-mmap-oom-32 +msm_shrink@copy-mmap-dmabuf-sanitycheck-8 +msm_shrink@copy-mmap-dmabuf-sanitycheck-32 +msm_shrink@copy-mmap-dmabuf-8 +msm_shrink@copy-mmap-dmabuf-32 +msm_shrink@copy-mmap-dmabuf-madvise-8 +msm_shrink@copy-mmap-dmabuf-madvise-32 +msm_shrink@copy-mmap-dmabuf-oom-8 +msm_shrink@copy-mmap-dmabuf-oom-32 +msm_mapping@ring +msm_mapping@sqefw +msm_mapping@shadow +msm_submitoverhead@submitbench-10-bos +msm_submitoverhead@submitbench-10-bos-no-implicit-sync +msm_submitoverhead@submitbench-100-bos +msm_submitoverhead@submitbench-100-bos-no-implicit-sync +msm_submitoverhead@submitbench-250-bos +msm_submitoverhead@submitbench-250-bos-no-implicit-sync +msm_submitoverhead@submitbench-500-bos +msm_submitoverhead@submitbench-500-bos-no-implicit-sync +msm_submitoverhead@submitbench-1000-bos +msm_submitoverhead@submitbench-1000-bos-no-implicit-sync +msm_recovery@hangcheck +msm_recovery@gpu-fault +msm_recovery@gpu-fault-parallel +msm_recovery@iova-fault +msm_submit@empty-submit +msm_submit@invalid-queue-submit +msm_submit@invalid-flags-submit +msm_submit@invalid-in-fence-submit +msm_submit@invalid-duplicate-bo-submit +msm_submit@invalid-cmd-idx-submit +msm_submit@invalid-cmd-type-submit +msm_submit@valid-submit
Re: [PATCH] drm/ci: Add msm tests
On Mon, Jan 8, 2024 at 6:13 PM Rob Clark wrote: > > On Mon, Jan 8, 2024 at 2:58 PM Abhinav Kumar > wrote: > > > > > > > > On 1/8/2024 11:50 AM, Rob Clark wrote: > > > From: Rob Clark > > > > > > The msm tests should skip on non-msm hw, so I think it should be safe to > > > enable everywhere. > > > > > > Signed-off-by: Rob Clark > > > --- > > > drivers/gpu/drm/ci/testlist.txt | 49 + > > > 1 file changed, 49 insertions(+) > > > > > > > I do see that all these tests use igt_msm_dev_open() to make sure it > > opens only the MSM card. > > > > But if igt_msm_dev_open() fails, I dont see a igt_require() on some of > > the tests to skip them. So how will it safely skip on non-msm HW? > > > > Unless i am missing something here > > hmm, at the time I added the initial msm tests, and > igt_msm_dev_open(), I verified that they skipped on intel.. but since > then I'd switched from intel to sc8280xp device for primary dev > device, so I'd need to re-test to remember how it works. If these > aren't skipping on !msm, it is a bug I double checked, these tests skip in drm_open_driver() with "No known gpu found for chipset flags 0x64 (msm)", so no problem to run them on all CI runners. BR, -R > BR, > -R > > > > diff --git a/drivers/gpu/drm/ci/testlist.txt > > > b/drivers/gpu/drm/ci/testlist.txt > > > index f82cd90372f4..eaeb751bb0ad 100644 > > > --- a/drivers/gpu/drm/ci/testlist.txt > > > +++ b/drivers/gpu/drm/ci/testlist.txt > > > @@ -2910,3 +2910,52 @@ kms_writeback@writeback-invalid-parameters > > > kms_writeback@writeback-fb-id > > > kms_writeback@writeback-check-output > > > prime_mmap_kms@buffer-sharing > > > +msm_shrink@copy-gpu-sanitycheck-8 > > > +msm_shrink@copy-gpu-sanitycheck-32 > > > +msm_shrink@copy-gpu-8 > > > +msm_shrink@copy-gpu-32 > > > +msm_shrink@copy-gpu-madvise-8 > > > +msm_shrink@copy-gpu-madvise-32 > > > +msm_shrink@copy-gpu-oom-8 > > > +msm_shrink@copy-gpu-oom-32 > > > +msm_shrink@copy-mmap-sanitycheck-8 > > > +msm_shrink@copy-mmap-sanitycheck-32 > > > +msm_shrink@copy-mmap-8 > > > +msm_shrink@copy-mmap-32 > > > +msm_shrink@copy-mmap-madvise-8 > > > +msm_shrink@copy-mmap-madvise-32 > > > +msm_shrink@copy-mmap-oom-8 > > > +msm_shrink@copy-mmap-oom-32 > > > +msm_shrink@copy-mmap-dmabuf-sanitycheck-8 > > > +msm_shrink@copy-mmap-dmabuf-sanitycheck-32 > > > +msm_shrink@copy-mmap-dmabuf-8 > > > +msm_shrink@copy-mmap-dmabuf-32 > > > +msm_shrink@copy-mmap-dmabuf-madvise-8 > > > +msm_shrink@copy-mmap-dmabuf-madvise-32 > > > +msm_shrink@copy-mmap-dmabuf-oom-8 > > > +msm_shrink@copy-mmap-dmabuf-oom-32 > > > +msm_mapping@ring > > > +msm_mapping@sqefw > > > +msm_mapping@shadow > > > +msm_submitoverhead@submitbench-10-bos > > > +msm_submitoverhead@submitbench-10-bos-no-implicit-sync > > > +msm_submitoverhead@submitbench-100-bos > > > +msm_submitoverhead@submitbench-100-bos-no-implicit-sync > > > +msm_submitoverhead@submitbench-250-bos > > > +msm_submitoverhead@submitbench-250-bos-no-implicit-sync > > > +msm_submitoverhead@submitbench-500-bos > > > +msm_submitoverhead@submitbench-500-bos-no-implicit-sync > > > +msm_submitoverhead@submitbench-1000-bos > > > +msm_submitoverhead@submitbench-1000-bos-no-implicit-sync > > > +msm_recovery@hangcheck > > > +msm_recovery@gpu-fault > > > +msm_recovery@gpu-fault-parallel > > > +msm_recovery@iova-fault > > > +msm_submit@empty-submit > > > +msm_submit@invalid-queue-submit > > > +msm_submit@invalid-flags-submit > > > +msm_submit@invalid-in-fence-submit > > > +msm_submit@invalid-duplicate-bo-submit > > > +msm_submit@invalid-cmd-idx-submit > > > +msm_submit@invalid-cmd-type-submit > > > +msm_submit@valid-submit
Re: [PATCH] drm/ci: Add msm tests
On Mon, Jan 8, 2024 at 2:58 PM Abhinav Kumar wrote: > > > > On 1/8/2024 11:50 AM, Rob Clark wrote: > > From: Rob Clark > > > > The msm tests should skip on non-msm hw, so I think it should be safe to > > enable everywhere. > > > > Signed-off-by: Rob Clark > > --- > > drivers/gpu/drm/ci/testlist.txt | 49 + > > 1 file changed, 49 insertions(+) > > > > I do see that all these tests use igt_msm_dev_open() to make sure it > opens only the MSM card. > > But if igt_msm_dev_open() fails, I dont see a igt_require() on some of > the tests to skip them. So how will it safely skip on non-msm HW? > > Unless i am missing something here hmm, at the time I added the initial msm tests, and igt_msm_dev_open(), I verified that they skipped on intel.. but since then I'd switched from intel to sc8280xp device for primary dev device, so I'd need to re-test to remember how it works. If these aren't skipping on !msm, it is a bug BR, -R > > diff --git a/drivers/gpu/drm/ci/testlist.txt > > b/drivers/gpu/drm/ci/testlist.txt > > index f82cd90372f4..eaeb751bb0ad 100644 > > --- a/drivers/gpu/drm/ci/testlist.txt > > +++ b/drivers/gpu/drm/ci/testlist.txt > > @@ -2910,3 +2910,52 @@ kms_writeback@writeback-invalid-parameters > > kms_writeback@writeback-fb-id > > kms_writeback@writeback-check-output > > prime_mmap_kms@buffer-sharing > > +msm_shrink@copy-gpu-sanitycheck-8 > > +msm_shrink@copy-gpu-sanitycheck-32 > > +msm_shrink@copy-gpu-8 > > +msm_shrink@copy-gpu-32 > > +msm_shrink@copy-gpu-madvise-8 > > +msm_shrink@copy-gpu-madvise-32 > > +msm_shrink@copy-gpu-oom-8 > > +msm_shrink@copy-gpu-oom-32 > > +msm_shrink@copy-mmap-sanitycheck-8 > > +msm_shrink@copy-mmap-sanitycheck-32 > > +msm_shrink@copy-mmap-8 > > +msm_shrink@copy-mmap-32 > > +msm_shrink@copy-mmap-madvise-8 > > +msm_shrink@copy-mmap-madvise-32 > > +msm_shrink@copy-mmap-oom-8 > > +msm_shrink@copy-mmap-oom-32 > > +msm_shrink@copy-mmap-dmabuf-sanitycheck-8 > > +msm_shrink@copy-mmap-dmabuf-sanitycheck-32 > > +msm_shrink@copy-mmap-dmabuf-8 > > +msm_shrink@copy-mmap-dmabuf-32 > > +msm_shrink@copy-mmap-dmabuf-madvise-8 > > +msm_shrink@copy-mmap-dmabuf-madvise-32 > > +msm_shrink@copy-mmap-dmabuf-oom-8 > > +msm_shrink@copy-mmap-dmabuf-oom-32 > > +msm_mapping@ring > > +msm_mapping@sqefw > > +msm_mapping@shadow > > +msm_submitoverhead@submitbench-10-bos > > +msm_submitoverhead@submitbench-10-bos-no-implicit-sync > > +msm_submitoverhead@submitbench-100-bos > > +msm_submitoverhead@submitbench-100-bos-no-implicit-sync > > +msm_submitoverhead@submitbench-250-bos > > +msm_submitoverhead@submitbench-250-bos-no-implicit-sync > > +msm_submitoverhead@submitbench-500-bos > > +msm_submitoverhead@submitbench-500-bos-no-implicit-sync > > +msm_submitoverhead@submitbench-1000-bos > > +msm_submitoverhead@submitbench-1000-bos-no-implicit-sync > > +msm_recovery@hangcheck > > +msm_recovery@gpu-fault > > +msm_recovery@gpu-fault-parallel > > +msm_recovery@iova-fault > > +msm_submit@empty-submit > > +msm_submit@invalid-queue-submit > > +msm_submit@invalid-flags-submit > > +msm_submit@invalid-in-fence-submit > > +msm_submit@invalid-duplicate-bo-submit > > +msm_submit@invalid-cmd-idx-submit > > +msm_submit@invalid-cmd-type-submit > > +msm_submit@valid-submit
Re: [PATCH] drm/ci: Add msm tests
On 1/8/2024 11:50 AM, Rob Clark wrote: From: Rob Clark The msm tests should skip on non-msm hw, so I think it should be safe to enable everywhere. Signed-off-by: Rob Clark --- drivers/gpu/drm/ci/testlist.txt | 49 + 1 file changed, 49 insertions(+) I do see that all these tests use igt_msm_dev_open() to make sure it opens only the MSM card. But if igt_msm_dev_open() fails, I dont see a igt_require() on some of the tests to skip them. So how will it safely skip on non-msm HW? Unless i am missing something here diff --git a/drivers/gpu/drm/ci/testlist.txt b/drivers/gpu/drm/ci/testlist.txt index f82cd90372f4..eaeb751bb0ad 100644 --- a/drivers/gpu/drm/ci/testlist.txt +++ b/drivers/gpu/drm/ci/testlist.txt @@ -2910,3 +2910,52 @@ kms_writeback@writeback-invalid-parameters kms_writeback@writeback-fb-id kms_writeback@writeback-check-output prime_mmap_kms@buffer-sharing +msm_shrink@copy-gpu-sanitycheck-8 +msm_shrink@copy-gpu-sanitycheck-32 +msm_shrink@copy-gpu-8 +msm_shrink@copy-gpu-32 +msm_shrink@copy-gpu-madvise-8 +msm_shrink@copy-gpu-madvise-32 +msm_shrink@copy-gpu-oom-8 +msm_shrink@copy-gpu-oom-32 +msm_shrink@copy-mmap-sanitycheck-8 +msm_shrink@copy-mmap-sanitycheck-32 +msm_shrink@copy-mmap-8 +msm_shrink@copy-mmap-32 +msm_shrink@copy-mmap-madvise-8 +msm_shrink@copy-mmap-madvise-32 +msm_shrink@copy-mmap-oom-8 +msm_shrink@copy-mmap-oom-32 +msm_shrink@copy-mmap-dmabuf-sanitycheck-8 +msm_shrink@copy-mmap-dmabuf-sanitycheck-32 +msm_shrink@copy-mmap-dmabuf-8 +msm_shrink@copy-mmap-dmabuf-32 +msm_shrink@copy-mmap-dmabuf-madvise-8 +msm_shrink@copy-mmap-dmabuf-madvise-32 +msm_shrink@copy-mmap-dmabuf-oom-8 +msm_shrink@copy-mmap-dmabuf-oom-32 +msm_mapping@ring +msm_mapping@sqefw +msm_mapping@shadow +msm_submitoverhead@submitbench-10-bos +msm_submitoverhead@submitbench-10-bos-no-implicit-sync +msm_submitoverhead@submitbench-100-bos +msm_submitoverhead@submitbench-100-bos-no-implicit-sync +msm_submitoverhead@submitbench-250-bos +msm_submitoverhead@submitbench-250-bos-no-implicit-sync +msm_submitoverhead@submitbench-500-bos +msm_submitoverhead@submitbench-500-bos-no-implicit-sync +msm_submitoverhead@submitbench-1000-bos +msm_submitoverhead@submitbench-1000-bos-no-implicit-sync +msm_recovery@hangcheck +msm_recovery@gpu-fault +msm_recovery@gpu-fault-parallel +msm_recovery@iova-fault +msm_submit@empty-submit +msm_submit@invalid-queue-submit +msm_submit@invalid-flags-submit +msm_submit@invalid-in-fence-submit +msm_submit@invalid-duplicate-bo-submit +msm_submit@invalid-cmd-idx-submit +msm_submit@invalid-cmd-type-submit +msm_submit@valid-submit
