Re: [PATCH] drm/i915/hwmon: Enable PL1 power limit

2023-02-07 Thread Matthew Auld
On Tue, 7 Feb 2023 at 17:19, Dixit, Ashutosh wrote: > > On Tue, 07 Feb 2023 08:12:25 -0800, Dixit, Ashutosh wrote: > > > > On Tue, 07 Feb 2023 01:32:44 -0800, Matthew Auld wrote: > > > > > > On Fri, 3 Feb 2023 at 15:54, Ashutosh Dixit > > > wrote: > > > > > > > > Previous documentation

Re: [PATCH] drm/i915/hwmon: Enable PL1 power limit

2023-02-07 Thread Dixit, Ashutosh
On Tue, 07 Feb 2023 08:12:25 -0800, Dixit, Ashutosh wrote: > > On Tue, 07 Feb 2023 01:32:44 -0800, Matthew Auld wrote: > > > > On Fri, 3 Feb 2023 at 15:54, Ashutosh Dixit > > wrote: > > > > > > Previous documentation suggested that PL1 power limit is always > > > enabled. However we now find

Re: [PATCH] drm/i915/hwmon: Enable PL1 power limit

2023-02-07 Thread Dixit, Ashutosh
On Tue, 07 Feb 2023 01:32:44 -0800, Matthew Auld wrote: > > On Fri, 3 Feb 2023 at 15:54, Ashutosh Dixit wrote: > > > > Previous documentation suggested that PL1 power limit is always > > enabled. However we now find this not to be the case on some > > platforms (such as ATSM). Therefore enable

Re: [PATCH] drm/i915/hwmon: Enable PL1 power limit

2023-02-07 Thread Matthew Auld
On Fri, 3 Feb 2023 at 15:54, Ashutosh Dixit wrote: > > Previous documentation suggested that PL1 power limit is always > enabled. However we now find this not to be the case on some > platforms (such as ATSM). Therefore enable PL1 power limit during hwmon > initialization. For some reason it

Re: [PATCH] drm/i915/hwmon: Enable PL1 power limit

2023-02-02 Thread Gwan-gyeong Mun
looks good to me, but could you please add bpsec# to commit log? Reviewed-by: Gwan-gyeong Mun On 2/2/23 4:52 AM, Ashutosh Dixit wrote: Previous documentation suggested that PL1 power limit is always enabled. However we now find this not to be the case on some platforms (such as ATSM).