Re: [PATCH] drm/vkms: Don't warn hrtimer_forward_now failure.

2020-05-27 Thread Daniel Vetter
On Tue, May 26, 2020 at 01:11:28PM +0200, Daniel Vetter wrote: > On Tue, May 26, 2020 at 6:39 AM Tetsuo Handa > wrote: > > > > On 2020/05/26 13:18, Tetsuo Handa wrote: > > > due to mode->crtc_clock <= 0. Thus, somehow initializing mode->crtc_clock > > > > 0 might be able > > > to solve this

Re: [PATCH] drm/vkms: Don't warn hrtimer_forward_now failure.

2020-05-26 Thread Daniel Vetter
On Tue, May 26, 2020 at 6:39 AM Tetsuo Handa wrote: > > On 2020/05/26 13:18, Tetsuo Handa wrote: > > due to mode->crtc_clock <= 0. Thus, somehow initializing mode->crtc_clock > > > 0 might be able > > to solve this problem. > > Well, I came to think that vkms_enable_vblank() should return an

Re: [PATCH] drm/vkms: Don't warn hrtimer_forward_now failure.

2020-05-26 Thread Tetsuo Handa
On 2020/05/26 2:00, Daniel Vetter wrote: > Forgot to add: I did run this quickly with vkms as secondary output. > Good fireworks show, but there's an entire army of additional splats > after the first one. The WARN_ON you're removing is only the > messenger, the real bug is probably one of the

Re: [PATCH] drm/vkms: Don't warn hrtimer_forward_now failure.

2020-05-26 Thread Tetsuo Handa
On 2020/05/26 13:18, Tetsuo Handa wrote: > due to mode->crtc_clock <= 0. Thus, somehow initializing mode->crtc_clock > 0 > might be able > to solve this problem. Well, I came to think that vkms_enable_vblank() should return an error to the caller when drm_calc_timestamping_constants() failed...

Re: [PATCH] drm/vkms: Don't warn hrtimer_forward_now failure.

2020-05-26 Thread Tetsuo Handa
On 2020/05/26 0:21, Daniel Vetter wrote: > On Mon, May 25, 2020 at 11:38:49PM +0900, Tetsuo Handa wrote: >> Commit 3a0709928b172a41 ("drm/vkms: Add vblank events simulated by >> hrtimers") introduced ret_overrun variable. And that variable was an >> unused-but-set-variable until commit

Re: [PATCH] drm/vkms: Don't warn hrtimer_forward_now failure.

2020-05-25 Thread Daniel Vetter
On Mon, May 25, 2020 at 5:34 PM Tetsuo Handa wrote: > > On 2020/05/26 0:21, Daniel Vetter wrote: > > On Mon, May 25, 2020 at 11:38:49PM +0900, Tetsuo Handa wrote: > >> Commit 3a0709928b172a41 ("drm/vkms: Add vblank events simulated by > >> hrtimers") introduced ret_overrun variable. And that

Re: [PATCH] drm/vkms: Don't warn hrtimer_forward_now failure.

2020-05-25 Thread Daniel Vetter
On Mon, May 25, 2020 at 5:34 PM Tetsuo Handa wrote: > > On 2020/05/26 0:21, Daniel Vetter wrote: > > On Mon, May 25, 2020 at 11:38:49PM +0900, Tetsuo Handa wrote: > >> Commit 3a0709928b172a41 ("drm/vkms: Add vblank events simulated by > >> hrtimers") introduced ret_overrun variable. And that

Re: [PATCH] drm/vkms: Don't warn hrtimer_forward_now failure.

2020-05-25 Thread Daniel Vetter
On Mon, May 25, 2020 at 11:38:49PM +0900, Tetsuo Handa wrote: > Commit 3a0709928b172a41 ("drm/vkms: Add vblank events simulated by > hrtimers") introduced ret_overrun variable. And that variable was an > unused-but-set-variable until commit 09ef09b4ab95dc40 ("drm/vkms: > WARN when