Re: [PATCH] drm: Shift wrap bug in create_in_format_blob()

2017-08-10 Thread Dan Carpenter
On Wed, Aug 09, 2017 at 03:38:33PM +0100, Daniel Stone wrote: > On 9 August 2017 at 15:36, Sean Paul wrote: > > On Wed, Aug 09, 2017 at 02:19:06PM +0300, Dan Carpenter wrote: > >> "plane->format_count" can go up to 64. (It's capped in > >> drm_universal_plane_init().) So we should be using ULL t

Re: [PATCH] drm: Shift wrap bug in create_in_format_blob()

2017-08-09 Thread Daniel Stone
On 9 August 2017 at 15:36, Sean Paul wrote: > On Wed, Aug 09, 2017 at 02:19:06PM +0300, Dan Carpenter wrote: >> "plane->format_count" can go up to 64. (It's capped in >> drm_universal_plane_init().) So we should be using ULL type instead of >> int here to prevent shift wrapping. >> >> Fixes: db1

Re: [PATCH] drm: Shift wrap bug in create_in_format_blob()

2017-08-09 Thread Sean Paul
On Wed, Aug 09, 2017 at 02:19:06PM +0300, Dan Carpenter wrote: > "plane->format_count" can go up to 64. (It's capped in > drm_universal_plane_init().) So we should be using ULL type instead of > int here to prevent shift wrapping. > > Fixes: db1689aa61bd ("drm: Create a format/modifier blob") >