Re: [PATCH -next] drm/shmob: Fix return value check in shmob_drm_probe

On Mon, Dec 17, 2018 at 05:18:30PM +0800, YueHaibing wrote: > In case of error, the function devm_ioremap_resource() returns ERR_PTR() > and never returns NULL. The NULL test in the return value check should > be replaced with IS_ERR(). > > Fixes: 8f1597c8f1a5 ("drm: shmobile: Perform

Re: [PATCH -next] drm/shmob: Fix return value check in shmob_drm_probe

Hi Yue, Thank you for the patch. On Monday, 17 December 2018 11:18:30 EET YueHaibing wrote: > In case of error, the function devm_ioremap_resource() returns ERR_PTR() > and never returns NULL. The NULL test in the return value check should > be replaced with IS_ERR(). > > Fixes: 8f1597c8f1a5

Re: [PATCH -next] drm/shmob: Fix return value check in shmob_drm_probe

Hi YeuHaibing, On 17/12/2018 09:18, YueHaibing wrote: > In case of error, the function devm_ioremap_resource() returns ERR_PTR() > and never returns NULL. The NULL test in the return value check should > be replaced with IS_ERR(). > This looks correct to me. I wonder if this failure pattern

Re: [PATCH -next] drm/shmob: fix return value check in shmob_drm_probe()

Hi Wei, Thank you for the patch. On Tuesday 25 Apr 2017 03:08:08 Wei Yongjun wrote: > From: Wei Yongjun > > In case of error, the function devm_ioremap_resource() returns ERR_PTR() > and never returns NULL. The NULL test in the return value check should > be replaced