Re: [PATCH 0/9] implicit fencing clarification

2018-04-09 Thread Daniel Vetter
On Fri, Apr 06, 2018 at 10:38:38AM +0300, Oleksandr Andrushchenko wrote:
> Hi, Daniel!
> 
> It seems that this series misses xen-front's
> "Use simple_display_pipe prepare_fb helper" change?

Hm indeed, I guess I was on an older tree. Will follow up. Care to review
the other patches meanwhile?
-Daniel

> 
> Thank you,
> Oleksandr
> 
> On 04/05/2018 06:44 PM, Daniel Vetter wrote:
> > Hi all,
> > 
> > Somewhat motivated (but only really tangentially) by the dirtyfb
> > discussion with Rob and Thomas I started digging around in the various
> > driver implementations for implicit vs. explicit fencing.
> > 
> > There's definitely a huge pile of drivers which don't do any implicit
> > fencing at all - not sure that's good or not. And for some of the drivers
> > with more history I think they don't correctly overwrite implicit fencing
> > when explicit fencing is present. At least I've gotten lost in the mazes
> > before I found positive proof.
> > 
> > So this is just the lower hanging stuff, plus a doc patch to hopefully
> > clarify this all better.
> > 
> > Comments and review and especially in the case of the msm/vc4 patches,
> > also testing, very much welcome.
> > 
> > Thanks, Daniel
> > 
> > Daniel Vetter (9):
> >drm/vmwgfx: Remove no-op prepare/cleanup_fb callbacks
> >drm: Move simple_display_pipe prepare_fb helper into gem fb helpers
> >drm/tve200: Use simple_display_pipe prepare_fb helper
> >drm/pl111: Use simple_display_pipe prepare_fb helper
> >drm/mxsfb: Use simple_display_pipe prepare_fb helper
> >drm/atomic: better doc for implicit vs explicit fencing
> >drm/gem-fb-helper: Always do implicit sync
> >drm/vc4: Always obey implicit sync
> >drm/msm: Always obey implicit fencing
> > 
> >   drivers/gpu/drm/drm_atomic.c |  8 +++
> >   drivers/gpu/drm/drm_gem_framebuffer_helper.c | 21 -
> >   drivers/gpu/drm/msm/msm_atomic.c |  2 +-
> >   drivers/gpu/drm/mxsfb/mxsfb_drv.c|  8 +--
> >   drivers/gpu/drm/pl111/pl111_display.c|  8 +--
> >   drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c  | 17 --
> >   drivers/gpu/drm/tinydrm/ili9225.c|  2 +-
> >   drivers/gpu/drm/tinydrm/mi0283qt.c   |  3 ++-
> >   drivers/gpu/drm/tinydrm/repaper.c|  2 +-
> >   drivers/gpu/drm/tinydrm/st7586.c |  2 +-
> >   drivers/gpu/drm/tinydrm/st7735r.c|  2 +-
> >   drivers/gpu/drm/tve200/tve200_display.c  |  8 +--
> >   drivers/gpu/drm/vc4/vc4_plane.c  | 11 +
> >   drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c  | 35 
> > 
> >   include/drm/drm_gem_framebuffer_helper.h |  3 +++
> >   include/drm/drm_modeset_helper_vtables.h |  5 +++-
> >   include/drm/drm_plane.h  |  7 +-
> >   include/drm/drm_simple_kms_helper.h  |  3 +++
> >   include/drm/tinydrm/tinydrm.h|  2 --
> >   19 files changed, 61 insertions(+), 88 deletions(-)
> > 
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel


Re: [PATCH 0/9] implicit fencing clarification

2018-04-06 Thread Oleksandr Andrushchenko

Hi, Daniel!

It seems that this series misses xen-front's
"Use simple_display_pipe prepare_fb helper" change?

Thank you,
Oleksandr

On 04/05/2018 06:44 PM, Daniel Vetter wrote:

Hi all,

Somewhat motivated (but only really tangentially) by the dirtyfb
discussion with Rob and Thomas I started digging around in the various
driver implementations for implicit vs. explicit fencing.

There's definitely a huge pile of drivers which don't do any implicit
fencing at all - not sure that's good or not. And for some of the drivers
with more history I think they don't correctly overwrite implicit fencing
when explicit fencing is present. At least I've gotten lost in the mazes
before I found positive proof.

So this is just the lower hanging stuff, plus a doc patch to hopefully
clarify this all better.

Comments and review and especially in the case of the msm/vc4 patches,
also testing, very much welcome.

Thanks, Daniel

Daniel Vetter (9):
   drm/vmwgfx: Remove no-op prepare/cleanup_fb callbacks
   drm: Move simple_display_pipe prepare_fb helper into gem fb helpers
   drm/tve200: Use simple_display_pipe prepare_fb helper
   drm/pl111: Use simple_display_pipe prepare_fb helper
   drm/mxsfb: Use simple_display_pipe prepare_fb helper
   drm/atomic: better doc for implicit vs explicit fencing
   drm/gem-fb-helper: Always do implicit sync
   drm/vc4: Always obey implicit sync
   drm/msm: Always obey implicit fencing

  drivers/gpu/drm/drm_atomic.c |  8 +++
  drivers/gpu/drm/drm_gem_framebuffer_helper.c | 21 -
  drivers/gpu/drm/msm/msm_atomic.c |  2 +-
  drivers/gpu/drm/mxsfb/mxsfb_drv.c|  8 +--
  drivers/gpu/drm/pl111/pl111_display.c|  8 +--
  drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c  | 17 --
  drivers/gpu/drm/tinydrm/ili9225.c|  2 +-
  drivers/gpu/drm/tinydrm/mi0283qt.c   |  3 ++-
  drivers/gpu/drm/tinydrm/repaper.c|  2 +-
  drivers/gpu/drm/tinydrm/st7586.c |  2 +-
  drivers/gpu/drm/tinydrm/st7735r.c|  2 +-
  drivers/gpu/drm/tve200/tve200_display.c  |  8 +--
  drivers/gpu/drm/vc4/vc4_plane.c  | 11 +
  drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c  | 35 
  include/drm/drm_gem_framebuffer_helper.h |  3 +++
  include/drm/drm_modeset_helper_vtables.h |  5 +++-
  include/drm/drm_plane.h  |  7 +-
  include/drm/drm_simple_kms_helper.h  |  3 +++
  include/drm/tinydrm/tinydrm.h|  2 --
  19 files changed, 61 insertions(+), 88 deletions(-)



___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel