Re: [PATCH 02/25] dma-fence: prime lockdep annotations

On Fri, Jul 10, 2020 at 03:01:10PM +0200, Christian König wrote: > Am 10.07.20 um 14:54 schrieb Jason Gunthorpe: > > On Fri, Jul 10, 2020 at 02:48:16PM +0200, Christian König wrote: > > > Am 10.07.20 um 14:43 schrieb Jason Gunthorpe: > > > > On Thu, Jul 09, 2020 at 10:09:11AM +0200, Daniel Vetter

Re: [PATCH 02/25] dma-fence: prime lockdep annotations

On Fri, Jul 10, 2020 at 04:02:35PM +0200, Daniel Vetter wrote: > > dma_fence only possibly makes some sense if you intend to expose the > > completion outside a single driver. > > > > The prefered kernel design pattern for this is to connect things with > > a function callback. > > > > So the

Re: [PATCH 02/25] dma-fence: prime lockdep annotations

On Thu, Jul 09, 2020 at 10:09:11AM +0200, Daniel Vetter wrote: > Hi Jason, > > Below the paragraph I've added after our discussions around dma-fences > outside of drivers/gpu. Good enough for an ack on this, or want something > changed? > > Thanks, Daniel > > > + * Note that only GPU drivers

Re: [PATCH 02/25] dma-fence: prime lockdep annotations

On Fri, Jul 10, 2020 at 02:48:16PM +0200, Christian König wrote: > Am 10.07.20 um 14:43 schrieb Jason Gunthorpe: > > On Thu, Jul 09, 2020 at 10:09:11AM +0200, Daniel Vetter wrote: > > > Hi Jason, > > > > > > Below the paragraph I've added after our discussions around dma-fences > > > outside of

Re: [PATCH 02/25] dma-fence: prime lockdep annotations

On Fri, Jul 10, 2020 at 4:23 PM Jason Gunthorpe wrote: > > On Fri, Jul 10, 2020 at 04:02:35PM +0200, Daniel Vetter wrote: > > > > dma_fence only possibly makes some sense if you intend to expose the > > > completion outside a single driver. > > > > > > The prefered kernel design pattern for this

Re: [PATCH 02/25] dma-fence: prime lockdep annotations

On Fri, Jul 10, 2020 at 3:48 PM Jason Gunthorpe wrote: > > On Fri, Jul 10, 2020 at 03:01:10PM +0200, Christian König wrote: > > Am 10.07.20 um 14:54 schrieb Jason Gunthorpe: > > > On Fri, Jul 10, 2020 at 02:48:16PM +0200, Christian König wrote: > > > > Am 10.07.20 um 14:43 schrieb Jason

Re: [PATCH 02/25] dma-fence: prime lockdep annotations

Am 10.07.20 um 14:54 schrieb Jason Gunthorpe: On Fri, Jul 10, 2020 at 02:48:16PM +0200, Christian König wrote: Am 10.07.20 um 14:43 schrieb Jason Gunthorpe: On Thu, Jul 09, 2020 at 10:09:11AM +0200, Daniel Vetter wrote: Hi Jason, Below the paragraph I've added after our discussions around

Re: [PATCH 02/25] dma-fence: prime lockdep annotations

Am 10.07.20 um 14:43 schrieb Jason Gunthorpe: On Thu, Jul 09, 2020 at 10:09:11AM +0200, Daniel Vetter wrote: Hi Jason, Below the paragraph I've added after our discussions around dma-fences outside of drivers/gpu. Good enough for an ack on this, or want something changed? Thanks, Daniel + *

Re: [PATCH 02/25] dma-fence: prime lockdep annotations

Hi Jason, Below the paragraph I've added after our discussions around dma-fences outside of drivers/gpu. Good enough for an ack on this, or want something changed? Thanks, Daniel > + * Note that only GPU drivers have a reasonable excuse for both requiring > + * _interval_notifier and callbacks