Re: [PATCH 1/3] dt-bindings: display: panel: Rename WL-355608-A8 panel
On Fri, 30 Aug 2024, at 7:56 PM, Neil Armstrong wrote: Thanks Neil, > > The only valid compatible with anbernic would be to use the exact > device in use and not a wildcard, > so you said the 3 devices using this panel are: > anbernic,rg35xx-2024 > anbernic,rg35xx-plus > anbernic,rg35xx-h > you should introduce 3 compatibles: > anbernic,rg35xx-2024-panel > anbernic,rg35xx-plus-panel > anbernic,rg35xx-h-panel > > but it's duplicating for nothing, to you should use fallbacks for 2 of > them to have in DT : > > anbernic,rg35xx-2024-panel > anbernic,rg35xx-plus-panel, anbernic,rg35xx-2024-panel > anbernic,rg35xx-h-panel, anbernic,rg35xx-2024-panel > > and only use anbernic,rg35xx-2024-panel in the driver. > > In this case bindings should be like: >properties: > compatible: >oneOf: > - const: anbernic,rg35xx-2024-panel > - items: > - enum: > - anbernic,rg35xx-plus-panel > - anbernic,rg35xx-h-panel > - const: anbernic,rg35xx-2024-panel > > (of course I selected rg35xx-2024 as the primary one, it could be > another, usually the older one) > If all are happy with this approach I will resubmit a V2 with that change this evening. Regards, Ryan
Re: [PATCH 1/3] dt-bindings: display: panel: Rename WL-355608-A8 panel
On 30/08/2024 03:43, Ryan Walklin wrote: On 28 Aug 2024, at 7:07 PM, Maxime Ripard wrote: On Tue, Aug 27, 2024 at 06:28:21PM GMT, Neil Armstrong wrote: Thanks both for the further feedback, agreed logical to use the device vendor and panel serial number, ie "anbernic,wl-355608-a8". Will post a V2 with a comment to that effect. Well in this case we can keep "wl-355608-a8", because the panel vendor _is not_ anbernic. And it's not a generic or ubiquitous device either. We've been over this already, anbernic is the best we have. I don’t have a strong preference either way but agree the anbernic vendor string is the best compromise. The only valid compatible with anbernic would be to use the exact device in use and not a wildcard, so you said the 3 devices using this panel are: anbernic,rg35xx-2024 anbernic,rg35xx-plus anbernic,rg35xx-h you should introduce 3 compatibles: anbernic,rg35xx-2024-panel anbernic,rg35xx-plus-panel anbernic,rg35xx-h-panel but it's duplicating for nothing, to you should use fallbacks for 2 of them to have in DT : anbernic,rg35xx-2024-panel anbernic,rg35xx-plus-panel, anbernic,rg35xx-2024-panel anbernic,rg35xx-h-panel, anbernic,rg35xx-2024-panel and only use anbernic,rg35xx-2024-panel in the driver. In this case bindings should be like: properties: compatible: oneOf: - const: anbernic,rg35xx-2024-panel - items: - enum: - anbernic,rg35xx-plus-panel - anbernic,rg35xx-h-panel - const: anbernic,rg35xx-2024-panel (of course I selected rg35xx-2024 as the primary one, it could be another, usually the older one) Neil Regards, Ryan
Re: [PATCH 1/3] dt-bindings: display: panel: Rename WL-355608-A8 panel
> On 28 Aug 2024, at 7:07 PM, Maxime Ripard wrote: > > On Tue, Aug 27, 2024 at 06:28:21PM GMT, Neil Armstrong wrote: >>> Thanks both for the further feedback, agreed logical to use the >>> device vendor and panel serial number, ie "anbernic,wl-355608-a8". >>> Will post a V2 with a comment to that effect. >> >> Well in this case we can keep "wl-355608-a8", because the panel vendor >> _is not_ anbernic. > > And it's not a generic or ubiquitous device either. We've been over > this already, anbernic is the best we have. I don’t have a strong preference either way but agree the anbernic vendor string is the best compromise. Regards, Ryan
Re: [PATCH 1/3] dt-bindings: display: panel: Rename WL-355608-A8 panel
On Tue, Aug 27, 2024 at 06:28:21PM GMT, Neil Armstrong wrote: > On 30/06/2024 10:16, Ryan Walklin wrote: > > On Fri, 28 Jun 2024, at 5:59 AM, Maxime Ripard wrote: > > > On Wed, Jun 26, 2024 at 04:34:11PM GMT, Conor Dooley wrote: > > > > On Wed, Jun 26, 2024 at 05:04:19PM +0200, Maxime Ripard wrote: > > > > > On Wed, Jun 26, 2024 at 02:25:54PM GMT, Neil Armstrong wrote: > > > > > > Can it be more specific ? because there's a lot of rg35xx defined > > > > > > in bindings: > > > > > > anbernic,rg351m > > > > > > anbernic,rg351v > > > > > > anbernic,rg353p > > > > > > anbernic,rg353ps > > > > > > anbernic,rg353v > > > > > > anbernic,rg353vs > > > > > > anbernic,rg35xx-2024 > > > > > > anbernic,rg35xx-plus > > > > > > anbernic,rg35xx-h > > > > Just to note only the three rg35xx-* devices use this particular panel. > > > > > > > > > > > > Yeah, if we have an identified model name, we should probably use > > > > > that, > > > > > with a comment that we couldn't figure out what the vendor was and > > > > > thus > > > > > went for anbernic. > > > > > > > > What's wrong with using the wl name that already exists as the model? > > > > Using rg-panel is total invention on our part, especially > > > > seeing as the commit message says that multiple models can use it. > > > > > > Yeah, that makes sense, sorry for the noise > > > > > Thanks both for the further feedback, agreed logical to use the > > device vendor and panel serial number, ie "anbernic,wl-355608-a8". > > Will post a V2 with a comment to that effect. > > Well in this case we can keep "wl-355608-a8", because the panel vendor > _is not_ anbernic. And it's not a generic or ubiquitous device either. We've been over this already, anbernic is the best we have. Maxime signature.asc Description: PGP signature
Re: [PATCH 1/3] dt-bindings: display: panel: Rename WL-355608-A8 panel
On 30/06/2024 10:16, Ryan Walklin wrote: On Fri, 28 Jun 2024, at 5:59 AM, Maxime Ripard wrote: On Wed, Jun 26, 2024 at 04:34:11PM GMT, Conor Dooley wrote: On Wed, Jun 26, 2024 at 05:04:19PM +0200, Maxime Ripard wrote: On Wed, Jun 26, 2024 at 02:25:54PM GMT, Neil Armstrong wrote: Can it be more specific ? because there's a lot of rg35xx defined in bindings: anbernic,rg351m anbernic,rg351v anbernic,rg353p anbernic,rg353ps anbernic,rg353v anbernic,rg353vs anbernic,rg35xx-2024 anbernic,rg35xx-plus anbernic,rg35xx-h Just to note only the three rg35xx-* devices use this particular panel. Yeah, if we have an identified model name, we should probably use that, with a comment that we couldn't figure out what the vendor was and thus went for anbernic. What's wrong with using the wl name that already exists as the model? Using rg-panel is total invention on our part, especially seeing as the commit message says that multiple models can use it. Yeah, that makes sense, sorry for the noise Thanks both for the further feedback, agreed logical to use the device vendor and panel serial number, ie "anbernic,wl-355608-a8". Will post a V2 with a comment to that effect. Well in this case we can keep "wl-355608-a8", because the panel vendor _is not_ anbernic. Neil Regards, Ryan
Re: [PATCH 1/3] dt-bindings: display: panel: Rename WL-355608-A8 panel
On Fri, 28 Jun 2024, at 5:59 AM, Maxime Ripard wrote: > On Wed, Jun 26, 2024 at 04:34:11PM GMT, Conor Dooley wrote: >> On Wed, Jun 26, 2024 at 05:04:19PM +0200, Maxime Ripard wrote: >> > On Wed, Jun 26, 2024 at 02:25:54PM GMT, Neil Armstrong wrote: >> > > Can it be more specific ? because there's a lot of rg35xx defined in >> > > bindings: >> > > anbernic,rg351m >> > > anbernic,rg351v >> > > anbernic,rg353p >> > > anbernic,rg353ps >> > > anbernic,rg353v >> > > anbernic,rg353vs >> > > anbernic,rg35xx-2024 >> > > anbernic,rg35xx-plus >> > > anbernic,rg35xx-h Just to note only the three rg35xx-* devices use this particular panel. >> > >> > Yeah, if we have an identified model name, we should probably use that, >> > with a comment that we couldn't figure out what the vendor was and thus >> > went for anbernic. >> >> What's wrong with using the wl name that already exists as the model? >> Using rg-panel is total invention on our part, especially >> seeing as the commit message says that multiple models can use it. > > Yeah, that makes sense, sorry for the noise > Thanks both for the further feedback, agreed logical to use the device vendor and panel serial number, ie "anbernic,wl-355608-a8". Will post a V2 with a comment to that effect. Regards, Ryan
Re: [PATCH 1/3] dt-bindings: display: panel: Rename WL-355608-A8 panel
On Wed, Jun 26, 2024 at 04:34:11PM GMT, Conor Dooley wrote:
> On Wed, Jun 26, 2024 at 05:04:19PM +0200, Maxime Ripard wrote:
> > On Wed, Jun 26, 2024 at 02:25:54PM GMT, Neil Armstrong wrote:
> > > On 26/06/2024 13:17, Ryan Walklin wrote:
> > > > The WL-355608-A8 is a 3.5" 640x480@60Hz RGB LCD display from an unknown
> > > > OEM used in a number of handheld gaming devices made by Anbernic.
> > > > Previously committed using the OEM serial without a vendor prefix,
> > > > however the preference is to use the integrating device vendor and name
> > > > where the OEM is unknown.
> > > >
> > > > Alter the filename and compatible string to reflect the convention.
> > > >
> > > > Fixes: f08aac40639c ("drm: panel: nv3052c: Add WL-355608-A8 panel")
> > > > Signed-off-by: Ryan Walklin
> > > > ---
> > > > .../{wl-355608-a8.yaml => anbernic,rg35xx-panel.yaml} | 8
> > > > 1 file changed, 4 insertions(+), 4 deletions(-)
> > > > rename
> > > > Documentation/devicetree/bindings/display/panel/{wl-355608-a8.yaml =>
> > > > anbernic,rg35xx-panel.yaml} (81%)
> > > >
> > > > diff --git
> > > > a/Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml
> > > > b/Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml
> > > > similarity index 81%
> > > > rename from
> > > > Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml
> > > > rename to
> > > > Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml
> > > > index 397c26be9bda5..a7d5ad0f29389 100644
> > > > --- a/Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml
> > > > +++
> > > > b/Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml
> > > > @@ -1,10 +1,10 @@
> > > > # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > > %YAML 1.2
> > > > ---
> > > > -$id: http://devicetree.org/schemas/display/panel/wl-355608-a8.yaml#
> > > > +$id:
> > > > http://devicetree.org/schemas/display/panel/anbernic,rg35xx-panel.yaml#
> > > > $schema: http://devicetree.org/meta-schemas/core.yaml#
> > > > -title: WL-355608-A8 3.5" (640x480 pixels) 24-bit IPS LCD panel
> > > > +title: Anbernic RG35XX (WL-355608-A8) 3.5" 640x480 24-bit IPS LCD panel
> > > > maintainers:
> > > > - Ryan Walklin
> > > > @@ -15,7 +15,7 @@ allOf:
> > > > properties:
> > > > compatible:
> > > > -const: wl-355608-a8
> > > > +const: anbernic,rg35xx-panel
> > > > reg:
> > > > maxItems: 1
> > > > @@ -41,7 +41,7 @@ examples:
> > > > #size-cells = <0>;
> > > > panel@0 {
> > > > -compatible = "wl-355608-a8";
> > > > +compatible = "anbernic,rg35xx-panel";
> > >
> > > Can it be more specific ? because there's a lot of rg35xx defined in
> > > bindings:
> > > anbernic,rg351m
> > > anbernic,rg351v
> > > anbernic,rg353p
> > > anbernic,rg353ps
> > > anbernic,rg353v
> > > anbernic,rg353vs
> > > anbernic,rg35xx-2024
> > > anbernic,rg35xx-plus
> > > anbernic,rg35xx-h
> >
> > Yeah, if we have an identified model name, we should probably use that,
> > with a comment that we couldn't figure out what the vendor was and thus
> > went for anbernic.
>
> What's wrong with using the wl name that already exists as the model?
> Using rg-panel is total invention on our part, especially
> seeing as the commit message says that multiple models can use it.
Yeah, that makes sense, sorry for the noise
Maxime
signature.asc
Description: PGP signature
Re: [PATCH 1/3] dt-bindings: display: panel: Rename WL-355608-A8 panel
On Wed, Jun 26, 2024 at 05:04:19PM +0200, Maxime Ripard wrote:
> On Wed, Jun 26, 2024 at 02:25:54PM GMT, Neil Armstrong wrote:
> > On 26/06/2024 13:17, Ryan Walklin wrote:
> > > The WL-355608-A8 is a 3.5" 640x480@60Hz RGB LCD display from an unknown
> > > OEM used in a number of handheld gaming devices made by Anbernic.
> > > Previously committed using the OEM serial without a vendor prefix,
> > > however the preference is to use the integrating device vendor and name
> > > where the OEM is unknown.
> > >
> > > Alter the filename and compatible string to reflect the convention.
> > >
> > > Fixes: f08aac40639c ("drm: panel: nv3052c: Add WL-355608-A8 panel")
> > > Signed-off-by: Ryan Walklin
> > > ---
> > > .../{wl-355608-a8.yaml => anbernic,rg35xx-panel.yaml} | 8
> > > 1 file changed, 4 insertions(+), 4 deletions(-)
> > > rename
> > > Documentation/devicetree/bindings/display/panel/{wl-355608-a8.yaml =>
> > > anbernic,rg35xx-panel.yaml} (81%)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml
> > > b/Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml
> > > similarity index 81%
> > > rename from
> > > Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml
> > > rename to
> > > Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml
> > > index 397c26be9bda5..a7d5ad0f29389 100644
> > > --- a/Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml
> > > +++
> > > b/Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml
> > > @@ -1,10 +1,10 @@
> > > # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > %YAML 1.2
> > > ---
> > > -$id: http://devicetree.org/schemas/display/panel/wl-355608-a8.yaml#
> > > +$id:
> > > http://devicetree.org/schemas/display/panel/anbernic,rg35xx-panel.yaml#
> > > $schema: http://devicetree.org/meta-schemas/core.yaml#
> > > -title: WL-355608-A8 3.5" (640x480 pixels) 24-bit IPS LCD panel
> > > +title: Anbernic RG35XX (WL-355608-A8) 3.5" 640x480 24-bit IPS LCD panel
> > > maintainers:
> > > - Ryan Walklin
> > > @@ -15,7 +15,7 @@ allOf:
> > > properties:
> > > compatible:
> > > -const: wl-355608-a8
> > > +const: anbernic,rg35xx-panel
> > > reg:
> > > maxItems: 1
> > > @@ -41,7 +41,7 @@ examples:
> > > #size-cells = <0>;
> > > panel@0 {
> > > -compatible = "wl-355608-a8";
> > > +compatible = "anbernic,rg35xx-panel";
> >
> > Can it be more specific ? because there's a lot of rg35xx defined in
> > bindings:
> > anbernic,rg351m
> > anbernic,rg351v
> > anbernic,rg353p
> > anbernic,rg353ps
> > anbernic,rg353v
> > anbernic,rg353vs
> > anbernic,rg35xx-2024
> > anbernic,rg35xx-plus
> > anbernic,rg35xx-h
>
> Yeah, if we have an identified model name, we should probably use that,
> with a comment that we couldn't figure out what the vendor was and thus
> went for anbernic.
What's wrong with using the wl name that already exists as the model?
Using rg-panel is total invention on our part, especially
seeing as the commit message says that multiple models can use it.
signature.asc
Description: PGP signature
Re: [PATCH 1/3] dt-bindings: display: panel: Rename WL-355608-A8 panel
On Wed, Jun 26, 2024 at 02:25:54PM GMT, Neil Armstrong wrote:
> On 26/06/2024 13:17, Ryan Walklin wrote:
> > The WL-355608-A8 is a 3.5" 640x480@60Hz RGB LCD display from an unknown
> > OEM used in a number of handheld gaming devices made by Anbernic.
> > Previously committed using the OEM serial without a vendor prefix,
> > however the preference is to use the integrating device vendor and name
> > where the OEM is unknown.
> >
> > Alter the filename and compatible string to reflect the convention.
> >
> > Fixes: f08aac40639c ("drm: panel: nv3052c: Add WL-355608-A8 panel")
> > Signed-off-by: Ryan Walklin
> > ---
> > .../{wl-355608-a8.yaml => anbernic,rg35xx-panel.yaml} | 8
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> > rename Documentation/devicetree/bindings/display/panel/{wl-355608-a8.yaml
> > => anbernic,rg35xx-panel.yaml} (81%)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml
> > b/Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml
> > similarity index 81%
> > rename from
> > Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml
> > rename to
> > Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml
> > index 397c26be9bda5..a7d5ad0f29389 100644
> > --- a/Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml
> > +++
> > b/Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml
> > @@ -1,10 +1,10 @@
> > # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > %YAML 1.2
> > ---
> > -$id: http://devicetree.org/schemas/display/panel/wl-355608-a8.yaml#
> > +$id:
> > http://devicetree.org/schemas/display/panel/anbernic,rg35xx-panel.yaml#
> > $schema: http://devicetree.org/meta-schemas/core.yaml#
> > -title: WL-355608-A8 3.5" (640x480 pixels) 24-bit IPS LCD panel
> > +title: Anbernic RG35XX (WL-355608-A8) 3.5" 640x480 24-bit IPS LCD panel
> > maintainers:
> > - Ryan Walklin
> > @@ -15,7 +15,7 @@ allOf:
> > properties:
> > compatible:
> > -const: wl-355608-a8
> > +const: anbernic,rg35xx-panel
> > reg:
> > maxItems: 1
> > @@ -41,7 +41,7 @@ examples:
> > #size-cells = <0>;
> > panel@0 {
> > -compatible = "wl-355608-a8";
> > +compatible = "anbernic,rg35xx-panel";
>
> Can it be more specific ? because there's a lot of rg35xx defined in bindings:
> anbernic,rg351m
> anbernic,rg351v
> anbernic,rg353p
> anbernic,rg353ps
> anbernic,rg353v
> anbernic,rg353vs
> anbernic,rg35xx-2024
> anbernic,rg35xx-plus
> anbernic,rg35xx-h
Yeah, if we have an identified model name, we should probably use that,
with a comment that we couldn't figure out what the vendor was and thus
went for anbernic.
Maxime
signature.asc
Description: PGP signature
Re: [PATCH 1/3] dt-bindings: display: panel: Rename WL-355608-A8 panel
On 26/06/2024 13:17, Ryan Walklin wrote:
The WL-355608-A8 is a 3.5" 640x480@60Hz RGB LCD display from an unknown
OEM used in a number of handheld gaming devices made by Anbernic.
Previously committed using the OEM serial without a vendor prefix,
however the preference is to use the integrating device vendor and name
where the OEM is unknown.
Alter the filename and compatible string to reflect the convention.
Fixes: f08aac40639c ("drm: panel: nv3052c: Add WL-355608-A8 panel")
Signed-off-by: Ryan Walklin
---
.../{wl-355608-a8.yaml => anbernic,rg35xx-panel.yaml} | 8
1 file changed, 4 insertions(+), 4 deletions(-)
rename Documentation/devicetree/bindings/display/panel/{wl-355608-a8.yaml =>
anbernic,rg35xx-panel.yaml} (81%)
diff --git a/Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml
b/Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml
similarity index 81%
rename from Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml
rename to
Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml
index 397c26be9bda5..a7d5ad0f29389 100644
--- a/Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml
+++ b/Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-panel.yaml
@@ -1,10 +1,10 @@
# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
%YAML 1.2
---
-$id: http://devicetree.org/schemas/display/panel/wl-355608-a8.yaml#
+$id: http://devicetree.org/schemas/display/panel/anbernic,rg35xx-panel.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#
-title: WL-355608-A8 3.5" (640x480 pixels) 24-bit IPS LCD panel
+title: Anbernic RG35XX (WL-355608-A8) 3.5" 640x480 24-bit IPS LCD panel
maintainers:
- Ryan Walklin
@@ -15,7 +15,7 @@ allOf:
properties:
compatible:
-const: wl-355608-a8
+const: anbernic,rg35xx-panel
reg:
maxItems: 1
@@ -41,7 +41,7 @@ examples:
#size-cells = <0>;
panel@0 {
-compatible = "wl-355608-a8";
+compatible = "anbernic,rg35xx-panel";
Can it be more specific ? because there's a lot of rg35xx defined in bindings:
anbernic,rg351m
anbernic,rg351v
anbernic,rg353p
anbernic,rg353ps
anbernic,rg353v
anbernic,rg353vs
anbernic,rg35xx-2024
anbernic,rg35xx-plus
anbernic,rg35xx-h
Neil
reg = <0>;
spi-3wire;
