Re: [PATCH 10/12] firmware: qcom_scm: Add qcom_scm_gpu_zap_resume()

[Andy Gross]

On Mon, Nov 28, 2016 at 12:28:35PM -0700, Jordan Crouse wrote:
> Add an interface to trigger the remote processor to reinitialize the GPU
> zap shader on power-up.
> 
> Signed-off-by: Jordan Crouse 
> ---



> +int __qcom_scm_gpu_zap_resume(struct device *dev)
> +{
> + struct qcom_scm_desc desc = {0};
> + struct arm_smccc_res res;
> + int ret;
> +
> + desc.args[0] = 0;
> + desc.args[1] = 13;

Can I get a define here for these two?  Or maybe a comment on what these values
are?

> + desc.arginfo = QCOM_SCM_ARGS(2);
> +
> + ret = qcom_scm_call(dev, QCOM_SCM_SVC_BOOT, 0x0A, , );

Same with the 0xA.  We usually throw a #define in for the command definitions.

Otherwise this all looks fine.  If you can get back to me with either the values
or a new patch I can include this in the next pull.

Thanks.

Andy
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 10/12] firmware: qcom_scm: Add qcom_scm_gpu_zap_resume()

[Andy Gross]

On Fri, Jan 13, 2017 at 10:22:45AM -0700, Jordan Crouse wrote:
> On Fri, Jan 13, 2017 at 11:12:41AM -0600, Andy Gross wrote:
> > On Mon, Nov 28, 2016 at 12:28:35PM -0700, Jordan Crouse wrote:
> > > Add an interface to trigger the remote processor to reinitialize the GPU
> > > zap shader on power-up.
> > > 
> > > Signed-off-by: Jordan Crouse 
> > > ---
> > 
> > 
> > 
> > > +int __qcom_scm_gpu_zap_resume(struct device *dev)
> > > +{
> > > + struct qcom_scm_desc desc = {0};
> > > + struct arm_smccc_res res;
> > > + int ret;
> > > +
> > > + desc.args[0] = 0;
> > > + desc.args[1] = 13;
> > 
> > Can I get a define here for these two?  Or maybe a comment on what these 
> > values
> > are?
> > 
> > > + desc.arginfo = QCOM_SCM_ARGS(2);
> > > +
> > > + ret = qcom_scm_call(dev, QCOM_SCM_SVC_BOOT, 0x0A, , );
> > 
> > Same with the 0xA.  We usually throw a #define in for the command 
> > definitions.
> > 
> > Otherwise this all looks fine.  If you can get back to me with either the 
> > values
> > or a new patch I can include this in the next pull.
> 
> Thanks for reaching out. Since this isn't my usual area I'll need to work out
> some terminology with the SCM folks to make sure I don't accidentally do
> anything that will get me in trouble.

Yeah I did a brief look through CAF.   I saw basically the same information.  If
you can't get an answer, let me know and I'll just take it and put in a comment.


Andy
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 10/12] firmware: qcom_scm: Add qcom_scm_gpu_zap_resume()

[Jordan Crouse]

On Fri, Jan 13, 2017 at 11:12:41AM -0600, Andy Gross wrote:
> On Mon, Nov 28, 2016 at 12:28:35PM -0700, Jordan Crouse wrote:
> > Add an interface to trigger the remote processor to reinitialize the GPU
> > zap shader on power-up.
> > 
> > Signed-off-by: Jordan Crouse 
> > ---
> 
> 
> 
> > +int __qcom_scm_gpu_zap_resume(struct device *dev)
> > +{
> > +   struct qcom_scm_desc desc = {0};
> > +   struct arm_smccc_res res;
> > +   int ret;
> > +
> > +   desc.args[0] = 0;
> > +   desc.args[1] = 13;
> 
> Can I get a define here for these two?  Or maybe a comment on what these 
> values
> are?
> 
> > +   desc.arginfo = QCOM_SCM_ARGS(2);
> > +
> > +   ret = qcom_scm_call(dev, QCOM_SCM_SVC_BOOT, 0x0A, , );
> 
> Same with the 0xA.  We usually throw a #define in for the command definitions.
> 
> Otherwise this all looks fine.  If you can get back to me with either the 
> values
> or a new patch I can include this in the next pull.

Thanks for reaching out. Since this isn't my usual area I'll need to work out
some terminology with the SCM folks to make sure I don't accidentally do
anything that will get me in trouble.

Jordan
-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel