Re: [PATCH 4/7] anv: Support wait for heterogeneous list of fences [v2]

2018-06-19 Thread Keith Packard
Jason Ekstrand writes: > You can have a full reviewed-by You're too kind :-) -- -keith signature.asc Description: PGP signature ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 4/7] anv: Support wait for heterogeneous list of fences [v2]

2018-06-19 Thread Jason Ekstrand
On June 19, 2018 22:16:37 "Keith Packard" wrote: Jason Ekstrand writes: I don't think I have any more comments on this patch. It's gross but I think it should work. I'll mark you down as 'Acked-by' then. Neither of us loves the implementation; I'll see about creating the kernel

Re: [PATCH 4/7] anv: Support wait for heterogeneous list of fences [v2]

2018-06-19 Thread Keith Packard
Jason Ekstrand writes: > I don't think I have any more comments on this patch. It's gross but I > think it should work. I'll mark you down as 'Acked-by' then. Neither of us loves the implementation; I'll see about creating the kernel infrastructure necessary to supplant it. -- -keith

Re: [PATCH 4/7] anv: Support wait for heterogeneous list of fences [v2]

2018-06-19 Thread Jason Ekstrand
On Tue, Jun 19, 2018 at 6:22 PM, Keith Packard wrote: > Jason Ekstrand writes: > > > I suppose we probably shouldn't worry about current_time being greater > than > > INT64_MAX? I guess if that happens we have pretty big problems... > > Nope, we've already given up on that working -- it's a

Re: [PATCH 4/7] anv: Support wait for heterogeneous list of fences [v2]

2018-06-19 Thread Keith Packard
Jason Ekstrand writes: > I suppose we probably shouldn't worry about current_time being greater than > INT64_MAX? I guess if that happens we have pretty big problems... Nope, we've already given up on that working -- it's a couple hundred years of system uptime. Neither of us have any concerns

Re: [PATCH 4/7] anv: Support wait for heterogeneous list of fences [v2]

2018-06-19 Thread Jason Ekstrand
On Tue, Jun 19, 2018 at 5:36 PM, Keith Packard wrote: > Jason Ekstrand writes: > > > I still don't really like this but I agree that this code really should > not > > be getting hit very often so it's probably not too bad. Maybe one day > > we'll be able to drop the non-syncobj paths entirely.

Re: [PATCH 4/7] anv: Support wait for heterogeneous list of fences [v2]

2018-06-19 Thread Keith Packard
Jason Ekstrand writes: > I still don't really like this but I agree that this code really should not > be getting hit very often so it's probably not too bad. Maybe one day > we'll be able to drop the non-syncobj paths entirely. Wouldn't that be > nice. I agree. What I want to have is

Re: [PATCH 4/7] anv: Support wait for heterogeneous list of fences [v2]

2018-06-19 Thread Jason Ekstrand
I still don't really like this but I agree that this code really should not be getting hit very often so it's probably not too bad. Maybe one day we'll be able to drop the non-syncobj paths entirely. Wouldn't that be nice. In the mean time, this is probably fine. I did see one issue below with