Re: [PATCH 4/8] arm64: dts: allwinner: Add ARM Mali GPU node for H6
On Thu, Apr 11, 2019 at 09:56:15AM +0200, Clément Péron wrote: > Hi, > > On Thu, 11 Apr 2019 at 09:28, Maxime Ripard wrote: > > > > On Thu, Apr 11, 2019 at 01:25:39AM +0200, Clément Péron wrote: > > > Add the mali gpu node to the H6 device-tree. > > > > > > Signed-off-by: Clément Péron > > > --- > > > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 80 > > > 1 file changed, 80 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > > b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > > index e0dc4a05c1ba..152b2128aadf 100644 > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > > @@ -17,6 +17,71 @@ > > > #address-cells = <1>; > > > #size-cells = <1>; > > > > > > + gpu_opp_table: opp_table1 { > > > + compatible = "operating-points-v2"; > > > + > > > + opp@75600 { > > > + opp-hz = /bits/ 64 <75600>; > > > + opp-microvolt = <104>; > > > + }; > > > + opp@62400 { > > > + opp-hz = /bits/ 64 <62400>; > > > + opp-microvolt = <95>; > > > + }; > > > + opp@57600 { > > > + opp-hz = /bits/ 64 <57600>; > > > + opp-microvolt = <93>; > > > + }; > > > + opp@54000 { > > > + opp-hz = /bits/ 64 <54000>; > > > + opp-microvolt = <91>; > > > + }; > > > + opp@50400 { > > > + opp-hz = /bits/ 64 <50400>; > > > + opp-microvolt = <89>; > > > + }; > > > + opp@45600 { > > > + opp-hz = /bits/ 64 <45600>; > > > + opp-microvolt = <87>; > > > + }; > > > + opp@43200 { > > > + opp-hz = /bits/ 64 <43200>; > > > + opp-microvolt = <86>; > > > + }; > > > + opp@42000 { > > > + opp-hz = /bits/ 64 <42000>; > > > + opp-microvolt = <85>; > > > + }; > > > + opp@40800 { > > > + opp-hz = /bits/ 64 <40800>; > > > + opp-microvolt = <84>; > > > + }; > > > + opp@38400 { > > > + opp-hz = /bits/ 64 <38400>; > > > + opp-microvolt = <83>; > > > + }; > > > + opp@36000 { > > > + opp-hz = /bits/ 64 <36000>; > > > + opp-microvolt = <82>; > > > + }; > > > + opp@33600 { > > > + opp-hz = /bits/ 64 <33600>; > > > + opp-microvolt = <81>; > > > + }; > > > + opp@31200 { > > > + opp-hz = /bits/ 64 <31200>; > > > + opp-microvolt = <81>; > > > + }; > > > + opp@26400 { > > > + opp-hz = /bits/ 64 <26400>; > > > + opp-microvolt = <81>; > > > + }; > > > + opp@21600 { > > > + opp-hz = /bits/ 64 <21600>; > > > + opp-microvolt = <81>; > > > + }; > > > + }; > > > + > > > > How were those OPPs tested? > > They are taken from the vendor device tree. > https://github.com/Allwinner-Homlet/H6-BSP4.9-linux/blob/master/arch/arm64/boot/dts/sunxi/sun50iw6p1.dtsi#L2121 Please remove them if you haven't tested them then. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 4/8] arm64: dts: allwinner: Add ARM Mali GPU node for H6
Hi, On Thu, 11 Apr 2019 at 09:28, Maxime Ripard wrote: > > On Thu, Apr 11, 2019 at 01:25:39AM +0200, Clément Péron wrote: > > Add the mali gpu node to the H6 device-tree. > > > > Signed-off-by: Clément Péron > > --- > > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 80 > > 1 file changed, 80 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > index e0dc4a05c1ba..152b2128aadf 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > @@ -17,6 +17,71 @@ > > #address-cells = <1>; > > #size-cells = <1>; > > > > + gpu_opp_table: opp_table1 { > > + compatible = "operating-points-v2"; > > + > > + opp@75600 { > > + opp-hz = /bits/ 64 <75600>; > > + opp-microvolt = <104>; > > + }; > > + opp@62400 { > > + opp-hz = /bits/ 64 <62400>; > > + opp-microvolt = <95>; > > + }; > > + opp@57600 { > > + opp-hz = /bits/ 64 <57600>; > > + opp-microvolt = <93>; > > + }; > > + opp@54000 { > > + opp-hz = /bits/ 64 <54000>; > > + opp-microvolt = <91>; > > + }; > > + opp@50400 { > > + opp-hz = /bits/ 64 <50400>; > > + opp-microvolt = <89>; > > + }; > > + opp@45600 { > > + opp-hz = /bits/ 64 <45600>; > > + opp-microvolt = <87>; > > + }; > > + opp@43200 { > > + opp-hz = /bits/ 64 <43200>; > > + opp-microvolt = <86>; > > + }; > > + opp@42000 { > > + opp-hz = /bits/ 64 <42000>; > > + opp-microvolt = <85>; > > + }; > > + opp@40800 { > > + opp-hz = /bits/ 64 <40800>; > > + opp-microvolt = <84>; > > + }; > > + opp@38400 { > > + opp-hz = /bits/ 64 <38400>; > > + opp-microvolt = <83>; > > + }; > > + opp@36000 { > > + opp-hz = /bits/ 64 <36000>; > > + opp-microvolt = <82>; > > + }; > > + opp@33600 { > > + opp-hz = /bits/ 64 <33600>; > > + opp-microvolt = <81>; > > + }; > > + opp@31200 { > > + opp-hz = /bits/ 64 <31200>; > > + opp-microvolt = <81>; > > + }; > > + opp@26400 { > > + opp-hz = /bits/ 64 <26400>; > > + opp-microvolt = <81>; > > + }; > > + opp@21600 { > > + opp-hz = /bits/ 64 <21600>; > > + opp-microvolt = <81>; > > + }; > > + }; > > + > > How were those OPPs tested? They are taken from the vendor device tree. https://github.com/Allwinner-Homlet/H6-BSP4.9-linux/blob/master/arch/arm64/boot/dts/sunxi/sun50iw6p1.dtsi#L2121 Clement > > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 4/8] arm64: dts: allwinner: Add ARM Mali GPU node for H6
On Thu, Apr 11, 2019 at 01:25:39AM +0200, Clément Péron wrote: > Add the mali gpu node to the H6 device-tree. > > Signed-off-by: Clément Péron > --- > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 80 > 1 file changed, 80 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > index e0dc4a05c1ba..152b2128aadf 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > @@ -17,6 +17,71 @@ > #address-cells = <1>; > #size-cells = <1>; > > + gpu_opp_table: opp_table1 { > + compatible = "operating-points-v2"; > + > + opp@75600 { > + opp-hz = /bits/ 64 <75600>; > + opp-microvolt = <104>; > + }; > + opp@62400 { > + opp-hz = /bits/ 64 <62400>; > + opp-microvolt = <95>; > + }; > + opp@57600 { > + opp-hz = /bits/ 64 <57600>; > + opp-microvolt = <93>; > + }; > + opp@54000 { > + opp-hz = /bits/ 64 <54000>; > + opp-microvolt = <91>; > + }; > + opp@50400 { > + opp-hz = /bits/ 64 <50400>; > + opp-microvolt = <89>; > + }; > + opp@45600 { > + opp-hz = /bits/ 64 <45600>; > + opp-microvolt = <87>; > + }; > + opp@43200 { > + opp-hz = /bits/ 64 <43200>; > + opp-microvolt = <86>; > + }; > + opp@42000 { > + opp-hz = /bits/ 64 <42000>; > + opp-microvolt = <85>; > + }; > + opp@40800 { > + opp-hz = /bits/ 64 <40800>; > + opp-microvolt = <84>; > + }; > + opp@38400 { > + opp-hz = /bits/ 64 <38400>; > + opp-microvolt = <83>; > + }; > + opp@36000 { > + opp-hz = /bits/ 64 <36000>; > + opp-microvolt = <82>; > + }; > + opp@33600 { > + opp-hz = /bits/ 64 <33600>; > + opp-microvolt = <81>; > + }; > + opp@31200 { > + opp-hz = /bits/ 64 <31200>; > + opp-microvolt = <81>; > + }; > + opp@26400 { > + opp-hz = /bits/ 64 <26400>; > + opp-microvolt = <81>; > + }; > + opp@21600 { > + opp-hz = /bits/ 64 <21600>; > + opp-microvolt = <81>; > + }; > + }; > + How were those OPPs tested? Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com signature.asc Description: PGP signature ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel