Re: [PATCH 5/5] drm: panel-orientation-quirks: Add Zotac Gaming Zone quirk
On Mon, 17 Mar 2025 at 10:23, Antheas Kapenekakis wrote:
>
> On Mon, 17 Mar 2025 at 10:20, Hans de Goede wrote:
> >
> > Hi,
> >
> > On 22-Feb-25 17:43, Antheas Kapenekakis wrote:
> > > The Zotac Gaming Zone handheld features a 1080p portrait OLED screen.
> > > Add the rotation to the panel orientation quirks.
> > >
> > > Signed-off-by: Antheas Kapenekakis
> > > ---
> > > drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++
> > > 1 file changed, 6 insertions(+)
> > >
> > > diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > > b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > > index f08cdc81dd9a..bbbe707f541d 100644
> > > --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > > +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > > @@ -479,6 +479,12 @@ static const struct dmi_system_id orientation_data[]
> > > = {
> > > DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER F1 EVA-02"),
> > > },
> > > .driver_data = (void *)&lcd1080x1920_leftside_up,
> > > + }, {/* Zotac Gaming Zone (OLED) */
> > > + .matches = {
> > > + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ZOTAC"),
> > > + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ZOTAC GAMING ZONE"),
> > > + },
> > > + .driver_data = (void *)&lcd1080x1920_leftside_up,
> > > }, {/* OrangePi Neo */
> >
> > The entries in this list are alphabetically sorted. Please post
> > a v2 (of just this patch) with this entry moved to the end, just
> > above the special "One Mix 2S" entry which is at the very end
> > because its DMI matches are all "Default string".
> >
> > Note another entry for another Zotac device, with a board name of
> > "G0A1W" has been added in drm-misc/next, so please base your v2
> > on top of drm-misc/next.
> >
> > Also the freedesktop.org infra is currently being migrated to
> > another data center, so the drm-misc tree currently is not
> > available I think.
> >
> > Regards,
> >
> > Hans
> >
> >
> >
> >
> > > .matches = {
> > > DMI_EXACT_MATCH(DMI_SYS_VENDOR, "OrangePi"),
> >
>
> Ok thanks. I will do that in a few days. Patches 1-4 hopefully should
> be good to merge.
>
> Antheas
Actually nevermind, this is the Zotac Zone so it is a dupe. It is fine
to drop this patch from the series and merge the rest.
Antheas
Re: [PATCH 5/5] drm: panel-orientation-quirks: Add Zotac Gaming Zone quirk
On Mon, 17 Mar 2025 at 10:20, Hans de Goede wrote:
>
> Hi,
>
> On 22-Feb-25 17:43, Antheas Kapenekakis wrote:
> > The Zotac Gaming Zone handheld features a 1080p portrait OLED screen.
> > Add the rotation to the panel orientation quirks.
> >
> > Signed-off-by: Antheas Kapenekakis
> > ---
> > drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > index f08cdc81dd9a..bbbe707f541d 100644
> > --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > @@ -479,6 +479,12 @@ static const struct dmi_system_id orientation_data[] =
> > {
> > DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER F1 EVA-02"),
> > },
> > .driver_data = (void *)&lcd1080x1920_leftside_up,
> > + }, {/* Zotac Gaming Zone (OLED) */
> > + .matches = {
> > + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ZOTAC"),
> > + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ZOTAC GAMING ZONE"),
> > + },
> > + .driver_data = (void *)&lcd1080x1920_leftside_up,
> > }, {/* OrangePi Neo */
>
> The entries in this list are alphabetically sorted. Please post
> a v2 (of just this patch) with this entry moved to the end, just
> above the special "One Mix 2S" entry which is at the very end
> because its DMI matches are all "Default string".
>
> Note another entry for another Zotac device, with a board name of
> "G0A1W" has been added in drm-misc/next, so please base your v2
> on top of drm-misc/next.
>
> Also the freedesktop.org infra is currently being migrated to
> another data center, so the drm-misc tree currently is not
> available I think.
>
> Regards,
>
> Hans
>
>
>
>
> > .matches = {
> > DMI_EXACT_MATCH(DMI_SYS_VENDOR, "OrangePi"),
>
Ok thanks. I will do that in a few days. Patches 1-4 hopefully should
be good to merge.
Antheas
Re: [PATCH 5/5] drm: panel-orientation-quirks: Add Zotac Gaming Zone quirk
Hi,
On 22-Feb-25 17:43, Antheas Kapenekakis wrote:
> The Zotac Gaming Zone handheld features a 1080p portrait OLED screen.
> Add the rotation to the panel orientation quirks.
>
> Signed-off-by: Antheas Kapenekakis
> ---
> drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index f08cdc81dd9a..bbbe707f541d 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -479,6 +479,12 @@ static const struct dmi_system_id orientation_data[] = {
> DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONEXPLAYER F1 EVA-02"),
> },
> .driver_data = (void *)&lcd1080x1920_leftside_up,
> + }, {/* Zotac Gaming Zone (OLED) */
> + .matches = {
> + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ZOTAC"),
> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ZOTAC GAMING ZONE"),
> + },
> + .driver_data = (void *)&lcd1080x1920_leftside_up,
> }, {/* OrangePi Neo */
The entries in this list are alphabetically sorted. Please post
a v2 (of just this patch) with this entry moved to the end, just
above the special "One Mix 2S" entry which is at the very end
because its DMI matches are all "Default string".
Note another entry for another Zotac device, with a board name of
"G0A1W" has been added in drm-misc/next, so please base your v2
on top of drm-misc/next.
Also the freedesktop.org infra is currently being migrated to
another data center, so the drm-misc tree currently is not
available I think.
Regards,
Hans
> .matches = {
> DMI_EXACT_MATCH(DMI_SYS_VENDOR, "OrangePi"),
