Re: [PATCH 5/8] dt-bindings: display/msm: qcom, eliza-mdss: Add Eliza SoC

2026-03-03 Thread Krzysztof Kozlowski
On 03/03/2026 16:56, Rob Herring (Arm) wrote:
> 
> On Tue, 03 Mar 2026 14:07:55 +0100, Krzysztof Kozlowski wrote:
>> Add MDSS/MDP display subsystem for Qualcomm Eliza SoC, being overall a
>> minor revision change against SM8750, but coming with few different
>> components, like different DSI PHY and added HDMI.
>>
>> The binding does not include HDMI description yet.
>>
>> Signed-off-by: Krzysztof Kozlowski 
>> ---
>>  .../bindings/display/msm/qcom,eliza-mdss.yaml  | 496 
>> +
>>  1 file changed, 496 insertions(+)
>>
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/display/msm/qcom,eliza-mdss.example.dts:25:18:
>  fatal error: dt-bindings/clock/qcom,eliza-gcc.h: No such file or directory
>25 | #include 

Mea culpa, I was testing on branch with the dependency, so obviously I
need to decouple these.

Best regards,
Krzysztof


Re: [PATCH 5/8] dt-bindings: display/msm: qcom,eliza-mdss: Add Eliza SoC

2026-03-03 Thread Rob Herring (Arm)


On Tue, 03 Mar 2026 14:07:55 +0100, Krzysztof Kozlowski wrote:
> Add MDSS/MDP display subsystem for Qualcomm Eliza SoC, being overall a
> minor revision change against SM8750, but coming with few different
> components, like different DSI PHY and added HDMI.
> 
> The binding does not include HDMI description yet.
> 
> Signed-off-by: Krzysztof Kozlowski 
> ---
>  .../bindings/display/msm/qcom,eliza-mdss.yaml  | 496 
> +
>  1 file changed, 496 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/display/msm/qcom,eliza-mdss.example.dts:25:18:
 fatal error: dt-bindings/clock/qcom,eliza-gcc.h: No such file or directory
   25 | #include 
  |  ^~~~
compilation terminated.
make[2]: *** [scripts/Makefile.dtbs:140: 
Documentation/devicetree/bindings/display/msm/qcom,eliza-mdss.example.dtb] 
Error 1
make[2]: *** Waiting for unfinished jobs
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1597: 
dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See 
https://patchwork.kernel.org/project/devicetree/patch/[email protected]

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.



Re: [PATCH 5/8] dt-bindings: display/msm: qcom, eliza-mdss: Add Eliza SoC

2026-03-03 Thread Dmitry Baryshkov
On Tue, Mar 03, 2026 at 02:07:55PM +0100, Krzysztof Kozlowski wrote:
> Add MDSS/MDP display subsystem for Qualcomm Eliza SoC, being overall a
> minor revision change against SM8750, but coming with few different
> components, like different DSI PHY and added HDMI.
> 
> The binding does not include HDMI description yet.
> 
> Signed-off-by: Krzysztof Kozlowski 
> ---
>  .../bindings/display/msm/qcom,eliza-mdss.yaml  | 496 
> +
>  1 file changed, 496 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov 


-- 
With best wishes
Dmitry