Re: [PATCH 6/6] [v4] drm/i915: Add support for CCS modifiers

2017-08-08 Thread Daniel Stone
Hi, On 3 August 2017 at 12:00, Daniel Stone wrote: > On 1 August 2017 at 17:58, Ben Widawsky wrote: >> @@ -1240,6 +1253,19 @@ intel_sprite_plane_create(struct drm_i915_private >> *dev_priv, >> plane_formats = skl_plane_formats; >> num_plane_formats = ARRAY_SIZE(s

Re: [PATCH 6/6] [v4] drm/i915: Add support for CCS modifiers

2017-08-04 Thread Daniel Stone
On 3 August 2017 at 18:21, Ben Widawsky wrote: > On 17-08-03 12:00:56, Daniel Stone wrote: >> if (pipe >= PIPE_C || plane >= PLANE_SPRITE1) >> >> cf. skl_check_ccs_aux_surface() which rejects CCS on anything other >> than PRIMARY/SPRITE0. >> >> I'll squash when pushing. > > Okay, thanks. With univ

Re: [PATCH 6/6] [v4] drm/i915: Add support for CCS modifiers

2017-08-03 Thread Ben Widawsky
On 17-08-03 12:00:56, Daniel Stone wrote: Hi, On 1 August 2017 at 17:58, Ben Widawsky wrote: @@ -1240,6 +1253,19 @@ intel_sprite_plane_create(struct drm_i915_private *dev_priv, plane_formats = skl_plane_formats; num_plane_formats = ARRAY_SIZE(skl_plane_formats)

Re: [PATCH 6/6] [v4] drm/i915: Add support for CCS modifiers

2017-08-03 Thread Daniel Stone
Hi, On 1 August 2017 at 17:58, Ben Widawsky wrote: > @@ -1240,6 +1253,19 @@ intel_sprite_plane_create(struct drm_i915_private > *dev_priv, > plane_formats = skl_plane_formats; > num_plane_formats = ARRAY_SIZE(skl_plane_formats); > modifiers = skl_p