Re: [PATCH 7/8] drm/msm/dpu: Add support for Eliza SoC
On 03/03/2026 15:10, Dmitry Baryshkov wrote:
> On Tue, Mar 03, 2026 at 02:07:57PM +0100, Krzysztof Kozlowski wrote:
>> Add support for DPU (v12.4) on Qualcomm Eliza SoC, with one
>> incomplete/skipped part: HDMI interface (INT_4).
>>
>> Signed-off-by: Krzysztof Kozlowski
>> ---
>> .../gpu/drm/msm/disp/dpu1/catalog/dpu_12_4_eliza.h | 365
>> +
>> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 1 +
>> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 1 +
>> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c| 1 +
>> 4 files changed, 368 insertions(+)
>>
>> +}, {
>> +.name = "intf_3", .id = INTF_3,
>> +.base = 0x37000, .len = 0x4bc,
>> +.type = INTF_DP,
>> +.controller_id = MSM_DP_CONTROLLER_1,
>
> There is no DP_1 on Eliza
You are right, thanks. It's paired with INTF_0.
Best regards,
Krzysztof
Re: [PATCH 7/8] drm/msm/dpu: Add support for Eliza SoC
On Tue, Mar 03, 2026 at 02:07:57PM +0100, Krzysztof Kozlowski wrote:
> Add support for DPU (v12.4) on Qualcomm Eliza SoC, with one
> incomplete/skipped part: HDMI interface (INT_4).
>
> Signed-off-by: Krzysztof Kozlowski
> ---
> .../gpu/drm/msm/disp/dpu1/catalog/dpu_12_4_eliza.h | 365
> +
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 1 +
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 1 +
> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c| 1 +
> 4 files changed, 368 insertions(+)
>
> + }, {
> + .name = "intf_3", .id = INTF_3,
> + .base = 0x37000, .len = 0x4bc,
> + .type = INTF_DP,
> + .controller_id = MSM_DP_CONTROLLER_1,
There is no DP_1 on Eliza
> + .prog_fetch_lines_worst_case = 24,
> + .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 30),
> + .intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 31),
> + }
> +};
> +
--
With best wishes
Dmitry
Re: [PATCH 7/8] drm/msm/dpu: Add support for Eliza SoC
On 03/03/2026 15:08, Dmitry Baryshkov wrote:
> On Tue, Mar 03, 2026 at 02:07:57PM +0100, Krzysztof Kozlowski wrote:
>> Add support for DPU (v12.4) on Qualcomm Eliza SoC, with one
>> incomplete/skipped part: HDMI interface (INT_4).
>>
>> Signed-off-by: Krzysztof Kozlowski
>> ---
>> .../gpu/drm/msm/disp/dpu1/catalog/dpu_12_4_eliza.h | 365
>> +
>> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 1 +
>> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 1 +
>> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c| 1 +
>> 4 files changed, 368 insertions(+)
>>
>> +
>> +static const struct dpu_mdp_cfg eliza_mdp = {
>> +.name = "top_0",
>> +.base = 0, .len = 0x494, // not verified
>
> This is very weird to read, coming from Qualcomm employee. Were the rest
> of data verified?
It's not weird, just mistake. Stale comment from going through all
differences and leaving this for later. I verified it.
Best regards,
Krzysztof
Re: [PATCH 7/8] drm/msm/dpu: Add support for Eliza SoC
On Tue, Mar 03, 2026 at 02:07:57PM +0100, Krzysztof Kozlowski wrote:
> Add support for DPU (v12.4) on Qualcomm Eliza SoC, with one
> incomplete/skipped part: HDMI interface (INT_4).
>
> Signed-off-by: Krzysztof Kozlowski
> ---
> .../gpu/drm/msm/disp/dpu1/catalog/dpu_12_4_eliza.h | 365
> +
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 1 +
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 1 +
> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c| 1 +
> 4 files changed, 368 insertions(+)
>
> +
> +static const struct dpu_mdp_cfg eliza_mdp = {
> + .name = "top_0",
> + .base = 0, .len = 0x494, // not verified
This is very weird to read, coming from Qualcomm employee. Were the rest
of data verified?
> + .clk_ctrls = {
> + [DPU_CLK_CTRL_REG_DMA] = { .reg_off = 0x2bc, .bit_off = 20 },
> + },
> +};
> +
--
With best wishes
Dmitry
