Re: [PATCH v10 1/5] dma-buf: Add dma-buf heaps framework

2019-10-08 Thread Randy Dunlap 
On 10/7/19 2:18 PM, John Stultz wrote:
> diff --git a/drivers/dma-buf/Kconfig b/drivers/dma-buf/Kconfig
> index a23b6752d11a..6e9c7c4d7447 100644
> --- a/drivers/dma-buf/Kconfig
> +++ b/drivers/dma-buf/Kconfig
> @@ -44,4 +44,13 @@ config DMABUF_SELFTESTS
>   default n
>   depends on DMA_SHARED_BUFFER
>  
> +menuconfig DMABUF_HEAPS
> + bool "DMA-BUF Userland Memory Heaps"
> + select DMA_SHARED_BUFFER
> + help
> +   Choose this option to enable the DMA-BUF userland memory heaps,

   heaps.

> +   this options creates per heap chardevs in /dev/dma_heap/ which

  This

> +   allows userspace to use to allocate dma-bufs that can be shared

?? to allocate & use

> +   between drivers.
> +
>  endmenu


-- 
~Randy
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v10 1/5] dma-buf: Add dma-buf heaps framework

2019-10-07 Thread John Stultz 
On Mon, Oct 7, 2019 at 2:21 PM Randy Dunlap  wrote:
> On 10/7/19 2:18 PM, John Stultz wrote:
> > diff --git a/drivers/dma-buf/Kconfig b/drivers/dma-buf/Kconfig
> > index a23b6752d11a..6e9c7c4d7447 100644
> > --- a/drivers/dma-buf/Kconfig
> > +++ b/drivers/dma-buf/Kconfig
> > @@ -44,4 +44,13 @@ config DMABUF_SELFTESTS
> >   default n
> >   depends on DMA_SHARED_BUFFER
> >
> > +menuconfig DMABUF_HEAPS
> > + bool "DMA-BUF Userland Memory Heaps"
> > + select DMA_SHARED_BUFFER
> > + help
> > +   Choose this option to enable the DMA-BUF userland memory heaps,
>
>heaps.
>
> > +   this options creates per heap chardevs in /dev/dma_heap/ which
>
>   This
>
> > +   allows userspace to use to allocate dma-bufs that can be shared
>
> ?? to allocate & use

I think the "to use" was just extraneous. I'll drop it.

Thanks for catching these. I'll fix them up and respin v11 later this week.

thanks
-john
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel