Re: [PATCH v2] drm/i915: Return correct EDP voltage swing table for 0.85V

2017-08-11 Thread Rodrigo Vivi 
On Fri, Aug 11, 2017 at 11:32 AM, Matthias Kaehlcke  wrote:
> El Mon, Jul 17, 2017 at 12:58:54PM -0700 Matthias Kaehlcke ha dit:
>
>> For 0.85V cnl_get_buf_trans_edp() returns the DP table, instead of EDP.
>> Use the correct table.
>>
>> The error was pointed out by this clang warning:
>>
>> drivers/gpu/drm/i915/intel_ddi.c:392:39: warning: variable
>>   'cnl_ddi_translations_edp_0_85V' is not needed and will not be emitted
>>   [-Wunneeded-internal-declaration]
>> static const struct cnl_ddi_buf_trans cnl_ddi_translations_edp_0_85V[] = 
>> {
>>
>> Fixes: cf54ca8bc567 ("drm/i915/cnl: Implement voltage swing sequence.")
>> Signed-off-by: Matthias Kaehlcke 
>> Reviewed-by: Manasi Navare 
>> ---
>> Changes in v2:
>> - Added 'Fixes' tag
>> - Added Reviewed-by: Manasi Navare 
>
> ping, it seems this patch went under the radar.

yes totally. sorry about that.

merged to dinq. Thanks for patch, review, and heads up

> ___
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel



-- 
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2] drm/i915: Return correct EDP voltage swing table for 0.85V

2017-08-11 Thread Matthias Kaehlcke 
El Mon, Jul 17, 2017 at 12:58:54PM -0700 Matthias Kaehlcke ha dit:

> For 0.85V cnl_get_buf_trans_edp() returns the DP table, instead of EDP.
> Use the correct table.
> 
> The error was pointed out by this clang warning:
> 
> drivers/gpu/drm/i915/intel_ddi.c:392:39: warning: variable
>   'cnl_ddi_translations_edp_0_85V' is not needed and will not be emitted
>   [-Wunneeded-internal-declaration]
> static const struct cnl_ddi_buf_trans cnl_ddi_translations_edp_0_85V[] = {
> 
> Fixes: cf54ca8bc567 ("drm/i915/cnl: Implement voltage swing sequence.")
> Signed-off-by: Matthias Kaehlcke 
> Reviewed-by: Manasi Navare 
> ---
> Changes in v2:
> - Added 'Fixes' tag
> - Added Reviewed-by: Manasi Navare 

ping, it seems this patch went under the radar.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel