Re: [PATCH v2 1/7] dt-bindings: backlight: qcom-wled: Document ovp values for PMI8994
On Thu, Jan 08, 2026 at 04:43:19AM +0100, Barnabás Czémán wrote: > Document ovp values supported by wled found in PMI8994. > > Reviewed-by: Konrad Dybcio > Signed-off-by: Barnabás Czémán > --- > .../bindings/leds/backlight/qcom-wled.yaml | 22 > -- > 1 file changed, 20 insertions(+), 2 deletions(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof
Re: [PATCH v2 1/7] dt-bindings: backlight: qcom-wled: Document ovp values for PMI8994
On 2026-01-08 10:22, Konrad Dybcio wrote: On 1/8/26 10:17 AM, [email protected] wrote: On 2026-01-08 09:54, Konrad Dybcio wrote: On 1/8/26 4:43 AM, Barnabás Czémán wrote: Document ovp values supported by wled found in PMI8994. Reviewed-by: Konrad Dybcio I reviewed a version of this that said PMI8950, which is very much not the same.. Let me try and get some more docs to confirm or deny what you're saying.. I have sent it for the previous revision msm-4.4 contains the documentation. https://lore.kernel.org/all/[email protected]/T/#u Right, but I didn't send any reply acknowledging that. On v1, my review tag meant "I concur this is the case for PMI8950" Yes, sorry. Since they are pretty much same i have considered it is a minor change i have only changed everything to pmi8994 because it was introduced before pmi8950 at upstream. I will be more careful next time. Because you carried it in v2, it appears as if I said "I concur this is the case for PMI8994", which is not what I then said. Konrad
Re: [PATCH v2 1/7] dt-bindings: backlight: qcom-wled: Document ovp values for PMI8994
On 1/8/26 10:17 AM, [email protected] wrote: > On 2026-01-08 09:54, Konrad Dybcio wrote: >> On 1/8/26 4:43 AM, Barnabás Czémán wrote: >>> Document ovp values supported by wled found in PMI8994. >>> >>> Reviewed-by: Konrad Dybcio >> >> I reviewed a version of this that said PMI8950, which is very much >> not the same.. >> >> Let me try and get some more docs to confirm or deny what you're >> saying.. > I have sent it for the previous revision msm-4.4 contains the documentation. > https://lore.kernel.org/all/[email protected]/T/#u Right, but I didn't send any reply acknowledging that. On v1, my review tag meant "I concur this is the case for PMI8950" Because you carried it in v2, it appears as if I said "I concur this is the case for PMI8994", which is not what I then said. Konrad
Re: [PATCH v2 1/7] dt-bindings: backlight: qcom-wled: Document ovp values for PMI8994
On 1/8/26 9:54 AM, Konrad Dybcio wrote: > On 1/8/26 4:43 AM, Barnabás Czémán wrote: >> Document ovp values supported by wled found in PMI8994. >> >> Reviewed-by: Konrad Dybcio > > I reviewed a version of this that said PMI8950, which is very much > not the same.. > > Let me try and get some more docs to confirm or deny what you're > saying.. PMI8994 indeed uses the same values as PMI8950, so let's keep my review tag (but please be more careful about that when making major changes between revisions in the future) Konrad
Re: [PATCH v2 1/7] dt-bindings: backlight: qcom-wled: Document ovp values for PMI8994
On 2026-01-08 09:54, Konrad Dybcio wrote: On 1/8/26 4:43 AM, Barnabás Czémán wrote: Document ovp values supported by wled found in PMI8994. Reviewed-by: Konrad Dybcio I reviewed a version of this that said PMI8950, which is very much not the same.. Let me try and get some more docs to confirm or deny what you're saying.. I have sent it for the previous revision msm-4.4 contains the documentation. https://lore.kernel.org/all/[email protected]/T/#u Konrad Signed-off-by: Barnabás Czémán --- .../bindings/leds/backlight/qcom-wled.yaml | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml index a8490781011d..19166186a1ff 100644 --- a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml +++ b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml @@ -98,8 +98,8 @@ properties: description: | Over-voltage protection limit. This property is for WLED4 only. $ref: /schemas/types.yaml#/definitions/uint32 -enum: [ 18100, 19600, 29600, 31100 ] -default: 29600 +minimum: 17800 +maximum: 31100 qcom,num-strings: description: | @@ -239,6 +239,24 @@ allOf: minimum: 0 maximum: 4095 + - if: + properties: +compatible: + contains: +const: qcom,pmi8994-wled + +then: + properties: +qcom,ovp-millivolt: + enum: [ 17800, 19400, 29500, 31000 ] + default: 29500 + +else: + properties: +qcom,ovp-millivolt: + enum: [ 18100, 19600, 29600, 31100 ] + default: 29600 + required: - compatible - reg
Re: [PATCH v2 1/7] dt-bindings: backlight: qcom-wled: Document ovp values for PMI8994
On 1/8/26 4:43 AM, Barnabás Czémán wrote: > Document ovp values supported by wled found in PMI8994. > > Reviewed-by: Konrad Dybcio I reviewed a version of this that said PMI8950, which is very much not the same.. Let me try and get some more docs to confirm or deny what you're saying.. Konrad > Signed-off-by: Barnabás Czémán > --- > .../bindings/leds/backlight/qcom-wled.yaml | 22 > -- > 1 file changed, 20 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml > b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml > index a8490781011d..19166186a1ff 100644 > --- a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml > +++ b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml > @@ -98,8 +98,8 @@ properties: > description: | >Over-voltage protection limit. This property is for WLED4 only. > $ref: /schemas/types.yaml#/definitions/uint32 > -enum: [ 18100, 19600, 29600, 31100 ] > -default: 29600 > +minimum: 17800 > +maximum: 31100 > >qcom,num-strings: > description: | > @@ -239,6 +239,24 @@ allOf: >minimum: 0 >maximum: 4095 > > + - if: > + properties: > +compatible: > + contains: > +const: qcom,pmi8994-wled > + > +then: > + properties: > +qcom,ovp-millivolt: > + enum: [ 17800, 19400, 29500, 31000 ] > + default: 29500 > + > +else: > + properties: > +qcom,ovp-millivolt: > + enum: [ 18100, 19600, 29600, 31100 ] > + default: 29600 > + > required: >- compatible >- reg >
