Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

On 9/12/23 17:13, Boris Brezillon wrote: On Tue, 12 Sep 2023 16:49:09 +0200 Boris Brezillon wrote: On Tue, 12 Sep 2023 16:33:01 +0200 Danilo Krummrich wrote: On 9/12/23 16:28, Boris Brezillon wrote: On Thu, 17 Aug 2023 13:13:31 +0200 Danilo Krummrich wrote: I think that's a

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

On 9/12/23 16:49, Boris Brezillon wrote: On Tue, 12 Sep 2023 16:33:01 +0200 Danilo Krummrich wrote: On 9/12/23 16:28, Boris Brezillon wrote: On Thu, 17 Aug 2023 13:13:31 +0200 Danilo Krummrich wrote: I think that's a misunderstanding. I'm not trying to say that it is *always*

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

On Tue, 12 Sep 2023 16:49:09 +0200 Boris Brezillon wrote: > On Tue, 12 Sep 2023 16:33:01 +0200 > Danilo Krummrich wrote: > > > On 9/12/23 16:28, Boris Brezillon wrote: > > > On Thu, 17 Aug 2023 13:13:31 +0200 > > > Danilo Krummrich wrote: > > > > > >> I think that's a misunderstanding.

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

On Tue, 12 Sep 2023 16:33:01 +0200 Danilo Krummrich wrote: > On 9/12/23 16:28, Boris Brezillon wrote: > > On Thu, 17 Aug 2023 13:13:31 +0200 > > Danilo Krummrich wrote: > > > >> I think that's a misunderstanding. I'm not trying to say that it is > >> *always* beneficial to fill up the ring

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

On 9/12/23 16:28, Boris Brezillon wrote: On Thu, 17 Aug 2023 13:13:31 +0200 Danilo Krummrich wrote: I think that's a misunderstanding. I'm not trying to say that it is *always* beneficial to fill up the ring as much as possible. But I think it is under certain circumstances, exactly those

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

On Thu, 17 Aug 2023 13:13:31 +0200 Danilo Krummrich wrote: > I think that's a misunderstanding. I'm not trying to say that it is > *always* beneficial to fill up the ring as much as possible. But I think > it is under certain circumstances, exactly those circumstances I > described for

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

On Tue, Aug 22, 2023 at 6:55 PM Faith Ekstrand wrote: > On Tue, Aug 22, 2023 at 4:51 AM Christian König > wrote: > >> Am 21.08.23 um 21:46 schrieb Faith Ekstrand: >> >> On Mon, Aug 21, 2023 at 1:13 PM Christian König >> wrote: >> >>> [SNIP] >>> So as long as nobody from userspace comes and

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

On Tue, Aug 22, 2023 at 4:51 AM Christian König wrote: > Am 21.08.23 um 21:46 schrieb Faith Ekstrand: > > On Mon, Aug 21, 2023 at 1:13 PM Christian König > wrote: > >> [SNIP] >> So as long as nobody from userspace comes and says we absolutely need to >> optimize this use case I would rather not

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

Am 21.08.23 um 21:46 schrieb Faith Ekstrand: On Mon, Aug 21, 2023 at 1:13 PM Christian König wrote: [SNIP] So as long as nobody from userspace comes and says we absolutely need to optimize this use case I would rather not do it. This is a place where nouveau's needs are

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

Am 21.08.23 um 21:07 schrieb Danilo Krummrich: On 8/21/23 20:12, Christian König wrote: Am 21.08.23 um 20:01 schrieb Danilo Krummrich: On 8/21/23 16:07, Christian König wrote: Am 18.08.23 um 13:58 schrieb Danilo Krummrich: [SNIP] I only see two possible outcomes: 1. You return -EBUSY (or

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

On Mon, Aug 21, 2023 at 1:13 PM Christian König wrote: > Am 21.08.23 um 20:01 schrieb Danilo Krummrich: > > On 8/21/23 16:07, Christian König wrote: > >> Am 18.08.23 um 13:58 schrieb Danilo Krummrich: > >>> [SNIP] > I only see two possible outcomes: > 1. You return -EBUSY (or similar)

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

On 8/21/23 20:12, Christian König wrote: Am 21.08.23 um 20:01 schrieb Danilo Krummrich: On 8/21/23 16:07, Christian König wrote: Am 18.08.23 um 13:58 schrieb Danilo Krummrich: [SNIP] I only see two possible outcomes: 1. You return -EBUSY (or similar) error code indicating the the hw can't

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

Am 21.08.23 um 20:01 schrieb Danilo Krummrich: On 8/21/23 16:07, Christian König wrote: Am 18.08.23 um 13:58 schrieb Danilo Krummrich: [SNIP] I only see two possible outcomes: 1. You return -EBUSY (or similar) error code indicating the the hw can't receive more commands. 2. Wait on

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

On 8/21/23 16:07, Christian König wrote: Am 18.08.23 um 13:58 schrieb Danilo Krummrich: [SNIP] I only see two possible outcomes: 1. You return -EBUSY (or similar) error code indicating the the hw can't receive more commands. 2. Wait on previously pushed commands to be executed. (3. Your

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

Am 18.08.23 um 13:58 schrieb Danilo Krummrich: [SNIP] I only see two possible outcomes: 1. You return -EBUSY (or similar) error code indicating the the hw can't receive more commands. 2. Wait on previously pushed commands to be executed. (3. Your driver crash because you accidentally

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

On 8/18/23 14:49, Matthew Brost wrote: On Fri, Aug 18, 2023 at 07:40:41AM +0200, Christian König wrote: Am 18.08.23 um 05:08 schrieb Matthew Brost: On Thu, Aug 17, 2023 at 01:13:31PM +0200, Danilo Krummrich wrote: On 8/17/23 07:33, Christian König wrote: Am 16.08.23 um 18:33 schrieb Danilo

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

On 8/17/23 18:17, Christian König wrote: Am 17.08.23 um 14:48 schrieb Danilo Krummrich: On 8/17/23 15:35, Christian König wrote: Am 17.08.23 um 13:13 schrieb Danilo Krummrich: On 8/17/23 07:33, Christian König wrote: [SNIP] My proposal would be to just keep the hw_submission_limit (maybe

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

On Fri, Aug 18, 2023 at 07:40:41AM +0200, Christian König wrote: > Am 18.08.23 um 05:08 schrieb Matthew Brost: > > On Thu, Aug 17, 2023 at 01:13:31PM +0200, Danilo Krummrich wrote: > > > On 8/17/23 07:33, Christian König wrote: > > > > Am 16.08.23 um 18:33 schrieb Danilo Krummrich: > > > > > On

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

Am 18.08.23 um 05:08 schrieb Matthew Brost: On Thu, Aug 17, 2023 at 01:13:31PM +0200, Danilo Krummrich wrote: On 8/17/23 07:33, Christian König wrote: Am 16.08.23 um 18:33 schrieb Danilo Krummrich: On 8/16/23 16:59, Christian König wrote: Am 16.08.23 um 14:30 schrieb Danilo Krummrich: On

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

On Thu, Aug 17, 2023 at 01:13:31PM +0200, Danilo Krummrich wrote: > On 8/17/23 07:33, Christian König wrote: > > Am 16.08.23 um 18:33 schrieb Danilo Krummrich: > > > On 8/16/23 16:59, Christian König wrote: > > > > Am 16.08.23 um 14:30 schrieb Danilo Krummrich: > > > > > On 8/16/23 16:05,

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

Am 17.08.23 um 14:48 schrieb Danilo Krummrich: On 8/17/23 15:35, Christian König wrote: Am 17.08.23 um 13:13 schrieb Danilo Krummrich: On 8/17/23 07:33, Christian König wrote: [SNIP] My proposal would be to just keep the hw_submission_limit (maybe rename it to submission_unit_limit) and add

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

On 8/17/23 15:35, Christian König wrote: Am 17.08.23 um 13:13 schrieb Danilo Krummrich: On 8/17/23 07:33, Christian König wrote: [SNIP] The hardware seems to work mostly the same for all vendors, but you somehow seem to think that filling the ring is somehow beneficial which is really not

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

Am 17.08.23 um 13:13 schrieb Danilo Krummrich: On 8/17/23 07:33, Christian König wrote: [SNIP] The hardware seems to work mostly the same for all vendors, but you somehow seem to think that filling the ring is somehow beneficial which is really not the case as far as I can see. I think

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

On 8/17/23 07:33, Christian König wrote: Am 16.08.23 um 18:33 schrieb Danilo Krummrich: On 8/16/23 16:59, Christian König wrote: Am 16.08.23 um 14:30 schrieb Danilo Krummrich: On 8/16/23 16:05, Christian König wrote: Am 16.08.23 um 13:30 schrieb Danilo Krummrich: Hi Matt, On 8/11/23 04:31,

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

Am 16.08.23 um 18:33 schrieb Danilo Krummrich: On 8/16/23 16:59, Christian König wrote: Am 16.08.23 um 14:30 schrieb Danilo Krummrich: On 8/16/23 16:05, Christian König wrote: Am 16.08.23 um 13:30 schrieb Danilo Krummrich: Hi Matt, On 8/11/23 04:31, Matthew Brost wrote: In XE, the new

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

On 8/16/23 16:59, Christian König wrote: Am 16.08.23 um 14:30 schrieb Danilo Krummrich: On 8/16/23 16:05, Christian König wrote: Am 16.08.23 um 13:30 schrieb Danilo Krummrich: Hi Matt, On 8/11/23 04:31, Matthew Brost wrote: In XE, the new Intel GPU driver, a choice has made to have a 1 to 1

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

On 8/16/23 16:38, Matthew Brost wrote: On Wed, Aug 16, 2023 at 02:30:38PM +0200, Danilo Krummrich wrote: On 8/16/23 16:05, Christian König wrote: Am 16.08.23 um 13:30 schrieb Danilo Krummrich: Hi Matt, On 8/11/23 04:31, Matthew Brost wrote: In XE, the new Intel GPU driver, a choice has made

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

Am 16.08.23 um 14:30 schrieb Danilo Krummrich: On 8/16/23 16:05, Christian König wrote: Am 16.08.23 um 13:30 schrieb Danilo Krummrich: Hi Matt, On 8/11/23 04:31, Matthew Brost wrote: In XE, the new Intel GPU driver, a choice has made to have a 1 to 1 mapping between a drm_gpu_scheduler and

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

On Wed, Aug 16, 2023 at 02:30:38PM +0200, Danilo Krummrich wrote: > On 8/16/23 16:05, Christian König wrote: > > Am 16.08.23 um 13:30 schrieb Danilo Krummrich: > > > Hi Matt, > > > > > > On 8/11/23 04:31, Matthew Brost wrote: > > > > In XE, the new Intel GPU driver, a choice has made to have a 1

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

On 8/16/23 16:05, Christian König wrote: Am 16.08.23 um 13:30 schrieb Danilo Krummrich: Hi Matt, On 8/11/23 04:31, Matthew Brost wrote: In XE, the new Intel GPU driver, a choice has made to have a 1 to 1 mapping between a drm_gpu_scheduler and drm_sched_entity. At first this seems a bit odd

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

Am 16.08.23 um 13:30 schrieb Danilo Krummrich: Hi Matt, On 8/11/23 04:31, Matthew Brost wrote: In XE, the new Intel GPU driver, a choice has made to have a 1 to 1 mapping between a drm_gpu_scheduler and drm_sched_entity. At first this seems a bit odd but let us explain the reasoning below. 1.

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

Hi Matt, On 8/11/23 04:31, Matthew Brost wrote: In XE, the new Intel GPU driver, a choice has made to have a 1 to 1 mapping between a drm_gpu_scheduler and drm_sched_entity. At first this seems a bit odd but let us explain the reasoning below. 1. In XE the submission order from multiple