Re: [PATCH v2 2/2] backlight: lm3630a: add an enable gpio for the HWEN pin

2019-09-12 Thread Daniel Thompson
On Wed, Sep 11, 2019 at 01:48:36PM -0500, Dan Murphy wrote: > > On 9/11/19 5:25 AM, Daniel Thompson wrote: > > On Tue, Sep 10, 2019 at 11:29:09PM +0200, Andreas Kemnade wrote: > > > For now just enable it in the probe function to allow i2c > > > access. Disabling also means resetting the register

Re: [PATCH v2 2/2] backlight: lm3630a: add an enable gpio for the HWEN pin

2019-09-11 Thread Andreas Kemnade
On Wed, 11 Sep 2019 13:48:36 -0500 Dan Murphy wrote: > >> @@ -535,6 +538,13 @@ static int lm3630a_probe(struct i2c_client *client, > >>} > >>pchip->pdata = pdata; > >> > >> + pchip->enable_gpio = devm_gpiod_get_optional(>dev, "enable", > >> +

Re: [PATCH v2 2/2] backlight: lm3630a: add an enable gpio for the HWEN pin

2019-09-11 Thread Dan Murphy
On 9/11/19 5:25 AM, Daniel Thompson wrote: On Tue, Sep 10, 2019 at 11:29:09PM +0200, Andreas Kemnade wrote: For now just enable it in the probe function to allow i2c access. Disabling also means resetting the register values to default and according to the datasheet does not give power

Re: [PATCH v2 2/2] backlight: lm3630a: add an enable gpio for the HWEN pin

2019-09-11 Thread Daniel Thompson
On Tue, Sep 10, 2019 at 11:29:09PM +0200, Andreas Kemnade wrote: > For now just enable it in the probe function to allow i2c > access. Disabling also means resetting the register values > to default and according to the datasheet does not give > power savings > > Tested on Kobo Clara HD. > >