Re: [PATCH v2 3/3] DRM: Add KMS driver for the Ingenic JZ47xx SoCs

2019-04-15 Thread Daniel Vetter
On Sat, Mar 16, 2019 at 10:59:44PM +0100, Sam Ravnborg wrote: > > + ret = drm_fbdev_generic_setup(drm, 16); > > + if (ret) { > > + dev_err(dev, "Failed to init fbdev\n"); > > + goto err_devclk_disable; > > + } > fbdev is usually considered an optionl feature that do not

Re: [PATCH v2 3/3] DRM: Add KMS driver for the Ingenic JZ47xx SoCs

2019-04-03 Thread Paul Cercueil
Hi Sam, Le sam. 16 mars 2019 à 22:59, Sam Ravnborg a écrit : Hi Paul. Thanks for the v2 submission. Did you analyze the possibility to utilize drm_simple_display_pipe_init() and the related infrastructure? If this fits it should simplify the driver. If it does not fit please let us know

Re: [PATCH v2 3/3] DRM: Add KMS driver for the Ingenic JZ47xx SoCs

2019-03-18 Thread Paul Cercueil
Hi Sam, Le sam. 16 mars 2019 à 22:59, Sam Ravnborg a écrit : Hi Paul. Thanks for the v2 submission. Did you analyze the possibility to utilize drm_simple_display_pipe_init() and the related infrastructure? If this fits it should simplify the driver. If it does not fit please let us know

Re: [PATCH v2 3/3] DRM: Add KMS driver for the Ingenic JZ47xx SoCs

2019-03-16 Thread Sam Ravnborg
Hi Paul. Thanks for the v2 submission. Did you analyze the possibility to utilize drm_simple_display_pipe_init() and the related infrastructure? If this fits it should simplify the driver. If it does not fit please let us know why. As this is a one crtc / one connector / one panel the