Re: [PATCH v2 4/8] dt-bindings: media: renesas, fdp1: Convert binding to YAML

2020-07-13 Thread Rob Herring
On Sun, 21 Jun 2020 03:47:30 +0300, Laurent Pinchart wrote:
> Convert the Renesas R-Car FDP1 text binding to YAML.
> 
> Signed-off-by: Laurent Pinchart 
> Reviewed-by: Geert Uytterhoeven 
> ---
> Changes since v1:
> 
> - Update MAINTAINERS
> ---
>  .../bindings/media/renesas,fdp1.txt   | 37 ---
>  .../bindings/media/renesas,fdp1.yaml  | 63 +++
>  MAINTAINERS   |  2 +-
>  3 files changed, 64 insertions(+), 38 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/media/renesas,fdp1.txt
>  create mode 100644 Documentation/devicetree/bindings/media/renesas,fdp1.yaml
> 

Reviewed-by: Rob Herring 
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel


Re: [PATCH v2 4/8] dt-bindings: media: renesas, fdp1: Convert binding to YAML

2020-07-01 Thread Niklas Söderlund
Hi Laurent,

Thanks for your work.

On 2020-06-21 03:47:30 +0300, Laurent Pinchart wrote:
> Convert the Renesas R-Car FDP1 text binding to YAML.
> 
> Signed-off-by: Laurent Pinchart 
> Reviewed-by: Geert Uytterhoeven 

Reviewed-by: Niklas Söderlund 

> ---
> Changes since v1:
> 
> - Update MAINTAINERS
> ---
>  .../bindings/media/renesas,fdp1.txt   | 37 ---
>  .../bindings/media/renesas,fdp1.yaml  | 63 +++
>  MAINTAINERS   |  2 +-
>  3 files changed, 64 insertions(+), 38 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/media/renesas,fdp1.txt
>  create mode 100644 Documentation/devicetree/bindings/media/renesas,fdp1.yaml
> 
> diff --git a/Documentation/devicetree/bindings/media/renesas,fdp1.txt 
> b/Documentation/devicetree/bindings/media/renesas,fdp1.txt
> deleted file mode 100644
> index 8dd1007bb573..
> --- a/Documentation/devicetree/bindings/media/renesas,fdp1.txt
> +++ /dev/null
> @@ -1,37 +0,0 @@
> -Renesas R-Car Fine Display Processor (FDP1)
> 
> -
> -The FDP1 is a de-interlacing module which converts interlaced video to
> -progressive video. It is capable of performing pixel format conversion 
> between
> -YCbCr/YUV formats and RGB formats. Only YCbCr/YUV formats are supported as
> -an input to the module.
> -
> -Required properties:
> -
> - - compatible: must be "renesas,fdp1"
> - - reg: the register base and size for the device registers
> - - interrupts : interrupt specifier for the FDP1 instance
> - - clocks: reference to the functional clock
> -
> -Optional properties:
> -
> - - power-domains: reference to the power domain that the FDP1 belongs to, if
> -  any.
> - - renesas,fcp: a phandle referencing the FCP that handles memory accesses
> -for the FDP1. Not needed on Gen2, mandatory on Gen3.
> -
> -Please refer to the binding documentation for the clock and/or power domain
> -providers for more details.
> -
> -
> -Device node example
> 
> -
> - fdp1@fe94 {
> - compatible = "renesas,fdp1";
> - reg = <0 0xfe94 0 0x2400>;
> - interrupts = ;
> - clocks = < CPG_MOD 119>;
> - power-domains = < R8A7795_PD_A3VP>;
> - renesas,fcp = <>;
> - };
> diff --git a/Documentation/devicetree/bindings/media/renesas,fdp1.yaml 
> b/Documentation/devicetree/bindings/media/renesas,fdp1.yaml
> new file mode 100644
> index ..f4db96a1f53c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/renesas,fdp1.yaml
> @@ -0,0 +1,63 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/renesas,fdp1.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Renesas R-Car Fine Display Processor (FDP1)
> +
> +maintainers:
> +  - Laurent Pinchart 
> +
> +description:
> +  The FDP1 is a de-interlacing module which converts interlaced video to
> +  progressive video. It is capable of performing pixel format conversion
> +  between YCbCr/YUV formats and RGB formats. Only YCbCr/YUV formats are
> +  supported as an input to the module.
> +
> +properties:
> +  compatible:
> +enum:
> +  - renesas,fdp1
> +
> +  reg:
> +maxItems: 1
> +
> +  interrupts:
> +maxItems: 1
> +
> +  clocks:
> +maxItems: 1
> +
> +  power-domains:
> +maxItems: 1
> +
> +  renesas,fcp:
> +$ref: /schemas/types.yaml#/definitions/phandle
> +description:
> +  A phandle referencing the FCP that handles memory accesses for the 
> FDP1.
> +  Not allowed on R-Car Gen2, mandatory on R-Car Gen3.
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +#include 
> +#include 
> +#include 
> +
> +fdp1@fe94 {
> +compatible = "renesas,fdp1";
> +reg = <0xfe94 0x2400>;
> +interrupts = ;
> +clocks = < CPG_MOD 119>;
> +power-domains = < R8A7795_PD_A3VP>;
> +renesas,fcp = <>;
> +};
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 660ed6606de2..7383dfa510a3 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -10710,7 +10710,7 @@ L:linux-me...@vger.kernel.org
>  L:   linux-renesas-...@vger.kernel.org
>  S:   Supported
>  T:   git git://linuxtv.org/media_tree.git
> -F:   Documentation/devicetree/bindings/media/renesas,fdp1.txt
> +F:   Documentation/devicetree/bindings/media/renesas,fdp1.yaml
>  F:   drivers/media/platform/rcar_fdp1.c
>  
>  MEDIA DRIVERS FOR RENESAS - VIN
> -- 
> Regards,
> 
> Laurent Pinchart
> 

-- 
Regards,
Niklas Söderlund
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel