Re: [PATCH v2 5/5] drm/vkms: Implement CRC debugfs API

2018-07-30 Thread Haneen Mohammed
On Wed, Jul 18, 2018 at 02:44:18PM -0400, Sean Paul wrote: > On Wed, Jul 18, 2018 at 07:24:34PM +0300, Haneen Mohammed wrote: > > First, just so you have the complete view, this is the missing part in this > > patch: > > -- vkms_crc.c > > static uint32_t _vkms_get_crc(struct vkms_crc_data

Re: [PATCH v2 5/5] drm/vkms: Implement CRC debugfs API

2018-07-19 Thread Haneen Mohammed
First, just so you have the complete view, this is the missing part in this patch: -- vkms_crc.c static uint32_t _vkms_get_crc(struct vkms_crc_data *crc_data) { struct drm_framebuffer *fb = _data->fb; struct drm_gem_object *gem_obj = drm_gem_fb_get_obj(fb, 0); struct

Re: [PATCH v2 5/5] drm/vkms: Implement CRC debugfs API

2018-07-19 Thread Haneen Mohammed
On Wed, Jul 18, 2018 at 02:44:18PM -0400, Sean Paul wrote: > On Wed, Jul 18, 2018 at 07:24:34PM +0300, Haneen Mohammed wrote: > > First, just so you have the complete view, this is the missing part in this > > patch: > > -- vkms_crc.c > > static uint32_t _vkms_get_crc(struct vkms_crc_data

Re: [PATCH v2 5/5] drm/vkms: Implement CRC debugfs API

2018-07-18 Thread Sean Paul
On Wed, Jul 18, 2018 at 07:24:34PM +0300, Haneen Mohammed wrote: > First, just so you have the complete view, this is the missing part in this > patch: > -- vkms_crc.c > static uint32_t _vkms_get_crc(struct vkms_crc_data *crc_data) > { > struct drm_framebuffer *fb = _data->fb; >

Re: [PATCH v2 5/5] drm/vkms: Implement CRC debugfs API

2018-07-17 Thread Sean Paul
On Tue, Jul 17, 2018 at 04:43:16PM -0400, Sean Paul wrote: > On Tue, Jul 17, 2018 at 02:52:20AM +0300, Haneen Mohammed wrote: > > On Mon, Jul 16, 2018 at 02:22:56PM -0400, Sean Paul wrote: > > > On Sat, Jul 14, 2018 at 03:23:32PM +0300, Haneen Mohammed wrote: > > > > Implement the set_crc_source()

Re: [PATCH v2 5/5] drm/vkms: Implement CRC debugfs API

2018-07-17 Thread Sean Paul
On Tue, Jul 17, 2018 at 02:52:20AM +0300, Haneen Mohammed wrote: > On Mon, Jul 16, 2018 at 02:22:56PM -0400, Sean Paul wrote: > > On Sat, Jul 14, 2018 at 03:23:32PM +0300, Haneen Mohammed wrote: > > > Implement the set_crc_source() callback. > > > Compute CRC using crc32 on the visible part of the

Re: [PATCH v2 5/5] drm/vkms: Implement CRC debugfs API

2018-07-17 Thread Haneen Mohammed
On Mon, Jul 16, 2018 at 02:22:56PM -0400, Sean Paul wrote: > On Sat, Jul 14, 2018 at 03:23:32PM +0300, Haneen Mohammed wrote: > > Implement the set_crc_source() callback. > > Compute CRC using crc32 on the visible part of the framebuffer. > > Use ordered workqueue to compute and add CRC at the end

Re: [PATCH v2 5/5] drm/vkms: Implement CRC debugfs API

2018-07-16 Thread Sean Paul
On Sat, Jul 14, 2018 at 03:23:32PM +0300, Haneen Mohammed wrote: > Implement the set_crc_source() callback. > Compute CRC using crc32 on the visible part of the framebuffer. > Use ordered workqueue to compute and add CRC at the end of a vblank. > > Use appropriate synchronization methods since