Re: [PATCH v2 8/8] dt-bindings: media: renesas, vsp1: Add power-domains and resets

2020-07-13 Thread Rob Herring
On Sun, 21 Jun 2020 03:47:34 +0300, Laurent Pinchart wrote:
> The power-domains and resets properties are used in all DT sources in
> the kernel but are absent from the bindings. Document them and make them
> mandatory.
> 
> Signed-off-by: Laurent Pinchart 
> Reviewed-by: Geert Uytterhoeven 
> ---
>  .../devicetree/bindings/media/renesas,vsp1.yaml| 14 ++
>  1 file changed, 14 insertions(+)
> 

Acked-by: Rob Herring 
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel


Re: [PATCH v2 8/8] dt-bindings: media: renesas,vsp1: Add power-domains and resets

2020-07-01 Thread Niklas Söderlund
Hi Laurent,

Thanks for your patch.

On 2020-06-21 03:47:34 +0300, Laurent Pinchart wrote:
> The power-domains and resets properties are used in all DT sources in
> the kernel but are absent from the bindings. Document them and make them
> mandatory.
> 
> Signed-off-by: Laurent Pinchart 
> Reviewed-by: Geert Uytterhoeven 

Reviewed-by: Niklas Söderlund 

> ---
>  .../devicetree/bindings/media/renesas,vsp1.yaml| 14 ++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/renesas,vsp1.yaml 
> b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml
> index 65e8ee61ce90..990e9c1dbc43 100644
> --- a/Documentation/devicetree/bindings/media/renesas,vsp1.yaml
> +++ b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml
> @@ -29,6 +29,12 @@ properties:
>clocks:
>  maxItems: 1
>  
> +  power-domains:
> +maxItems: 1
> +
> +  resets:
> +maxItems: 1
> +
>renesas,fcp:
>  $ref: /schemas/types.yaml#/definitions/phandle
>  description:
> @@ -39,6 +45,8 @@ required:
>- reg
>- interrupts
>- clocks
> +  - power-domains
> +  - resets
>  
>  additionalProperties: false
>  
> @@ -59,24 +67,30 @@ examples:
>- |
>  #include 
>  #include 
> +#include 
>  
>  vsp@fe928000 {
>  compatible = "renesas,vsp1";
>  reg = <0xfe928000 0x8000>;
>  interrupts = ;
>  clocks = < CPG_MOD 131>;
> +power-domains = < R8A7790_PD_ALWAYS_ON>;
> +resets = < 131>;
>  };
>  
># R8A77951 (R-Car H3) VSP2-BC
>- |
>  #include 
>  #include 
> +#include 
>  
>  vsp@fe92 {
>  compatible = "renesas,vsp2";
>  reg = <0xfe92 0x8000>;
>  interrupts = ;
>  clocks = < CPG_MOD 624>;
> +power-domains = < R8A7795_PD_A3VP>;
> +resets = < 624>;
>  
>  renesas,fcp = <>;
>  };
> -- 
> Regards,
> 
> Laurent Pinchart
> 

-- 
Regards,
Niklas Söderlund
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel