Re: [PATCH v4 00/17] drm: add gem ttm helpers, rework mmap workflow.

2019-09-17 Thread Daniel Vetter
On Tue, Aug 27, 2019 at 07:13:41AM +0200, Gerd Hoffmann wrote: > Hi, > > > Also this patch series also adjust vram helpers, and I think it has a > > slightly different goal: Just aligning mmap paths a bit more between > > ttm and not-ttm based drivers. > > Not just ttm/not-ttm.

Re: [PATCH v4 00/17] drm: add gem ttm helpers, rework mmap workflow.

2019-09-03 Thread Daniel Vetter
On Thu, Aug 08, 2019 at 03:44:00PM +0200, Gerd Hoffmann wrote: > > > Gerd Hoffmann (17): > drm/ttm: turn ttm_bo_device.vma_manager into a pointer > drm/ttm: add gem_ttm_bo_device_init() > drm/vram: switch vram helpers to the new gem_ttm_bo_device_init() > drm/qxl: switch qxl to the new

Re: [PATCH v4 00/17] drm: add gem ttm helpers, rework mmap workflow.

2019-08-26 Thread Gerd Hoffmann
Hi, > Also this patch series also adjust vram helpers, and I think it has a > slightly different goal: Just aligning mmap paths a bit more between > ttm and not-ttm based drivers. Not just ttm/not-ttm. gem_driver->fops->mmap is the only fops callback where we can't use a generic gem callback

Re: [PATCH v4 00/17] drm: add gem ttm helpers, rework mmap workflow.

2019-08-26 Thread Gerd Hoffmann
On Mon, Aug 26, 2019 at 10:47:07AM +0200, Thomas Zimmermann wrote: > Hi, > > I would have liked to get some context on the purpose of GEM TTM > helpers. Is is just share-able code? Yes. Shareable code for drivers which use both ttm and gem (all except vmgfx). > From my understanding VRAM

Re: [PATCH v4 00/17] drm: add gem ttm helpers, rework mmap workflow.

2019-08-26 Thread Daniel Vetter
On Mon, Aug 26, 2019 at 10:47 AM Thomas Zimmermann wrote: > > Hi, > > I would have liked to get some context on the purpose of GEM TTM > helpers. Is is just share-able code? > > From my understanding VRAM helpers _are_ GEM TTM helpers. And they where > re-named to VRAM helpers, so that the naming

Re: [PATCH v4 00/17] drm: add gem ttm helpers, rework mmap workflow.

2019-08-26 Thread Thomas Zimmermann
Hi, I would have liked to get some context on the purpose of GEM TTM helpers. Is is just share-able code? From my understanding VRAM helpers _are_ GEM TTM helpers. And they where re-named to VRAM helpers, so that the naming is independent from the implementation (and vice versa). Wrt qxl, would

Re: [PATCH v4 00/17] drm: add gem ttm helpers, rework mmap workflow.

2019-08-08 Thread Gerd Hoffmann
On Thu, Aug 08, 2019 at 08:39:11AM -0600, Rob Herring wrote: > On Thu, Aug 8, 2019 at 7:44 AM Gerd Hoffmann wrote: > > > > > > > > Gerd Hoffmann (17): > > drm/ttm: turn ttm_bo_device.vma_manager into a pointer > > drm/ttm: add gem_ttm_bo_device_init() > > drm/vram: switch vram helpers to

Re: [PATCH v4 00/17] drm: add gem ttm helpers, rework mmap workflow.

2019-08-08 Thread Rob Herring
On Thu, Aug 8, 2019 at 7:44 AM Gerd Hoffmann wrote: > > > > Gerd Hoffmann (17): > drm/ttm: turn ttm_bo_device.vma_manager into a pointer > drm/ttm: add gem_ttm_bo_device_init() > drm/vram: switch vram helpers to the new gem_ttm_bo_device_init() > drm/qxl: switch qxl to the new