RE: [PATCH v4.19.x] make 'user_access_begin()' do 'access_ok()'

2020-05-28 Thread Ashwin H
csail.mit.edu; > rost...@goodmis.org; Steven Rostedt ; Linus > Torvalds > Subject: RE: [PATCH v4.19.x] make 'user_access_begin()' do 'access_ok()' > > > > > -Original Message- > > From: Greg KH > > Sent: Wednesday, May 27, 2020 9:02 PM > > To: Ash

RE: [PATCH v4.19.x] make 'user_access_begin()' do 'access_ok()'

2020-05-28 Thread Ashwin H
csail.mit.edu; > rost...@goodmis.org; Steven Rostedt ; Linus > Torvalds > Subject: Re: [PATCH v4.19.x] make 'user_access_begin()' do 'access_ok()' > > On Wed, May 13, 2020 at 05:08:19PM +, Ashwin H wrote: > > > Ok, but what does that mean for us? > > > > >

Re: [PATCH v4.19.x] make 'user_access_begin()' do 'access_ok()'

2020-05-27 Thread Greg KH
On Wed, May 13, 2020 at 05:08:19PM +, Ashwin H wrote: > > Ok, but what does that mean for us? > > > > You need to say why you are sending a patch, otherwise we will guess wrong. > > In drivers/gpu/drm/i915/i915_gem_execbuffer.c, ioctl functions does > user_access_begin() without doing

RE: [PATCH v4.19.x] make 'user_access_begin()' do 'access_ok()'

2020-05-13 Thread Ashwin H
> Ok, but what does that mean for us? > > You need to say why you are sending a patch, otherwise we will guess wrong. In drivers/gpu/drm/i915/i915_gem_execbuffer.c, ioctl functions does user_access_begin() without doing access_ok(Checks if a user space pointer is valid) first. A local

Re: [PATCH v4.19.x] make 'user_access_begin()' do 'access_ok()'

2020-05-13 Thread Greg KH
On Wed, May 13, 2020 at 06:13:17AM +, Ashwin H wrote: > This patch fixes CVE-2018-20669 in 4.19 tree. Ok, but what does that mean for us? You need to say why you are sending a patch, otherwise we will guess wrong. greg k-h ___ dri-devel mailing

Re: [PATCH v4.19.x] make 'user_access_begin()' do 'access_ok()'

2020-05-13 Thread Ashwin H
This patch fixes CVE-2018-20669 in 4.19 tree. On 13/05/20, 11:36 AM, "Greg KH" wrote: On Wed, May 13, 2020 at 07:19:21AM +0530, ashwin-h wrote: > From: Linus Torvalds > > commit 594cc251fdd0d231d342d88b2fdff4bc42fb0690 upstream. > > Originally, the rule used to be

Re: [PATCH v4.19.x] make 'user_access_begin()' do 'access_ok()'

2020-05-13 Thread Greg KH
On Wed, May 13, 2020 at 07:19:21AM +0530, ashwin-h wrote: > From: Linus Torvalds > > commit 594cc251fdd0d231d342d88b2fdff4bc42fb0690 upstream. > > Originally, the rule used to be that you'd have to do access_ok() > separately, and then user_access_begin() before actually doing the > direct