Re: [PATCH v5 4/6] dt-bindings: gpu: v3d: Add additional examples to improve binding checks
On 16/03/2025 18:42, Maíra Canal wrote: > Hi Krzysztof, > > On 16/03/25 13:43, Krzysztof Kozlowski wrote: >> On Sun, Mar 16, 2025 at 11:15:11AM -0300, Maíra Canal wrote: >>> To prevent future changes that might inadvertently break the ABI, add >>> more examples to the binding. These examples improve coverage and help >> >> Examples are not related to ABI at all. >> >>> ensure `make dt_binding_check` produces more robust validation results. >> >> No, don't add more examples differing by one property. Keep one/two >> examples. > > I had the intention to add examples to avoid people from changing the > reg order in the future. For example, we changed the register order when Example does not stop that at all. Changes nothing here. Best regards, Krzysztof
Re: [PATCH v5 4/6] dt-bindings: gpu: v3d: Add additional examples to improve binding checks
Hi Krzysztof,
On 16/03/25 13:43, Krzysztof Kozlowski wrote:
On Sun, Mar 16, 2025 at 11:15:11AM -0300, Maíra Canal wrote:
To prevent future changes that might inadvertently break the ABI, add
more examples to the binding. These examples improve coverage and help
Examples are not related to ABI at all.
ensure `make dt_binding_check` produces more robust validation results.
No, don't add more examples differing by one property. Keep one/two
examples.
I had the intention to add examples to avoid people from changing the
reg order in the future. For example, we changed the register order when
we converted the binding from txt to YAML. My goal was to avoid such
thing to happen again.
From the feedback, I'll drop this patch. Thanks!
Best Regards,
- Maíra
Signed-off-by: Maíra Canal
---
.../devicetree/bindings/gpu/brcm,bcm-v3d.yaml | 34 --
1 file changed, 32 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml
b/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml
index
766a310ab653855d7cc9a80f18c2083218fe307e..39b8f0ee1f727628307d758844008ae1189902b2
100644
--- a/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml
+++ b/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml
@@ -123,6 +123,38 @@ allOf:
additionalProperties: false
examples:
+ - |
+#include
+#include
+
+gpu@7ec0 {
+ compatible= "brcm,2711-v3d";
+ reg = <0x7ec0 0x4000>,
+<0x7ec04000 0x4000>;
+ reg-names = "hub", "core0";
+
+ power-domains = <&pm BCM2835_POWER_DOMAIN_GRAFX_V3D>;
That's the only notable difference - one new property.
+ resets = <&pm BCM2835_RESET_V3D>;
+ interrupts = ;
+};
+
+ - |
+#include
+#include
+
+gpu@200 {
+ compatible = "brcm,2712-v3d";
+ reg = <0x0200 0x4000>,
+<0x02008000 0x6000>,
+<0x02030800 0x0700>;
+ reg-names = "hub", "core0", "sms";
+
+ power-domains = <&pm BCM2835_POWER_DOMAIN_GRAFX_V3D>;
+ resets = <&pm BCM2835_RESET_V3D>;
+ interrupts = ,
+ ;
No differences here at all.
Best regards,
Krzysztof
Re: [PATCH v5 4/6] dt-bindings: gpu: v3d: Add additional examples to improve binding checks
On Sun, Mar 16, 2025 at 11:15:11AM -0300, Maíra Canal wrote:
> To prevent future changes that might inadvertently break the ABI, add
> more examples to the binding. These examples improve coverage and help
Examples are not related to ABI at all.
> ensure `make dt_binding_check` produces more robust validation results.
No, don't add more examples differing by one property. Keep one/two
examples.
>
> Signed-off-by: Maíra Canal
> ---
> .../devicetree/bindings/gpu/brcm,bcm-v3d.yaml | 34
> --
> 1 file changed, 32 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml
> b/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml
> index
> 766a310ab653855d7cc9a80f18c2083218fe307e..39b8f0ee1f727628307d758844008ae1189902b2
> 100644
> --- a/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml
> +++ b/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml
> @@ -123,6 +123,38 @@ allOf:
> additionalProperties: false
>
> examples:
> + - |
> +#include
> +#include
> +
> +gpu@7ec0 {
> + compatible= "brcm,2711-v3d";
> + reg = <0x7ec0 0x4000>,
> +<0x7ec04000 0x4000>;
> + reg-names = "hub", "core0";
> +
> + power-domains = <&pm BCM2835_POWER_DOMAIN_GRAFX_V3D>;
That's the only notable difference - one new property.
> + resets = <&pm BCM2835_RESET_V3D>;
> + interrupts = ;
> +};
> +
> + - |
> +#include
> +#include
> +
> +gpu@200 {
> + compatible = "brcm,2712-v3d";
> + reg = <0x0200 0x4000>,
> +<0x02008000 0x6000>,
> +<0x02030800 0x0700>;
> + reg-names = "hub", "core0", "sms";
> +
> + power-domains = <&pm BCM2835_POWER_DOMAIN_GRAFX_V3D>;
> + resets = <&pm BCM2835_RESET_V3D>;
> + interrupts = ,
> + ;
No differences here at all.
Best regards,
Krzysztof
