Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-16 Thread Daniel Stone
On Wed, 16 Feb 2022 at 14:13, Sui Jingfeng <15330273...@189.cn> wrote: > On 2022/2/16 21:46, Daniel Stone wrote: > > Other systems have this limitation, and Mesa's 'kmsro' concept makes > > this work transparently, as long as your driver can export dmabufs > > when running in 'VRAM' mode. > > When

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-16 Thread Sui Jingfeng
On 2022/2/16 21:46, Daniel Stone wrote: On Wed, 9 Feb 2022 at 15:41, Sui Jingfeng <15330273...@189.cn> wrote: On 2022/2/9 16:43, Maxime Ripard wrote: More fundamentally (and this extends to the CMA, caching and VRAM stuff you explained above), why can't the driver pick the right decision all

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-16 Thread Maxime Ripard
On Wed, Feb 16, 2022 at 09:34:47PM +0800, Sui Jingfeng wrote: > On 2022/2/10 00:16, Maxime Ripard wrote: > > And, to reinstate, we already have a mechanism to set an EDID, and if it > > wasn't an option, the DT is not the place to store an EDID blob. > > Hi, > > > if DT is not the place to

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-16 Thread Maxime Ripard
On Sun, Feb 13, 2022 at 02:11:30AM +0800, Sui Jingfeng wrote: > > On 2022/2/10 00:16, Maxime Ripard wrote: > > On Wed, Feb 09, 2022 at 10:38:41PM +0800, Sui Jingfeng wrote: > > > On 2022/2/9 16:49, Maxime Ripard wrote: > > > > On Fri, Feb 04, 2022 at 12:04:19AM +0800, Sui Jingfeng wrote: > > > >

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-16 Thread Daniel Stone
On Wed, 9 Feb 2022 at 15:41, Sui Jingfeng <15330273...@189.cn> wrote: > On 2022/2/9 16:43, Maxime Ripard wrote: > > More fundamentally (and this extends to the CMA, caching and VRAM stuff > > you explained above), why can't the driver pick the right decision all > > the time and why would that be

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-16 Thread Sui Jingfeng
On 2022/2/10 00:16, Maxime Ripard wrote: And, to reinstate, we already have a mechanism to set an EDID, and if it wasn't an option, the DT is not the place to store an EDID blob. Hi, if DT is not the place to store EDID blob, why nvidia can do that ? output->edid =

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-12 Thread Ilia Mirkin
On Wed, Feb 9, 2022 at 11:16 AM Maxime Ripard wrote: > > On Wed, Feb 09, 2022 at 10:38:41PM +0800, Sui Jingfeng wrote: > > On 2022/2/9 16:49, Maxime Ripard wrote: > > > On Fri, Feb 04, 2022 at 12:04:19AM +0800, Sui Jingfeng wrote: > > > > > > +/* Get the simple EDID data from the device tree > >

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-12 Thread Sui Jingfeng
On 2022/2/10 00:16, Maxime Ripard wrote: On Wed, Feb 09, 2022 at 10:38:41PM +0800, Sui Jingfeng wrote: On 2022/2/9 16:49, Maxime Ripard wrote: On Fri, Feb 04, 2022 at 12:04:19AM +0800, Sui Jingfeng wrote: +/* Get the simple EDID data from the device tree + * the length must be EDID_LENGTH,

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-10 Thread Jiaxun Yang
在 2022/2/9 8:52, Maxime Ripard 写道: On Thu, Feb 03, 2022 at 11:47:16PM +0800, Sui Jingfeng wrote: [...] DT isn't really a solution either. Let's take the distribution perspective there. Suppose you're a Fedora or Debian developer, and want to make a single kernel image, and ship a DT to the

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-10 Thread Jiaxun Yang
在 2022/2/9 14:04, Maxime Ripard 写道: On Wed, Feb 09, 2022 at 11:56:48AM +, Jiaxun Yang wrote: 在 2022/2/9 8:52, Maxime Ripard 写道: On Thu, Feb 03, 2022 at 11:47:16PM +0800, Sui Jingfeng wrote: [...] DT isn't really a solution either. Let's take the distribution perspective there.

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-09 Thread Maxime Ripard
On Wed, Feb 09, 2022 at 11:41:06PM +0800, Sui Jingfeng wrote: > > Then, you have "modeset", and I'm not sure why it's supposed to be > > there, at all. This is a modesetting driver, why would I want to disable > > modesetting entirely? > > Something you want fbdev driver, for example

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-09 Thread Maxime Ripard
On Wed, Feb 09, 2022 at 10:38:41PM +0800, Sui Jingfeng wrote: > On 2022/2/9 16:49, Maxime Ripard wrote: > > On Fri, Feb 04, 2022 at 12:04:19AM +0800, Sui Jingfeng wrote: > > > > > +/* Get the simple EDID data from the device tree > > > > > + * the length must be EDID_LENGTH, since it is simple. >

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-09 Thread Sui Jingfeng
On 2022/2/9 16:43, Maxime Ripard wrote: On Fri, Feb 04, 2022 at 12:29:39AM +0800, Sui Jingfeng wrote: +static int lsdc_modeset = 1; +MODULE_PARM_DESC(modeset, "Enable/disable CMA-based KMS(1 = enabled(default), 0 = disabled)"); +module_param_named(modeset, lsdc_modeset, int, 0644); + +static

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-09 Thread Sui Jingfeng
On 2022/2/9 16:49, Maxime Ripard wrote: On Fri, Feb 04, 2022 at 12:04:19AM +0800, Sui Jingfeng wrote: +/* Get the simple EDID data from the device tree + * the length must be EDID_LENGTH, since it is simple. + * + * @np: device node contain edid data + * @edid_data: where the edid data to

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-09 Thread Maxime Ripard
On Wed, Feb 09, 2022 at 11:56:48AM +, Jiaxun Yang wrote: > > > 在 2022/2/9 8:52, Maxime Ripard 写道: > > On Thu, Feb 03, 2022 at 11:47:16PM +0800, Sui Jingfeng wrote: > [...] > > DT isn't really a solution either. Let's take the distribution > > perspective there. Suppose you're a Fedora or

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-09 Thread Maxime Ripard
On Thu, Feb 03, 2022 at 11:47:16PM +0800, Sui Jingfeng wrote: > On 2022/2/3 16:58, Maxime Ripard wrote: > > > diff --git a/drivers/gpu/drm/lsdc/Kconfig b/drivers/gpu/drm/lsdc/Kconfig > > > new file mode 100644 > > > index ..7ed1b0fdbe1b > > > --- /dev/null > > > +++

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-09 Thread Maxime Ripard
On Fri, Feb 04, 2022 at 12:04:19AM +0800, Sui Jingfeng wrote: > > > +/* Get the simple EDID data from the device tree > > > + * the length must be EDID_LENGTH, since it is simple. > > > + * > > > + * @np: device node contain edid data > > > + * @edid_data: where the edid data to store to > > > +

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-09 Thread Maxime Ripard
On Fri, Feb 04, 2022 at 12:29:39AM +0800, Sui Jingfeng wrote: > > > +static int lsdc_modeset = 1; > > > +MODULE_PARM_DESC(modeset, "Enable/disable CMA-based KMS(1 = > > > enabled(default), 0 = disabled)"); > > > +module_param_named(modeset, lsdc_modeset, int, 0644); > > > + > > > +static int

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-09 Thread Maxime Ripard
On Fri, Feb 04, 2022 at 12:41:37AM +0800, Sui Jingfeng wrote: > > > +static int lsdc_primary_plane_atomic_check(struct drm_plane *plane, > > > +struct drm_atomic_state *state) > > > +{ > > > + struct drm_device *ddev = plane->dev; > > > + struct lsdc_device

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-03 Thread Sui Jingfeng
+static int lsdc_primary_plane_atomic_check(struct drm_plane *plane, + struct drm_atomic_state *state) +{ + struct drm_device *ddev = plane->dev; + struct lsdc_device *ldev = to_lsdc(ddev); + struct drm_plane_state *old_plane_state =

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-03 Thread Sui Jingfeng
+static enum drm_mode_status +lsdc_crtc_helper_mode_valid(struct drm_crtc *crtc, + const struct drm_display_mode *mode) +{ + struct drm_device *ddev = crtc->dev; + struct lsdc_device *ldev = to_lsdc(ddev); + const struct lsdc_chip_desc *desc =

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-03 Thread Sui Jingfeng
diff --git a/drivers/gpu/drm/lsdc/Makefile b/drivers/gpu/drm/lsdc/Makefile new file mode 100644 index ..342990654478 --- /dev/null +++ b/drivers/gpu/drm/lsdc/Makefile @@ -0,0 +1,15 @@ +# +# Makefile for the lsdc drm device driver. +# + +lsdc-y := \ + lsdc_drv.o \ +

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-03 Thread Sui Jingfeng
On 2022/2/3 16:58, Maxime Ripard wrote: diff --git a/drivers/gpu/drm/lsdc/Kconfig b/drivers/gpu/drm/lsdc/Kconfig new file mode 100644 index ..7ed1b0fdbe1b --- /dev/null +++ b/drivers/gpu/drm/lsdc/Kconfig @@ -0,0 +1,38 @@ +config DRM_LSDC + tristate "DRM Support for loongson's

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-03 Thread Sui Jingfeng
On 2022/2/3 16:58, Maxime Ripard wrote: Hi, On Thu, Feb 03, 2022 at 04:25:44PM +0800, Sui Jingfeng wrote: From: suijingfeng There is a display controller in loongson's LS2K1000 SoC and LS7A1000 bridge, and the DC in those chip is a PCI device. This patch provide a minimal support for this

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-03 Thread Dan Carpenter
On Thu, Feb 03, 2022 at 12:29:11PM +0100, Krzysztof Kozlowski wrote: > On Thu, 3 Feb 2022 at 12:08, Dan Carpenter wrote: > > > > > > This does not look like compliant with GPL-2.0. You cannot call a > > > license GPL-2.0 and restrict it with some other provisions. > > > > That's the MIT license.

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-03 Thread Krzysztof Kozlowski
On Thu, 3 Feb 2022 at 12:08, Dan Carpenter wrote: > > On Thu, Feb 03, 2022 at 09:53:35AM +0100, Krzysztof Kozlowski wrote: > > > diff --git a/drivers/gpu/drm/lsdc/lsdc_connector.c > > > b/drivers/gpu/drm/lsdc/lsdc_connector.c > > > new file mode 100644 > > > index ..ae5fc0c90961 > >

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-03 Thread Dan Carpenter
On Thu, Feb 03, 2022 at 09:53:35AM +0100, Krzysztof Kozlowski wrote: > > diff --git a/drivers/gpu/drm/lsdc/lsdc_connector.c > > b/drivers/gpu/drm/lsdc/lsdc_connector.c > > new file mode 100644 > > index ..ae5fc0c90961 > > --- /dev/null > > +++ b/drivers/gpu/drm/lsdc/lsdc_connector.c >

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-03 Thread Maxime Ripard
Hi, On Thu, Feb 03, 2022 at 04:25:44PM +0800, Sui Jingfeng wrote: > From: suijingfeng > > There is a display controller in loongson's LS2K1000 SoC and LS7A1000 > bridge, and the DC in those chip is a PCI device. This patch provide > a minimal support for this display controller which is mainly

Re: [PATCH v6 1/3] drm/lsdc: add drm driver for loongson display controller

2022-02-03 Thread Krzysztof Kozlowski
On Thu, 3 Feb 2022 at 09:26, Sui Jingfeng <15330273...@189.cn> wrote: > > From: suijingfeng > > There is a display controller in loongson's LS2K1000 SoC and LS7A1000 > bridge, and the DC in those chip is a PCI device. This patch provide > a minimal support for this display controller which is