Re: [PATCH v6 4/5] drm/tidss: New driver for TI Keystone platform Display SubSystem

2020-01-16 Thread Jyri Sarha
On 15/01/2020 19:13, Sam Ravnborg wrote: > Hi Jyri. > >> Well, I'll bite the bullet then, and start mangling the code to the >> "strict" format. > > While touching the code please consider moving all logging > over to the new drm_{err,warn,info,dbg} functions. > They give the nice "[drm]"

Re: [PATCH v6 4/5] drm/tidss: New driver for TI Keystone platform Display SubSystem

2020-01-15 Thread Sam Ravnborg
Hi Jyri. > Well, I'll bite the bullet then, and start mangling the code to the > "strict" format. While touching the code please consider moving all logging over to the new drm_{err,warn,info,dbg} functions. They give the nice "[drm]" marker. And they are a tad shorter as you do not have to

Re: [PATCH v6 4/5] drm/tidss: New driver for TI Keystone platform Display SubSystem

2020-01-15 Thread Jyri Sarha
On 15/01/2020 16:43, Sam Ravnborg wrote: > Hi Jyri. > >>> ... v6: - Check CTM and gamma support from dispc_features when creating crtc - Implement CTM support for k2g and fix k3 CTM implementation - Remove gamma property persistence and always write color properties

Re: [PATCH v6 4/5] drm/tidss: New driver for TI Keystone platform Display SubSystem

2020-01-15 Thread Sam Ravnborg
Hi Jyri. > >> > > ... > >> v6: - Check CTM and gamma support from dispc_features when creating crtc > >> - Implement CTM support for k2g and fix k3 CTM implementation > >> - Remove gamma property persistence and always write color properties > >> in a new modeset > > > > I applied

Re: [PATCH v6 4/5] drm/tidss: New driver for TI Keystone platform Display SubSystem

2020-01-15 Thread Jyri Sarha
On 15/01/2020 14:22, Sam Ravnborg wrote: > Hi Jyri. > > On Wed, Jan 15, 2020 at 01:45:38PM +0200, Jyri Sarha wrote: >> This patch adds a new DRM driver for Texas Instruments DSS IPs used on >> Texas Instruments Keystone K2G, AM65x, and J721e SoCs. The new DSS IP is >> a major change to the older

Re: [PATCH v6 4/5] drm/tidss: New driver for TI Keystone platform Display SubSystem

2020-01-15 Thread Sam Ravnborg
Hi Jyri. > > v6: - Check CTM and gamma support from dispc_features when creating crtc > - Implement CTM support for k2g and fix k3 CTM implementation > - Remove gamma property persistence and always write color properties > in a new modeset I get this error when I build this patch

Re: [PATCH v6 4/5] drm/tidss: New driver for TI Keystone platform Display SubSystem

2020-01-15 Thread Sam Ravnborg
Hi Jyri. On Wed, Jan 15, 2020 at 01:45:38PM +0200, Jyri Sarha wrote: > This patch adds a new DRM driver for Texas Instruments DSS IPs used on > Texas Instruments Keystone K2G, AM65x, and J721e SoCs. The new DSS IP is > a major change to the older DSS IP versions, which are supported by > the