Re: [PATCHv2 04/56] omap/drm: drop unused dsi.configure_pins

2020-03-25 Thread Tomi Valkeinen
On 25/02/2020 01:20, Sebastian Reichel wrote: The panel-dsi-cm's ddata->pin_config is always NULL, so this callback is never called. Instead the DSI encoder gets the pin configuration directly from DT. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 11 -

Re: [PATCHv2 04/56] omap/drm: drop unused dsi.configure_pins

2020-02-26 Thread Sebastian Reichel
Hi Laurent, On Wed, Feb 26, 2020 at 11:36:30PM +0200, Laurent Pinchart wrote: > > > I think you can drop the definition of the omap_dsi_pin_config structure > > > earlier in this file too, as well as the OMAP_DSS_MAX_DSI_PINS macro. > > > With this fixed, > > > > No, the struct is still used by t

Re: [PATCHv2 04/56] omap/drm: drop unused dsi.configure_pins

2020-02-26 Thread Laurent Pinchart
Hi Sebastian, On Wed, Feb 26, 2020 at 10:28:19PM +0100, Sebastian Reichel wrote: > On Tue, Feb 25, 2020 at 01:42:49AM +0200, Laurent Pinchart wrote: > > On Tue, Feb 25, 2020 at 12:20:34AM +0100, Sebastian Reichel wrote: > > > The panel-dsi-cm's ddata->pin_config is always NULL, so this > > > callb

Re: [PATCHv2 04/56] omap/drm: drop unused dsi.configure_pins

2020-02-26 Thread Sebastian Reichel
Hi Laurent, On Tue, Feb 25, 2020 at 01:42:49AM +0200, Laurent Pinchart wrote: > Hi Sebastian, > > Thank you for the patch. > > On Tue, Feb 25, 2020 at 12:20:34AM +0100, Sebastian Reichel wrote: > > The panel-dsi-cm's ddata->pin_config is always NULL, so this > > callback is never called. Instead

Re: [PATCHv2 04/56] omap/drm: drop unused dsi.configure_pins

2020-02-24 Thread Laurent Pinchart
Hi Sebastian, Thank you for the patch. On Tue, Feb 25, 2020 at 12:20:34AM +0100, Sebastian Reichel wrote: > The panel-dsi-cm's ddata->pin_config is always NULL, so this > callback is never called. Instead the DSI encoder gets the pin > configuration directly from DT. > > Signed-off-by: Sebastian