Re: [PULL] drm/i915: Add HDCP support to i915
On Wed, 14 Feb 2018, Sean Paul wrote: > On Wed, Feb 14, 2018 at 02:48:29PM +0100, Hans Verkuil wrote: >> Yes, your patches I've seen, but the 12 from Ramalingam I haven't seen. >> At least not on dri-devel. It's a bit weird. > > Ahh, I'm sorry I misunderstood. I think Ram may have sent those to intel-gfx > exclusively. We rarely post i915 specific patches to dri-devel, just intel-gfx, but in cases where they warrant changes in drm core it may be warranted to add a wider audience. Sorry about failing to do that here. All the commits have Link: tags back to the patches posted publicly, with message-ids. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PULL] drm/i915: Add HDCP support to i915
On Wed, Feb 14, 2018 at 02:48:29PM +0100, Hans Verkuil wrote: > On 14/02/18 14:44, Sean Paul wrote: > > On Wed, Feb 14, 2018 at 3:33 AM, Hans Verkuil wrote: > >> Hi Sean, > >> > >> On 13/02/18 21:18, Sean Paul wrote: > >>> > >>> Hi Dave, > >>> Here's the pull request for HDCP. Hopefully no surprises since it's been > >>> baking > >>> in drm-tip for a while now. > >>> > >>> topic/hdcp-2018-02-13: > >>> Add HDCP support to i915 drm driver. > >>> > >>> Cheers, Sean > >>> > >>> > >>> The following changes since commit > >>> b0caa1333b6d2d928a00304e9fb6674526c37b79: > >>> > >>> Merge tag 'imx-drm-next-2018-01-02' of > >>> git://git.pengutronix.de/git/pza/linux into drm-next (2018-01-05 11:33:24 > >>> +1000) > >>> > >>> are available in the Git repository at: > >>> > >>> git://anongit.freedesktop.org/drm/drm-misc tags/topic/hdcp-2018-02-13 > >>> > >>> for you to fetch changes up to 2834d9dfaf0276e197158be6af8e1a1d59e58289: > >>> > >>> drm/i915: fix misalignment in HDCP register def (2018-02-05 12:59:29 > >>> -0500) > >>> > >>> > >>> Add HDCP support to i915 drm driver. > >>> > >>> > >>> Chris Wilson (1): > >>> drm/i915/dp: Fix compilation of intel_dp_hdcp_check_link > >>> > >>> Ramalingam C (12): > >>> drm/i915: Extending HDCP for HSW, BDW and BXT+ > >>> drm/i915: II stage HDCP auth for repeater only > >>> drm/i915: Start repeater auth on READY/CP_IRQ > >>> drm/i915: Check for downstream topology errors > >>> drm/i915: Handle failure from 2nd stage HDCP auth > >>> drm/i915: Stop encryption for repeater with no sink > >>> drm/i915: Connector info in HDCP debug msgs > >>> drm/i915: Retry HDCP bksv read > >>> drm/i915: Optimize HDCP key load > >>> drm/i915: Detect panel's hdcp capability > >>> drm/i915: Reauthenticate HDCP on failure > >>> drm/i915: fix misalignment in HDCP register def > >> > >> Were these ever posted to dri-devel? I can't find them there. > >> > >> Do these patches from Ramalingam C add repeater support to the i915? > >> If so, then I am certainly interested in seeing these since we (Cisco) > >> are working on HDCP (including repeater support) for HDMI receivers. > >> > > > > Hi Hans! > > We had a conversation on these patches and repeater support when I > > initially posted them :-) > > https://lists.freedesktop.org/archives/intel-gfx/2017-December/149112.html > > Yes, your patches I've seen, but the 12 from Ramalingam I haven't seen. > At least not on dri-devel. It's a bit weird. Ahh, I'm sorry I misunderstood. I think Ram may have sent those to intel-gfx exclusively. Repeater support was introduced in the initial post. Ram's changes mainly focus on HDCP compliance. Sean > > Regards, > > Hans > > > > > It'd be great if you could try it out and report back. > > > > Cheers, > > > > Sean > > > >> Nothing public yet, it's too early for that. But it would be nice to > >> test with the i915 driver. > >> > >> Regards, > >> > >> Hans > >> > >>> > >>> Sean Paul (13): > >>> drm: Fix link-status kerneldoc line lengths > >>> drm/i915: Add more control to wait_for routines > >>> drm: Add Content Protection property > >>> drm: Add some HDCP related #defines > >>> drm/i915: Add HDCP framework + base implementation > >>> drm/i915: Make use of indexed write GMBUS feature > >>> drm/i915: Add function to output Aksv over GMBUS > >>> drm/i915: Implement HDCP for HDMI > >>> drm/i915: Implement HDCP for DisplayPort > >>> drm/i915: Don't allow HDCP on PORT E/F > >>> drm/i915: Only disable HDCP when it's active > >>> drm/i915: Restore HDCP DRM_INFO when with no downstream > >>> drm/i915: Downgrade hdcp logs from INFO to DEBUG_KMS > >>> > >>> drivers/gpu/drm/drm_atomic.c | 8 + > >>> drivers/gpu/drm/drm_connector.c | 87 +++- > >>> drivers/gpu/drm/i915/Makefile| 1 + > >>> drivers/gpu/drm/i915/i915_drv.h | 1 + > >>> drivers/gpu/drm/i915/i915_reg.h | 86 > >>> drivers/gpu/drm/i915/intel_atomic.c | 2 + > >>> drivers/gpu/drm/i915/intel_ddi.c | 36 ++ > >>> drivers/gpu/drm/i915/intel_display.c | 4 + > >>> drivers/gpu/drm/i915/intel_dp.c | 277 +++- > >>> drivers/gpu/drm/i915/intel_drv.h | 109 - > >>> drivers/gpu/drm/i915/intel_hdcp.c| 807 > >>> +++ > >>> drivers/gpu/drm/i915/intel_hdmi.c| 250 +++ > >>> drivers/gpu/drm/i915/intel_i2c.c | 81 +++- > >>> drivers/gpu/drm/i915/intel_uncore.c | 23 +- > >>> drivers/gpu/drm/i915/intel_uncore.h | 14 +- > >>> include/drm/drm_connector.h | 16 + > >>> include/drm/drm_dp_helper.h | 17 + > >>> include/drm/drm_hdcp.h | 41 ++ > >>> include/uapi/drm/drm_mode.h | 4 + > >>> 19 files c
Re: [PULL] drm/i915: Add HDCP support to i915
On 14/02/18 14:44, Sean Paul wrote: > On Wed, Feb 14, 2018 at 3:33 AM, Hans Verkuil wrote: >> Hi Sean, >> >> On 13/02/18 21:18, Sean Paul wrote: >>> >>> Hi Dave, >>> Here's the pull request for HDCP. Hopefully no surprises since it's been >>> baking >>> in drm-tip for a while now. >>> >>> topic/hdcp-2018-02-13: >>> Add HDCP support to i915 drm driver. >>> >>> Cheers, Sean >>> >>> >>> The following changes since commit b0caa1333b6d2d928a00304e9fb6674526c37b79: >>> >>> Merge tag 'imx-drm-next-2018-01-02' of >>> git://git.pengutronix.de/git/pza/linux into drm-next (2018-01-05 11:33:24 >>> +1000) >>> >>> are available in the Git repository at: >>> >>> git://anongit.freedesktop.org/drm/drm-misc tags/topic/hdcp-2018-02-13 >>> >>> for you to fetch changes up to 2834d9dfaf0276e197158be6af8e1a1d59e58289: >>> >>> drm/i915: fix misalignment in HDCP register def (2018-02-05 12:59:29 >>> -0500) >>> >>> >>> Add HDCP support to i915 drm driver. >>> >>> >>> Chris Wilson (1): >>> drm/i915/dp: Fix compilation of intel_dp_hdcp_check_link >>> >>> Ramalingam C (12): >>> drm/i915: Extending HDCP for HSW, BDW and BXT+ >>> drm/i915: II stage HDCP auth for repeater only >>> drm/i915: Start repeater auth on READY/CP_IRQ >>> drm/i915: Check for downstream topology errors >>> drm/i915: Handle failure from 2nd stage HDCP auth >>> drm/i915: Stop encryption for repeater with no sink >>> drm/i915: Connector info in HDCP debug msgs >>> drm/i915: Retry HDCP bksv read >>> drm/i915: Optimize HDCP key load >>> drm/i915: Detect panel's hdcp capability >>> drm/i915: Reauthenticate HDCP on failure >>> drm/i915: fix misalignment in HDCP register def >> >> Were these ever posted to dri-devel? I can't find them there. >> >> Do these patches from Ramalingam C add repeater support to the i915? >> If so, then I am certainly interested in seeing these since we (Cisco) >> are working on HDCP (including repeater support) for HDMI receivers. >> > > Hi Hans! > We had a conversation on these patches and repeater support when I > initially posted them :-) > https://lists.freedesktop.org/archives/intel-gfx/2017-December/149112.html Yes, your patches I've seen, but the 12 from Ramalingam I haven't seen. At least not on dri-devel. It's a bit weird. Regards, Hans > > It'd be great if you could try it out and report back. > > Cheers, > > Sean > >> Nothing public yet, it's too early for that. But it would be nice to >> test with the i915 driver. >> >> Regards, >> >> Hans >> >>> >>> Sean Paul (13): >>> drm: Fix link-status kerneldoc line lengths >>> drm/i915: Add more control to wait_for routines >>> drm: Add Content Protection property >>> drm: Add some HDCP related #defines >>> drm/i915: Add HDCP framework + base implementation >>> drm/i915: Make use of indexed write GMBUS feature >>> drm/i915: Add function to output Aksv over GMBUS >>> drm/i915: Implement HDCP for HDMI >>> drm/i915: Implement HDCP for DisplayPort >>> drm/i915: Don't allow HDCP on PORT E/F >>> drm/i915: Only disable HDCP when it's active >>> drm/i915: Restore HDCP DRM_INFO when with no downstream >>> drm/i915: Downgrade hdcp logs from INFO to DEBUG_KMS >>> >>> drivers/gpu/drm/drm_atomic.c | 8 + >>> drivers/gpu/drm/drm_connector.c | 87 +++- >>> drivers/gpu/drm/i915/Makefile| 1 + >>> drivers/gpu/drm/i915/i915_drv.h | 1 + >>> drivers/gpu/drm/i915/i915_reg.h | 86 >>> drivers/gpu/drm/i915/intel_atomic.c | 2 + >>> drivers/gpu/drm/i915/intel_ddi.c | 36 ++ >>> drivers/gpu/drm/i915/intel_display.c | 4 + >>> drivers/gpu/drm/i915/intel_dp.c | 277 +++- >>> drivers/gpu/drm/i915/intel_drv.h | 109 - >>> drivers/gpu/drm/i915/intel_hdcp.c| 807 >>> +++ >>> drivers/gpu/drm/i915/intel_hdmi.c| 250 +++ >>> drivers/gpu/drm/i915/intel_i2c.c | 81 +++- >>> drivers/gpu/drm/i915/intel_uncore.c | 23 +- >>> drivers/gpu/drm/i915/intel_uncore.h | 14 +- >>> include/drm/drm_connector.h | 16 + >>> include/drm/drm_dp_helper.h | 17 + >>> include/drm/drm_hdcp.h | 41 ++ >>> include/uapi/drm/drm_mode.h | 4 + >>> 19 files changed, 1821 insertions(+), 43 deletions(-) >>> create mode 100644 drivers/gpu/drm/i915/intel_hdcp.c >>> create mode 100644 include/drm/drm_hdcp.h >>> >> ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PULL] drm/i915: Add HDCP support to i915
On Wed, Feb 14, 2018 at 3:33 AM, Hans Verkuil wrote: > Hi Sean, > > On 13/02/18 21:18, Sean Paul wrote: >> >> Hi Dave, >> Here's the pull request for HDCP. Hopefully no surprises since it's been >> baking >> in drm-tip for a while now. >> >> topic/hdcp-2018-02-13: >> Add HDCP support to i915 drm driver. >> >> Cheers, Sean >> >> >> The following changes since commit b0caa1333b6d2d928a00304e9fb6674526c37b79: >> >> Merge tag 'imx-drm-next-2018-01-02' of >> git://git.pengutronix.de/git/pza/linux into drm-next (2018-01-05 11:33:24 >> +1000) >> >> are available in the Git repository at: >> >> git://anongit.freedesktop.org/drm/drm-misc tags/topic/hdcp-2018-02-13 >> >> for you to fetch changes up to 2834d9dfaf0276e197158be6af8e1a1d59e58289: >> >> drm/i915: fix misalignment in HDCP register def (2018-02-05 12:59:29 -0500) >> >> >> Add HDCP support to i915 drm driver. >> >> >> Chris Wilson (1): >> drm/i915/dp: Fix compilation of intel_dp_hdcp_check_link >> >> Ramalingam C (12): >> drm/i915: Extending HDCP for HSW, BDW and BXT+ >> drm/i915: II stage HDCP auth for repeater only >> drm/i915: Start repeater auth on READY/CP_IRQ >> drm/i915: Check for downstream topology errors >> drm/i915: Handle failure from 2nd stage HDCP auth >> drm/i915: Stop encryption for repeater with no sink >> drm/i915: Connector info in HDCP debug msgs >> drm/i915: Retry HDCP bksv read >> drm/i915: Optimize HDCP key load >> drm/i915: Detect panel's hdcp capability >> drm/i915: Reauthenticate HDCP on failure >> drm/i915: fix misalignment in HDCP register def > > Were these ever posted to dri-devel? I can't find them there. > > Do these patches from Ramalingam C add repeater support to the i915? > If so, then I am certainly interested in seeing these since we (Cisco) > are working on HDCP (including repeater support) for HDMI receivers. > Hi Hans! We had a conversation on these patches and repeater support when I initially posted them :-) https://lists.freedesktop.org/archives/intel-gfx/2017-December/149112.html It'd be great if you could try it out and report back. Cheers, Sean > Nothing public yet, it's too early for that. But it would be nice to > test with the i915 driver. > > Regards, > > Hans > >> >> Sean Paul (13): >> drm: Fix link-status kerneldoc line lengths >> drm/i915: Add more control to wait_for routines >> drm: Add Content Protection property >> drm: Add some HDCP related #defines >> drm/i915: Add HDCP framework + base implementation >> drm/i915: Make use of indexed write GMBUS feature >> drm/i915: Add function to output Aksv over GMBUS >> drm/i915: Implement HDCP for HDMI >> drm/i915: Implement HDCP for DisplayPort >> drm/i915: Don't allow HDCP on PORT E/F >> drm/i915: Only disable HDCP when it's active >> drm/i915: Restore HDCP DRM_INFO when with no downstream >> drm/i915: Downgrade hdcp logs from INFO to DEBUG_KMS >> >> drivers/gpu/drm/drm_atomic.c | 8 + >> drivers/gpu/drm/drm_connector.c | 87 +++- >> drivers/gpu/drm/i915/Makefile| 1 + >> drivers/gpu/drm/i915/i915_drv.h | 1 + >> drivers/gpu/drm/i915/i915_reg.h | 86 >> drivers/gpu/drm/i915/intel_atomic.c | 2 + >> drivers/gpu/drm/i915/intel_ddi.c | 36 ++ >> drivers/gpu/drm/i915/intel_display.c | 4 + >> drivers/gpu/drm/i915/intel_dp.c | 277 +++- >> drivers/gpu/drm/i915/intel_drv.h | 109 - >> drivers/gpu/drm/i915/intel_hdcp.c| 807 >> +++ >> drivers/gpu/drm/i915/intel_hdmi.c| 250 +++ >> drivers/gpu/drm/i915/intel_i2c.c | 81 +++- >> drivers/gpu/drm/i915/intel_uncore.c | 23 +- >> drivers/gpu/drm/i915/intel_uncore.h | 14 +- >> include/drm/drm_connector.h | 16 + >> include/drm/drm_dp_helper.h | 17 + >> include/drm/drm_hdcp.h | 41 ++ >> include/uapi/drm/drm_mode.h | 4 + >> 19 files changed, 1821 insertions(+), 43 deletions(-) >> create mode 100644 drivers/gpu/drm/i915/intel_hdcp.c >> create mode 100644 include/drm/drm_hdcp.h >> > ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PULL] drm/i915: Add HDCP support to i915
Hi Sean, On 13/02/18 21:18, Sean Paul wrote: > > Hi Dave, > Here's the pull request for HDCP. Hopefully no surprises since it's been > baking > in drm-tip for a while now. > > topic/hdcp-2018-02-13: > Add HDCP support to i915 drm driver. > > Cheers, Sean > > > The following changes since commit b0caa1333b6d2d928a00304e9fb6674526c37b79: > > Merge tag 'imx-drm-next-2018-01-02' of > git://git.pengutronix.de/git/pza/linux into drm-next (2018-01-05 11:33:24 > +1000) > > are available in the Git repository at: > > git://anongit.freedesktop.org/drm/drm-misc tags/topic/hdcp-2018-02-13 > > for you to fetch changes up to 2834d9dfaf0276e197158be6af8e1a1d59e58289: > > drm/i915: fix misalignment in HDCP register def (2018-02-05 12:59:29 -0500) > > > Add HDCP support to i915 drm driver. > > > Chris Wilson (1): > drm/i915/dp: Fix compilation of intel_dp_hdcp_check_link > > Ramalingam C (12): > drm/i915: Extending HDCP for HSW, BDW and BXT+ > drm/i915: II stage HDCP auth for repeater only > drm/i915: Start repeater auth on READY/CP_IRQ > drm/i915: Check for downstream topology errors > drm/i915: Handle failure from 2nd stage HDCP auth > drm/i915: Stop encryption for repeater with no sink > drm/i915: Connector info in HDCP debug msgs > drm/i915: Retry HDCP bksv read > drm/i915: Optimize HDCP key load > drm/i915: Detect panel's hdcp capability > drm/i915: Reauthenticate HDCP on failure > drm/i915: fix misalignment in HDCP register def Were these ever posted to dri-devel? I can't find them there. Do these patches from Ramalingam C add repeater support to the i915? If so, then I am certainly interested in seeing these since we (Cisco) are working on HDCP (including repeater support) for HDMI receivers. Nothing public yet, it's too early for that. But it would be nice to test with the i915 driver. Regards, Hans > > Sean Paul (13): > drm: Fix link-status kerneldoc line lengths > drm/i915: Add more control to wait_for routines > drm: Add Content Protection property > drm: Add some HDCP related #defines > drm/i915: Add HDCP framework + base implementation > drm/i915: Make use of indexed write GMBUS feature > drm/i915: Add function to output Aksv over GMBUS > drm/i915: Implement HDCP for HDMI > drm/i915: Implement HDCP for DisplayPort > drm/i915: Don't allow HDCP on PORT E/F > drm/i915: Only disable HDCP when it's active > drm/i915: Restore HDCP DRM_INFO when with no downstream > drm/i915: Downgrade hdcp logs from INFO to DEBUG_KMS > > drivers/gpu/drm/drm_atomic.c | 8 + > drivers/gpu/drm/drm_connector.c | 87 +++- > drivers/gpu/drm/i915/Makefile| 1 + > drivers/gpu/drm/i915/i915_drv.h | 1 + > drivers/gpu/drm/i915/i915_reg.h | 86 > drivers/gpu/drm/i915/intel_atomic.c | 2 + > drivers/gpu/drm/i915/intel_ddi.c | 36 ++ > drivers/gpu/drm/i915/intel_display.c | 4 + > drivers/gpu/drm/i915/intel_dp.c | 277 +++- > drivers/gpu/drm/i915/intel_drv.h | 109 - > drivers/gpu/drm/i915/intel_hdcp.c| 807 > +++ > drivers/gpu/drm/i915/intel_hdmi.c| 250 +++ > drivers/gpu/drm/i915/intel_i2c.c | 81 +++- > drivers/gpu/drm/i915/intel_uncore.c | 23 +- > drivers/gpu/drm/i915/intel_uncore.h | 14 +- > include/drm/drm_connector.h | 16 + > include/drm/drm_dp_helper.h | 17 + > include/drm/drm_hdcp.h | 41 ++ > include/uapi/drm/drm_mode.h | 4 + > 19 files changed, 1821 insertions(+), 43 deletions(-) > create mode 100644 drivers/gpu/drm/i915/intel_hdcp.c > create mode 100644 include/drm/drm_hdcp.h > ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
