Re: [Patch 2/4] dt-bindings: display/ti: Add plane binding to dispc node

2018-04-20 Thread Daniel Vetter
On Fri, Apr 20, 2018 at 10:21:35AM +0300, Tomi Valkeinen wrote: > On 20/04/18 10:00, Daniel Vetter wrote: > > (Adding Benoit back, he was dropped at some point in the thread) > > > Stuff randomly not working is officially how atomic works. That's what the > > TEST_ONLY mode is for. There's a lot

Re: [Patch 2/4] dt-bindings: display/ti: Add plane binding to dispc node

2018-04-20 Thread Tomi Valkeinen
On 20/04/18 10:00, Daniel Vetter wrote: (Adding Benoit back, he was dropped at some point in the thread) > Stuff randomly not working is officially how atomic works. That's what the > TEST_ONLY mode is for. There's a lot more than virtualized planes that > might or might not push any given plane

Re: [Patch 2/4] dt-bindings: display/ti: Add plane binding to dispc node

2018-04-20 Thread Daniel Vetter
On Thu, Apr 19, 2018 at 10:11:05AM +0300, Tomi Valkeinen wrote: > On 19/04/18 09:34, Daniel Vetter wrote: > > >> But the kernel cannot know what the user wants to do, so it cannot > >> configure the planes. If we have an HDMI output which supports 2k+ and a > >> -2k LCD, and 4 hw planes, we can

Re: [Patch 2/4] dt-bindings: display/ti: Add plane binding to dispc node

2018-04-19 Thread Tomi Valkeinen
On 19/04/18 09:34, Daniel Vetter wrote: >> But the kernel cannot know what the user wants to do, so it cannot >> configure the planes. If we have an HDMI output which supports 2k+ and a >> -2k LCD, and 4 hw planes, we can set up the planes at least in the >> following ways: >> >> - One virtual

Re: [Patch 2/4] dt-bindings: display/ti: Add plane binding to dispc node

2018-04-19 Thread Daniel Vetter
On Tue, Apr 17, 2018 at 05:37:25PM +0300, Tomi Valkeinen wrote: > Hi Rob, > > On 09/04/18 21:17, Rob Herring wrote: > > >>> For HDMI, you can't know in advance what resolution will be. So I > >>> think you always need to reserve 2 planes. Now, if you want to reduce > >> > >> We can decide not to

Re: [Patch 2/4] dt-bindings: display/ti: Add plane binding to dispc node

2018-04-17 Thread Tomi Valkeinen
Hi Rob, On 09/04/18 21:17, Rob Herring wrote: >>> For HDMI, you can't know in advance what resolution will be. So I >>> think you always need to reserve 2 planes. Now, if you want to reduce >> >> We can decide not to support 2k+ resolutions for HDMI, which, with this >> series, happens by not

Re: [Patch 2/4] dt-bindings: display/ti: Add plane binding to dispc node

2018-04-09 Thread Rob Herring
On Fri, Mar 23, 2018 at 2:53 AM, Tomi Valkeinen wrote: > Hi Rob, > > On 23/03/18 03:23, Rob Herring wrote: > >>> Ok, I think the description was a bit unclear. So, the driver can do >>> this just fine, it can reserve hw planes dynamically when needed. The >>> problem is the

Re: [Patch 2/4] dt-bindings: display/ti: Add plane binding to dispc node

2018-03-23 Thread Tomi Valkeinen
Hi Rob, On 23/03/18 03:23, Rob Herring wrote: >> Ok, I think the description was a bit unclear. So, the driver can do >> this just fine, it can reserve hw planes dynamically when needed. The >> problem is the userspace. >> >> When a DRM application starts, it sees a bunch of planes, and can see

Re: [Patch 2/4] dt-bindings: display/ti: Add plane binding to dispc node

2018-03-22 Thread Rob Herring
On Mon, Mar 19, 2018 at 2:15 AM, Tomi Valkeinen wrote: > Hi Rob, > > On 19/03/18 02:06, Rob Herring wrote: >> On Wed, Mar 14, 2018 at 6:23 AM, Tomi Valkeinen >> wrote: >>> On 09/03/18 20:27, Benoit Parrot wrote: >>> > Is logical plane a h/w

Re: [Patch 2/4] dt-bindings: display/ti: Add plane binding to dispc node

2018-03-19 Thread Tomi Valkeinen
Hi Rob, On 19/03/18 02:06, Rob Herring wrote: > On Wed, Mar 14, 2018 at 6:23 AM, Tomi Valkeinen wrote: >> On 09/03/18 20:27, Benoit Parrot wrote: >> Is logical plane a h/w concept? >>> >>> It does represent a hardware resource. >> >> Logical plane is not a hw concept,

Re: [Patch 2/4] dt-bindings: display/ti: Add plane binding to dispc node

2018-03-18 Thread Rob Herring
On Wed, Mar 14, 2018 at 6:23 AM, Tomi Valkeinen wrote: > On 09/03/18 20:27, Benoit Parrot wrote: > >>> Is logical plane a h/w concept? >> >> It does represent a hardware resource. > > Logical plane is not a hw concept, it just describes a group of one or > two HW planes.

Re: [Patch 2/4] dt-bindings: display/ti: Add plane binding to dispc node

2018-03-14 Thread Tomi Valkeinen
On 09/03/18 20:27, Benoit Parrot wrote: >> Is logical plane a h/w concept? > > It does represent a hardware resource. Logical plane is not a hw concept, it just describes a group of one or two HW planes. Then again, in the context of 2k+ displays, two HW planes must always be used together, so

Re: [Patch 2/4] dt-bindings: display/ti: Add plane binding to dispc node

2018-03-09 Thread Benoit Parrot
Rob Herring wrote on Fri [2018-Mar-02 13:19:13 -0600]: > On Fri, Mar 2, 2018 at 7:48 AM, Benoit Parrot wrote: > > Add 'plane' child node to generic DISPC node as an optional > > property. > > Why? What problem are you solving? Ah yes, I guess on its own it

Re: [Patch 2/4] dt-bindings: display/ti: Add plane binding to dispc node

2018-03-02 Thread Rob Herring
On Fri, Mar 2, 2018 at 7:48 AM, Benoit Parrot wrote: > Add 'plane' child node to generic DISPC node as an optional > property. Why? What problem are you solving? > > Signed-off-by: Benoit Parrot > --- > .../devicetree/bindings/display/ti/ti,omap-dss.txt | 63 >