Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs

2024-05-03 Thread Andy Shevchenko
On Fri, May 03, 2024 at 12:57:33PM +0800, Sui Jingfeng wrote: > On 2024/5/3 01:28, Andy Shevchenko wrote: > > On Fri, May 03, 2024 at 12:25:17AM +0800, Sui Jingfeng wrote: > > > On 2024/5/2 16:32, Andy Shevchenko wrote: > > > > On Wed, May 01, 2024 at 12:27:14AM +0800, Sui Jingfeng wrote: > > > >

Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs

2024-05-02 Thread Sui Jingfeng
Hi, On 2024/5/3 01:28, Andy Shevchenko wrote: On Fri, May 03, 2024 at 12:25:17AM +0800, Sui Jingfeng wrote: On 2024/5/2 16:32, Andy Shevchenko wrote: On Wed, May 01, 2024 at 12:27:14AM +0800, Sui Jingfeng wrote: On 2024/4/30 22:13, Andy Shevchenko wrote: On Fri, Apr 26, 2024 at 05:13:43AM

Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs

2024-05-02 Thread Andy Shevchenko
On Fri, May 03, 2024 at 01:28:26AM +0800, Sui Jingfeng wrote: > On 2024/5/2 15:34, Neil Armstrong wrote: > > On 30/04/2024 11:34, Maxime Ripard wrote: > > > On Tue, Apr 30, 2024 at 12:54:39AM +0800, Sui Jingfeng wrote: > > > > On 2024/4/29 19:55, Maxime Ripard wrote: > > > > > On Sat, Apr 27, 2024

Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs

2024-05-02 Thread Andy Shevchenko
On Fri, May 03, 2024 at 12:25:17AM +0800, Sui Jingfeng wrote: > On 2024/5/2 16:32, Andy Shevchenko wrote: > > On Wed, May 01, 2024 at 12:27:14AM +0800, Sui Jingfeng wrote: > > > On 2024/4/30 22:13, Andy Shevchenko wrote: > > > > On Fri, Apr 26, 2024 at 05:13:43AM +0800, Sui Jingfeng wrote: ... >

Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs

2024-05-02 Thread Sui Jingfeng
Hi, On 2024/5/2 15:34, Neil Armstrong wrote: On 30/04/2024 11:34, Maxime Ripard wrote: On Tue, Apr 30, 2024 at 12:54:39AM +0800, Sui Jingfeng wrote: On 2024/4/29 19:55, Maxime Ripard wrote: On Sat, Apr 27, 2024 at 01:57:46PM +0800, Sui Jingfeng wrote: On 2024/4/26 14:23, Maxime Ripard

Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs

2024-05-02 Thread Sui Jingfeng
Hi, On 2024/5/2 16:32, Andy Shevchenko wrote: On Wed, May 01, 2024 at 12:27:14AM +0800, Sui Jingfeng wrote: On 2024/4/30 22:13, Andy Shevchenko wrote: On Fri, Apr 26, 2024 at 05:13:43AM +0800, Sui Jingfeng wrote: ... the former might be subdivided to "is it swnode backed or real fwnode

Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs

2024-05-02 Thread Andy Shevchenko
On Thu, May 02, 2024 at 09:34:17AM +0200, Neil Armstrong wrote: > On 30/04/2024 11:34, Maxime Ripard wrote: ... > Anyway since the rant is finished I'll land the patches. Thank you all for the review and discussion! -- With Best Regards, Andy Shevchenko

Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs

2024-05-02 Thread Andy Shevchenko
On Wed, May 01, 2024 at 12:27:14AM +0800, Sui Jingfeng wrote: > On 2024/4/30 22:13, Andy Shevchenko wrote: > > On Fri, Apr 26, 2024 at 05:13:43AM +0800, Sui Jingfeng wrote: ... > > the former might be subdivided to "is it swnode backed or real fwnode one?" > > > Yeah, > On non-DT cases, it can

Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs

2024-05-02 Thread Neil Armstrong
On 30/04/2024 11:34, Maxime Ripard wrote: On Tue, Apr 30, 2024 at 12:54:39AM +0800, Sui Jingfeng wrote: On 2024/4/29 19:55, Maxime Ripard wrote: On Sat, Apr 27, 2024 at 01:57:46PM +0800, Sui Jingfeng wrote: On 2024/4/26 14:23, Maxime Ripard wrote: On Fri, Apr 26, 2024 at 04:43:18AM +0800,

Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs

2024-04-30 Thread Sui Jingfeng
Hi, On 2024/4/30 22:32, Andy Shevchenko wrote: On Fri, Apr 26, 2024 at 04:43:18AM +0800, Sui Jingfeng wrote: On 2024/4/26 03:10, Andy Shevchenko wrote: On Fri, Apr 26, 2024 at 02:08:16AM +0800, Sui Jingfeng wrote: On 2024/4/25 22:26, Andy Shevchenko wrote: It seems driver missed the point

Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs

2024-04-30 Thread Sui Jingfeng
On 2024/4/30 22:13, Andy Shevchenko wrote: On Fri, Apr 26, 2024 at 05:13:43AM +0800, Sui Jingfeng wrote: On 2024/4/26 03:12, Andy Shevchenko wrote: On Fri, Apr 26, 2024 at 02:53:22AM +0800, Sui Jingfeng wrote: On 2024/4/26 02:08, Sui Jingfeng wrote: ... Are you speaking to yourself? I'm

Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs

2024-04-30 Thread Andy Shevchenko
On Fri, Apr 26, 2024 at 04:43:18AM +0800, Sui Jingfeng wrote: > On 2024/4/26 03:10, Andy Shevchenko wrote: > > On Fri, Apr 26, 2024 at 02:08:16AM +0800, Sui Jingfeng wrote: > > > On 2024/4/25 22:26, Andy Shevchenko wrote: > > > > It seems driver missed the point of proper use of device property

Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs

2024-04-30 Thread Andy Shevchenko
On Fri, Apr 26, 2024 at 05:13:43AM +0800, Sui Jingfeng wrote: > On 2024/4/26 03:12, Andy Shevchenko wrote: > > On Fri, Apr 26, 2024 at 02:53:22AM +0800, Sui Jingfeng wrote: > > > On 2024/4/26 02:08, Sui Jingfeng wrote: ... > > Are you speaking to yourself? I'm totally lost. > > > > Please, if

Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs

2024-04-30 Thread Maxime Ripard
On Tue, Apr 30, 2024 at 12:54:39AM +0800, Sui Jingfeng wrote: > On 2024/4/29 19:55, Maxime Ripard wrote: > > On Sat, Apr 27, 2024 at 01:57:46PM +0800, Sui Jingfeng wrote: > > > On 2024/4/26 14:23, Maxime Ripard wrote: > > > > On Fri, Apr 26, 2024 at 04:43:18AM +0800, Sui Jingfeng wrote: > > > > >

Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs

2024-04-29 Thread Sui Jingfeng
Hi, On 2024/4/29 19:55, Maxime Ripard wrote: On Sat, Apr 27, 2024 at 01:57:46PM +0800, Sui Jingfeng wrote: Hi, On 2024/4/26 14:23, Maxime Ripard wrote: Hi, On Fri, Apr 26, 2024 at 04:43:18AM +0800, Sui Jingfeng wrote: On 2024/4/26 03:10, Andy Shevchenko wrote: On Fri, Apr 26, 2024 at

Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs

2024-04-29 Thread Maxime Ripard
On Sat, Apr 27, 2024 at 01:57:46PM +0800, Sui Jingfeng wrote: > Hi, > > > On 2024/4/26 14:23, Maxime Ripard wrote: > > Hi, > > > > On Fri, Apr 26, 2024 at 04:43:18AM +0800, Sui Jingfeng wrote: > > > On 2024/4/26 03:10, Andy Shevchenko wrote: > > > > On Fri, Apr 26, 2024 at 02:08:16AM +0800, Sui

Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs

2024-04-26 Thread Sui Jingfeng
Hi, On 2024/4/26 14:23, Maxime Ripard wrote: Hi, On Fri, Apr 26, 2024 at 04:43:18AM +0800, Sui Jingfeng wrote: On 2024/4/26 03:10, Andy Shevchenko wrote: On Fri, Apr 26, 2024 at 02:08:16AM +0800, Sui Jingfeng wrote: On 2024/4/25 22:26, Andy Shevchenko wrote: It seems driver missed the

Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs

2024-04-26 Thread Sui Jingfeng
Hi, On 2024/4/26 14:23, Maxime Ripard wrote: Hi, On Fri, Apr 26, 2024 at 04:43:18AM +0800, Sui Jingfeng wrote: On 2024/4/26 03:10, Andy Shevchenko wrote: On Fri, Apr 26, 2024 at 02:08:16AM +0800, Sui Jingfeng wrote: On 2024/4/25 22:26, Andy Shevchenko wrote: It seems driver missed the

Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs

2024-04-26 Thread Maxime Ripard
Hi, On Fri, Apr 26, 2024 at 04:43:18AM +0800, Sui Jingfeng wrote: > On 2024/4/26 03:10, Andy Shevchenko wrote: > > On Fri, Apr 26, 2024 at 02:08:16AM +0800, Sui Jingfeng wrote: > > > On 2024/4/25 22:26, Andy Shevchenko wrote: > > > > It seems driver missed the point of proper use of device

Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs

2024-04-25 Thread Sui Jingfeng
On 2024/4/26 04:43, Sui Jingfeng wrote: But both of will be safe then. But both of us will be safe then. -- Best regards, Sui

Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs

2024-04-25 Thread Sui Jingfeng
Hi, On 2024/4/26 03:12, Andy Shevchenko wrote: On Fri, Apr 26, 2024 at 02:53:22AM +0800, Sui Jingfeng wrote: On 2024/4/26 02:08, Sui Jingfeng wrote: Are you speaking to yourself? I'm totally lost. Please, if you want to give a constructive feedback, try to understand the topic from

Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs

2024-04-25 Thread Sui Jingfeng
Hi, On 2024/4/26 03:10, Andy Shevchenko wrote: On Fri, Apr 26, 2024 at 02:08:16AM +0800, Sui Jingfeng wrote: On 2024/4/25 22:26, Andy Shevchenko wrote: It seems driver missed the point of proper use of device property APIs. Correct this by updating headers and calls respectively. You are

Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs

2024-04-25 Thread Andy Shevchenko
On Fri, Apr 26, 2024 at 02:53:22AM +0800, Sui Jingfeng wrote: > On 2024/4/26 02:08, Sui Jingfeng wrote: Are you speaking to yourself? I'm totally lost. Please, if you want to give a constructive feedback, try to understand the topic from different aspects and then clearly express it. -- With

Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs

2024-04-25 Thread Andy Shevchenko
On Fri, Apr 26, 2024 at 02:08:16AM +0800, Sui Jingfeng wrote: > On 2024/4/25 22:26, Andy Shevchenko wrote: > > It seems driver missed the point of proper use of device property APIs. > > Correct this by updating headers and calls respectively. > > You are using the 'seems' here exactly saying

Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs

2024-04-25 Thread Sui Jingfeng
Hi, On 2024/4/26 02:08, Sui Jingfeng wrote: Hi, On 2024/4/25 22:26, Andy Shevchenko wrote: It seems driver missed the point of proper use of device property APIs. Correct this by updating headers and calls respectively. You are using the 'seems' here exactly saying that you are not 100%

Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs

2024-04-25 Thread Sui Jingfeng
Hi, On 2024/4/25 22:26, Andy Shevchenko wrote: It seems driver missed the point of proper use of device property APIs. Correct this by updating headers and calls respectively. You are using the 'seems' here exactly saying that you are not 100% sure. Please allow me to tell you the truth: