Re: [Dri-devel] Re: [PATCH] CodingStyle fixes for drm_agpsupport

On Thu, 14 Aug 2003 11:43:40 -0700 Philip Brown <[EMAIL PROTECTED]> wrote: | On Thu, Aug 14, 2003 at 07:47:11AM -0700, Larry McVoy wrote: | > ... | > Indeed I have. And there is a reason that we have a policy at BitMover | > where "formatting changes" are prohibited and we make people redo their

Re: drm patch

On Fri, 27 Aug 2004 09:44:51 +0100 (IST) Dave Airlie wrote: | | DRM_INFO("Used old pci detect: framebuffer loaded\n"); | | we print that... it should be enough I think.. | | Dave. | On Fri, 27 Aug 2004, Mike Mestnik wrote: | | > Not to be a nit prick, but shoulden't there at least be a warni

[PATCH] sis: use unsigned 1-bit fields

Hi, 1-bit fields should be unsigned (i.e., no sign bit). Sparse also complains about them, as in: drivers/char/drm/sis_ds.h:88:12: warning: dubious one-bit signed bitfield drivers/char/drm/sis_ds.h:89:16: warning: dubious one-bit signed bitfield Is current linux-2.6.9-bk tree anything close to DRM

Re: __FUNCTION__ vs __func__

Eric Anholt wrote: One of our developers who is working with a non-gcc compiler has asked if we could convert __FUNCTION__ usage in the drm to __func__. __func__ has the benefits of being shorter, being c99, and still being just fine for gcc 2.95. Any opposition? Most of linux-kernel still uses &

[PATCH] SIS DRM bool. bitfields

(resend) Make 1-bit fields be unsigned (no sign bit :). sparse complains about them: drivers/char/drm/sis_ds.h:88:12: warning: dubious one-bit signed bitfield drivers/char/drm/sis_ds.h:89:16: warning: dubious one-bit signed bitfield Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> diffstat:= dri

Re: radeon: Unknown symbol i2c_bit_add_bus

Sergio Monteiro Basto wrote: thanks, Now I can load radeon.ko after modprobe i2c_via.ko Do you have i2c-algo-bit.ko loaded (or built into your kernel image)? That's where i2c_bit_add|del_bus are. Check this .config symbol: CONFIG_I2C_ALGOBIT=y (on my system) On Mon, 2004-12-13 at 17:27 -0500, Ad

[PATCH] radeon_state: use NULL instead of 0 for ptr.

Fix sparse NULL/0 warning: drivers/char/drm/radeon_state.c:1845:15: warning: Using plain integer as NULL pointer Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> diffstat:= drivers/char/drm/radeon_state.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -Naurp ./drivers/char/drm/

[PATCH] drm/radeon: use NULL instead of 0

(resend) Fix sparse NULL/0 warning: drivers/char/drm/radeon_state.c:1845:15: warning: Using plain integer as NULL pointer Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> diffstat:= drivers/char/drm/radeon_state.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -Naurp ./drivers/