Sehr geehrter Herr.
Entschuldigen Sie meine Stцrung; Mein Name ist Lieutenant Andrew Ferrara,
derzeit bin ich im aktiven Dienst in Afghanistan. Bitte, muss ich eine verdeckt
Business-Angebot, die von gegenseitigem Nutzen fьr uns beide werden.
Am Samstag 20. Juli, meine Kollegen und ich
On Wed, Aug 21, 2013 at 01:27:15PM -0400, Lidza Louina wrote:
This patch fixes the error: foo* bar should be foo *bar.
I have a nit pick about this changelog. It's not something to
resend over, of course, but for future patches. The word fix
should only be used for bugfixes. The word clean
On Wed, Aug 21, 2013 at 09:48:38PM -0400, Lidza Louina wrote:
The declaration for the ioctl function has changed. The previous version
of this declaration took struct file *file as a parameter and the new
one does not. This patch removes that parameter.
It also removes cases for the commands
On Thu, Aug 22, 2013 at 06:00:14PM +0200, Wolfram Sang wrote:
I2C of helpers used to live in of_i2c.c but experience (from SPI) shows
that it is much cleaner to have this in the core. This also removes a
circular dependency between the helpers and the core, and so we can
finally register child
On Thu, Aug 22, 2013 at 05:38:51PM +0100, Rupesh Gujare wrote:
+/*--
* Context: softirq-serialized
*/
Don't resend the patch, but these comments are not in kernel style.
It's explained in
Cc: Forest Bond for...@alittletooquiet.net
Signed-off-by: Bjørn Mork bj...@mork.no
---
drivers/staging/vt6655/hostap.c |2 +-
drivers/staging/vt6655/ioctl.c |2 +-
drivers/staging/vt6655/wpactl.c |2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git
Copying the dev_addr from a parent device is an operation
common to a number of drivers. The addr_assign_type should
be updated accordingly, either by reusing the value from
the source device or explicitly indicating that the address
is stolen by setting addr_assign_type to NET_ADDR_STOLEN.
This
On Fri, Aug 23, 2013 at 11:35:13AM +0200, Bjørn Mork wrote:
Cc: Forest Bond for...@alittletooquiet.net
Signed-off-by: Bjørn Mork bj...@mork.no
---
The changlog is missing. Why does this patch help?
regards,
dan carpenter
___
devel mailing list
Dan Carpenter dan.carpen...@oracle.com writes:
On Fri, Aug 23, 2013 at 11:35:13AM +0200, Bjørn Mork wrote:
Cc: Forest Bond for...@alittletooquiet.net
Signed-off-by: Bjørn Mork bj...@mork.no
---
The changlog is missing.
Yes, right. Sorry about that.
Why does this patch help?
It ensures
On 23/08/13 10:05, Dan Carpenter wrote:
On Thu, Aug 22, 2013 at 05:38:51PM +0100, Rupesh Gujare wrote:
+/*--
* Context: softirq-serialized
*/
Don't resend the patch, but these comments are not in kernel style.
struct pt_regs pointer is no longer passed as a irq handler
argument.
Signed-off-by: navin patidar nav...@cdac.in
---
drivers/staging/rtl8187se/r8180_core.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8180_core.c
Commit dcd7b8bd63cb81c5b973bf86510ca3c80bbbd162 (staging: comedi: put
module _after_ detach by myself) reversed a couple of calls in
`comedi_device_attach()` when recovering from an error returned by the
low-level driver's 'attach' handler. Unfortunately, that introduced a
NULL pointer
Sehr geehrter Herr.
Entschuldigen Sie meine Stцrung; Mein Name ist Lieutenant Andrew Ferrara,
derzeit bin ich im aktiven Dienst in Afghanistan. Bitte, muss ich eine verdeckt
Business-Angebot, die von gegenseitigem Nutzen fьr uns beide werden.
Am Samstag 20. Juli, meine Kollegen und ich
On Fri, Aug 23, 2013 at 05:00:06PM +0530, navin patidar wrote:
struct pt_regs pointer is no longer passed as a irq handler
argument.
Good eye.
Could you also remove the cast to (void *) so the compiler can catch
this in the future?
- if (request_irq(dev-irq, (void *)rtl8180_interrupt,
m68k/sparc64 allmodconfig:
drivers/staging/dgnc/dgnc_driver.c: In function ‘dgnc_cleanup_board’:
drivers/staging/dgnc/dgnc_driver.c:459: error: implicit declaration of function
‘kfree’
drivers/staging/dgnc/dgnc_driver.c: In function ‘dgnc_driver_kzmalloc’:
drivers/staging/dgnc/dgnc_driver.c:905:
On Fri, Aug 23, 2013 at 4:47 AM, Dan Carpenter dan.carpen...@oracle.com wrote:
On Wed, Aug 21, 2013 at 09:48:38PM -0400, Lidza Louina wrote:
The declaration for the ioctl function has changed. The previous version
of this declaration took struct file *file as a parameter and the new
one does
The private data structure (`struct comedi_bond_private`) for the
overall comedi_bond device maps each channel individually to a pointer
to the `struct bonded_device` it belongs to via array member
`chan_id_dev_map[MAX_CHANS]`. This speeds up look-ups from channel
number to bonded device a bit,
The `subdev_type` member of `struct bonded_device` is set but not used.
Remove it.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/comedi_bond.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/comedi_bond.c
If a DIO subdevice has more than 32 channels, its 'insn_bits' handler is
supposed to take account of the base channel from
`CR_CHAN(insn-chanspec)`. (The comedi core will adjust the base
channel to 0 and shift the mask and data to compensate if the subdevice
has less than or equal to 32
The comedi core will free `dev-private` if it is non-NULL after calling
the detach handler (`bonding_detach()`), so don't bother freeing it in
`bonding_detach()`.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/comedi_bond.c | 2 --
1 file changed, 2 deletions(-)
`bonding_attach()` is the comedi attach handler for the driver. Any
non-negative return value is treated as successful, but 0 is the
preferred return value on success.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/comedi_bond.c | 2 +-
1 file changed, 1
The `char file[]` variable in `do_dev_config()` doesn't need to be
initialized as it gets overwritten with a `snprintf()`. It just needs
to be long enough.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/comedi_bond.c | 2 +-
1 file changed, 1 insertion(+), 1
Change `do_dev_config()` to return an error code on failure and 0 on
success, instead of 0 on failure and 1 on success.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/comedi_bond.c | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
The comedi_bond driver can be used to map the DIO subdevices of some
other comedi devices into one, giant, uber DIO subdevice. However, it
has a few bugs such as memory leaks (but only if a memory allocation
fails), buffer overflow when more than 256 channels are added, not
handling
Reformat some comments according to CodingStyle and remove some comments
inherited from the comedi 'skel' example driver.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/comedi_bond.c | 141 ++-
1 file changed, 73 insertions(+), 68
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/comedi_bond.c | 47 ++--
1 file changed, 24 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/comedi/drivers/comedi_bond.c
b/drivers/staging/comedi/drivers/comedi_bond.c
index
Correct spelling typo in staging/bcm
Signed-off-by: Masanari Iida standby2...@gmail.com
---
drivers/staging/bcm/Ioctl.h | 2 +-
drivers/staging/bcm/Misc.c | 2 +-
drivers/staging/bcm/nvm.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/bcm/Ioctl.h
On Friday, August 23, 2013 6:45 AM, Ian Abbott wrote:
If a DIO subdevice has more than 32 channels, its 'insn_bits' handler is
supposed to take account of the base channel from
`CR_CHAN(insn-chanspec)`. (The comedi core will adjust the base
channel to 0 and shift the mask and data to
schedule_work() returns true if succeeded false on failure,
error check was doing exactly reverse.
Also removes extra variable.
Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com
---
drivers/staging/ozwpan/ozpd.c |6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git
On Thu, Jul 25, 2013 at 7:50 PM, Dave Kleikamp dave.kleik...@oracle.com wrote:
Change the direct_IO aop to take an iov_iter argument rather than an iovec.
This will get passed down through most filesystems so that only the
__blockdev_direct_IO helper need be aware of whether user or kernel
On 32-bit m68k, I get lots of warnings like:
warning: integer constant is too large for ‘long’ type
Switch the L*_POISON definitions from too-large constants and casts
to the proper constant types to fix this.
Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org
---
The values in
On Fri, Aug 23, 2013 at 02:23:49PM +0200, Geert Uytterhoeven wrote:
m68k/sparc64 allmodconfig:
drivers/staging/dgnc/dgnc_driver.c: In function ‘dgnc_cleanup_board’:
drivers/staging/dgnc/dgnc_driver.c:459: error: implicit declaration of
function ‘kfree’
drivers/staging/dgnc/dgnc_driver.c:
Use macro instead of hard coded value for readability.
Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com
---
drivers/staging/ozwpan/ozhcd.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c
index
We have icreased interrupt end point buffer size to 512 bytes,
Change variable data type to accomodate it.
Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com
---
drivers/staging/ozwpan/ozhcd.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Max. TX frame size supported is changed to 760 bytes.
Signed-off-by: Rupesh Gujare rupesh.guj...@atmel.com
---
drivers/staging/ozwpan/ozproto.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ozwpan/ozproto.h b/drivers/staging/ozwpan/ozproto.h
index
On Wed, Aug 21, 2013 at 09:48:38PM -0400, Lidza Louina wrote:
-static int dgap_tty_ioctl(struct tty_struct *tty, struct file *file,
unsigned int cmd,
+static int dgap_tty_ioctl(struct tty_struct *tty, unsigned int cmd,
unsigned long arg)
Btw, now that this file compiles I see
36 matches
Mail list logo
