Re: [PATCH] staging : android : sync : fix a checkpatch warning

2014-02-09 Thread DaeSeok Youn
CC+ Joe Perches. 2014-02-10 14:58 GMT+09:00 Daeseok Youn : > From 16140b1ec1b1e1060f74707e4a6661aface81a14 Mon Sep 17 00:00:00 2001 > From: Daeseok Youn > Date: Mon, 10 Feb 2014 14:36:48 +0900 > Subject: [PATCH] staging : android : sync : fix a checkpatch warning > > - WARNING: missing space afte

Re: [PATCH] staging : ion : Fix some checkpatch warnings and an error

2014-02-09 Thread DaeSeok Youn
I think It looks better than reported by checkpatch.pl. But I have a qeustion, if your patch is applied to checkpatch.pl file, a return type of "void *" line will be changed. for example, void * (*map_kernel)(struct ion_heap *heap, struct ion_buffer *buffer); => void *(*map_kernel)(struct ion_heap

[PATCH] staging: android: timed_output: fix a checkpatch warning

2014-02-09 Thread Daeseok Youn
>From 866c5eb6cb88b59702802876a724dfd0144c447e Mon Sep 17 00:00:00 2001 From: Daeseok Youn Date: Mon, 10 Feb 2014 14:38:05 +0900 Subject: [PATCH] staging: android: timed_output: fix a checkpatch warning - WARNING: Multiple spaces after return type Signed-off-by: Daeseok Youn --- drivers/stagin

[PATCH] staging : android : sync : fix a checkpatch warning

2014-02-09 Thread Daeseok Youn
>From 16140b1ec1b1e1060f74707e4a6661aface81a14 Mon Sep 17 00:00:00 2001 From: Daeseok Youn Date: Mon, 10 Feb 2014 14:36:48 +0900 Subject: [PATCH] staging : android : sync : fix a checkpatch warning - WARNING: missing space after return type Signed-off-by: Daeseok Youn --- drivers/staging/andro

[PATCH] staging : ion : Fix some checkpatch warnings and an error

2014-02-09 Thread Daeseok Youn
>From aa06cc53c7214a044fbc220872aa6210c09608d3 Mon Sep 17 00:00:00 2001 From: Daeseok Youn Date: Mon, 10 Feb 2014 14:27:40 +0900 Subject: [PATCH] staging : ion : Fix some checkpatch warnings and an error Warning: - Unnecessary space after function pointer name - Prefer seq_puts to seq_printf - qu

Re: [PATCH] staging : android : fix checkpatch issues

2014-02-09 Thread DaeSeok Youn
2014-02-10 13:26 GMT+09:00 Greg KH : > On Mon, Feb 10, 2014 at 10:59:14AM +0900, Daeseok Youn wrote: >> >From 1348300b03697d0499eddba6035a851d1278abd1 Mon Sep 17 00:00:00 2001 >> From: Daeseok Youn >> Date: Mon, 10 Feb 2014 10:45:30 +0900 >> Subject: [PATCH] staging : android : fix checkpatch issu

Re: [PATCH] staging : android : fix checkpatch issues

2014-02-09 Thread Greg KH
On Mon, Feb 10, 2014 at 10:59:14AM +0900, Daeseok Youn wrote: > >From 1348300b03697d0499eddba6035a851d1278abd1 Mon Sep 17 00:00:00 2001 > From: Daeseok Youn > Date: Mon, 10 Feb 2014 10:45:30 +0900 > Subject: [PATCH] staging : android : fix checkpatch issues > > drivers/staging/android/ > ion/ion.

[PATCH] drivers:staging:silicom: Fixed MACRO, Extern, parentheses Coding style warnings and errors

2014-02-09 Thread Surendra Patil
Fixed MACRO,Extern and parentheses Coding style warnings and errors - listed only few bpctl_mod.c:120: WARNING: externs should be avoided in .c files bpctl_mod.c:121: WARNING: externs should be avoided in .c files bpctl_mod.c:122: WARNING: externs should be avoided in .c files bpctl_mod.c:124: WAR

[PATCH] staging : android : fix checkpatch issues

2014-02-09 Thread Daeseok Youn
>From 1348300b03697d0499eddba6035a851d1278abd1 Mon Sep 17 00:00:00 2001 From: Daeseok Youn Date: Mon, 10 Feb 2014 10:45:30 +0900 Subject: [PATCH] staging : android : fix checkpatch issues drivers/staging/android/ ion/ion.c : - WARNNING: Unnecessary space after function pointer name - ERROR: ret

[PATCH net] hyperv: Fix the carrier status setting

2014-02-09 Thread Haiyang Zhang
Signed-off-by: Haiyang Zhang Reviewed-by: K. Y. Srinivasan --- drivers/net/hyperv/netvsc_drv.c | 24 +++- 1 files changed, 15 insertions(+), 9 deletions(-) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index 7756118..836211c 100644 --- a/dr

[PATCH 5/6] staging: r8188eu: Eliminate macro to get next list item

2014-02-09 Thread Larry Finger
The driver contains a macro that gets the next item in a linked list. Replace it with a simple copy of the pointer. Signed-off-by: Larry Finger --- drivers/staging/rtl8188eu/core/rtw_ap.c | 32 +++--- drivers/staging/rtl8188eu/core/rtw_cmd.c | 2 +- drivers/staging/rt

[PATCH 4/6] staging: r8188eu: Replace misspelled local container macro

2014-02-09 Thread Larry Finger
This driver has its own implementation of a "container_of" macro. It is replaced with the standard container_of version. Most of these are a straight one-to-one replacement; however, a few of the instances referred to the member of a union. Those were replaced with the struct that is part of that u

[PATCH 2/6] staging: r8188eu: Remove dead file

2014-02-09 Thread Larry Finger
After the previous cleanups, file hal/odm_interface.c is now empty. It is hereby deleted, and removed from Makefile. Signed-off-by: Larry Finger --- drivers/staging/rtl8188eu/Makefile| 1 - drivers/staging/rtl8188eu/hal/odm_interface.c | 1 - 2 files changed, 2 deletions(-) delete m

[PATCH 3/6] staging: r8188eu: Remove some dead code from headers

2014-02-09 Thread Larry Finger
The headers for this driver contain a number of unused structs and macros that are removed. File include/ioctl_cfg80211.h is now empty and was deleted. Signed-off-by: Larry Finger --- drivers/staging/rtl8188eu/include/ioctl_cfg80211.h | 107 - drivers/staging/rtl8188eu/includ

[PATCH 1/6] staging: r8188eu: Replace wrapper around _rtw_memcmp()

2014-02-09 Thread Larry Finger
This wrapper is replaced with a simple memcmp(). As the wrapper inverts the logic of memcmp(), care needed to be taken. This patch also adds one include of vmalloc.h that was missed in a previous patch. Signed-off-by: Larry Finger --- drivers/staging/rtl8188eu/core/rtw_ap.c | 16 ++---

[PATCH 0/6] Various cleanups of r8188eu

2014-02-09 Thread Larry Finger
As has been noted, this driver is very rough. This set of patches is intended to smooth some of the rough edges. Signed-off-by: Larry Finger Larry Finger (6): staging: r8188eu: Replace wrapper around _rtw_memcmp() staging: r8188eu: Remove dead file staging: r8188eu: Remove some dead code

Re: [PATCH 20/28] Remove OMAP_PM_SRF

2014-02-09 Thread Richard Weinberger
Am 09.02.2014 20:55, schrieb Paul Bolle: > On Sun, 2014-02-09 at 19:47 +0100, Richard Weinberger wrote: >> The symbol is an orphan, get rid of it. >> >> Signed-off-by: Richard Weinberger >> --- >> drivers/staging/tidspbridge/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> d

Re: [PATCH 20/28] Remove OMAP_PM_SRF

2014-02-09 Thread Paul Bolle
On Sun, 2014-02-09 at 19:47 +0100, Richard Weinberger wrote: > The symbol is an orphan, get rid of it. > > Signed-off-by: Richard Weinberger > --- > drivers/staging/tidspbridge/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/tidspbridge/Kconfig

[PATCH 20/28] Remove OMAP_PM_SRF

2014-02-09 Thread Richard Weinberger
The symbol is an orphan, get rid of it. Signed-off-by: Richard Weinberger --- drivers/staging/tidspbridge/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/tidspbridge/Kconfig b/drivers/staging/tidspbridge/Kconfig index 1b6d581..b5e74e9 100644 --- a/dri

Re: [PATCH] drivers:statging:rtl8821ae Fixed few coding style errors

2014-02-09 Thread Larry Finger
On 02/09/2014 02:29 AM, Surendra Patil wrote: Fixed few coding style errors in header files base.h:58: WARNING: please, no space before tabs base.h:81: ERROR: "(foo*)" should be "(foo *)" pci.h:338: ERROR: "foo * bar" should be "foo *bar" pci.h:151: ERROR: do not use C99 // comments Signed-off-b

Re: [PATCH 2/2] vers:staging:rtl8821ae: Fixed multiple coding style erors and warnings

2014-02-09 Thread Larry Finger
On 02/09/2014 01:30 AM, Surendra Patil wrote: Fixed multiple coding style errors and warnings wifi.h:1077: WARNING: please, no space before tabs wifi.h:762: WARNING: missing space after struct definition wifi.h:972: WARNING: please, no spaces at the start of a line wifi.h:1825: WARNING: Unnecessa

Re: [PATCH 1/2] drivers:staging:rtl8821ae: Fixed few coding style erors and warnings

2014-02-09 Thread Larry Finger
On 02/09/2014 01:30 AM, Surendra Patil wrote: Fixed multiple coding style errors and warnings wifi.h:1077: WARNING: please, no space before tabs wifi.h:762: WARNING: missing space after struct definition wifi.h:972: WARNING: please, no spaces at the start of a line wifi.h:1825: WARNING: Unnecessa

[PATCH] [media] v4l: omap4iss: Remove VIDEO_OMAP4_DEBUG

2014-02-09 Thread Paul Bolle
Commit d632dfefd36f ("[media] v4l: omap4iss: Add support for OMAP4 camera interface - Build system") added a Kconfig entry for VIDEO_OMAP4_DEBUG. But nothing uses that symbol. This entry was apparently copied from a similar entry for "OMAP 3 Camera debug messages". But a corresponding Makefile lin

[PATCH] Staging: rtl8812ae: remove undefined Kconfig macros

2014-02-09 Thread Paul Bolle
There are references to four undefined Kconfig macros in the code. Remove these as the checks for them will always evaluate to false. There are additional cleanups possible now, but I'll gladly leave those to people that are actually familiar with the code. Signed-off-by: Paul Bolle --- Untested

Re: [PATCH RFC 0/2] drivers/base: simplify simple DT-based components

2014-02-09 Thread Russell King - ARM Linux
On Sun, Feb 09, 2014 at 10:22:19AM +0100, Jean-Francois Moine wrote: > On Fri, 7 Feb 2014 20:23:51 + > Russell King - ARM Linux wrote: > > > Here's my changes to the TDA998x driver to add support for the component > > helper. The TDA998x driver retains support for the old way so that > > dri

Re: [PATCH RFC 0/2] drivers/base: simplify simple DT-based components

2014-02-09 Thread Jean-Francois Moine
On Fri, 7 Feb 2014 20:23:51 + Russell King - ARM Linux wrote: > Here's my changes to the TDA998x driver to add support for the component > helper. The TDA998x driver retains support for the old way so that > drivers can be transitioned. For any one DRM "card" the transition to I rewrote th

[PATCH 3/3] staging: rtl8188eu: remove header file ethernet.h

2014-02-09 Thread navin patidar
"ethernet.h" is included in three files but only "rtw_recv.c" using two macros defined in "ethernet.h", so move used macros in "rtw_recv.c" and remove "include/ethernet.h" header file and inclusion of this header file. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_recv.c

[PATCH 2/3] staging: rtl8188eu: remove header file ip.h

2014-02-09 Thread navin patidar
"ip.h" is included in four files but not being used, so remove "include/ip.h" header file and inclusion of this header file. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_recv.c |1 - drivers/staging/rtl8188eu/core/rtw_xmit.c |1 - drivers/staging/rtl8188e

[PATCH 1/3] staging: rtl8188eu: remove header file if_ether.h

2014-02-09 Thread navin patidar
"if_ether.h" is included in three files but not being used, so remove "include/if_ether.h" header file and inclusion of this header file. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_recv.c |1 - drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c |1 - drivers/sta

[PATCH] drivers:statging:rtl8821ae Fixed few coding style errors

2014-02-09 Thread Surendra Patil
Fixed few coding style errors in header files base.h:58: WARNING: please, no space before tabs base.h:81: ERROR: "(foo*)" should be "(foo *)" pci.h:338: ERROR: "foo * bar" should be "foo *bar" pci.h:151: ERROR: do not use C99 // comments Signed-off-by: Surendra Patil --- drivers/staging/rtl8821a