[PATCH] staging: dgap: Fixed sparse error: same symbol redeclared with different type

2014-03-12 Thread Masood Mehmood
sparse reported dgap_do_fep_load is redeclared with different type. while fixing, I noticed __user attribute is used incorrectly in declaration. There is no need to define __user for firware->data. Replaced the __user with 'const uchar *' from function dgap_do_fep_load and did the same for functio

[PATCH] Staging: lustre: fld: moved EXPORT_SYMBOL() for a fix.

2014-03-12 Thread Gary Rookard
I moved EXPORT_SYMBOL(fld_client_proc_fini); for a EXPORT_SYMBOL should be immediately below its function warning fix. Signed-off-by: Gary Alan Rookard --- On branch staging-next drivers/staging/lustre/lustre/fld/fld_request.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a

Re: [PATCH] Staging: lustre: fld: moved EXPORT_SYMBOL() for a fix.

2014-03-12 Thread Greg KH
On Thu, Mar 13, 2014 at 12:04:18AM -0400, Gary Rookard wrote: > I moved EXPORT_SYMBOL(fld_client_proc_fini); for a warning fix. What is the warning? ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/list

[PATCH] Staging: lustre: fld: moved EXPORT_SYMBOL() for a fix.

2014-03-12 Thread Gary Rookard
I moved EXPORT_SYMBOL(fld_client_proc_fini); for a warning fix. Signed-off-by: Gary Alan Rookard --- On branch staging-next drivers/staging/lustre/lustre/fld/fld_request.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/fld/fld_request.c b/dri

Re: [PATCH 3/3] staging/ozwpan: coding style ether_addr_copy

2014-03-12 Thread Greg Kroah-Hartman
On Thu, Mar 13, 2014 at 10:21:44AM +0900, Jérôme Pinot wrote: > This fixes the following issues detected by checkpatch.pl: > > WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses > are __aligned(2) > #220: FILE: drivers/staging/ozwpan/ozcdev.c:220: > + memcpy

[PATCH 3/3] staging/ozwpan: coding style ether_addr_copy

2014-03-12 Thread Jérôme Pinot
This fixes the following issues detected by checkpatch.pl: WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) #220: FILE: drivers/staging/ozwpan/ozcdev.c:220: + memcpy(g_cdev.active_addr, addr, ETH_ALEN); WARNING: Prefer ether_addr_copy()

[PATCH 2/3] staging/ozwpan: coding style __constant_

2014-03-12 Thread Jérôme Pinot
This fixes the following issues detected by checkpatch.pl: WARNING: __constant_cpu_to_le16 should be cpu_to_le16 #1991: FILE: drivers/staging/ozwpan/ozhcd.c:1991: + __constant_cpu_to_le16(0x0001); WARNING: __constant_cpu_to_le32 should be cpu_to_le32 #2185: FILE: drivers

[PATCH 1/3] staging/ozwpan: formatting coding style

2014-03-12 Thread Jérôme Pinot
This fixes the following spacing issues detected by checkpatch.pl: WARNING: line over 80 characters #357: FILE: drivers/staging/ozwpan/ozhcd.c:357: +static struct oz_urb_link *oz_uncancel_urb(struct oz_hcd *ozhcd, struct urb *urb) ERROR: trailing whitespace #25: FILE: drivers/staging/ozwpan

git not pulling origin staging-next cleanly.

2014-03-12 Thread Gary Rookard
Hi, Could this problem be local machine (git-1.9.0-1) or dare I say it, a tmp server-side melt-down of sorts? I've tried everything nothing seams to work. Thanks for your time, -Gary Rookard ___ devel mailing list de...@linuxdriverproject.org http://dri

Re: [PATCH v3 1/2] Staging: comedi: addi-data: Fix long CamelCase function names

2014-03-12 Thread Ian Abbott
On 2014-03-12 01:06, Hartley Sweeten wrote: On Tuesday, March 11, 2014 3:19 PM, Fred Akers wrote: This patch fixes a few function names that are very long and are not in the correct naming style Signed-off-by: Fred Akers Fred, I pulled Greg's staging tree to see if your patches apply. Patc

Re: [PATCH v9][ 7/8] ARM: dts: mbimx51sd: Add display support.

2014-03-12 Thread Denis Carikli
On 03/06/2014 05:26 PM, Philipp Zabel wrote: Hi Denis, Hi, Does this board really have a DVI connector and no I2C bus routed to the DDC pins? Yes, I2C is not routed to the DVI connector. Denis. ___ devel mailing list de...@linuxdriverproject.org ht

Re: [RFC PATCH 00/22] staging: add skein/threefish crypto algos

2014-03-12 Thread Jason Cooper
On Tue, Mar 11, 2014 at 09:32:32PM +, Jason Cooper wrote: > To facilitate tinkering with this, One can pull from the following: > > git://git.infradead.org/users/jcooper/linux.git tags/staging-skein-3.14-rc1 > > This is based on v3.14-rc1, and is prone to rebasing based on comments. Hmmm,

[PATCH 04/04] staging: dgap: Add a pr_info per board info

2014-03-12 Thread Mark Hounschell
This patch adds a pr_info per board that indicates board number, type, etc.. Signed-off-by: Mark Hounschell Cc: Greg Kroah-Hartman --- drivers/staging/dgap/dgap.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index ddeff5f..77d

[PATCH 02/03] staging: dgap: remove unused brd->state states

2014-03-12 Thread Mark Hounschell
This patch removes unused brd->state states previously used in the userland firmware download process. Signed-off-by: Mark Hounschell Tested-by: Mark Hounschell Cc: Greg Kroah-Hartman --- drivers/staging/dgap/dgap.c | 5 - drivers/staging/dgap/dgap.h | 17 - 2 files chang

[PATCH 03/03] staging: dgap: remove more unneeded brd-state states

2014-03-12 Thread Mark Hounschell
This patch removes more unneeded brd-state states Signed-off-by: Mark Hounschell Tested-by: Mark Hounschell Cc: Greg Kroah-Hartman --- drivers/staging/dgap/dgap.c | 35 +-- drivers/staging/dgap/dgap.h | 2 -- 2 files changed, 17 insertions(+), 20 deletions(-)

[PATCH 01/03] staging: dgap: remove unneeded dgap_driver_states

2014-03-12 Thread Mark Hounschell
The only driver states we need now is READY or !READY. No need for a sysfs method of seeing those 2 states so the sysfs entries for dgap_driver_state is also removed. Signed-off-by: Mark Hounschell Tested-by: Mark Hounschell Cc: Greg Kroah-Hartman --- drivers/staging/dgap/dgap.c | 26 +

[PATCH 00/04] staging: dgap: Digi International dgap driver

2014-03-12 Thread Mark Hounschell
patches 1-3 remove most of the unneeded state machine tracking code and variables previously used in the old firmware loading process. patch 4 adds back in a pr_info that provided information on each board found and configured. This got removed in a previous patch that removed the debug and traci

[PATCH v10][ 06/10] ARM: dts: imx5*, imx6*: correct display-timings nodes.

2014-03-12 Thread Denis Carikli
The imx-drm driver can't use the de-active and pixelclk-active display-timings properties yet. Instead the data-enable and the pixel data clock polarity are hardcoded in the imx-drm driver. So theses properties are now set to keep the same behaviour when imx-drm will start using them. Signed-off

[PATCH v10][ 07/10] imx-drm: Prepare imx-drm for extra display-timings retrival.

2014-03-12 Thread Denis Carikli
The hardware behaviour was kept. Signed-off-by: Denis Carikli --- ChangeLog v9->v10: - New patch that was splitted out of "staging: imx-drm: Use de-active and pixelclk-active display-timings." - The IMXDRM_MODE_FLAG_ are now using the BIT macros. - The SET_CLK_POL and SET_DE_POL masks were rem

[PATCH v10][ 05/10] imx-drm: use defines for clock polarity settings

2014-03-12 Thread Denis Carikli
Signed-off-by: Denis Carikli --- ChangeLog v9->v10: - New patch which was splitted out from: "staging: imx-drm: Use de-active and pixelclk-active display-timings.". - Fixes many issues in "staging: imx-drm: Use de-active and pixelclk-active display-timings.": - More clear meaning of the pola

[PATCH v10][ 03/10] imx-drm: Correct BGR666 and the board's dts that use them.

2014-03-12 Thread Denis Carikli
The current BGR666 is not consistent with the other color mapings like BGR24. BGR666 should be in the same byte order than BGR24. Signed-off-by: Denis Carikli Acked-by: Philipp Zabel --- ChangeLog v9->v10: - Rebased. - Added Philipp Zabel's Ack. - Included Lothar Waßmann's suggestion about imx-l

[PATCH v10][ 04/10] imx-drm: Match ipu_di_signal_cfg's clk_pol with its description.

2014-03-12 Thread Denis Carikli
According to the datasheet, setting the di0_polarity_disp_clk field in the GENERAL di register sets the output clock polarity to active high. Signed-off-by: Denis Carikli --- ChangeLog v9->v10: - New patch that is now needed by the "staging: imx-drm: Use de-active and pixelclk-active" patch. --

[PATCH v10][ 09/10] imx-drm: parallel-display: retrive extra display-timings.

2014-03-12 Thread Denis Carikli
If de-active and/or pixelclk-active properties were set in the display-timings DT node, they were not used. Instead the data-enable and the pixel data clock polarity were hardcoded. Signed-off-by: Denis Carikli --- ChangeLog v9->v10: - New patch from what's left of: "staging: imx-drm: Use de-a

[PATCH v10][ 08/10] imx-drm: imx-drm-core: provide a common display timings retrival function.

2014-03-12 Thread Denis Carikli
imx_drm_of_get_extra_timing_flags will be used to retrive the native-mode and de-active display-timings node properties in the device tree. Signed-off-by: Denis Carikli --- ChangeLog v9->v10: - New patch that was splitted out of "staging: imx-drm: Use de-active and pixelclk-active - When a IMXD

[PATCH v10][ 10/10] ARM: dts: mbimx51sd: Add display support.

2014-03-12 Thread Denis Carikli
The CMO-QVGA, DVI-SVGA and DVI-VGA are added. Signed-off-by: Denis Carikli --- ChangeLog v9->v10: - Rebased - Now enables the cmo-qvga regulator at boot. ChangeLog v8->v9: - Removed the Cc. They are now set in git-send-email directly. - updated pixelclk-active after the following patch: "imx-d

[PATCH v10][ 01/10] [media] v4l2: add new V4L2_PIX_FMT_RGB666 pixel format.

2014-03-12 Thread Denis Carikli
That new macro is needed by the imx_drm staging driver for supporting the QVGA display of the eukrea-cpuimx51 board. Signed-off-by: Denis Carikli Acked-by: Mauro Carvalho Chehab Acked-by: Laurent Pinchart Acked-by: Philipp Zabel --- ChangeLog v9->v10: - Rebased on top of: "211e7f2 [media]

[PATCH v10][ 02/10] imx-drm: Add RGB666 support for parallel display.

2014-03-12 Thread Denis Carikli
Signed-off-by: Denis Carikli Acked-by: Philipp Zabel --- ChangeLog v8->v9: - Rebased. - Added Philipp Zabel's ack. - Shortened the patch title. ChangeLog v8->v9: - Removed the Cc. They are now set in git-send-email directly. - Rebased. ChangeLog v7->v8: - Shrinked even more the Cc list. Change

Re: [PATCH] staging/ozwpan: coding style

2014-03-12 Thread Greg Kroah-Hartman
On Wed, Mar 12, 2014 at 07:01:32PM +0900, Jérôme Pinot wrote: > Hi, > > This commit fixes warnings reported by checkpatch.pl Which specific warnings? And it looks like you fixed a number of different things in the same patch, please break it up into doing "one thing per patch". thanks, greg k-

Re: [PATCH v9][ 3/8] staging: imx-drm: Correct BGR666 and the board's dts that use them.

2014-03-12 Thread Lothar Waßmann
Hi, Denis Carikli wrote: > The current BGR666 is not consistent with the other color mapings like BGR24. > BGR666 should be in the same byte order than BGR24. > [...] > diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-dc.c > b/drivers/staging/imx-drm/ipu-v3/ipu-dc.c > index 6f9abe8..154d293 10064

[PATCH] staging: unisys: use kzalloc instead of kmalloc/memset 0

2014-03-12 Thread Daeseok Youn
Signed-off-by: Daeseok Youn --- drivers/staging/unisys/uislib/uislib.c |5 + drivers/staging/unisys/uislib/uisutils.c |2 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/unisys/uislib/uislib.c b/drivers/staging/unisys/uislib/uislib.c index d77df9a

[PATCH] staging/ozwpan: coding style

2014-03-12 Thread Jérôme Pinot
Hi, This commit fixes warnings reported by checkpatch.pl Signed-off-by: Jerome Pinot --- drivers/staging/ozwpan/ozcdev.c | 4 ++-- drivers/staging/ozwpan/ozhcd.c | 8 drivers/staging/ozwpan/ozpd.c| 2 +- drivers/staging/ozwpan/ozpd.h| 2 +- drivers/staging/ozwpan/ozproto.c |