Re: [firefly] [PATCH] staging: cxt1e1: hwprobe: Fix sparse warning

>> Signed-off-by: Matei Oprea >> Cc: ROSEdu Kernel Community > > Why the cc: for a non-maintainer / person? We try to keep track of student's contributions in this way. Also, patches are internally reviewed on this mailing list before sending them to maintainers. thanks, Daniel. ___

Re: [PATCH] STAGING: comedi: title block update

On Tue, Mar 18, 2014 at 11:24:31PM -0500, michael wrote: > Follow up patch for "STAGING: comedi: style and checkpatch fixes". > Removes the file name in the comment block per suggestions. > > Signed-off-by: Michael Welling Minor problem for future patches, your "From:" line doesn't match your "S

Re: [PATCH] staging: unisys: use kzalloc instead of kmalloc/memset 0

Thanks for reply. I will do that. Regards, Daeseok Youn. 2014-03-19 11:31 GMT+09:00 Greg KH : > On Wed, Mar 19, 2014 at 10:04:40AM +0900, DaeSeok Youn wrote: >> oh... >> You didn't get my reply about vmalloc usage. >> >> My replay attach again, below. >> >> > 2014-03-18 9:37 GMT+09:00 Greg KH : >

[PATCH] STAGING: comedi: title block update

Follow up patch for "STAGING: comedi: style and checkpatch fixes". Removes the file name in the comment block per suggestions. Signed-off-by: Michael Welling --- diff --git a/drivers/staging/comedi/proc.c b/drivers/staging/comedi/proc.c index 7a5bf5b..91dea25 100644 --- a/drivers/staging/comedi/p

Re: [PATCH] staging: unisys: use kzalloc instead of kmalloc/memset 0

On Wed, Mar 19, 2014 at 10:04:40AM +0900, DaeSeok Youn wrote: > oh... > You didn't get my reply about vmalloc usage. > > My replay attach again, below. > > > 2014-03-18 9:37 GMT+09:00 Greg KH : > >> On Tue, Mar 18, 2014 at 09:26:07AM +0900, DaeSeok Youn wrote: > >>> I think vmalloc/kmalloc in uis

Re: [PATCH] staging: unisys: use kzalloc instead of kmalloc/memset 0

oh... You didn't get my reply about vmalloc usage. My replay attach again, below. > 2014-03-18 9:37 GMT+09:00 Greg KH : >> On Tue, Mar 18, 2014 at 09:26:07AM +0900, DaeSeok Youn wrote: >>> I think vmalloc/kmalloc in uislib_malloc() can be removed and just use >>> vmalloc/kmalloc directly. >> >> Y

Re: [PATCH] staging: wlags49_h2: Coding style correction

On Wed, Mar 19, 2014 at 01:52:09AM +0100, Mathieu Maret wrote: > As the file was mixing tab and space, reindent the file > Mainly correct use of C99 comments, > space between parenthesis, > remove commented code > > Signed-off-by: Mathieu Maret > --- > drivers/staging/wlags49_h2/wl_netdev.c | 19

Re: [PATCH] staging: unisys: use kzalloc instead of kmalloc/memset 0

On Wed, Mar 19, 2014 at 09:03:49AM +0900, DaeSeok Youn wrote: > Hi, greg. > > Review my comment below. What comment? confused, greg k-h- ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/drive

Re: [PATCH] staging: unisys: use kzalloc instead of kmalloc/memset 0

A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Wed, Mar 19, 2014 at 09:09:59AM +0900, DaeSeok Youn wrote: > Hi, Ken > Thanks for review. > > But I have a question, I wan to know why tracing buffer > status(Malloc_FailuresAlloc, Malloc_BytesInU

Re: [PATCH] staging: unisys: use kzalloc instead of kmalloc/memset 0

Hi, Ken Thanks for review. But I have a question, I wan to know why tracing buffer status(Malloc_FailuresAlloc, Malloc_BytesInUse...) for info_proc_read_helper() are needed. If it doesn't need, whole tracing stuff for memory can be removed. After getting a reply from you and greg, I will make a

Re: [PATCH] staging: unisys: use kzalloc instead of kmalloc/memset 0

Hi, greg. Review my comment below. Thanks. Daeseok Youn. 2014-03-18 17:11 GMT+09:00 DaeSeok Youn : > 2014-03-18 9:37 GMT+09:00 Greg KH : >> On Tue, Mar 18, 2014 at 09:26:07AM +0900, DaeSeok Youn wrote: >>> I think vmalloc/kmalloc in uislib_malloc() can be removed and just use >>> vmalloc/kmalloc

Re: [PATCH] staging/xillybus: Handle OOM in xillybus_init()

Hi, I stand (shamefully) corrected. Thanks. Eli On 19/03/14 01:07, Richard Weinberger wrote: alloc_workqueue() can fail and returns NULL in case of OOM. Handle this case and undo class_create(). Signed-off-by: Richard Weinberger --- drivers/staging/xillybus/xillybus_core.c | 6 +- 1

Re: [PATCH] staging: cxt1e1: hwprobe: Fix sparse warning

On Wed, Mar 19, 2014 at 12:33:19AM +0200, Matei Oprea wrote: > This fixes the following sparse warning: > * drivers/staging/cxt1e1/hwprobe.c:43:19: > warning: symbol 'hdw_info' was not declared. Should it be static? > * drivers/staging/cxt1e1/hwprobe.c:47:1: > warning: symbol 'show_two' was not d

Re: [PATCH] staging: cxt1e1: hwprobe: Fix sparse warning

On Wed, Mar 19, 2014 at 12:33:19AM +0200, Matei Oprea wrote: > This fixes the following sparse warning: > * drivers/staging/cxt1e1/hwprobe.c:43:19: > warning: symbol 'hdw_info' was not declared. Should it be static? > * drivers/staging/cxt1e1/hwprobe.c:47:1: > warning: symbol 'show_two' was not d

Re: [PATCH] staging: cxt1e1: hwprobe: Fix sparse warning

On Wed, Mar 19, 2014 at 12:33:19AM +0200, Matei Oprea wrote: > This fixes the following sparse warning: > * drivers/staging/cxt1e1/hwprobe.c:43:19: > warning: symbol 'hdw_info' was not declared. Should it be static? > * drivers/staging/cxt1e1/hwprobe.c:47:1: > warning: symbol 'show_two' was not d

Re: [PATCH] staging: slicoss: Fix prefer ether_addr_copy over memcpy

El 17/03/14 23:49, Jingoo Han escribió: On Tuesday, March 18, 2014 2:04 PM, Joel Pelaez Jorge wrote: @@ -810,8 +810,8 @@ static int slic_mac_set_address(struct net_device *dev, void *ptr) if (!is_valid_ether_addr(addr->sa_data)) return -EINVAL; - memcpy(dev->dev_

[PATCH] staging/xillybus: Handle OOM in xillybus_init()

alloc_workqueue() can fail and returns NULL in case of OOM. Handle this case and undo class_create(). Signed-off-by: Richard Weinberger --- drivers/staging/xillybus/xillybus_core.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/staging/xillybus/xillybus_core.c

[PATCH] staging: cxt1e1: hwprobe: Fix sparse warning

This fixes the following sparse warning: * drivers/staging/cxt1e1/hwprobe.c:43:19: warning: symbol 'hdw_info' was not declared. Should it be static? * drivers/staging/cxt1e1/hwprobe.c:47:1: warning: symbol 'show_two' was not declared. Should it be static? * drivers/staging/cxt1e1/hwprobe.c:99:1:

[PATCH] staging: line6: Fix coding style problem

From: Mikhail Boiko Fix style issue for eudyptula challenge Signed-off-by: Mikhail Boiko --- --- a/drivers/staging/line6/capture.c.orig 2014-03-18 23:35:36.440486308 +0200 +++ a/drivers/staging/line6/capture.c 2014-03-18 23:35:40.660486377 +0200 @@ -157,6 +157,7 @@ void line6_capture_copy(str

Re: [PATCH] Staging: bcm: CmHost: moved and removed declarations and tmp bracing.

On Tue, 18 Mar 2014, Greg KH wrote: On Mon, Mar 17, 2014 at 08:21:34PM -0400, Gary Rookard wrote: Firstly, some background is needed to confirm the validity of this patch as error fixing. It seems the developer when writing this driver from scratch, used what are known to me as error suppress

[PATCH net-next, v3] hyperv: Add support for virtual Receive Side Scaling (vRSS)

This feature allows multiple channels to be used by each virtual NIC. It is available on Hyper-V host 2012 R2. Signed-off-by: Haiyang Zhang Reviewed-by: K. Y. Srinivasan --- drivers/net/hyperv/hyperv_net.h | 112 ++- drivers/net/hyperv/netvsc.c | 134 ++

[PATCH] staging: unisys: kmalloc/memset to kzalloc conversation

This patch solves the Coccinelle warning: "kzalloc should be used instead of kmalloc/memset" This patch is a fixup for linux-next: 97a84f1203786985856a0d4b49b1d7cc387238ce "Staging: unisys: Replace kmalloc/memset with kzalloc" The ALLOC_CMDRSP #define is after transformation to k

[patch][wip] staging: unisys: kmalloc/memset move to kzalloc

Hi, I have followed this thread and have seen that not all parts was kcalloc'ized. Please review this patch and maybe include it. This patch is WIP because I have no hardware and can only do a compile test. version 2: * remove ALLOC_CMDRSP define Bye, Silvio _

[PATCH] Staging: bcm: CmHost: moved and removed declarations and tmp bracing.

Firstly, some background is needed to confirm the validity of this patch as error fixing. It seems the developer when writing this driver from scratch, used what are known to me as error suppressors in the form of extra tmp bracing added to the case labels. They aid during construction time, but ar

Re: [PATCH] staging: slicoss: Fix prefer ether_addr_copy over memcpy

On Mon, Mar 17, 2014 at 09:17:35PM -0600, Joel Pelaez Jorge wrote: > This patch fixes the following checkpatch.pl issues caused by the new > function: ether_addr_copy > > Signed-off-by: Joel Pelaez Jorge > --- > diff --git a/drivers/staging/slicoss/slicoss.c > b/drivers/staging/slicoss/slicoss.c

Re: [PATCH] staging: dgap: Fixed sparse error: same symbol redeclared with different type

On Thu, Mar 13, 2014 at 03:02:59AM -0700, Masood Mehmood wrote: > sparse reported dgap_do_fep_load is redeclared with different type. while > fixing, I noticed __user attribute is used incorrectly in declaration. > There is no need to define __user for firware->data. > > Replaced the __user with '

Re: [PATCH] staging: r8188eu: memory leak in rtw_free_cmd_obj if command is (_Set_Drv_Extra)

On Tue, Mar 18, 2014 at 10:25:27AM -0400, Wang, Xiaoming wrote: > pcmd->parmbuf->pbuf has been allocated if command is > GEN_CMD_CODE(_Set_Drv_Extra), > and it enqueued by rtw_enqueue_cmd. rtw_cmd_thread dequeue pcmd by > rtw_dequeue_cmd. > The memory leak happened on this branch "if( _FAIL == >

Re: [PATCH] Staging: bcm: CmHost: moved and removed declarations and tmp bracing.

On Mon, Mar 17, 2014 at 08:21:34PM -0400, Gary Rookard wrote: > Firstly, some background is needed to confirm the validity of > this patch as error fixing. It seems the developer when writing > this driver from scratch, used what are known to me as error > suppressors in the form of extra tmp braci

Re: [RFC PATCH 03/22] staging: crypto: skein: allow building statically

On Tue, Mar 18, 2014 at 08:58:49AM -0400, Jason Cooper wrote: > On Mon, Mar 17, 2014 at 02:52:52PM -0700, Greg KH wrote: > > On Tue, Mar 11, 2014 at 09:32:35PM +, Jason Cooper wrote: > > > These are the minimum changes required to get the code to build > > > statically in the kernel. It's nece

[PATCH] staging: omap24xx: fix coding style

Fix missing parentheses in macros Errors found by checkpatch.pl Signed-off-by: Ioana Ileana --- drivers/staging/media/omap24xx/tcm825x.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/omap24xx/tcm825x.h b/drivers/staging/media/omap24xx/tcm825x.h

Re: [PATCH 1/6] Staging: unisys: channels: Cleanup sparse warnings

On 03/17/2014 04:43 PM, Mark Einon wrote: Clean up multiple sparse warnings mostly due to different address spaces when accessing I/O memory. Also, remove SignalRemoveAll(), SignalQueueHasOneElement(), SignalQueueIsFull(), because they were never called. Signed-off-by: Ken Cox diff --git

Re: [PATCH 08/12] imx-drm: Use drm_display_mode timings flags.

Hi, Denis Carikli wrote: > The previous hardware behaviour was kept if the > flags are not set. > > Signed-off-by: Denis Carikli > --- > ChangeLog v10->v11: > - This patch was splitted-out and adapted from: > "Prepare imx-drm for extra display-timings retrival." > - The display-timings dt spec

Re: [PATCH 07/12] drm: drm_display_mode: add signal polarity flags

Hi, Laurent Pinchart wrote: > Hi Lothar, > > On Tuesday 18 March 2014 08:50:30 Lothar Waßmann wrote: > > Laurent Pinchart wrote: > > > On Monday 17 March 2014 16:14:36 Lothar Waßmann wrote: > > > > Laurent Pinchart wrote: > > > > > On Monday 17 March 2014 14:41:09 Andrzej Hajda wrote: > > > > > >

Re: [PATCH 07/12] drm: drm_display_mode: add signal polarity flags

Hi Russell, On Tuesday 18 March 2014 12:56:23 Russell King - ARM Linux wrote: > On Tue, Mar 18, 2014 at 01:41:54PM +0100, Laurent Pinchart wrote: > > Hi Lothar, > > > > That's not my point. I *know* that DE is a data gating signal with a > > polarity already defined by the DRM_MODE_FLAG_POL_DE_(L

Re: [PATCH] staging: unisys: use kzalloc instead of kmalloc/memset 0

On 03/17/2014 07:26 PM, DaeSeok Youn wrote: I think vmalloc/kmalloc in uislib_malloc() can be removed and just use vmalloc/kmalloc directly. (UISMALLOC() macro is also removed.) And uislib_malloc() is renamed to "uislib_trace_buffer_status()" which is just tracing buffer status(Malloc_FailuresAl

Re: [RFC PATCH 03/22] staging: crypto: skein: allow building statically

On Mon, Mar 17, 2014 at 02:52:52PM -0700, Greg KH wrote: > On Tue, Mar 11, 2014 at 09:32:35PM +, Jason Cooper wrote: > > These are the minimum changes required to get the code to build > > statically in the kernel. It's necessary to do this first so that we > > can empirically determine that f

Re: [PATCH 07/12] drm: drm_display_mode: add signal polarity flags

On Tue, Mar 18, 2014 at 01:41:54PM +0100, Laurent Pinchart wrote: > Hi Lothar, > > That's not my point. I *know* that DE is a data gating signal with a polarity > already defined by the DRM_MODE_FLAG_POL_DE_(LOW|HIGH) flags. Like all other > signals it gets generated on a clock edge and is sampl

Re: [PATCH 07/12] drm: drm_display_mode: add signal polarity flags

Hi Lothar, On Tuesday 18 March 2014 08:50:30 Lothar Waßmann wrote: > Laurent Pinchart wrote: > > On Monday 17 March 2014 16:14:36 Lothar Waßmann wrote: > > > Laurent Pinchart wrote: > > > > On Monday 17 March 2014 14:41:09 Andrzej Hajda wrote: > > > > > On 03/13/2014 06:17 PM, Denis Carikli wrote:

RE: [PATCH RESEND] x86, hyperv: bypass the timer_irq_works() check

> -Original Message- > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Thursday, February 27, 2014 7:30 PM > To: KY Srinivasan; Haiyang Zhang; t...@linutronix.de; mi...@redhat.com; > h...@zytor.com; x...@kernel.org; de...@linuxdriverproject.org; linux- > ker...@vger.kernel.org > Cc:

Melhore a sua conta de e-mail

Caro E-mail de Conta de Usuário , Devido aos e-mails de lixo / spam que você recebe diariamente , estamos atualizando tudo contas de email filtro de spam para limitar todos os e-mails não solicitados para razões de segurança e para melhorar a nossa conta de e-mail novo e melhorado recursos e m

Re: [PATCH 07/12] drm: drm_display_mode: add signal polarity flags

On Tue, Mar 18, 2014 at 08:50:30AM +0100, Lothar Waßmann wrote: > Hi, > > Laurent Pinchart wrote: > > Hi Lothar, > > > > On Monday 17 March 2014 16:14:36 Lothar Waßmann wrote: > > > DE is not a clock signal, but an 'Enable' signal whose value (high or > > > low) defines the window in which the pi

Re: [PATCH] staging: unisys: use kzalloc instead of kmalloc/memset 0

2014-03-18 9:37 GMT+09:00 Greg KH : > On Tue, Mar 18, 2014 at 09:26:07AM +0900, DaeSeok Youn wrote: >> I think vmalloc/kmalloc in uislib_malloc() can be removed and just use >> vmalloc/kmalloc directly. > > Yes. Actually, just use kmalloc, I don't knwo why vmalloc is being > used, but cc: the driv

Re: [PATCH 07/12] drm: drm_display_mode: add signal polarity flags

Hi, Laurent Pinchart wrote: > Hi Lothar, > > On Monday 17 March 2014 16:14:36 Lothar Waßmann wrote: > > Laurent Pinchart wrote: > > > On Monday 17 March 2014 14:41:09 Andrzej Hajda wrote: > > > > On 03/13/2014 06:17 PM, Denis Carikli wrote: > > > > > We need a way to pass signal polarity informat