[PATCH 2/2 v4] staging: comedi: addi_apci_1564: tidy up apci1564_reset()

2014-04-16 Thread Chase Southwood
The reset function for this driver is a bit of a mess; clean it up to ensure that it is functioning properly. Signed-off-by: Chase Southwood --- 2: *Changed order of register accesses for digital input registers back to original ordering. *Removed read of digital output status register and reorde

[PATCH] staging: rts5139: fixed coding style

2014-04-16 Thread Thomas Tanaka
Fixed checkpatch warnings > 80 lines Signed-off-by: Thomas Tanaka --- drivers/staging/rts5139/rts51x_fop.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rts5139/rts51x_fop.c b/drivers/staging/rts5139/rts51x_fop.c index 677d18b..cf4e

Re: [PATCH] Staging:Line6:usbdefs.h parenthesis for Marcos

2014-04-16 Thread Greg KH
On Tue, Apr 08, 2014 at 05:11:26PM +0100, Paul McQuade wrote: > ERROR: Macros with complex values should be enclosed in parenthesis > > Signed-off-by: Paul McQuade > --- > drivers/staging/line6/usbdefs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/li

Re: [PATCH 3.14.0/linux-next]: staging/line6: playback.c style corrections

2014-04-16 Thread Greg KH
On Sun, Apr 06, 2014 at 08:53:02AM +0300, Sami Laine wrote: > From: Sami Laine > > Five coding style corrections to drivers/staging/line6/playback.c. > > Signed-Off-by: Sami Laine > --- Sorry, but someone sent this same patch just before you did, so I can't apply yours :( greg k-h ___

Re: [PATCH 1/4] Staging: lustre: Fixed formatting errors in lib-types.h identified by checkpatch.pl

2014-04-16 Thread Greg KH
On Wed, Apr 02, 2014 at 07:12:56PM +1100, Joshua Baldock wrote: > Fixed '{' not on same line as struct in file lib-types.h identified by > checkpatch.pl > > Signed-off-by: Joshua Baldock > --- > drivers/staging/lustre/include/linux/lnet/lib-types.h | 12 > 1 file changed, 4 inserti

Re: [PATCH v2] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-04-16 Thread Greg KH
On Fri, Apr 11, 2014 at 11:04:42AM -0400, Marcos A. Di Pietro wrote: > Fixes code style errors in drivers/staging/bcm/Qos.c > > Patch submitted as part of the Eudyptula Challenge > > Signed-off-by: Marcos A. Di Pietro > --- > drivers/staging/bcm/Qos.c | 7 +-- > 1 file changed, 5 insertions

Re: [PATCH 3/3] Staging:android:uapi:binder.h __packed

2014-04-16 Thread Greg KH
On Tue, Apr 08, 2014 at 07:02:04PM +0100, Paul McQuade wrote: > WARNING: __packed is preferred over __attribute__((packed)) > > Signed-off-by: Paul McQuade > --- > drivers/staging/android/uapi/binder.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Not on uapi .h files, sorry :( _

Re: [PATCH RESEND 2/2] staging: binder: Code simplification

2014-04-16 Thread Greg KH
On Tue, Apr 15, 2014 at 12:03:06PM +0200, Mathieu Maret wrote: > Remove duplicate code > > Signed-off-by: Mathieu Maret > --- > drivers/staging/android/binder.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/android/binder.c > b/drivers/staging/

Re: [PATCH] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-04-16 Thread Greg KH
On Wed, Apr 16, 2014 at 07:39:06PM -0400, Marcos A. Di Pietro wrote: > On 04/16/2014 02:25 PM, Greg KH wrote: > > On Wed, Apr 16, 2014 at 02:18:46PM -0400, Marcos Di Pietro wrote: > >> On Wed, Apr 16, 2014 at 11:39 AM, Greg KH wrote: > >>> On Tue, Apr 15, 2014 at 09:37:18PM -0400, Marcos A. Di Pie

Re: [PATCH] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-04-16 Thread Dan Carpenter
Marcos, you're communicating poorly. You actually sent an ok patch earlier, but then you replied to a different thread "hi did you apply my patch?" and everyone gets confused because you replied to the wrong email. Now you are sending a garbage patch which is not a proper v2 patch and cannot be a

Re: [PATCH 2/2 v3] staging: comedi: addi_apci_1564: fixup and absorb apci1564_reset()

2014-04-16 Thread Chase Southwood
>On Wednesday, April 16, 2014 7:04 PM, Hartley Sweeten > wrote: >>On Wednesday, April 16, 2014 4:53 PM, Chase Southwood wrote: >>>On Wednesday, April 16, 2014 6:36 PM, Hartley Sweeten >>> wrote: On Wednesday, April 16, 2014 4:34 PM, Chase Southwood wrote: Move apci1564_reset() from hwdrv

RE: [PATCH 2/2 v3] staging: comedi: addi_apci_1564: fixup and absorb apci1564_reset()

2014-04-16 Thread Hartley Sweeten
On Wednesday, April 16, 2014 4:53 PM, Chase Southwood wrote: >>On Wednesday, April 16, 2014 6:36 PM, Hartley Sweeten >> wrote: >>>On Wednesday, April 16, 2014 4:34 PM, Chase Southwood wrote: >>>Move apci1564_reset() from hwdrv_apci1564.c to addi_apci_1564.c.  The >>>function was very messy and fai

Re: [PATCH] staging: android: binder.c: avoid sparse checker warning: cast removes address space of expression

2014-04-16 Thread Dan Carpenter
On Wed, Apr 16, 2014 at 10:42:17PM +0200, Yves Deweerdt wrote: > > __user should be kept when casting to struct binder_version * > > Mathieu sent this one earlier. http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2014-April/048614.html His is perfect, except that he missed the

Re: [PATCH 2/2 v3] staging: comedi: addi_apci_1564: fixup and absorb apci1564_reset()

2014-04-16 Thread Chase Southwood
>On Wednesday, April 16, 2014 6:36 PM, Hartley Sweeten > wrote: >>On Wednesday, April 16, 2014 4:34 PM, Chase Southwood wrote: >>Move apci1564_reset() from hwdrv_apci1564.c to addi_apci_1564.c.  The >>function was very messy and failed to reset a couple registers, these >>issues were fixed on the

Re: [PATCH 2/2 V2] staging: r8188eu: Fix case where ethtype was never obtained and always be checked against 0

2014-04-16 Thread Dan Carpenter
On Wed, Apr 16, 2014 at 02:49:34PM -0500, Larry Finger wrote: > if (auth_alg == 2) { > + /* get ether_type */ > + ptr = ptr + pfhdr->attrib.hdrlen + LLC_HEADER_SIZE; > + memcpy(ðer_type, ptr, 2); > + ether_type = ntohs((unsigned short)ether_type

Re: [PATCH] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-04-16 Thread Marcos A. Di Pietro
On 04/16/2014 02:25 PM, Greg KH wrote: > On Wed, Apr 16, 2014 at 02:18:46PM -0400, Marcos Di Pietro wrote: >> On Wed, Apr 16, 2014 at 11:39 AM, Greg KH wrote: >>> On Tue, Apr 15, 2014 at 09:37:18PM -0400, Marcos A. Di Pietro wrote: On 04/10/2014 07:56 PM, Greg KH wrote: > On Thu, Apr 10,

RE: [PATCH 2/2 v3] staging: comedi: addi_apci_1564: fixup and absorb apci1564_reset()

2014-04-16 Thread Hartley Sweeten
On Wednesday, April 16, 2014 4:34 PM, Chase Southwood wrote: > > Move apci1564_reset() from hwdrv_apci1564.c to addi_apci_1564.c. The > function was very messy and failed to reset a couple registers, these > issues were fixed on the move. The commit message needs updated. You are no longer moving

[PATCH 2/2 v3] staging: comedi: addi_apci_1564: fixup and absorb apci1564_reset()

2014-04-16 Thread Chase Southwood
Move apci1564_reset() from hwdrv_apci1564.c to addi_apci_1564.c. The function was very messy and failed to reset a couple registers, these issues were fixed on the move. Signed-off-by: Chase Southwood --- 2: *Changed order of register accesses for digital input registers back to original orderin

RE: [PATCH 2/2 v2] staging: comedi: addi_apci_1564: fixup and absorb apci1564_reset()

2014-04-16 Thread Hartley Sweeten
On Tuesday, April 15, 2014 11:58 PM, Chase Southwood wrote: > We can remove this function from the boardinfo and move the code from > hwdrv_apci1564.c into addi_apci_1564.c since it is the only reset function > used by the driver. The function was also messy and failed to reset a few > registers, t

RE: [PATCH 1/2] staging: comedi: addi_apci_1564: remove use of devpriv->iobase

2014-04-16 Thread Hartley Sweeten
On Monday, April 14, 2014 10:54 PM, Chase Southwood wrote: > devpriv->iobase is currently being used to hold the iobase address used to > read/write the board's registers. The same address is stored in the > comedi_device dev->iobase. We use that instead. The eventual goal is to > decrease the d

RE: [PATCH 02/49] staging: comedi: have core check cmd->chanlist_len min

2014-04-16 Thread Hartley Sweeten
On Wednesday, April 16, 2014 10:52 AM, Ian Abbott wrote: >>> NAK. This will break existing libcomedi library function >>> comedi_get_generic_timed(), which will call the COMEDI_CMDTEST ioctl >>> with a NULL chanlist (but with chanlist_len > 1) and with start_src etc. >>> set to values other than T

[PATCH 14/15] staging: comedi: me4000: tidy up the chanlist checking

2014-04-16 Thread H Hartley Sweeten
The ai_check_chanlist() function validates that the cmd->chanlist is compatible with the hardware. This is step 5 of the (*do_cmdtest). For aesthetics, rename this function so it has namespace associated with the driver and tidy up the code. To minimize the noise, change the dev_err() to dev_dbg(

[PATCH 15/15] staging: comedi: ni_labpc: tidy up the chanlist checking

2014-04-16 Thread H Hartley Sweeten
The labpc_ai_chanlist_invalid() function validates that the cmd->chanlist is compatible with the hardware. This is step 5 of the (*do_cmdtest). For aesthetics, rename this function and tidy up the code. To minimize the noise, change the comedi_error(), which is a wrapper around dev_err(), to dev_

[PATCH 04/15] staging: comedi: cb_pcidas: factor out chanlist checking from (*do_cmdtest)

2014-04-16 Thread H Hartley Sweeten
Step 5 of the (*do_cmdtest) validates that the cmd->chanlist is compatible with the hardware. For aesthetics, factor out the step 5 code for the analog input and analog output async command support. Tidy up the factored out code. To minimize the noise, change the comedi_error(), which is a wrappe

[PATCH 13/15] staging: comedi: ni_mio_common: factor out chanlist checking from (*do_cmdtest)

2014-04-16 Thread H Hartley Sweeten
Step 5 of the (*do_cmdtest) validates that the cmd->chanlist is compatible with the hardware. Remove the unnecessary step 5 code in the analog output async command support. For aesthetics, factor out the step 5 code for the "cdio" async command support. Tidy up the factored out code. Signed-off-

[PATCH 12/15] staging: comedi: ni_at_a2150: factor out chanlist checking from (*do_cmdtest)

2014-04-16 Thread H Hartley Sweeten
Step 5 of the (*do_cmdtest) validates that the cmd->chanlist is compatible with the hardware. For aesthetics, factor out the step 5 code for the analog input async command support. Tidy up the factored out code. To minimize the noise, change the comedi_error(), which is a wrapper around dev_err()

[PATCH 03/15] staging: comedi: amplc_pci230: factor out chanlist checking from (*do_cmdtest)

2014-04-16 Thread H Hartley Sweeten
Step 5 of the (*do_cmdtest) validates that the cmd->chanlist is compatible with the hardware. For aesthetics, factor out the step 5 code for the analog output and analog input async command support. Tidy up the factored out code. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Ha

[PATCH 05/15] staging: comedi: cb_pcidas64: factor out chanlist checking from (*do_cmdtest)

2014-04-16 Thread H Hartley Sweeten
Step 5 of the (*do_cmdtest) validates that the cmd->chanlist is compatible with the hardware. For aesthetics, factor out the step 5 code for the analog input and analog output async command support. Tidy up the factored out code. To minimize the noise, change the comedi_error(), which is a wrappe

[PATCH 00/15] staging: comedi: drivers: cleanup step 5 of (*do_cmdtest)

2014-04-16 Thread H Hartley Sweeten
Step 5 of the (*do_cmdtest) validates that the cmd->chanlist is compatible with the hardware. As pointed out by Ian Abbott, some of the step 5 operations are buggy because they access the cmd->chanlist[] without checking the cmd->chanlist_len. This series factors out step 5 from (*do_cmdtest) fun

[PATCH 09/15] staging: comedi: das800: factor out chanlist checking from (*do_cmdtest)

2014-04-16 Thread H Hartley Sweeten
Step 5 of the (*do_cmdtest) validates that the cmd->chanlist is compatible with the hardware. For aesthetics, factor out the step 5 code for the analog input async command support. Tidy up the factored out code. To minimize the noise, change the dev_err() to dev_dbg(). Signed-off-by: H Hartley S

[PATCH 10/15] staging: comedi: dmm32at: factor out chanlist checking from (*do_cmdtest)

2014-04-16 Thread H Hartley Sweeten
Step 5 of the (*do_cmdtest) validates that the cmd->chanlist is compatible with the hardware. For aesthetics, factor out the step 5 code for the analog input async command support. Tidy up the factored out code. To minimize the noise, change the comedi_error(), which is a wrapper around dev_err()

[PATCH 01/15] staging: comedi: adl_pci9111: factor out chanlist checking from (*do_cmdtest)

2014-04-16 Thread H Hartley Sweeten
Step 5 of the (*do_cmdtest) validates that the cmd->chanlist is compatible with the hardware. For aesthetics, factor out the step 5 code for the analog input async command support. Tidy up the factored out code. To minimize the noise, change the comedi_err(), which is a wrapper around dev_err(),

[PATCH 08/15] staging: comedi: das1800: factor out chanlist checking from (*do_cmdtest)

2014-04-16 Thread H Hartley Sweeten
Step 5 of the (*do_cmdtest) validates that the cmd->chanlist is compatible with the hardware. For aesthetics, factor out the step 5 code for the analog input async command support. Tidy up the factored out code. To minimize the noise, change the comedi_error(), which is a wrapper around dev_err()

[PATCH 06/15] staging: comedi: das16: factor out chanlist checking from (*do_cmdtest)

2014-04-16 Thread H Hartley Sweeten
Step 5 of the (*do_cmdtest) validates that the cmd->chanlist is compatible with the hardware. For aesthetics, factor out the step 5 code for the analog input async command support. Tidy up the factored out code. To minimize the noise, change the dev_err() to dev_dbg(). Signed-off-by: H Hartley S

[PATCH 07/15] staging: comedi: das16m1: factor out chanlist checking from (*do_cmdtest)

2014-04-16 Thread H Hartley Sweeten
Step 5 of the (*do_cmdtest) validates that the cmd->chanlist is compatible with the hardware. For aesthetics, factor out the step 5 code for the analog input async command support. Tidy up the factored out code. To minimize the noise, change the comedi_error(), which is a wrapper around dev_err()

[PATCH 11/15] staging: comedi: gsc_hpdi: factor out chanlist checking from (*do_cmdtest)

2014-04-16 Thread H Hartley Sweeten
Step 5 of the (*do_cmdtest) validates that the cmd->chanlist is compatible with the hardware. For aesthetics, factor out the step 5 code for the async command support. Tidy up the factored out code. To minimize the noise, change the dev_err() to dev_dbg(). Signed-off-by: H Hartley Sweeten Cc: I

[PATCH 02/15] staging: comedi: amplc_pci224: factor out chanlist checking from (*do_cmdtest)

2014-04-16 Thread H Hartley Sweeten
Step 5 of the (*do_cmdtest) validates that the cmd->chanlist is compatible with the hardware. For aesthetics, factor the step 5 code for the analog output async command support. Tidy up the factored out code. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/s

[PATCH] staging: android: binder.c: avoid sparse checker warning: cast removes address space of expression

2014-04-16 Thread Yves Deweerdt
__user should be kept when casting to struct binder_version * Signed-off-by: Yves Deweerdt --- drivers/staging/android/binder.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c index cfe4bc8..0f74e4

[PATCH 2/2 V2] staging: r8188eu: Fix case where ethtype was never obtained and always be checked against 0

2014-04-16 Thread Larry Finger
Zero-initializing ether_type masked that the ether type would never be obtained for 8021x packets and the comparison against eapol_type would always fail. Reported-by: Jes Sorensen Signed-off-by: Larry Finger Cc: Stable --- drivers/staging/rtl8188eu/core/rtw_recv.c | 15 ++- 1 file

[PATCH 1/2 V2] staging: r8712u: Fix case where ethtype was never obtained and always be checked against 0

2014-04-16 Thread Larry Finger
Zero-initializing ether_type masked that the ether type would never be obtained for 8021x packets and the comparison against eapol_type would always fail. Reported-by: Jes Sorensen Signed-off-by: Larry Finger Cc: Stable --- drivers/staging/rtl8712/rtl871x_recv.c | 13 ++--- 1 file chan

Re: [PATCH] staging : android : uapi : fix coding style

2014-04-16 Thread Joe Perches
(adding John Stultz) On Wed, 2014-04-16 at 23:27 +0900, Seunghun Lee wrote: > This patch fix checkpatch.pl warnings and errors. [] > diff --git a/drivers/staging/android/uapi/binder.h > b/drivers/staging/android/uapi/binder.h [] > @@ -169,7 +169,7 @@ struct binder_ptr_cookie { > struct binder_ha

Re: [PATCH 3/3] staging: r8712u: Fix case where ethtype was never obtained and always be checked against 0

2014-04-16 Thread Greg KH
On Wed, Apr 09, 2014 at 11:13:00AM -0500, Larry Finger wrote: > Zero-initializing ether_type masked that the ether type would never be > obtained for 8021x packets and the comparition against eapol_type > would always fail. > > Reported-by: Jes Sorensen > Signed-off-by: Larry Finger > Cc: Stable

Re: [PATCH 2/3] staging: r8188eu: Fix case where ethtype was never obtained and always be checked against 0

2014-04-16 Thread Greg KH
On Wed, Apr 09, 2014 at 11:12:59AM -0500, Larry Finger wrote: > Zero-initializing ether_type masked that the ether type would never be > obtained for 8021x packets and the comparition against eapol_type > would always fail. > > Reported-by: Jes Sorensen > Signed-off-by: Larry Finger > Cc: Stable

Re: [PATCH] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-04-16 Thread Greg KH
On Wed, Apr 16, 2014 at 02:18:46PM -0400, Marcos Di Pietro wrote: > On Wed, Apr 16, 2014 at 11:39 AM, Greg KH wrote: > > On Tue, Apr 15, 2014 at 09:37:18PM -0400, Marcos A. Di Pietro wrote: > >> On 04/10/2014 07:56 PM, Greg KH wrote: > >> > On Thu, Apr 10, 2014 at 07:27:27PM -0400, Marcos A. Di Pi

Re: [PATCH] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-04-16 Thread Marcos Di Pietro
On Wed, Apr 16, 2014 at 11:39 AM, Greg KH wrote: > On Tue, Apr 15, 2014 at 09:37:18PM -0400, Marcos A. Di Pietro wrote: >> On 04/10/2014 07:56 PM, Greg KH wrote: >> > On Thu, Apr 10, 2014 at 07:27:27PM -0400, Marcos A. Di Pietro wrote: >> >>> That's pretty obviously not going to apply properly, yo

Re: [PATCH 02/49] staging: comedi: have core check cmd->chanlist_len min

2014-04-16 Thread Ian Abbott
On 2014-04-16 17:44, Hartley Sweeten wrote: On Wednesday, April 16, 2014 8:57 AM, Ian Abbott wrote: On 2014-04-15 18:37, H Hartley Sweeten wrote: The only time the chanlist can be NULL and chanlist_len < 1 is when a COMEDI_CMDTEST ioctl is done, usually for the comedilib function comedi_get_cmd

Re: [PATCH 19/49] staging: comedi: ni_mio_common: factor out step 5 of (*do_cmdtest)

2014-04-16 Thread Ian Abbott
On 2014-04-15 18:37, H Hartley Sweeten wrote: Step 5 of the (*do_cmdtest) validates that the chanlist, chan/range/aref/etc, is compatible with the actual hardware. At this point in the (*do_cmdtest) the chanlist is valid, due to checks in the core, so the sanity check is not needed. For aestheti

Re: [PATCH 18/49] staging: comedi: ni_labpc: cleanup labpc_ai_chanlist_invalid()

2014-04-16 Thread Ian Abbott
On 2014-04-15 18:37, H Hartley Sweeten wrote: This is the Step 5 helper function of the (*do_cmdtest). It validates that the chanlist, chan/range/aref/etc, is compatible with the actual hardware. At this point in the (*do_cmdtest) the chanlist is valid, due to checks in the core, so any sanity ch

Re: [PATCH] staging : android : uapi : fix coding style

2014-04-16 Thread Colin Cross
(resending without the html) On Wed, Apr 16, 2014 at 9:36 AM, John Stultz wrote: > > On 04/16/2014 07:39 AM, Joe Perches wrote: > > On Wed, 2014-04-16 at 23:27 +0900, Seunghun Lee wrote: > >> This patch fix checkpatch.pl warnings and errors. > > [] > >> diff --git a/drivers/staging/android/uapi/b

Re: [PATCH 15/49] staging: comedi: gsc_hpdi: factor out step 5 of (*do_cmdtest)

2014-04-16 Thread Ian Abbott
On 2014-04-15 18:37, H Hartley Sweeten wrote: Step 5 of the (*do_cmdtest) validates that the chanlist, chan/range/aref/etc, is compatible with the actual hardware. At this point in the (*do_cmdtest) the chanlist is valid, due to checks in the core, so the sanity check is not needed. For aestheti

Re: [PATCH 17/49] staging: comedi: ni_at_a2150: factor out step 5 of (*do_cmdtest)

2014-04-16 Thread Ian Abbott
On 2014-04-15 18:37, H Hartley Sweeten wrote: Step 5 of the (*do_cmdtest) validates that the chanlist, chan/range/aref/etc, is compatible with the actual hardware. At this point in the (*do_cmdtest) the chanlist is valid, due to checks in the core, so the sanity check is not needed. For aestheti

Re: [PATCH 16/49] staging: comedi: me4000: cleanup ai_check_chanlist()

2014-04-16 Thread Ian Abbott
On 2014-04-15 18:37, H Hartley Sweeten wrote: This is the Step 5 helper function of the (*do_cmdtest). It validates that the chanlist, chan/range/aref/etc, is compatible with the actual hardware. At this point in the (*do_cmdtest) the chanlist is valid, due to checks in the core, so any sanity ch

Re: [PATCH 14/49] staging: comedi: dmm32at: factor out step 5 of (*do_cmdtest)

2014-04-16 Thread Ian Abbott
On 2014-04-15 18:37, H Hartley Sweeten wrote: Step 5 of the (*do_cmdtest) validates that the chanlist, chan/range/aref/etc, is compatible with the actual hardware. At this point in the (*do_cmdtest) the chanlist is valid, due to checks in the core, so the sanity check is not needed. For aestheti

Re: [PATCH 13/49] staging: comedi: das800: factor out step 5 of (*do_cmdtest)

2014-04-16 Thread Ian Abbott
On 2014-04-15 18:37, H Hartley Sweeten wrote: Step 5 of the (*do_cmdtest) validates that the chanlist, chan/range/aref/etc, is compatible with the actual hardware. At this point in the (*do_cmdtest) the chanlist is valid, due to checks in the core, so the sanity check is not needed. For aestheti

RE: [PATCH 02/49] staging: comedi: have core check cmd->chanlist_len min

2014-04-16 Thread Hartley Sweeten
On Wednesday, April 16, 2014 8:57 AM, Ian Abbott wrote: > On 2014-04-15 18:37, H Hartley Sweeten wrote: >> The only time the chanlist can be NULL and chanlist_len < 1 is when a >> COMEDI_CMDTEST ioctl is done, usually for the comedilib function >> comedi_get_cmd_src_mask(). This comedilib function

Re: [PATCH 12/49] staging: comedi: das1800: factor out step 5 of (*do_cmdtest)

2014-04-16 Thread Ian Abbott
On 2014-04-15 18:37, H Hartley Sweeten wrote: Step 5 of the (*do_cmdtest) validates that the chanlist, chan/range/aref/etc, is compatible with the actual hardware. At this point in the (*do_cmdtest) the chanlist is valid, due to checks in the core, so the sanity check is not needed. For aestheti

Re: [PATCH 11/49] staging: comedi: das16m1: factor out step 5 of (*do_cmdtest)

2014-04-16 Thread Ian Abbott
On 2014-04-15 18:37, H Hartley Sweeten wrote: Step 5 of the (*do_cmdtest) validates that the chanlist, chan/range/aref/etc, is compatible with the actual hardware. At this point in the (*do_cmdtest) the chanlist is valid, due to checks in the core, so the sanity check is not needed. For aestheti

Re: [PATCH 10/49] staging: comedi: das16: factor out step 5 of (*do_cmdtest)

2014-04-16 Thread Ian Abbott
On 2014-04-15 18:37, H Hartley Sweeten wrote: Step 5 of the (*do_cmdtest) validates that the chanlist, chan/range/aref/etc, is compatible with the actual hardware. At this point in the (*do_cmdtest) the chanlist is valid, due to checks in the core, so the sanity check is not needed. For aestheti

Re: [PATCH 09/49] staging: comedi: cb_pcidas64: factor out step 5 of (*do_cmdtest)

2014-04-16 Thread Ian Abbott
On 2014-04-15 18:37, H Hartley Sweeten wrote: Step 5 of the (*do_cmdtest) validates that the chanlist, chan/range/aref/etc, is compatible with the actual hardware. At this point in the (*do_cmdtest) the chanlist is valid, due to checks in the core, so the sanity check is not needed. For aestheti

Re: [PATCH] staging : android : uapi : fix coding style

2014-04-16 Thread John Stultz
On 04/16/2014 07:39 AM, Joe Perches wrote: > On Wed, 2014-04-16 at 23:27 +0900, Seunghun Lee wrote: >> This patch fix checkpatch.pl warnings and errors. > [] >> diff --git a/drivers/staging/android/uapi/binder.h >> b/drivers/staging/android/uapi/binder.h > [] >> @@ -169,7 +169,7 @@ struct binder_p

Re: [PATCH 08/49] staging: comedi: cb_pcidas: factor out step 5 of (*do_cmdtest)

2014-04-16 Thread Ian Abbott
On 2014-04-15 18:37, H Hartley Sweeten wrote: Step 5 of the (*do_cmdtest) validates that the chanlist, chan/range/aref/etc, is compatible with the actual hardware. At this point in the (*do_cmdtest) the chanlist is valid, due to checks in the core, so the sanity check is not needed. For aestheti

Re: [PATCH 07/49] staging: comedi: amplc_pci230: factor out step 5 of (*do_cmdtest)

2014-04-16 Thread Ian Abbott
On 2014-04-15 18:37, H Hartley Sweeten wrote: Step 5 of the (*do_cmdtest) validates that the chanlist, chan/range/aref/etc, is compatible with the actual hardware. At this point in the (*do_cmdtest) the chanlist is valid, due to checks in the core, so the sanity check is not needed. For aestheti

Re: [PATCH 06/49] staging: comedi: amplc_pci224: factor out step 5 of (*do_cmdtest)

2014-04-16 Thread Ian Abbott
On 2014-04-15 18:37, H Hartley Sweeten wrote: Step 5 of the (*do_cmdtest) validates that the chanlist, chan/range/aref/etc, is compatible with the actual hardware. At this point in the (*do_cmdtest) the chanlist is valid, due to checks in the core, so the sanity check is not needed. For aestheti

Re: [PATCH 05/49] staging: comedi: adl_pci9111: factor out step 5 of (*do_cmdtest)

2014-04-16 Thread Ian Abbott
On 2014-04-15 18:37, H Hartley Sweeten wrote: Step 5 of the (*do_cmdtest) validates that the chanlist, chan/range/aref/etc, is compatible with the actual hardware. At this point in the (*do_cmdtest) the chanlist is valid, due to checks in the core, so the sanity check is not needed. For aestheti

Re: [PATCH 05/49] staging: comedi: adl_pci9111: factor out step 5 of (*do_cmdtest)

2014-04-16 Thread Ian Abbott
On 2014-04-16 09:18, Dan Carpenter wrote: On Tue, Apr 15, 2014 at 10:37:25AM -0700, H Hartley Sweeten wrote: Step 5 of the (*do_cmdtest) validates that the chanlist, chan/range/aref/etc, ^^ Numbering the steps like this seems a bad idea in case we add another step in the middle. regards

Re: [PATCH 02/49] staging: comedi: have core check cmd->chanlist_len min

2014-04-16 Thread Ian Abbott
On 2014-04-15 18:37, H Hartley Sweeten wrote: The only time the chanlist can be NULL and chanlist_len < 1 is when a COMEDI_CMDTEST ioctl is done, usually for the comedilib function comedi_get_cmd_src_mask(). This comedilib function sets all the command sources to TRIG_ANY and Step 1 of the (*do_c

[PATCH] staging: android: uapi: fix coding style

2014-04-16 Thread Seunghun Lee
This patch fix checkpatch.pl warning and errors. Signed-off-by: Seunghun Lee --- drivers/staging/android/uapi/ion.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h index f09e7c1..6aa4956 1

Re: [PATCH] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-04-16 Thread Greg KH
On Tue, Apr 15, 2014 at 09:37:18PM -0400, Marcos A. Di Pietro wrote: > On 04/10/2014 07:56 PM, Greg KH wrote: > > On Thu, Apr 10, 2014 at 07:27:27PM -0400, Marcos A. Di Pietro wrote: > >>> That's pretty obviously not going to apply properly, you have line-wrapp > >>> on. You can't cut-and-paste pa

Re: [PATCH] staging : android : uapi : fix coding style

2014-04-16 Thread earl
On 04/16/2014 11:44 PM, Dan Carpenter wrote: Subject is not correct format. Should be: [PATCH] staging: android: uapi: fix coding style On Wed, Apr 16, 2014 at 11:27:39PM +0900, Seunghun Lee wrote: This patch fix checkpatch.pl warnings and errors. Patch does too many things at once. Split

Re: [PATCH] staging : android : uapi : fix coding style

2014-04-16 Thread Dan Carpenter
Subject is not correct format. Should be: [PATCH] staging: android: uapi: fix coding style On Wed, Apr 16, 2014 at 11:27:39PM +0900, Seunghun Lee wrote: > This patch fix checkpatch.pl warnings and errors. > Patch does too many things at once. Split it up. > Signed-off-by: Seunghun Lee > ---

[PATCH] staging : android : uapi : fix coding style

2014-04-16 Thread Seunghun Lee
This patch fix checkpatch.pl warnings and errors. Signed-off-by: Seunghun Lee --- drivers/staging/android/uapi/binder.h |2 +- drivers/staging/android/uapi/ion.h| 20 +--- 2 files changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/staging/android/uapi/bind

Re: [PATCH 2/2 v2] staging: comedi: addi_apci_1564: fixup and absorb apci1564_reset()

2014-04-16 Thread Ian Abbott
On 2014-04-16 07:57, Chase Southwood wrote: We can remove this function from the boardinfo and move the code from hwdrv_apci1564.c into addi_apci_1564.c since it is the only reset function used by the driver. The function was also messy and failed to reset a few registers, these issues were fixed

[PATCH/RESENT] staging] speakup: fix typo in kobjects.c

2014-04-16 Thread Hayato Suzuki
Correct spelling typo in kobjects.c Signed-off-by: Hayato Suzuki Acked-by: Samuel Thibault --- drivers/staging/speakup/kobjects.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c index 1ca91f7..7495b89 1

Re: [PATCH v7 2/4] [v6 fix] mfd/rtsx_usb: add comment in rtsx_usb_suspend

2014-04-16 Thread Lee Jones
On Fri, 11 Apr 2014, rogera...@realtek.com wrote: > From: Roger Tseng > > Explain why there is no need to have a symmetric LED turn-on in resume handler > while calling rtsx_usb_turn_off_led() in suspend handler. > > Signed-off-by: Roger Tseng > --- > drivers/mfd/rtsx_usb.c | 6 ++ > 1 fi

Re: [PATCH v7 1/4] [v6 fix] mfd/rtsx_usb: fix possible race condition

2014-04-16 Thread Lee Jones
> From: Roger Tseng > > Fix two possible race condition generated by misuse of del_timer in > rtsx_usb_bulk_transfer_sglist() and uninitialized timers before > mfd_add_devices > in rtsx_usb_probe(). > > Signed-off-by: Roger Tseng > --- > drivers/mfd/rtsx_usb.c | 8 > 1 file changed,

[staging:staging-next 133/193] drivers/staging/rtl8723au/core/rtw_mlme_ext.c:1236 OnAssocReq23a() error: we previously assumed 'p' could be null (see line 1234)

2014-04-16 Thread Dan Carpenter
tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next head: dff222670ebebf1a7f147a23ccb5fc0312f2ae7e commit: da290c54610f49ef475f7f88668259216b08fc36 [133/193] staging: rtl8723au: OnAssocReq23a(): Clean up and use more ieee80211.h New smatch warnings: drivers/st

Re: [PATCH 05/49] staging: comedi: adl_pci9111: factor out step 5 of (*do_cmdtest)

2014-04-16 Thread Dan Carpenter
On Tue, Apr 15, 2014 at 10:37:25AM -0700, H Hartley Sweeten wrote: > Step 5 of the (*do_cmdtest) validates that the chanlist, chan/range/aref/etc, ^^ Numbering the steps like this seems a bad idea in case we add another step in the middle. regards, dan carpenter

Re: [PATCH v7 4/4] memstick: Add realtek USB memstick host driver

2014-04-16 Thread Lee Jones
Hi Andrew, > From: Roger Tseng > > Realtek USB memstick host driver provides memstick host support based on the > Realtek USB card reader MFD driver. > > Signed-off-by: Roger Tseng > --- > drivers/memstick/host/Kconfig | 10 + > drivers/memstick/host/Makefile | 1 + > drivers/me

Re: [PATCH v7 0/4] Add modules for realtek USB card reader

2014-04-16 Thread Lee Jones
> From: Roger Tseng > > This patchset adds modules to support Realtek USB vendor specific class > flash > card reader: one base module in MFD subsystem and two host modules in > both mmc > and memstick subsystems. The architecture is similar to rtsx_pci. > > >>>

Re: [PATCH] staging: dgrp: Fixed coding style

2014-04-16 Thread Jingoo Han
On Wednesday, April 16, 2014 4:44 PM, Dan Carpenter wrote: > On Tue, Apr 15, 2014 at 05:54:39PM -0700, Thomas Tanaka wrote: > > Fixed line width > 80 > > > > Signed-off-by: Thomas Tanaka > > --- > > drivers/staging/dgrp/dgrp_sysfs.c |4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH] Staging:bcm: Fixes coding style issues in drivers/staging/bcm/Qos.c

2014-04-16 Thread Dan Carpenter
On Tue, Apr 15, 2014 at 09:37:18PM -0400, Marcos A. Di Pietro wrote: > > Greg, > > Where you able to apply the patch successfully? > Silence means Greg hasn't gotten around to it and no one else has an issue with the patch. Silence after 2 weeks means either the merge window was open or maybe

Re: [PATCH] staging: dgrp: Fixed coding style

2014-04-16 Thread Dan Carpenter
On Tue, Apr 15, 2014 at 05:54:39PM -0700, Thomas Tanaka wrote: > Fixed line width > 80 > > Signed-off-by: Thomas Tanaka > --- > drivers/staging/dgrp/dgrp_sysfs.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/dgrp/dgrp_sysfs.c > b/drivers/stagi

Re: [PATCH v7 0/4] Add modules for realtek USB card reader

2014-04-16 Thread Ulf Hansson
On 16 April 2014 05:19, Roger wrote: > On 04/11/2014 06:36 PM, Oliver Neukum wrote: >> >> On Fri, 2014-04-11 at 11:28 +0100, Lee Jones wrote: > > From: Roger Tseng > > This patchset adds modules to support Realtek USB vendor specific class > flash > card reader: one base m