Re: [PATCH] fix the code style errors in sn9c102

2014-04-19 Thread Jianyu Zhan
On Sat, Apr 19, 2014 at 11:09 AM, Jinqiang Zeng jinqiangz...@gmail.com wrote: --- drivers/staging/media/sn9c102/sn9c102.h| 30 +- drivers/staging/media/sn9c102/sn9c102_core.c | 342 ++-- drivers/staging/media/sn9c102/sn9c102_devtable.h | 22 +-

[PATCH] Staging: imx-drm: Fix some lines over 80 characters

2014-04-19 Thread Antoine Schweitzer-Chaput
Signed-off-by: Antoine Schweitzer-Chaput anto...@schweitzer-chaput.fr --- drivers/staging/imx-drm/ipu-v3/ipu-common.c | 6 -- drivers/staging/imx-drm/ipu-v3/ipu-dc.c | 3 ++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-common.c

Re: [PATCH] Staging: crystalhd: Mark local functions as static

2014-04-19 Thread bojan prtvar
On Sat, Apr 19, 2014 at 1:23 AM, Greg KH gre...@linuxfoundation.org wrote: On Fri, Apr 18, 2014 at 07:57:51PM +0200, Bojan Prtvar wrote: This fixes the following sparse warnings: drivers/staging/crystalhd/crystalhd_lnx.c:631:5: warning: symbol 'chd_dec_pci_suspend' was not declared. Should it

Re: [PATCH] Staging: crystalhd: Mark local functions as static

2014-04-19 Thread bojan prtvar
On Sat, Apr 19, 2014 at 9:58 AM, bojan prtvar prtva...@gmail.com wrote: On Sat, Apr 19, 2014 at 1:23 AM, Greg KH gre...@linuxfoundation.org wrote: On Fri, Apr 18, 2014 at 07:57:51PM +0200, Bojan Prtvar wrote: This fixes the following sparse warnings:

Re: [PATCH 02/02] linux-next: staging: gdm72xx: Fix naked sscanf

2014-04-19 Thread Dan Carpenter
On Thu, Apr 17, 2014 at 04:31:44PM +0300, Alexandr Terekhov wrote: Fix naked sscanf Signed-off-by: Alexandr Terekhov alexandr_terek...@epam.com Sign off with the email you use to send patches so we can at least try to verify that the are real. diff --git

[PATCH 1/9] staging: rtl8821ae: Remove file #if 1

2014-04-19 Thread Mark Einon
All code in this file is encapsulated in a useless #if 1 declaration, remove it. Signed-off-by: Mark Einon m...@einon.net --- drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git

[PATCH 9/9] staging: rtl8821ae: don't initialise statics to 0 or NULL in halbtc8192e2ant.c

2014-04-19 Thread Mark Einon
Fixes all checkpatch errors reporting that statics shouldn't be initialised to their defualt values. Signed-off-by: Mark Einon m...@einon.net --- drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 5/9] staging: rtl8821ae: Remove declaration assignment to zero

2014-04-19 Thread Mark Einon
We set btrssi to zero and then immediately assign it. Assign it on declaration instead. Signed-off-by: Mark Einon m...@einon.net --- drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH 7/9] staging: rtl8821ae: halbtc8192e2ant.c fix checkpatch leading spaces/tabs issues

2014-04-19 Thread Mark Einon
Fix checkpatch issues relating to using leading spaces instead of tabs. Whitespace changes only. Signed-off-by: Mark Einon m...@einon.net --- .../staging/rtl8821ae/btcoexist/halbtc8192e2ant.c | 42 ++-- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git

[PATCH 4/9] staging: rtl8821ae: Fix halbtc8192e2ant.c 'defined but not used' sparse warnings

2014-04-19 Thread Mark Einon
Sparse complains about halbtc8192e2ant_low_penalty_ra() not being used, and subsequently halbtc8192e2ant_set_sw_penalty_tx_rateadaptive() when this is removed. remove both functions. Signed-off-by: Mark Einon m...@einon.net --- .../staging/rtl8821ae/btcoexist/halbtc8192e2ant.c | 48

[PATCH 3/9] staging: rtl8821ae: Fix halbtc8192e2ant.c 'should it be static?' sparse warnings

2014-04-19 Thread Mark Einon
In halbtc8192e2ant.c, fix all instances of the sparse warning: warning: symbol 'xxx' was not declared. Should it be static? Signed-off-by: Mark Einon m...@einon.net --- .../staging/rtl8821ae/btcoexist/halbtc8192e2ant.c | 218 ++-- 1 file changed, 114 insertions(+), 104

[PATCH 8/9] staging: rtl8821ae: Fix indetentation of switch case statements

2014-04-19 Thread Mark Einon
Fixes checkpatch error: ERROR: switch and case should be at the same indent + switch (coex_dm-cur_retrylimit_type) { + case 0: /* normal mode */ [...] + case 1: /* retry limit=8 */ [...] + default: Signed-off-by:

[PATCH 6/9] staging: rtl8821ae: Fix checkpatch whitespace issues

2014-04-19 Thread Mark Einon
Whitespace changes only to appease checkpatch warnings. Signed-off-by: Mark Einon m...@einon.net --- .../staging/rtl8821ae/btcoexist/halbtc8192e2ant.c | 100 ++-- 1 file changed, 50 insertions(+), 50 deletions(-) diff --git

[PATCH 2/9] staging: rtl8821ae: Remove unused functions

2014-04-19 Thread Mark Einon
Remove functions not being called from anywhere: halbtc8192e2ant_set_adc_backoff() halbtc8192e2ant_adc_backoff() Signed-off-by: Mark Einon m...@einon.net --- .../staging/rtl8821ae/btcoexist/halbtc8192e2ant.c | 38 1 file changed, 38 deletions(-) diff --git

[PATCH v2 0/2] staging: rtl8188eu: fix checkpatch errors.

2014-04-19 Thread Konrad Zapalowicz
This patch removes the following checkpatch errors: rtl8188eu/core/rtw_p2p.c: - 1508: ERROR: code indent should use tabs where possible - 1509: ERROR: code indent should use tabs where possible - 1510: ERROR: code indent should use tabs where possible rtl8188eu/core/rtw_recv.c -

[PATCH v2 1/2] staging: rtl8188eu: fix spaces instead of tabs for rtw_p2p.c

2014-04-19 Thread Konrad Zapalowicz
This commit fixes the following checkpatch errors: rtl8188eu/core/rtw_p2p.c - 1508: ERROR: code indent should use tabs where possible - 1509: ERROR: code indent should use tabs where possible - 1510: ERROR: code indent should use tabs where possible Signed-off-by: Konrad Zapalowicz

[PATCH v2 2/2] staging: rtl8188eu: fix spaces instead of tabs for rtw_recv.c

2014-04-19 Thread Konrad Zapalowicz
This commit fixes the following checkpatch errors: rtl8188eu/core/rtw_recv.c - 1874: ERROR: code indent should use tabs where possible Signed-off-by: Konrad Zapalowicz bergo.tor...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_recv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: r8192e_pci driver broken 3.14+

2014-04-19 Thread Sean MacLennan
A sparse error fixup removed a htons() which is required for the driver to function. Put the htons() back. Signed-off-by: Sean MacLennan se...@seanm.ca --- diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c index 11d0a9d..3e79bff 100644 ---

Re: r8192e_pci driver broken 3.14+

2014-04-19 Thread Sean MacLennan
Fix a sparse error in the htons() call. htons() returns a __be16 not a u16. Signed-off-by: Sean MacLennan se...@seanm.ca --- diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c index 3e79bff..b7dd153 100644 --- a/drivers/staging/rtl8192e/rtllib_tx.c +++

Re: r8192e_pci driver broken 3.14+

2014-04-19 Thread Greg KH
On Sat, Apr 19, 2014 at 02:12:34PM -0400, Sean MacLennan wrote: Fix a sparse error in the htons() call. htons() returns a __be16 not a u16. Signed-off-by: Sean MacLennan se...@seanm.ca --- You sent 2 patches, which should I apply? I've deleted both from my inbox, please resend the proper

Re: r8192e_pci driver broken 3.14+

2014-04-19 Thread Sean MacLennan
On Sat, 19 Apr 2014 11:17:23 -0700 Greg KH gre...@linuxfoundation.org wrote: On Sat, Apr 19, 2014 at 02:12:34PM -0400, Sean MacLennan wrote: Fix a sparse error in the htons() call. htons() returns a __be16 not a u16. Signed-off-by: Sean MacLennan se...@seanm.ca --- You sent 2

Re: r8192e_pci driver broken 3.14+

2014-04-19 Thread Greg KH
On Sat, Apr 19, 2014 at 03:10:04PM -0400, Sean MacLennan wrote: On Sat, 19 Apr 2014 11:17:23 -0700 Greg KH gre...@linuxfoundation.org wrote: On Sat, Apr 19, 2014 at 02:12:34PM -0400, Sean MacLennan wrote: Fix a sparse error in the htons() call. htons() returns a __be16 not a u16.

Re: [PATCH v2 3/4] staging: vt6655: remove dead code

2014-04-19 Thread Guido Martínez
On Fri, Apr 18, 2014 at 04:09:58PM -0700, Greg KH wrote: This patch does not apply, can you refresh it, and the 4/4 patch, against my latest tree and resend? Sending them now as v3. I'm not sure a v3 is most fitting for this situation, so please tell me if you want me to resend them in a

[PATCH v3 0/2] staging: vt6655: style fixes

2014-04-19 Thread Guido Martínez
Update the third and fourth v2 patches to apply cleanly on greg's current tree. Guido Martínez (2): staging: vt6655: remove dead code staging: vt6655: fix checkpatch bracing issues drivers/staging/vt6655/IEEE11h.c | 6 - drivers/staging/vt6655/baseband.c| 101 -

[PATCH] r8192e_pci driver broken 3.14+

2014-04-19 Thread Sean MacLennan
A sparse error fixup removed a htons() which is required for the driver to function. This patch puts the htons() back and fixes the sparse warning correctly by changing the left side cast. Signed-off-by: Sean MacLennan se...@seanm.ca --- diff --git a/drivers/staging/rtl8192e/rtllib_tx.c

[PATCH 1/2] Staging: dgnc: dgnc_driver: fixed coding style of dgnc_pci_tbl

2014-04-19 Thread Son P. Nguyen
From: Son P. Nguyen fastmu...@gmail.com Fixed coding style of dgnc_pci_tbl definition (longer than 80 chars) Signed-off-by: Son P. Nguyen fastmu...@gmail.com --- drivers/staging/dgnc/dgnc_driver.c | 36 +++- 1 file changed, 19 insertions(+), 17 deletions(-) diff

[PATCH 2/2] Staging: dgnc: dgnc_driver: fixed coding style braces

2014-04-19 Thread Son P. Nguyen
From: Son P. Nguyen fastmu...@gmail.com Fixed incorrect braces (coding style) PS: This is for task 10 of eudyptula-challenge. Signed-off-by: Son P. Nguyen fastmu...@gmail.com --- drivers/staging/dgnc/dgnc_driver.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff

[PATCH] Staging: rtl8192e: Fix declaration of symbols

2014-04-19 Thread Joel Pelaez Jorge
The two declarations with issues in rtl_wx.h: * function: struct iw_statistics *r8192_get_wireless_stats(); * variable: extern struct iw_handler_def r8192_wx_handlers_def; The symbol 'r8192_get_wireless_stats' is declared as 'extern' but it is only used in the local scope. The declaration is

[PATCH v2 0/3] staging: gdm72xx: Minor cleanup

2014-04-19 Thread Michalis Pappas
The following patches perform various cleanups on the gdm72xx driver. PATCH 1/3 fixes some small coding style issues PATCH 2/3 removes an already completed item from the TODO list PATCH 3/3 replaces some jiffies comparisons with wrap-safe functions After all patches have been applied, the only

[PATCH v2 1/3] staging: gdm72xx: Minor cleanup

2014-04-19 Thread Michalis Pappas
Minor white-space fixes as suggested by checkpatch.pl. Signed-off-by: Michalis Pappas mpap...@fastmail.fm --- drivers/staging/gdm72xx/gdm_qos.c | 2 +- drivers/staging/gdm72xx/gdm_wimax.c | 2 ++ drivers/staging/gdm72xx/usb_boot.c | 1 + 3 files changed, 4 insertions(+), 1 deletion(-) diff

[PATCH v2 2/3] staging: gdm72xx: Minor cleanup

2014-04-19 Thread Michalis Pappas
Removed line related to replacement of kernel_thread with kthread, as issue was fixed on ff5e4a1d2702582614996f6f6d005e9b5caadeb8. Signed-off-by: Michalis Pappas mpap...@fastmail.fm --- drivers/staging/gdm72xx/TODO | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/gdm72xx/TODO

[PATCH v2 3/3] staging: gdm72xx: Minor cleanup

2014-04-19 Thread Michalis Pappas
Replaced comparisons on jiffies values with wrap-safe functions. Signed-off-by: Michalis Pappas mpap...@fastmail.fm --- drivers/staging/gdm72xx/gdm_usb.c | 2 +- drivers/staging/gdm72xx/sdio_boot.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH] Staging:dgap:dgap_tty.c: Upgraded driver to use Mutex instead of semaphore

2014-04-19 Thread Kumar Gaurav
Hi All, Any update on below patch. Do i need to make any modification? On Thursday 17 April 2014 09:25 PM, Kumar Gaurav wrote: dgap driver uses semaphore for obtaining lock. I upgraded it to use MUTEX. Signed-off-by: Kumar Gaurav kumargauravgup...@gmail.com ---

[PATCH] ced1401 coding style fixes

2014-04-19 Thread Jinqiang Zeng
Signed-off-by: Jinqiang Zeng jinqiangz...@gmail.com --- drivers/staging/ced1401/usb1401.c |8 ++-- drivers/staging/ced1401/use14_ioc.h |4 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/ced1401/usb1401.c b/drivers/staging/ced1401/usb1401.c