[PATCH] staging: et131x: Remove empty file Module.symvers

2014-04-27 Thread Daniele Forsi
It was added by commit e0349d5ba (staging: et131x: Remove unused rcv_pend_lock spinlock) Signed-off-by: Daniele Forsi dfo...@gmail.com --- drivers/staging/et131x/Module.symvers | 0 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 drivers/staging/et131x/Module.symvers diff

Re: [RFC PATCH 0/8] component helper improvements

2014-04-27 Thread Daniel Vetter
On Sun, Apr 27, 2014 at 1:00 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: A while back, Laurent raised some comments about the component helper, which this patch set starts to address. The first point it addresses is the repeated parsing inefficiency when deferred probing

Re: [RFC PATCH 0/8] component helper improvements

2014-04-27 Thread Russell King - ARM Linux
On Sun, Apr 27, 2014 at 02:51:30PM +0200, Daniel Vetter wrote: On Sun, Apr 27, 2014 at 1:00 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: A while back, Laurent raised some comments about the component helper, which this patch set starts to address. The first point it

[PATCH 02/47] staging/lustre/ptlrpc: Remove log message about export timer update

2014-04-27 Thread Oleg Drokin
From: Cheng Shao cheng_s...@xyratex.com Function ptlrpc_update_export_timer generates lots of D_HA level log messages whenever the export timer gets updated. Those log messages are found little use for issue investigations, and it will take space in the Lustre log buffer. We are removing it now.

[PATCH 06/47] staging/lustre/lnet: Dropped messages are not accounted correctly

2014-04-27 Thread Oleg Drokin
From: Matt Ezell ezel...@ornl.gov LNET messages that are dropped are not accounted for correctly in /proc/sys/lnet/stats. What I assume to be a simple typo is causing drop_length to be double-counted and drop_count to never be incremented. Signed-off-by: Matt Ezell ezel...@ornl.gov Reviewed-on:

[PATCH 01/47] staging/lustre/ptlrpc: Fix assertion failure of null_alloc_rs()

2014-04-27 Thread Oleg Drokin
From: Patrick Farrell p...@cray.com lustre_get_emerg_rs() set the size of the reply buffer to zero by mistake, which will cause LBUG in null_alloc_rs() when memory pressure is high. This patch fix this problem and adds a size check to avoid the problem of insufficient buffer size. Signed-off-by:

[PATCH 09/47] staging/lustre/ptlrpc: don't try to recover no_recov connection

2014-04-27 Thread Oleg Drokin
From: Andreas Dilger andreas.dil...@intel.com If a connection has been stopped with ptlrpc_pinger_del_import() and marked obd_no_recov, don't reconnect in ptlrpc_disconnect_import() if the import is already disconnected. Otherwise, without the pinger it will just wait there indefinitely for the

[PATCH 04/47] staging/lustre/gss: Shared key mechanism flavors

2014-04-27 Thread Oleg Drokin
From: Andrew Korty a...@iu.edu Implement security flavors and GSSAPI mechanism to perform shared key authentication (ski) and encryption (skpi). Signed-off-by: Andrew Korty a...@iu.edu Reviewed-on: http://review.whamcloud.com/8629 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3289

[PATCH 03/47] staging/lustre/gss: gssnull security flavor

2014-04-27 Thread Oleg Drokin
From: Andrew Korty a...@iu.edu This change implements the gssnull security flavor for the purpose of testing the Lustre GSS code. It provides and uses a null GSS mechanism so this testing doesn't have to involve any code related to Kerberos or any other authentication method. Signed-off-by:

[PATCH 08/47] staging/lustre/clio: clear nowait flag agl lock re-enqueue

2014-04-27 Thread Oleg Drokin
From: Niu Yawei yawei@intel.com The LDLM_FL_BLOCK_NOWAIT flag should be cleared when re-enqueue the agl lock as normal glimpse, otherwise, it won't get size back if there is conflicting locks on other client. Signed-off-by: Niu Yawei yawei@intel.com Reviewed-on:

[PATCH 05/47] staging/lustre/osc: don't activate deactivated obd_import

2014-04-27 Thread Oleg Drokin
From: Hongchao Zhang hongchao.zh...@intel.com In ptlrpc_activate_import(), obd_import-imp_deactive should be checked if it is deactivated, otherwise it will trigger an LBUG in ptlrpc_invalidate_import(): ptlrpc_invalidate_import() ASSERTION(imp-imp_invalid) failed Signed-off-by: Hongchao

[PATCH 00/47] Lustre fixes and cleanups

2014-04-27 Thread Oleg Drokin
Hello! This pile of patches brings in most of the recent fixes from current Lustre development tree, also code cleanups, junk removal and such. A relatively unsynced area remaining is in client io stack that is undergoing some major shakeups now, I'll try to tackle it later once

[PATCH 12/47] staging/lustre: restore __GFP_WAIT flag to memalloc calls

2014-04-27 Thread Oleg Drokin
From: Ann Koehler a...@cray.com In Lustre 2.4, the flags passed to the memory allocation functions are translated from CFS enumeration values types to the kernel GFP values by calling cfs_alloc_flags_to_gfp(). This function adds __GFP_WAIT to all flags except CFS_ALLOC_ATOMIC. In 2.5, when the

[PATCH 13/47] staging/lustre/gss: fix uninitialized variable

2014-04-27 Thread Oleg Drokin
From: Dmitry Eremin dmitry.ere...@intel.com 'sg-page_link' is used uninitialized in many functions. Signed-off-by: Dmitry Eremin dmitry.ere...@intel.com Reviewed-on: http://review.whamcloud.com/9325 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4629 Reviewed-by: James Simmons

[PATCH 14/47] staging/lustre: quiet console permission error messages

2014-04-27 Thread Oleg Drokin
From: Andreas Dilger andreas.dil...@intel.com Quiet some common console error messages for permission errors that can be hit in common cases. Signed-off-by: Andreas Dilger andreas.dil...@intel.com Reviewed-on: http://review.whamcloud.com/8988 Intel-bug-id:

[PATCH 17/47] staging/lustre/hsm: count NULL terminator in hai_zero/hal_size

2014-04-27 Thread Oleg Drokin
From: Peng Tao bergw...@gmail.com If fsname is 8-byte aligned, hai_zero fails to count the ending NULL terminator causing hai to directly attached after fsname and future hai_zero will return a different position for first hai. Signed-off-by: Peng Tao bergw...@gmail.com Reviewed-on:

[PATCH 15/47] staging/lustre/lov: remove unused lov llog code

2014-04-27 Thread Oleg Drokin
From: John L. Hammond john.hamm...@intel.com Remove the unused functions lov_llog_init(), lov_llog_finish(), their supporting functions, and the file lov_log.c. Signed-off-by: John L. Hammond john.hamm...@intel.com Reviewed-on: http://review.whamcloud.com/8539 Intel-bug-id:

[PATCH 11/47] staging/lustre/ptlrpc: add rpc_cache

2014-04-27 Thread Oleg Drokin
From: Andriy Skulysh andriy_skul...@xyratex.com Add rpc_cache for allocating ptlrpc_requests. Xyratex-bug-id: MRP-689 Signed-off-by: Andriy Skulysh andriy_skul...@xyratex.com Signed-off-by: Niu Yawei yawei@intel.com Reviewed-on: http://review.whamcloud.com/6874 Intel-bug-id:

[PATCH 07/47] staging/lustre/ldlm: Hold lock when clearing flag

2014-04-27 Thread Oleg Drokin
From: Li Xi pkuelel...@gmail.com This patch moves lock's skip flag clearing from lru-delete to lru-add code to prevent clearing lock's flag without resource lock protection. Signed-off-by: Li Xi l...@ddn.com Signed-off-by: Bobi Jam bobijam...@intel.com Reviewed-on:

[PATCH 20/47] staging/lustre/llite: issue OST_SYNC for fsync()

2014-04-27 Thread Oleg Drokin
From: Bobi Jam bobijam...@intel.com The last parameter @datasync of fsync() has following indication: * if datasync=0, we'd always flush data and metadata * if datasync=1, we'd always flush data while does not flush modifed metadata unless that metadata is needed in order to allow a

[PATCH 18/47] staging/lustre/hsm: HSM requests not delivered

2014-04-27 Thread Oleg Drokin
From: James Nunez james.a.nu...@intel.com The total size of an HSM archive request may exceed the desired (LNET) message. When this happens, it can hang the client and not allow the archive request to succeed. Before we know the total size of the hsm_action_items, we need to limit the size of

[PATCH 24/47] staging/lustre/llite: Avoid statahead thread start/stop deadlocks

2014-04-27 Thread Oleg Drokin
From: Christopher J. Morrone morro...@llnl.gov The statahead and statahead agl threads blindly set their thread state to SVC_RUNNING without checking the state first. If, for instance, another thread sets the state to SVC_STOPPING that stop signal will now have been lost. Deadlock ensues. We

[PATCH 21/47] staging/lustre/llite: deadlock taking lli_trunc_sem during file write

2014-04-27 Thread Oleg Drokin
From: Bobi Jam bobijam...@intel.com File write before io loop will take lli_trun_sem read semaphore to protect osc_extent, while after generic_file_aio_write() done, it could possible need to kill suid or sgid, which will call ll_setattr_raw() to change the inode's attribute, and it does not

[PATCH 10/47] staging/lustre/gss: fix few issues found by Klocwork Insight tool

2014-04-27 Thread Oleg Drokin
From: Dmitry Eremin dmitry.ere...@intel.com Array 'message_buf' of size 500 may use index value(s) -1 Object 'enc_key.data' was freed at line 164 after being freed by calling 'free' at line 150. Also there are 3 similar errors on line(s) 164. Suspicious dereference of pointer 'vmsg' before NULL

[PATCH 28/47] staging/lustre/ldlm: fix NULL pointer dereference

2014-04-27 Thread Oleg Drokin
From: Dmitry Eremin dmitry.ere...@intel.com Pointer '*exp' returned from call to function 'class_conn2export' at line 523 may be NULL and may be dereferenced at line 543. Signed-off-by: Dmitry Eremin dmitry.ere...@intel.com Reviewed-on: http://review.whamcloud.com/9323 ntel-bug-id:

[PATCH 32/47] staging/lustre/lnet: NI shutdown may loop forever

2014-04-27 Thread Oleg Drokin
From: Liang Zhen liang.z...@intel.com lnet_shutdown_lndnis() may enter endless loop if there is a busy NI, this is injected by LNet SMP improvements. It's fixed in this patch. Signed-off-by: Liang Zhen liang.z...@intel.com Reviewed-on: http://review.whamcloud.com/9706 Intel-bug-id:

[PATCH 26/47] staging/lustre/llite: access layout version under a lock

2014-04-27 Thread Oleg Drokin
From: Jinshan Xiong jinshan.xi...@intel.com We used to access layout version under the protection of ldlm lock, this introduces extra overhead for dlm lock matching. In this patch, lli_layout_lock is introduced to access the layout version. Also, when a layout lock is losing, we should tear down

[PATCH 37/47] staging/lustre/llite: Do not rate limit dirty page discard warning

2014-04-27 Thread Oleg Drokin
From: Ryan Haasken haas...@cray.com Messages which are printed by ll_dirty_page_discard_warn() should not be rate limited. If they are rate limited, some files which may be corrupted on client eviction will not be reported to the user. This patch changes the CWARN to a CDEBUG to disable console

[PATCH 25/47] stagaing/lustre: Improve statahead debug messages

2014-04-27 Thread Oleg Drokin
From: Christopher J. Morrone morro...@llnl.gov The statahead debug messages include the pid of the current process in their body. This is both redudant (because all lustre log messages contain the pid), and sometimes downright misleading. For instance the messages would say something like

[PATCH 34/47] staging/lustre/libcfs: add CPU table functions for uniprocessor

2014-04-27 Thread Oleg Drokin
From: Li Xi l...@ddn.com Some CPU table functions for uniprocessor architecture is missing. Signed-off-by: Li Xi l...@ddn.com Signed-off-by: James Simmons uja.o...@gmail.com Reviewed-on: http://review.whamcloud.com/8873 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4199 Reviewed-by: Bob

[PATCH 38/47] staging/lustre/lloop: avoid panic during blockdev_info

2014-04-27 Thread Oleg Drokin
From: Bob Glossman bob.gloss...@intel.com Change the LL_IOC_LLOOP_INFO ioctl in the lustre lloop device driver to return an error instead of causing panics with LASSERT(). Signed-off-by: Bob Glossman bob.gloss...@intel.com Reviewed-on: http://review.whamcloud.com/9888 Intel-bug-id:

[PATCH 23/47] staging/lustre: Limit reply buffer size

2014-04-27 Thread Oleg Drokin
From: Brian Behlendorf behlendo...@llnl.gov When allocating a reply buffer for the striping information don't assume the unlikely worst case. Instead, assume the common case and size the buffer based on the observed default ea/cookie size. The default size is initialized to a single stripe and

[PATCH 39/47] staging/lustre/clio: Solve a race in cl_lock_put

2014-04-27 Thread Oleg Drokin
From: Jinshan Xiong jinshan.xi...@intel.com It's not atomic to check the last reference and state of cl_lock in cl_lock_put(). This can cause a problem that an using lock is freed, if the process is preempted between atomic_dec_and_test() and (lock-cll_state == CLS_FREEING). This problem can be

[PATCH 35/47] staging/lustre: replace semaphores with mutexes

2014-04-27 Thread Oleg Drokin
From: Dmitry Eremin dmitry.ere...@intel.com It's just optimization. The mutex subsystem is slightly faster and has better scalability for contended workloads. Remove the lustre_lock and it's accessor functions l_lock(), l_unlock(), l_lock_init(), and l_has_lock() since they have not been used by

[PATCH 16/47] staging/lustre/obdclass: remove uses of lov_stripe_md

2014-04-27 Thread Oleg Drokin
From: John L. Hammond john.hamm...@intel.com Remove the unused function llog_obd_add(). Remove the unused count and parameters from llog_cancel(). Move dump_lsm() from obdclass to the only module that uses it (lov). Remove obd_lov.h. Signed-off-by: John L. Hammond john.hamm...@intel.com

[PATCH 33/47] staging/lustre: remove lustre/include/ioctl.h

2014-04-27 Thread Oleg Drokin
From: John L. Hammond john.hamm...@intel.com Remove the nowhere included header lustre/include/ioctl.h. Signed-off-by: John L. Hammond john.hamm...@intel.com Reviewed-on: http://review.whamcloud.com/9757 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-2675 Reviewed-by: Bob Glossman

[PATCH 36/47] staging/lustre/clio: replace semaphore with mutex

2014-04-27 Thread Oleg Drokin
From: Dmitry Eremin dmitry.ere...@intel.com According https://www.kernel.org/doc/Documentation/mutex-design.txt: - the mutex subsystem is slightly faster and has better scalability for contended workloads. In terms of 'ops per CPU cycle', the semaphore kernel performed 551 ops/sec per 1% of

[PATCH 44/47] staging/lustre: Always clamp cdls_delay between min and max

2014-04-27 Thread Oleg Drokin
From: Ryan Haasken haas...@cray.com In libcfs_debug_vmsg2, cdls_delay is only clamped between the minimum and the maximum when it is increased by multiplying by the backoff factor. It is not clamped when it is decreased by dividing by the backoff factor. This allows it to achieve values less

[PATCH 46/47] staging/lustre: Fix unsafe userspace access in many proc files

2014-04-27 Thread Oleg Drokin
Apparently we are pretty bad about verifying our buffers passed from userspace. Signed-off-by: Oleg Drokin oleg.dro...@intel.com Reviewed-on: http://review.whamcloud.com/9059 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4563 Reviewed-by: Dmitry Eremin dmitry.ere...@intel.com Reviewed-by:

[PATCH 19/47] staging/lustre: fix permission problem of setfacl

2014-04-27 Thread Oleg Drokin
From: Li Xi l...@ddn.com Setxattr does not check the permission when setting ACL xattrs. This will cause security problem because any user can walk around permission checking by changing ACL rules. Signed-off-by: Li Xi l...@ddn.com Reviewed-on: http://review.whamcloud.com/9473 Intel-bug-id:

[PATCH 30/47] staging/lustre/mdc: fix issue found by Klocwork Insight tool

2014-04-27 Thread Oleg Drokin
From: Dmitry Eremin dmitry.ere...@intel.com Pointer 'mod' checked for NULL at line 160 may be dereferenced at line 208. Signed-off-by: Dmitry Eremin dmitry.ere...@intel.com Reviewed-on: http://review.whamcloud.com/9387 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4629 Reviewed-by: Lai

[PATCH 40/47] staging/lustre/mdc: use cl_max_mds_md to pack getattr RPC

2014-04-27 Thread Oleg Drokin
From: wang di di.w...@intel.com In some cases, cl_default_mds_easize might be zero, especially for MDC connected to non-MDT0, then mdc might pack getattr RPC with zero eadatasize. If client is trying to access remote striped directory with zero eadatasize, MDT will not return layout information

[PATCH 27/47] staging/lustre: shrink lu_object_header by 8 bytes on x86_64

2014-04-27 Thread Oleg Drokin
From: Andreas Dilger andreas.dil...@intel.com Locate the loh_flags and loh_ref fields together in lu_object_header to avoid holes and shrink the structure by 8 bytes. Signed-off-by: Andreas Dilger andreas.dil...@intel.com Reviewed-on: http://review.whamcloud.com/9185 Intel-bug-id:

[PATCH 42/47] staging/lustre: remove assertion of spin_is_locked()

2014-04-27 Thread Oleg Drokin
From: Li Xi l...@ddn.com spin_is_locked() is always false when the platform is uniprocessor and CONFIG_DEBUG_SPINLOCK is not enabled. This patch replaces its assertion by assert_spin_locked(). Signed-off-by: Li Xi l...@ddn.com Signed-off-by: James Simmons uja.o...@gmail.com Reviewed-on:

[PATCH 47/47] staging/lustre/llite: prevent buffer overflow in fiemap

2014-04-27 Thread Oleg Drokin
From: Bobi Jam bobijam...@intel.com lov_fiemap() does not take consider its @vallen parameter, which is the max buffer size the caller can hold for the fiemap extents. This patch fixes this and limits the max mapped fiemap extent count to fit in the preallocted buffer. This patch also fixes a

[PATCH 43/47] staging/lustre/osc: Update inode timestamp for lockless IO as well

2014-04-27 Thread Oleg Drokin
From: Swapnil Pimpale spimp...@ddn.com Removed the checks for oi_lockless from osc_io_read_start() and osc_io_write_start(). This patch also removes the unnecessary call to cl_object_attr_get() in osc_io_write_start() before calling cl_object_attr_set() Signed-off-by: Swapnil Pimpale

[PATCH 22/47] staging/lustre/lov: to not hold sub locks at initialization

2014-04-27 Thread Oleg Drokin
From: Jinshan Xiong jinshan.xi...@intel.com Otherwise, it will cause deadlock because it essentially holds some sub locks and then to request others in an arbitrary order. Signed-off-by: Jinshan Xiong jinshan.xi...@intel.com Reviewed-on: http://review.whamcloud.com/9152 Reviewed-by: Lai Siyao

[PATCH 29/47] staging/lustre/lnet: lnet: fix issues found by Klocwork Insight tool

2014-04-27 Thread Oleg Drokin
From: Dmitry Eremin dmitry.ere...@intel.com Null pointer 'cp' that comes from line 2544 may be dereferenced at line 2618. Pointer 'ni' checked for NULL at line 1569 may be passed to function and may be dereferenced there by passing argument 1 to function 'lnet_ni_notify_locked' at line 1621.

Re: [PATCH 04/47] staging/lustre/gss: Shared key mechanism flavors

2014-04-27 Thread Greg Kroah-Hartman
On Sun, Apr 27, 2014 at 01:06:28PM -0400, Oleg Drokin wrote: From: Andrew Korty a...@iu.edu Implement security flavors and GSSAPI mechanism to perform shared key authentication (ski) and encryption (skpi). Signed-off-by: Andrew Korty a...@iu.edu Reviewed-on:

Re: [PATCH 29/47] staging/lustre/lnet: lnet: fix issues found by Klocwork Insight tool

2014-04-27 Thread Greg Kroah-Hartman
On Sun, Apr 27, 2014 at 01:06:53PM -0400, Oleg Drokin wrote: From: Dmitry Eremin dmitry.ere...@intel.com Null pointer 'cp' that comes from line 2544 may be dereferenced at line 2618. Pointer 'ni' checked for NULL at line 1569 may be passed to function and may be dereferenced there by

Re: [PATCH 46/47] staging/lustre: Fix unsafe userspace access in many proc files

2014-04-27 Thread Greg Kroah-Hartman
On Sun, Apr 27, 2014 at 01:07:10PM -0400, Oleg Drokin wrote: Apparently we are pretty bad about verifying our buffers passed from userspace. Understatement of the day... ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH 00/47] Lustre fixes and cleanups

2014-04-27 Thread Greg Kroah-Hartman
On Sun, Apr 27, 2014 at 01:06:24PM -0400, Oleg Drokin wrote: Hello! This pile of patches brings in most of the recent fixes from current Lustre development tree, also code cleanups, junk removal and such. A relatively unsynced area remaining is in client io stack that is

Re: [PATCH] staging: line6: fix possible overrun

2014-04-27 Thread Dan Carpenter
On Sat, Apr 26, 2014 at 11:59:46PM +0200, Mateusz Guzik wrote: And sadly enough some of those -id strings are more than 15 characters and a NUL which will fit in card-id. So this overflow is real. The card-shortname is a 32 char array so none of those overflow. If we want to sovle the

[bug report] forever loop in ksocknal_push()

2014-04-27 Thread Dan Carpenter
Hello Peng Tao, The patch d7e09d0397e8: staging: add Lustre file system client support from May 2, 2013, leads to the following static checker warning: drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:1904 ksocknal_push() info: ignoring unreachable code.

Re: [PATCH 00/47] Lustre fixes and cleanups

2014-04-27 Thread Oleg Drokin
Hello! On Apr 27, 2014, at 1:33 PM, Greg Kroah-Hartman wrote: I've applied these, except for the 3 gss patches. Thanks. gss stuff was kind of totally separate, tso I thought it was not so bad idea to include them, but they are definitely not required. Also, there is now a build warning in

Re: [bug report] forever loop in ksocknal_push()

2014-04-27 Thread Drokin, Oleg
Thanks! Liang, any comments about this? On Apr 27, 2014, at 2:26 PM, Dan Carpenter wrote: Hello Peng Tao, The patch d7e09d0397e8: staging: add Lustre file system client support from May 2, 2013, leads to the following static checker warning:

[PATCH] staging/lustre/llite: Fix a compile warning.

2014-04-27 Thread Oleg Drokin
Quiet the warning below in Lustre code. Actually the warning is invalid since we either always assign the symname in ll_readlink_internal or return an error there and then the following rc check would assign symlink variable explicitly. In file included from

Re: [PATCH] staging: line6: fix possible overrun

2014-04-27 Thread Laurent Navet
Thank's for your answers, will try to look deeper, If we want to sovle the truncation issue then we need to think of shorter names for BassPODxtLive, BassPODxtPro, PODStudioUX1, and PODStudioUX2. In that case I suggest compile time assertions that ids and names fit That sounds like

Re: [PATCH] staging: line6: fix possible overrun

2014-04-27 Thread Mateusz Guzik
On Sun, Apr 27, 2014 at 08:39:32PM +0300, Dan Carpenter wrote: On Sat, Apr 26, 2014 at 11:59:46PM +0200, Mateusz Guzik wrote: And sadly enough some of those -id strings are more than 15 characters and a NUL which will fit in card-id. So this overflow is real. The card-shortname is a 32

[GIT PULL] imx-drm urgent fixes

2014-04-27 Thread Russell King
Greg, Please incorporate the latest imx-drm urgent fixes, which can be found at: git://ftp.arm.linux.org.uk/~rmk/linux-arm.git imx-drm-fixes-urgent with SHA1 a3fe964135d0e4b925eaf4a5891c84daa7885c86. These are the urgent fixes which should be required. arm-soc people have acked the change

[GIT PULL] imx-drm non-urgent fixes

2014-04-27 Thread Russell King
Greg, Please incorporate the latest imx-drm non-urgent fixes, which can be found at: git://ftp.arm.linux.org.uk/~rmk/linux-arm.git imx-drm-fixes with SHA1 1e6d486be4ea3f17c99c933703f53a6d566292a9. These are the less urgent fixes, but nevertheless, I think they should be submitted for an -rc

Re: [PATCH] staging: et131x: Remove empty file Module.symvers

2014-04-27 Thread Mark Einon
On Sun, Apr 27, 2014 at 02:34:48PM +0200, Daniele Forsi wrote: It was added by commit e0349d5ba (staging: et131x: Remove unused rcv_pend_lock spinlock) Signed-off-by: Daniele Forsi dfo...@gmail.com Acked-by: Mark Einon mark.ei...@gmail.com ___

[PATCH 3/5] staging/lustre/lnet: fix potential null pointer dereference

2014-04-27 Thread Oleg Drokin
From: Dmitry Eremin dmitry.ere...@intel.com Pointer 'tsc' returned from call to function 'sfw_find_test_case' at line 571 may be NULL and will be dereferenced at line 572. found by Klocwork Insight tool Signed-off-by: Dmitry Eremin dmitry.ere...@intel.com Reviewed-on:

[PATCH 0/5] Lustre Klocwork fixes

2014-04-27 Thread Oleg Drokin
This is just splitting big lnet fixes patch from Klocwork static analysis tool into smaller bits. Dmitry Eremin (5): staging/lustre/lnet: fix potential null pointer dereference staging/lustre/lnet: remove unused variable staging/lustre/lnet: fix potential null pointer dereference

[PATCH 2/5] staging/lustre/lnet: remove unused variable

2014-04-27 Thread Oleg Drokin
From: Dmitry Eremin dmitry.ere...@intel.com Local variable 'hash' is never used found by Klocwork Insight tool Signed-off-by: Dmitry Eremin dmitry.ere...@intel.com Reviewed-on: http://review.whamcloud.com/9386 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4629 Reviewed-by: John L. Hammond

[PATCH 5/5] staging/lustre/lnet: fix potential null pointer dereference

2014-04-27 Thread Oleg Drokin
From: Dmitry Eremin dmitry.ere...@intel.com Pointer 'ni' checked for NULL at line 1569 may be passed to function and may be dereferenced there by passing argument 1 to function 'lnet_ni_notify_locked' at line 1621. found by Klocwork Insight tool Signed-off-by: Dmitry Eremin

[PATCH 4/5] staging/lustre/lnet: fix potential null pointer dereference

2014-04-27 Thread Oleg Drokin
From: Dmitry Eremin dmitry.ere...@intel.com Null pointer 'cp' that comes from line 2544 may be dereferenced at line 2618. found by Klocwork Insight tool Signed-off-by: Dmitry Eremin dmitry.ere...@intel.com Reviewed-on: http://review.whamcloud.com/9386 Intel-bug-id:

[PATCH 1/5] staging/lustre/lnet: fix potential null pointer dereference

2014-04-27 Thread Oleg Drokin
From: Dmitry Eremin dmitry.ere...@intel.com Null pointer 'best_iface' that comes from line 802 may be dereferenced at line 832. found by Klocwork Insight tool Signed-off-by: Dmitry Eremin dmitry.ere...@intel.com Reviewed-on: http://review.whamcloud.com/9386 Intel-bug-id:

Re: [PATCH 1/5] staging/lustre/lnet: fix potential null pointer dereference

2014-04-27 Thread One Thousand Gnomes
Reviewed-by: John L. Hammond john.hamm...@intel.com Reviewed-by: Isaac Huang he.hu...@intel.com Signed-off-by: Oleg Drokin oleg.dro...@intel.com --- drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 1/5] staging/lustre/lnet: fix potential null pointer dereference

2014-04-27 Thread Oleg Drokin
On Apr 27, 2014, at 6:05 PM, One Thousand Gnomes wrote: Reviewed-by: John L. Hammond john.hamm...@intel.com Reviewed-by: Isaac Huang he.hu...@intel.com Signed-off-by: Oleg Drokin oleg.dro...@intel.com --- drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c | 4 ++-- 1 file changed, 2

Re: [PATCH 0/5] Lustre Klocwork fixes

2014-04-27 Thread Greg Kroah-Hartman
On Sun, Apr 27, 2014 at 05:17:21PM -0400, Oleg Drokin wrote: This is just splitting big lnet fixes patch from Klocwork static analysis tool into smaller bits. Dmitry Eremin (5): staging/lustre/lnet: fix potential null pointer dereference staging/lustre/lnet: remove unused variable

Re: [PATCH 1/5] staging/lustre/lnet: fix potential null pointer dereference

2014-04-27 Thread Greg Kroah-Hartman
On Sun, Apr 27, 2014 at 06:19:59PM -0400, Oleg Drokin wrote: On Apr 27, 2014, at 6:05 PM, One Thousand Gnomes wrote: Reviewed-by: John L. Hammond john.hamm...@intel.com Reviewed-by: Isaac Huang he.hu...@intel.com Signed-off-by: Oleg Drokin oleg.dro...@intel.com ---

Re: [PATCH 5/5] staging/lustre/lnet: fix potential null pointer dereference

2014-04-27 Thread Greg Kroah-Hartman
On Sun, Apr 27, 2014 at 05:17:26PM -0400, Oleg Drokin wrote: From: Dmitry Eremin dmitry.ere...@intel.com Pointer 'ni' checked for NULL at line 1569 may be passed to function and may be dereferenced there by passing argument 1 to function 'lnet_ni_notify_locked' at line 1621. found by

Re: [PATCH 3/5] staging/lustre/lnet: fix potential null pointer dereference

2014-04-27 Thread Greg Kroah-Hartman
On Sun, Apr 27, 2014 at 05:17:24PM -0400, Oleg Drokin wrote: From: Dmitry Eremin dmitry.ere...@intel.com Pointer 'tsc' returned from call to function 'sfw_find_test_case' at line 571 may be NULL and will be dereferenced at line 572. found by Klocwork Insight tool Signed-off-by: Dmitry

Re: [PATCH] staging: line6: fix possible overrun

2014-04-27 Thread Dan Carpenter
On Sun, Apr 27, 2014 at 10:00:43PM +0200, Mateusz Guzik wrote: and a WARN_ON + -EINVAL in line6_init_audio to catch future offenders. Returning -EINVAL is a bad idea because it would break the driver completely and make it unusable. Well I would vote for returning the error

Re: [PATCH] staging: dgap: implement error handling in dgap_tty_register()

2014-04-27 Thread DaeSeok Youn
OK. I'll make my patch based on Mark's patch. Thanks. Daeseok Youn. 2014-04-27 3:48 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com: On Sat, Apr 26, 2014 at 11:39:38AM +0900, DaeSeok Youn wrote: Hi, please check below my comments. 2014-04-25 23:41 GMT+09:00 Mark Hounschell

Re: [PATCH 5/5] staging/lustre/lnet: fix potential null pointer dereference

2014-04-27 Thread Oleg Drokin
Hello! On Apr 27, 2014, at 6:39 PM, Greg Kroah-Hartman wrote: -lnet_ni_notify_locked(ni, lp); +if (ni != NULL) +lnet_ni_notify_locked(ni, lp); Why can't lnet_ni_notify_locked() accept NULL as an input? It makes no sense, because then there is nowhere to send the

Re: [PATCH next-20140424] staging/cxt1e1: sparse warning corrections

2014-04-27 Thread DaeSeok Youn
Hi, 2014-04-27 0:53 GMT+09:00 Sami Laine laine.j.s...@gmail.com: From: Sami Laine laine.j.s...@gmail.com do not include this line on your patch. it is not necessary. Corrected sparse static declaration warnings. Signed-off-by: Sami Laine laine.j.s...@gmail.com --- diff --git

[PATCH] staging/lustre: Replace jobid acquiring with per node setting

2014-04-27 Thread Oleg Drokin
Insted of meddling directly in process environment variables (which is also not possible on certain platforms due to not exported symbols), create jobid_name proc file to represent this info (to be filled by job scheduler epilogue). Signed-off-by: Oleg Drokin oleg.dro...@intel.com CC: Andreas

[PATCH v3 1/4] staging/lustre/lnet: Drop useless LASSERT in ksocknal_select_ips

2014-04-27 Thread Oleg Drokin
It should never be NULL because our interface list is up to date, and even if it does, we'll just crash anyway so we are no better off. Signed-off-by: Oleg Drokin oleg.dro...@intel.com --- drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c | 4 1 file changed, 4 deletions(-) diff --git

[PATCH v3 3/4] staging/lustre/lnet: fix potential null pointer dereference in kiblnd_rejected

2014-04-27 Thread Oleg Drokin
From: Dmitry Eremin dmitry.ere...@intel.com Null pointer 'cp' that comes from line 2544 may be dereferenced at line 2618. found by Klocwork Insight tool Signed-off-by: Dmitry Eremin dmitry.ere...@intel.com Reviewed-on: http://review.whamcloud.com/9386 Intel-bug-id:

[PATCH v3 2/4] staging/lustre/lnet: remove unused variable in lnet_destroy_remote_nets_table

2014-04-27 Thread Oleg Drokin
From: Dmitry Eremin dmitry.ere...@intel.com Local variable 'hash' is never used found by Klocwork Insight tool Signed-off-by: Dmitry Eremin dmitry.ere...@intel.com Reviewed-on: http://review.whamcloud.com/9386 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4629 Reviewed-by: John L. Hammond

[PATCH v3 4/4] staging/lustre/lnet: fix potential null pointer dereference

2014-04-27 Thread Oleg Drokin
Pointer 'ni' checked for NULL at line 1569 may be passed to function and may be dereferenced there by passing argument 1 to function 'lnet_ni_notify_locked' at line 1621. found by Klocwork Insight tool Signed-off-by: Oleg Drokin oleg.dro...@intel.com CC: Dmitry Eremin dmitry.ere...@intel.com CC:

[PATCH v3 0/4] Lustre Klocwork fixes

2014-04-27 Thread Oleg Drokin
This is just splitting big lnet fixes patch from Klocwork static analysis tool into smaller bits. Reworked according to previous comments. Also, this time with correct CC list. Dmitry Eremin (2): staging/lustre/lnet: remove unused variable in lnet_destroy_remote_nets_table