From: Micky Ching micky_ch...@realsil.com.cn
This reverts commit c42deffd5b53c9e583d83c7964854ede2f12410d.
commit mmc: rtsx: add support for pre_req and post_req did use
mutex_unlock() in tasklet, but mutex_unlock() can't used in
tasklet(atomic context). The driver need use mutex to avoid
Hi Chris and Ulf,
Since the original commit is merged into kernel 3.15-rc, we want this patch
apply to the 3.15-rc to avoid cause serious problem.
Is there any thing I need do?
Best Regards.
micky.
On 04/28/2014 03:36 PM, micky_ch...@realsil.com.cn wrote:
From: Micky Ching
On Sat, Apr 26, 2014 at 10:13:55PM +0530, navin patidar wrote:
Use inline functions provided by USB subsystem to check endpoint type,
instead of macros implemented by driver to do the same.
Unnecessary debugging messages are also removed.
I like both these changes but they would have been
On Sat, Apr 26, 2014 at 10:15:04PM +0200, Christian Engelmayer wrote:
Pointer 'pbpctl_dev_c' in function bypass_init_module() is unused.
Thus remove it.
Signed-off-by: Christian Engelmayer cenge...@gmx.at
---
Compile tested and applies against v3.15-rc2 as well as branch staging-next
of
Nice, Chase, you've become an expert on comedi, it seems.
I can't say how happy comedi patches make me these days. Ian, you and
Hartley are doing a fantastic job.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
From: Roger Tseng rogera...@realtek.com
Realtek USB memstick host driver provides memstick host support based on the
Realtek USB card reader MFD driver.
Signed-off-by: Roger Tseng rogera...@realtek.com
---
drivers/memstick/host/Kconfig | 10 +
drivers/memstick/host/Makefile
From: Roger Tseng rogera...@realtek.com
Realtek USB SD/MMC host driver provides mmc host support based on the Realtek
USB card reader MFD driver.
Signed-off-by: Roger Tseng rogera...@realtek.com
Acked-by: Ulf Hansson ulf.hans...@linaro.org
---
drivers/mmc/host/Kconfig |7 +
On 2014-04-27 02:37, Chase Southwood wrote:
This driver only uses PCI bar 1 (devpriv-i_IobaseAmcc), and PCI bar 2
(dev-iobase) doon't bother reading the unused PCI bars.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten
On 28 April 2014 09:36, micky_ch...@realsil.com.cn wrote:
From: Micky Ching micky_ch...@realsil.com.cn
This reverts commit c42deffd5b53c9e583d83c7964854ede2f12410d.
commit mmc: rtsx: add support for pre_req and post_req did use
mutex_unlock() in tasklet, but mutex_unlock() can't used in
The obd_ioctl_getdata() function caps data-ioc_len at
OBD_MAX_IOCTL_BUFFER and then calls this obd_ioctl_is_invalid() to check
that the other values inside data are valid.
There are several lengths inside data but when they are added together
they must not be larger than data-ioc_len. The checks
of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Signed-off-by: Fabio Estevam fabio.este...@freescale.com
---
Changes since v1:
- Rebased it against linux-next 20140428
drivers/staging/imx-drm/imx-hdmi.c | 2 ++
1 file changed, 2 insertions(+)
diff
On 2014-04-28 11:19, Ian Abbott wrote:
On 2014-04-27 02:37, Chase Southwood wrote:
This driver only uses PCI bar 1 (devpriv-i_IobaseAmcc), and PCI bar 2
(dev-iobase) doon't bother reading the unused PCI bars.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott
fix some code style related to the use of braces in a one statement block
Signed-off-by: Rui Miguel Silva rmf...@gmail.com
---
Changes v1-v2:
fix error regarding a newline insertion.
drivers/staging/rtl8192u/r8192U_dm.c | 6 ++
drivers/staging/rtl8192u/r8192U_wx.c | 3 +--
Hi Chris and Ulf,
This patch should be applied to 3.15(rc), 3.14, 3.13.
without this patch the MMC card can not identified.
Best Regards.
micky.
On 03/27/2014 01:35 PM, micky_ch...@realsil.com.cn wrote:
From: Micky Ching micky_ch...@realsil.com.cn
commit
Hi Chris and Ulf,
This patch is denpend on commit c42deffd5b53c9e583d83c7964854ede2f12410d.
mmc: rtsx: add support for pre_req and post_req, and we discard the
previous commit.
we want discard this patch also(it it now in linux-next), need I send
another patch to
revert or it will be discard
Am 28.04.2014 12:58, schrieb Dan Carpenter:
The obd_ioctl_getdata() function caps data-ioc_len at
OBD_MAX_IOCTL_BUFFER and then calls this obd_ioctl_is_invalid() to check
that the other values inside data are valid.
There are several lengths inside data but when they are added together
On Mon, Apr 28, 2014 at 01:35:19PM +0200, walter harms wrote:
Am 28.04.2014 12:58, schrieb Dan Carpenter:
The obd_ioctl_getdata() function caps data-ioc_len at
OBD_MAX_IOCTL_BUFFER and then calls this obd_ioctl_is_invalid() to check
that the other values inside data are valid.
On Mon, Apr 28, 2014 at 11:53:50AM +0100, Lee Jones wrote:
From: Micky Ching micky_ch...@realsil.com.cn
This reverts commit c42deffd5b53c9e583d83c7964854ede2f12410d.
Why was this patch even merged without an MFD Ack?
I think process questions like this are very important.
These patches
On Mon, Apr 28, 2014 at 07:30:52PM +0800, micky wrote:
Hi Chris and Ulf,
This patch should be applied to 3.15(rc), 3.14, 3.13.
without this patch the MMC card can not identified.
Top posting is annoying.
If Chris and Ulf don't mind then you could actually deal with this by
yourself. Read
On 04/25/2014 05:32 PM, Greg KH wrote:
On Thu, Apr 24, 2014 at 01:57:12PM -0500, Ken Cox wrote:
The visorutil module was lacking license info.
Signed-off-by: Ken Cox j...@redhat.com
---
drivers/staging/unisys/visorutil/visorkmodutils.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
From: Micky Ching micky_ch...@realsil.com.cn
This reverts commit c42deffd5b53c9e583d83c7964854ede2f12410d.
Why was this patch even merged without an MFD Ack?
commit mmc: rtsx: add support for pre_req and post_req did use
mutex_unlock() in tasklet, but mutex_unlock() can't used in
On Mon, Apr 28, 2014 at 07:37:49PM +0800, micky wrote:
Hi Chris and Ulf,
This patch is denpend on commit c42deffd5b53c9e583d83c7964854ede2f12410d.
mmc: rtsx: add support for pre_req and post_req, and we discard
the previous commit.
we want discard this patch also(it it now in linux-next),
On 28 April 2014 14:29, Lee Jones lee.jo...@linaro.org wrote:
From: Micky Ching micky_ch...@realsil.com.cn
This reverts commit c42deffd5b53c9e583d83c7964854ede2f12410d.
Why was this patch even merged without an MFD Ack?
commit mmc: rtsx: add support for pre_req and post_req did use
Yes, it is indeed a deadloop, I think we didn¹t catch it because it¹s only
called by an utility command which is probably never tried by anyone.
I have posted a patch for it: http://review.whamcloud.com/10128
Thanks
Liang
On 4/28/14, 2:38 AM, Drokin, Oleg oleg.dro...@intel.com wrote:
Thanks!
Fix two format string mismatch in ad7280a.c
Signed-off-by: Masanari Iida standby2...@gmail.com
---
drivers/staging/iio/adc/ad7280a.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/iio/adc/ad7280a.c
b/drivers/staging/iio/adc/ad7280a.c
index
24.03.2014 01:18, Aaro Koskinen пишет:
Hi,
On Sat, Mar 22, 2014 at 01:13:52PM +0400, Sergey Popov wrote:
scsi 0:0:0:0: Direct-Access SanDisk Cruzer Facet 1.26 PQ: 0 ANSI: 5
sd 0:0:0:0: [sda] 15633408 512-byte logical blocks: (8.00 GB/7.45 GiB)
usb 1-1: reset high-speed USB device
The visorutil module was lacking license info.
Signed-off-by: Ken Cox j...@redhat.com
---
drivers/staging/unisys/visorutil/visorkmodutils.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/unisys/visorutil/visorkmodutils.c
b/drivers/staging/unisys/visorutil/visorkmodutils.c
This patch adds support for detection of s-Par firmware by checking for
the hypervisor bit in the CPU capabilities, and then querying the hypervisor
ID cpuid leaf.
This functionality will be used by the unisys drivers to determine if
they are being loaded on an s-Par platform and refuse to load
From: K. Y. Srinivasan k...@microsoft.com
Date: Fri, 25 Apr 2014 20:55:23 -0700
@@ -467,6 +467,9 @@ static int netvsc_start_xmit(struct sk_buff *skb, struct
net_device *net)
if (skb_is_gso(skb))
goto do_lso;
+ if (skb-ip_summed != CHECKSUM_PARTIAL)
+
This continues the cleanup of the async command support code for this driver
and addresses a number of issues pointed out by Ian Abbott.
H Hartley Sweeten (12):
staging: comedi: adv_pci1710: tidy up pci171x_ai_check_chanlist()
staging: comedi: adv_pci1710: don't check the chanlist twice
This member of the private data is not ued by the driver. Remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adv_pci1710.c | 1 -
1 file changed, 1
This member of the private data is not necessary. We can determine if
the analog input command is neverending by checking the cmd-stop_src:
TRIG_COUNT - !neverending_ai
TRIG_NONE - neverending_ai
Do that instead and remove the unnecessary member.
Signed-off-by: H Hartley Sweeten
For aesthetics, rename this function so it has namespace associated
with the driver.
Change the parameters to the function. The 'mode' is really a flag to
load the counters and the divisors can be found in the private data.
To clarify the code and remove the magic numbers, use the 8253.h
helpers
The chanlist is checked in Step 5 of the (*do_cmdtest) there is no
reason to check it again in the (*do_cmd). The only reason its done
again is to get the actual 'seglen', the non-repeating length of the
chanlist.
Save the 'seglen' found by pci171x_ai_check_chanlist() in the private
data and use
This member of the private data is always set to I8254_OSC_BASE_10MHZ. Remove
it from the private data and just open code the value.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Tidy up this function to clarify what the chanlist is being checked for.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adv_pci1710.c | 81
This member of the private data is set to 0 but never used. Just remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adv_pci1710.c | 3 ---
1 file changed, 3
Currently, the fl_owner isn't set for flock locks. Some filesystems use
byte-range locks to simulate flock locks and there is a common idiom in
those that does:
fl-fl_owner = (fl_owner_t)filp;
fl-fl_start = 0;
fl-fl_end = OFFSET_MAX;
Since flock locks are generally owned by the open
On Saturday, April 26, 2014 6:37 PM, Chase Southwood wrote:
This driver only uses PCI bar 1 (devpriv-i_IobaseAmcc), and PCI bar 2
(dev-iobase) doon't bother reading the unused PCI bars.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley
On Saturday, April 26, 2014 6:37 PM, Chase Southwood wrote:
This board always has 32 digital inputs. Remove the test when
initializing the subdevice.
Also, since this board is the only one supported by this driver,
remove the boardinfo about the digital inputs and just use the
data directly
On Saturday, April 26, 2014 6:37 PM, Chase Southwood wrote:
This include is no longer needed.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
drivers/staging/comedi/drivers/addi_apci_1564.c |
On Saturday, April 26, 2014 6:36 PM, Chase Southwood wrote:
Reading the eeprom on this board is not necessary. All information
required is in the boardinfo.
Remove the eeprom support code which is not really useful here.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian
On Mon, Apr 28, 2014 at 01:50:13PM -0400, Jeff Layton wrote:
Currently, the fl_owner isn't set for flock locks. Some filesystems use
byte-range locks to simulate flock locks and there is a common idiom in
those that does:
fl-fl_owner = (fl_owner_t)filp;
fl-fl_start = 0;
-Original Message-
From: David Miller [mailto:da...@davemloft.net]
Sent: Monday, April 28, 2014 10:24 AM
To: KY Srinivasan
Cc: net...@vger.kernel.org; linux-ker...@vger.kernel.org;
de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
jasow...@redhat.com;
Pointer 'pbpctl_dev_c' in function bypass_init_module() is unused. Thus remove
it. With the last variable declaration gone, there is no more need for an own
block. Remove it and adapt the indenting accordingly.
Signed-off-by: Christian Engelmayer cenge...@gmx.at
---
v2: Added changes requested by
Fixed following coding style issues.
- No space is necessary after a cast
- Alignment should match open parenthesis
- Braces {} should be used on all arms of this statement
Signed-off-by: Junsu Shin jsshin@gmail.comx
---
drivers/staging/gdm72xx/gdm_wimax.c | 71
Remove some unnecessary pacer divisor calculations. The divisors are calculated
as part of the (*do_cmdtest) and don't need done in the (*do_cmd).
Remomove the older, unused, divisor calc functions in 8253.h to avoid any
confusion.
Remove some unnecessary private data members in a couple drivers
Refactor this code to reduce the indent level and the 80 char
lines.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/das1800.c | 71
This member of the private data is a copy of the s-async-prealloc_bufsz.
Use that instead.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/addi-data/addi_common.h
Use a local variable for the comedi_cmd and tidy up this function a bit.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/addi_apci_2032.c | 20 ++--
This member of the private data is a copy of the cmd-flags. Use that instead.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/addi-data/addi_common.h| 1 -
This private data member is set when an analog input async command is
started by apci3120_cyclic_ai() and cleared when the command finishes
or is canceled.
Rename the CamelCase member to 'ai_running' and convert it to a
bit-field flag.
Remove the unnecessary clearing of the flag before or after
This member of the private data is a copy of the cmd-stop_arg. Use that
instead.
Fix the b_AiContinuous check in apci3120_ai_cmd(). The (*do_cmdtest) validates
that the cmd-stop_arg os = 1 for TRIG_COUNT and 0 for TRIG_NONE. The correct
test to set this flag is (cmd-stop_src == TRIG_NONE).
The analog input async command can use the pacer for the convert_src. The
(*do_cmdtest) calculates the divisors when validating the cmd argument.
There is no reason to recalc the divisors in the (*do_cmd). Just use the
values from the private data.
Also, tidy up das16m1_set_pacer() and
This member of the private data can be determined by checking the cmd-stop_src.
Do that instead.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/amplc_pci230.c | 25
This member of the private data can be determined by checking the cmd-stop_src.
Do that instead.
Fix the b_AiContinuous check in apci3120_ai_cmd(). The (*do_cmdtest) validates
that the cmd-stop_arg os = 1 for TRIG_COUNT and 0 for TRIG_NONE. The correct
test to set this flag is (cmd-stop_src ==
This member of the private data is a copy of the cmd-scan_begin_arg.
Use that instead.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/addi-data/addi_common.h|
This member of the private data can be determined by checking the cmd-stop_src.
Do that instead.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/amplc_pci224.c | 21
The (*do_cmdtest) validates that the cmd-convert_src can only be
TRIG_TIMER. Remove the unnecessay checks.
THis also simplifies the (*do_cmd) a bit since mode 3 (whatever that
is) is never a valid mode.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott
This private data member is not used by this driver. Remove the unnecessary
clearing of it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
The analog output async command can use the pacer for the scan_begin_src.
The (*do_cmdtest) calculates the divisors when validating the cmd argument.
There is no reason to recalc the divisors in the (*do_cmd). Just use the
values from the private data.
For aesthetics, factor out the code that
The analog input async command can use the pacer for the scan_begin_src
or the convert_src. The (*do_cmdtest) calculates the divisors when
validating the cmd argument.
There is no reason to recalc the divisors in the (*do_cmd). Just use the
values from the private data.
For aesthetics, rename
This member of the private data is a copy of the cmd-convert_arg. Use
that instead.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/addi-data/addi_common.h| 1 -
This member of the private data is a copy of the cmd-chanlist. Use that
instead.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/addi-data/addi_common.h| 1 -
This member of the private data is a copy of the cmd-scan_end_arg. Use that
instead.
Use a local variable in apci3120_cyclic_ai() for the DMA 'scan_bytes', which
is the cmd-scan_end_arg * 2. Replace the open-coded '2' with sizeof(short).
Signed-off-by: H Hartley Sweeten
This member of the private data can be determined by checking the cmd-stop_src.
Do that instead.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/amplc_pci230.c | 22
The analog input async command can use the pacer for the scan_bagin_src
or the convert_src. The (*do_cmdtest) validates that only one of these
sources has the TRIG_TIMER selected and calculates the divisors when
validating the cmd argument.
There is no reason to recalc the divisors in the
None of the comedi drivers use the i8253_cascade_ns_to_timer_2div_old()
or i8253_cascade_ns_to_timer_power() helpers to calculate the cascaded
divisors. Remove them to avoid any confusion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
This step in the (*do_cmdtest) fixes the comedi_cmd arguments, usually
for TRIG_TIMER sources.
Tidy up this step to clarify the code and remove the extra local
variables. All the arguments are unsigned long so change the 'tmp'
local variable type and rename it for aesthetics.
Signed-off-by: H
All of the comedi drivers use the i8253_cascade_ns_to_timer macro
when calculating the divisors for the cascaded timers. This macro
just causes the i8253_cascade_ns_to_timer_2div() inline to be used.
Rename i8253_cascade_ns_to_timer_2div() and remove the macro.
Signed-off-by: H Hartley Sweeten
On Mon, Apr 28, 2014 at 08:47:27PM +0200, Christian Engelmayer wrote:
Pointer 'pbpctl_dev_c' in function bypass_init_module() is unused. Thus remove
it. With the last variable declaration gone, there is no more need for an own
block. Remove it and adapt the indenting accordingly.
Function rtw_mp_pwrtrk() dynamically allocates a temporary buffer that
is not freed in all error paths. Use a centralized exit path and make sure
that all memory is freed correctly. Detected by Coverity - 1077715.
Signed-off-by: Christian Engelmayer cenge...@gmx.at
---
Function rtw_mp_QueryDrv() dynamically allocates a temporary buffer that
is not freed in all error paths. Use a centralized exit path and make sure
that all memory is freed correctly. Detected by Coverity - CID 1077713.
Signed-off-by: Christian Engelmayer cenge...@gmx.at
---
Function rtw_wx_read32() dynamically allocates a temporary buffer that is not
freed in all error paths. Use a centralized exit path and make sure that all
memory is freed correctly. Detected by Coverity - CID 1077711.
Signed-off-by: Christian Engelmayer cenge...@gmx.at
---
On 28/04/14 19:11, Hartley Sweeten wrote:
On Saturday, April 26, 2014 6:37 PM, Chase Southwood wrote:
This board always has 32 digital inputs. Remove the test when
initializing the subdevice.
Also, since this board is the only one supported by this driver,
remove the boardinfo about the
On Saturday, April 26, 2014 7:04 AM, Christian Engelmayer wrote:
Some board pointer are assigned twice via comedi_board() in the comedi low
level driver attach functions. Remove the duplicate assignment from the
variable definition where the pointer is not used anyway until assigned later
in
Unnecessary debugging messages are removed from usb_dvobj_init().
Signed-off-by: navin patidar navin.pati...@gmail.com
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 34 +++
1 file changed, 3 insertions(+), 31 deletions(-)
diff --git
Use inline functions provided by USB subsystem to check endpoint type,
instead of inline functions implemented by driver to do the same.
Signed-off-by: navin patidar navin.pati...@gmail.com
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 57 +--
1 file changed, 10
On Mon, Apr 28, 2014 at 2:55 PM, Dan Carpenter dan.carpen...@oracle.com wrote:
On Sat, Apr 26, 2014 at 10:13:55PM +0530, navin patidar wrote:
Use inline functions provided by USB subsystem to check endpoint type,
instead of macros implemented by driver to do the same.
Unnecessary debugging
From: Micky Ching micky_ch...@realsil.com.cn
This reverts commit 1f7b581b3ffcb2a8437397a02f4af89fa6934d08.
The patch depend on commit c42deffd5b53c9e583d83c7964854ede2f12410d
mmc: rtsx: add support for pre_req and post_req, but the previous
patch was discard. So we have to delete the patch.
From: Micky Ching micky_ch...@realsil.com.cn
This reverts commit c42deffd5b53c9e583d83c7964854ede2f12410d.
commit mmc: rtsx: add support for pre_req and post_req did use
mutex_unlock() in tasklet, but mutex_unlock() can't used in
tasklet(atomic context). The driver need use mutex to avoid
Ok, I generated a new patchset based on running checkpatch.pl with the
--strict option, as well as any recommendations made earlier on this thread.
From the following patches, both 8/10 and 9/10 involve whitespace fixes:
the former fixes issues reported by checkpatch.pl while the latter is
mostly
Removed unnecessary extern declarations from header files
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/gdm_wimax.h | 6 +++---
drivers/staging/gdm72xx/sdio_boot.h | 2 +-
drivers/staging/gdm72xx/usb_boot.h | 4 ++--
3 files changed, 6 insertions(+), 6
Replaced comparisons on jiffies values with wrap-safe functions.
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/gdm_usb.c | 2 +-
drivers/staging/gdm72xx/sdio_boot.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git
Modified struct allocation to match coding standards
---
drivers/staging/gdm72xx/gdm_qos.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gdm72xx/gdm_qos.c
b/drivers/staging/gdm72xx/gdm_qos.c
index 50d43ad..519db48 100644
---
Fixed some braces to conform with coding style
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/gdm_wimax.c | 16
drivers/staging/gdm72xx/netlink_k.c | 7 ---
2 files changed, 12 insertions(+), 11 deletions(-)
diff --git
Removed commented-out code
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/gdm_qos.h | 17 -
drivers/staging/gdm72xx/gdm_wimax.c | 4
drivers/staging/gdm72xx/gdm_wimax.h | 6 --
drivers/staging/gdm72xx/usb_boot.c | 17
Whitespace fixes to conform to coding standards
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/gdm_qos.c | 72 ++---
drivers/staging/gdm72xx/gdm_sdio.c | 15
drivers/staging/gdm72xx/gdm_usb.c | 43
Indentation and other whitespace fixes.
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/gdm_qos.c | 2 +-
drivers/staging/gdm72xx/gdm_sdio.c | 14 +++---
drivers/staging/gdm72xx/gdm_sdio.h | 29 +
drivers/staging/gdm72xx/gdm_usb.c | 17
Removed line related to replacement of kernel_thread with kthread,
as issue was fixed on ff5e4a1d2702 ('Staging: gdm72xx: gdm_usb:
fix deprecated function kernel_thread')
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/TODO | 1 -
1 file changed, 1 deletion(-)
On 04/28/2014 03:56 PM, Christian Engelmayer wrote:
Function rtw_wx_read32() dynamically allocates a temporary buffer that is not
freed in all error paths. Use a centralized exit path and make sure that all
memory is freed correctly. Detected by Coverity - CID 1077711.
Signed-off-by: Christian
Signed-off-by: Jimmy Li coder.l...@gmail.com
---
drivers/staging/iio/resolver/ad2s1210.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/iio/resolver/ad2s1210.c
b/drivers/staging/iio/resolver/ad2s1210.c
index 7fbaba4..3d6e123 100644
---
92 matches
Mail list logo
