On Tuesday, April 29, 2014 2:56 PM, Jimmy Li wrote:
Signed-off-by: Jimmy Li coder.l...@gmail.com
---
drivers/staging/iio/resolver/ad2s1210.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/iio/resolver/ad2s1210.c
b/drivers/staging/iio/resolver/ad2s1210.c
index
On Tue, Apr 29, 2014 at 03:07:04PM +0900, Jingoo Han wrote:
On Tuesday, April 29, 2014 2:56 PM, Jimmy Li wrote:
Signed-off-by: Jimmy Li coder.l...@gmail.com
---
drivers/staging/iio/resolver/ad2s1210.c |1 +
1 file changed, 1 insertion(+)
diff --git
From: Lad, Prabhakar prabhakar.cse...@gmail.com
this patch fixes following sparse warning,
dm365_resizer.c:223:1: warning: symbol 'resizer_calculate_resize_ratios' was
not declared. Should it be static?
dm365_resizer.c:313:5: warning: symbol 'resizer_configure_output_win' was not
declared.
On Tue, Apr 29, 2014 at 06:55:13AM +0530, navin patidar wrote:
Use inline functions provided by USB subsystem to check endpoint type,
instead of inline functions implemented by driver to do the same.
Signed-off-by: navin patidar navin.pati...@gmail.com
Looks nice. Thanks. :)
Reviewed-by:
On 29 April 2014 03:54, micky_ch...@realsil.com.cn wrote:
From: Micky Ching micky_ch...@realsil.com.cn
This reverts commit 1f7b581b3ffcb2a8437397a02f4af89fa6934d08.
The patch depend on commit c42deffd5b53c9e583d83c7964854ede2f12410d
mmc: rtsx: add support for pre_req and post_req, but the
On 29 April 2014 03:54, micky_ch...@realsil.com.cn wrote:
From: Micky Ching micky_ch...@realsil.com.cn
This reverts commit c42deffd5b53c9e583d83c7964854ede2f12410d.
commit mmc: rtsx: add support for pre_req and post_req did use
mutex_unlock() in tasklet, but mutex_unlock() can't used in
From: Micky Ching micky_ch...@realsil.com.cn
The commit mmc: rtsx: add support for pre_req and post_req have some
problem,
using mutex_unlock() in atomic context, spinlock deadlock, it is hard to fix
these problem, and better to use a new method. So just remove it.
The commit mmc: rtsx:
Hartley,
Ah geez...my brain got all tangled looking at old git commits for
other addi-data drivers. I apologize for this silly mistake. I'll
fix that title and send a new version of the patchset tomorrow.
Thanks,
Chase
On Mon, Apr 28, 2014 at 12:59 PM, Hartley Sweeten
Hartley and Ian,
Yes, I had a feeling I should have gone with what was present, but my
desire to follow the documentation I wasn't too familiar with won out
:P
I'll spin a new revision of this patchset ASAP with this changed back
and all of my bad titles (oof...) fixed as well and I'll make sure
This board always has 32 digital inputs. Remove the test when
initializing the subdevice.
Also, since this board is the only one supported by this driver,
remove the boardinfo about the digital inputs and just use the
data directly in the subdevice init.
Signed-off-by: Chase Southwood
This driver only uses PCI bar 1 (devpriv-i_IobaseAmcc), and PCI bar 2
(dev-iobase) doon't bother reading the unused PCI bars.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley Sweeten hswee...@visionengravers.com
---
2: Bad PCI bar numbers
The i_IorangeBase1, i_PCIEeprom, and pc_EepromChip data in the boardinfo
was only needed to work out the usage of the PCI bars. Now that that is
squared away, this info is no longer needed and can be removed.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott
This driver no longer reads the eeprom to find the board specific data,
all the necessary data is in the boardinfo. Use the boardinfo directly
instead of passing through devpriv-s_EeParameters.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: H Hartley
On Sun, Apr 27, 2014 at 01:06:42PM -0400, Oleg Drokin wrote:
diff --git a/drivers/staging/lustre/lustre/llite/dir.c
b/drivers/staging/lustre/lustre/llite/dir.c
index 7fbc18e..c391b60 100644
--- a/drivers/staging/lustre/lustre/llite/dir.c
+++ b/drivers/staging/lustre/lustre/llite/dir.c
@@
On Sun, Apr 27, 2014 at 01:06:35PM -0400, Oleg Drokin wrote:
diff --git a/drivers/staging/lustre/lustre/ptlrpc/ptlrpc_module.c
b/drivers/staging/lustre/lustre/ptlrpc/ptlrpc_module.c
index 0efd358..251ae75 100644
--- a/drivers/staging/lustre/lustre/ptlrpc/ptlrpc_module.c
+++
[hijacking the thread since it has the right Cc list already, sorry]
I stumbled over this doing randconfig builds on linux-next
8--
From c11f54f1e5ea0557e076867ca31c90bcb20e3e0c Mon Sep 17 00:00:00 2001
From: Arnd Bergmann a...@arndb.de
Date: Tue, 29 Apr 2014 11:41:40 +0200
Subject:
On Sun, Apr 27, 2014 at 01:06:54PM -0400, Oleg Drokin wrote:
From: Dmitry Eremin dmitry.ere...@intel.com
Pointer 'mod' checked for NULL at line 160 may be dereferenced at line 208.
This seems to be a real bug, btw. For example, FSFILT_IOC_SETFLAGS
calls md_setattr() with a NULL mod in
On Sun, Apr 27, 2014 at 01:07:05PM -0400, Oleg Drokin wrote:
From: John L. Hammond john.hamm...@intel.com
In llite remove unused declarations, parameters, types, and unused,
get-only, or set-only structure members. Add static and const
qualifiers to declarations where possible.
On 29 April 2014 11:45, Arnd Bergmann a...@arndb.de wrote:
[hijacking the thread since it has the right Cc list already, sorry]
I stumbled over this doing randconfig builds on linux-next
8--
From c11f54f1e5ea0557e076867ca31c90bcb20e3e0c Mon Sep 17 00:00:00 2001
From: Arnd Bergmann
On Tuesday 29 April 2014 13:05:15 Ulf Hansson wrote:
On 29 April 2014 11:45, Arnd Bergmann a...@arndb.de wrote:
drivers/built-in.o: In function `rtsx_usb_sdmmc_drv_remove':
:(.text+0x806480): undefined reference to `led_classdev_unregister'
drivers/built-in.o: In function
On 2014-04-29 09:34, Chase Southwood wrote:
This board always has 32 digital inputs. Remove the test when
initializing the subdevice.
Also, since this board is the only one supported by this driver,
remove the boardinfo about the digital inputs and just use the
data directly in the subdevice
On 2014-04-29 09:37, Chase Southwood wrote:
The i_IorangeBase1, i_PCIEeprom, and pc_EepromChip data in the boardinfo
was only needed to work out the usage of the PCI bars. Now that that is
squared away, this info is no longer needed and can be removed.
Signed-off-by: Chase Southwood
On 2014-04-29 09:35, Chase Southwood wrote:
This driver only uses PCI bar 1 (devpriv-i_IobaseAmcc), and PCI bar 2
(dev-iobase) doon't bother reading the unused PCI bars.
The description needs fixing as it's back to using PCI bar 0 and 1.
Also, there's a typo: doon't - don't. :)
--
-=( Ian
On 2014-04-29 09:38, Chase Southwood wrote:
This driver no longer reads the eeprom to find the board specific data,
all the necessary data is in the boardinfo. Use the boardinfo directly
instead of passing through devpriv-s_EeParameters.
Signed-off-by: Chase Southwood chase.southw...@gmail.com
On 2014-04-28 18:41, H Hartley Sweeten wrote:
This continues the cleanup of the async command support code for this driver
and addresses a number of issues pointed out by Ian Abbott.
H Hartley Sweeten (12):
staging: comedi: adv_pci1710: tidy up pci171x_ai_check_chanlist()
staging: comedi:
At Mon, 28 Apr 2014 01:44:25 +0300,
Dan Carpenter wrote:
On Sun, Apr 27, 2014 at 10:00:43PM +0200, Mateusz Guzik wrote:
and a WARN_ON + -EINVAL in line6_init_audio to catch future
offenders.
Returning -EINVAL is a bad idea because it would break the driver
completely and
On 2014-04-28 19:53, H Hartley Sweeten wrote:
The analog input async command can use the pacer for the scan_bagin_src
or the convert_src. The (*do_cmdtest) validates that only one of these
sources has the TRIG_TIMER selected and calculates the divisors when
validating the cmd argument.
There is
On 2014-04-28 19:53, H Hartley Sweeten wrote:
The analog output async command can use the pacer for the scan_begin_src.
The (*do_cmdtest) calculates the divisors when validating the cmd argument.
There is no reason to recalc the divisors in the (*do_cmd). Just use the
values from the private
On 2014-04-28 19:53, H Hartley Sweeten wrote:
The analog input async command can use the pacer for the convert_src. The
(*do_cmdtest) calculates the divisors when validating the cmd argument.
There is no reason to recalc the divisors in the (*do_cmd). Just use the
values from the private data.
Yeah. If this were a brand new driver then returning -EINVAL would be a
good idea.
Smatch actually warns about this code as well if you turn on the
--spammy option. But there are too many of these kinds of warnings and
even I can't check them all so the warning is basically useless.
In a few
On 2014-04-28 19:53, H Hartley Sweeten wrote:
The analog input async command can use the pacer for the scan_begin_src
or the convert_src. The (*do_cmdtest) calculates the divisors when
validating the cmd argument.
There is no reason to recalc the divisors in the (*do_cmd). Just use the
values
On Tue, Apr 29, 2014 at 04:47:11PM +0200, Takashi Iwai wrote:
At Mon, 28 Apr 2014 01:44:25 +0300,
Dan Carpenter wrote:
On Sun, Apr 27, 2014 at 10:00:43PM +0200, Mateusz Guzik wrote:
and a WARN_ON + -EINVAL in line6_init_audio to catch future
offenders.
Returning -EINVAL
On 2014-04-28 19:53, H Hartley Sweeten wrote:
Remove some unnecessary pacer divisor calculations. The divisors are calculated
as part of the (*do_cmdtest) and don't need done in the (*do_cmd).
Remomove the older, unused, divisor calc functions in 8253.h to avoid any
confusion.
Remove some
This patch fixes Missing a blank line after declarations warnings.
Signed-off-by: Seunghun Lee way...@gmail.com
---
drivers/staging/android/alarm-dev.c |1 +
drivers/staging/android/binder.c | 37 +
drivers/staging/android/ion/ion.c
We have two options:
1) Do we risk introducing new truncation bugs.
2) Do we risk breaking the driver because we didn't catch every
truncation bug.
Truncation bugs here are very low impact and probably no one would even
notice. That's how not worried I am about truncation bugs in this
On Wed, Apr 30, 2014 at 01:59:12AM +0900, Seunghun Lee wrote:
This patch fixes Missing a blank line after declarations warnings.
Signed-off-by: Seunghun Lee way...@gmail.com
Quite a few of these are false checkpatch.pl false positives. Just
ignore the false positives.
regards,
dan carpenter
On Tuesday, April 29, 2014 7:52 AM, Ian Abbott wrote:
On 2014-04-28 19:53, H Hartley Sweeten wrote:
The analog input async command can use the pacer for the scan_bagin_src
or the convert_src. The (*do_cmdtest) validates that only one of these
sources has the TRIG_TIMER selected and calculates
Tidy up this function to clarify what the chanlist is being checked for.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adv_pci1710.c | 81
This continues the cleanup of the async command support code for this driver
and addresses a number of issues pointed out by Ian Abbott.
v2: fix a typo in PATCH 08/12 spotted by Ian Abbott
H Hartley Sweeten (12):
staging: comedi: adv_pci1710: tidy up pci171x_ai_check_chanlist()
staging:
This member of the private data is is not necessary. We can just check the
cmd-flags for TRIG_WAKE_EOS when needed. Remvoe the member.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
This member of the private data is not necessary. We can determine if
the analog input command is neverending by checking the cmd-stop_src:
TRIG_COUNT - !neverending_ai
TRIG_NONE - neverending_ai
Do that instead and remove the unnecessary member.
Signed-off-by: H Hartley Sweeten
This member of the private data is set to 0 but never used. Just remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adv_pci1710.c | 3 ---
1 file
The local variable 'mode' is not necessary. We can determine the mode
by checking the cmd-convert_src and cmd-start_src. Do this instead
to clarify the code.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
This define enables code that checks for analog input channel dropout
when reading samples. The define is enabled so we might as well always
enable the code and remove the define.
Factor out the common channel dropout detect code as a helper function
and cleanup the code.
Signed-off-by: H
The chanlist is checked in Step 5 of the (*do_cmdtest) there is no
reason to check it again in the (*do_cmd). The only reason its done
again is to get the actual 'seglen', the non-repeating length of the
chanlist.
Save the 'seglen' found by pci171x_ai_check_chanlist() in the private
data and use
This member of the private data is always set to I8254_OSC_BASE_10MHZ. Remove
it from the private data and just open code the value.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
When the cmd-convert_src == TRIG_TIMER the divisors needed to
generate the pacer time are calculated in the (*do_cmdtest) to
validate the cmd-convert_arg. The core always does the (*do_cmdtest)
before the (*do_cmd) so there is no reason to recalc the divisors.
Save the calculated divisors in the
For aesthetics, rename the helper functions that are called by
the interrupt function to handle reading the analog input samples.
Also, change the parameters to the helpers to the comedi_device
and comedi_subdevice pointers.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
For aesthetics, rename this function so it has namespace associated
with the driver.
Change the parameters to the function. The 'mode' is really a flag to
load the counters and the divisors can be found in the private data.
To clarify the code and remove the magic numbers, use the 8253.h
helpers
-Original Message-
From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
Sent: Tuesday, April 29, 2014 6:03 AM
To: Oleg Drokin
Cc: Greg Kroah-Hartman; linux-ker...@vger.kernel.org;
de...@driverdev.osuosl.org; Drokin, Oleg; Hammond, John
Subject: Re: [PATCH 41/47]
The analog output async command can use the pacer for the scan_begin_src.
The (*do_cmdtest) calculates the divisors when validating the cmd argument.
There is no reason to recalc the divisors in the (*do_cmd). Just use the
values from the private data.
For aesthetics, factor out the code that
The analog input async command can use the pacer for the convert_src. The
(*do_cmdtest) calculates the divisors when validating the cmd argument.
There is no reason to recalc the divisors in the (*do_cmd). Just use the
values from the private data.
Refactor das16m1_set_pacer() to use the
Remove some unnecessary pacer divisor calculations. The divisors are calculated
as part of the (*do_cmdtest) and don't need done in the (*do_cmd).
Remomove the older, unused, divisor calc functions in 8253.h to avoid any
confusion.
Remove some unnecessary private data members in a couple drivers
The analog input async command can use the pacer for the scan_bagin_src
or the convert_src. The (*do_cmdtest) validates that only one of these
sources has the TRIG_TIMER selected and calculates the divisors when
validating the cmd argument.
There is no reason to recalc the divisors in the
None of the comedi drivers use the i8253_cascade_ns_to_timer_2div_old()
or i8253_cascade_ns_to_timer_power() helpers to calculate the cascaded
divisors. Remove them to avoid any confusion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
This step in the (*do_cmdtest) fixes the comedi_cmd arguments, usually
for TRIG_TIMER sources.
Tidy up this step to clarify the code and remove the extra local
variables. All the arguments are unsigned long so change the 'tmp'
local variable type and rename it for aesthetics.
Signed-off-by: H
This private data member is set when an analog input async command is
started by apci3120_cyclic_ai() and cleared when the command finishes
or is canceled.
Rename the CamelCase member to 'ai_running' and convert it to a
bit-field flag.
Remove the unnecessary clearing of the flag before or after
This member of the private data is a copy of the cmd-chanlist. Use that
instead.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/addi-data/addi_common.h| 1 -
This member of the private data is a copy of the cmd-stop_arg. Use that
instead.
Fix the b_AiContinuous check in apci3120_ai_cmd(). The (*do_cmdtest) validates
that the cmd-stop_arg os = 1 for TRIG_COUNT and 0 for TRIG_NONE. The correct
test to set this flag is (cmd-stop_src == TRIG_NONE).
This member of the private data is a copy of the s-async-prealloc_bufsz.
Use that instead.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/addi-data/addi_common.h
This member of the private data can be determined by checking the cmd-stop_src.
Do that instead.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/amplc_pci224.c | 21
Use a local variable for the comedi_cmd and tidy up this function a bit.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/addi_apci_2032.c | 20 ++--
As pointed out by Ian Abbott, the i8254_load() function does not
use the I8254_MODE* values to specify the mode.
Refactor the 8254 timer programming to use the i8254_set_mode()
and i8254_write() helpers instead of i8254_load(). This allows
us to use the I8254_MODE* defines to clarify the code.
This member of the private data can be determined by checking the cmd-stop_src.
Do that instead.
Fix the b_AiContinuous check in apci3120_ai_cmd(). The (*do_cmdtest) validates
that the cmd-stop_arg os = 1 for TRIG_COUNT and 0 for TRIG_NONE. The correct
test to set this flag is (cmd-stop_src ==
This member of the private data is a copy of the cmd-scan_end_arg. Use that
instead.
Use a local variable in apci3120_cyclic_ai() for the DMA 'scan_bytes', which
is the cmd-scan_end_arg * 2. Replace the open-coded '2' with sizeof(short).
Signed-off-by: H Hartley Sweeten
This member of the private data can be determined by checking the cmd-stop_src.
Do that instead.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/amplc_pci230.c | 22
Refactor the 8254 timer programming to use the i8254_set_mode()
and i8254_write() helpers instead of i8254_load(). This allows
us to use the I8254_MODE* defines to clarify the code.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
All of the comedi drivers use the i8253_cascade_ns_to_timer macro
when calculating the divisors for the cascaded timers. This macro
just causes the i8253_cascade_ns_to_timer_2div() inline to be used.
Rename i8253_cascade_ns_to_timer_2div() and remove the macro.
Signed-off-by: H Hartley Sweeten
The (*do_cmdtest) validates that the cmd-convert_src can only be
TRIG_TIMER. Remove the unnecessay checks.
THis also simplifies the (*do_cmd) a bit since mode 3 (whatever that
is) is never a valid mode.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott
As pointed out by Ian Abbott, the i8254_load() function does not
use the I8254_MODE* values to specify the mode.
The labpc_counter_load() function in this driver is passed an
I8254_MODE* value so we need to use the i8254_set_mode() and
i8254_write() helpers instead of i8254_load() to program the
Refactor the 8254 timer programming to use the i8254_set_mode()
and i8254_write() helpers instead of i8254_load(). This allows
us to use the I8254_MODE* defines to clarify the code.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
As pointed out by Ian Abbott, the i8254_load() function does not
use the I8254_MODE* values to specify the mode.
Refactor the 8254 timer programming to use the i8254_set_mode()
and i8254_write() helpers instead of i8254_load(). This allows
us to use the I8254_MODE* defines to clarify the code.
This member of the private data is a copy of the cmd-scan_begin_arg.
Use that instead.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/addi-data/addi_common.h|
This private data member is not used by this driver. Remove the unnecessary
clearing of it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
As pointed out by Ian Abbott, the i8254_load() function does not
use the I8254_MODE* values to specify the mode.
Refactor the 8254 timer programming to use the i8254_set_mode()
and i8254_write() helpers instead of i8254_load(). This allows
us to use the I8254_MODE* defines to clarify the code.
This member of the private data can be determined by checking the cmd-stop_src.
Do that instead.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/amplc_pci230.c | 25
This member of the private data is a copy of the cmd-flags. Use that instead.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/addi-data/addi_common.h| 1 -
This member of the private data is a copy of the cmd-convert_arg. Use
that instead.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/addi-data/addi_common.h| 1 -
Refactor the 8254 timer programming to use the i8254_set_mode()
and i8254_write() helpers instead of i8254_load(). This allows
us to use the I8254_MODE* defines to clarify the code.
The das800_set_frequency() function will not fail. For aesthetics
change the return to a void and remove the error
Refactor the 8254 timer programming to use the i8254_set_mode()
and i8254_write() helpers instead of i8254_load(). This allows
us to use the I8254_MODE* defines to clarify the code.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
Refactor the 8254 timer programming to use the i8254_set_mode()
and i8254_write() helpers instead of i8254_load(). This allows
us to use the I8254_MODE* defines to clarify the code.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
On Tuesday, April 29, 2014 12:59 PM, H Hartley Sweeten wrote:
Remove some unnecessary pacer divisor calculations. The divisors are
calculated
as part of the (*do_cmdtest) and don't need done in the (*do_cmd).
Remove the older, unused, divisor calc functions in 8253.h to avoid any
confusion.
On Tue, Apr 29, 2014 at 07:16:54PM +, Hammond, John wrote:
-Original Message-
From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
Sent: Tuesday, April 29, 2014 6:03 AM
To: Oleg Drokin
Cc: Greg Kroah-Hartman; linux-ker...@vger.kernel.org;
de...@driverdev.osuosl.org;
On, Tuesday, April 29, 2014 1:38 AM, Chase Southwood wrote:
This driver no longer reads the eeprom to find the board specific data,
all the necessary data is in the boardinfo. Use the boardinfo directly
instead of passing through devpriv-s_EeParameters.
Signed-off-by: Chase Southwood
On 29/04/14 18:56, Hartley Sweeten wrote:
On Tuesday, April 29, 2014 7:52 AM, Ian Abbott wrote:
On 2014-04-28 19:53, H Hartley Sweeten wrote:
- /* Write the values of ctr1 and ctr2 into counters 1 and 2 */
- i8254_load(devpriv-pacer_counter_dio + ADC8254, 0, 1,
-
Hi Dan,
I have send this patch to fix the static checker warning, but not
applied yet.
Best Regards.
micky.
On 04/02/2014 05:58 PM, micky_ch...@realsil.com.cn wrote:
From: Micky Ching micky_ch...@realsil.com.cn
The patch fa590c222fba: staging: rts5208: add support for rts5208
and rts5288
Hi Lee,
On 04/29/2014 04:02 PM, Lee Jones wrote:
From: Micky Ching micky_ch...@realsil.com.cn
The commit mmc: rtsx: add support for pre_req and post_req have some problem,
using mutex_unlock() in atomic context, spinlock deadlock, it is hard to fix
these problem, and better to use a new
Hi Dan,
It is a indent mistake, I had sent a patch to fix it.
see: https://lkml.org/lkml/2014/4/2/127
Best Regards.
micky.
On 04/29/2014 08:18 PM, Dan Carpenter wrote:
What happened with this. My guess is that the code is buggy and curly
braces were intended but I'm not confident enough to
Hello!
On Apr 29, 2014, at 7:02 AM, Dan Carpenter wrote:
diff --git a/drivers/staging/lustre/lustre/llite/statahead.c
b/drivers/staging/lustre/lustre/llite/statahead.c
index 51c5327..1b47774 100644
--- a/drivers/staging/lustre/lustre/llite/statahead.c
+++
Hello!
On Apr 29, 2014, at 5:46 AM, Dan Carpenter wrote:
+/* Fall through */
case 7:
sptlrpc_fini();
-case 5:
+/* Fall through */
+case 6:
ldlm_exit();
-case 4:
+/* Fall through */
+case 5:
On Apr 29, 2014, at 5:08 AM, Dan Carpenter wrote:
On Sun, Apr 27, 2014 at 01:06:42PM -0400, Oleg Drokin wrote:
diff --git a/drivers/staging/lustre/lustre/llite/dir.c
b/drivers/staging/lustre/lustre/llite/dir.c
index 7fbc18e..c391b60 100644
--- a/drivers/staging/lustre/lustre/llite/dir.c
On 04/29/2014 08:46 PM, Arnd Bergmann wrote:
On Tuesday 29 April 2014 13:05:15 Ulf Hansson wrote:
On 29 April 2014 11:45, Arnd Bergmann a...@arndb.de wrote:
drivers/built-in.o: In function `rtsx_usb_sdmmc_drv_remove':
:(.text+0x806480): undefined reference to `led_classdev_unregister'
92 matches
Mail list logo
